Günther Deschner
13533e12fd
s3-spoolss: add support for _spoolss_SetPrinter level 8.
...
Guenther
2010-02-19 00:42:25 +01:00
Michael Adam
1a42b020fd
nss_wrapper: fix segfault in print_group() in the testsuite
...
Running
'TESTS=posix_s3 POSIX_SUBTESTS="RPC-SAMR-LARGE-DC LOCAL-NSS-WRAPPER" make test'
from s3 made smbtorture4 crash on my box.
Michael
2010-02-19 00:37:41 +01:00
Jeremy Allison
11a87cd31e
More fixes for bug #7146 - Samba miss-parses authenticated RPC packets.
...
Ensure we calculate the space correctly (including the ss_padding_len)
when constructing reply packets.
Jeremy.
2010-02-18 15:03:30 -08:00
Günther Deschner
2eb83f2964
s4-smbtorture: add LOCAL-NSS-WRAPPER-DUPLICATES test.
...
Guenther
2010-02-18 23:25:16 +01:00
Günther Deschner
9b9c9fd175
s4-smbtorture: be more verbose in LOCAL-NSS-WRAPPER.
...
Guenther
2010-02-18 23:25:16 +01:00
Björn Jacke
c0ebca237c
s3: optimize strict allocate for XFS on IRIX
2010-02-18 22:45:46 +01:00
Günther Deschner
77164a8a5d
testprogs: add tests for GetJob() to spoolss test.
...
Guenther
2010-02-18 22:01:04 +01:00
Jeremy Allison
a4e8210ba7
Fix bug #7155 - valgrind Conditional jump or move depends on uninitialised value(s) error when "mangling method = hash"
...
The charset array allocated in init_chartest() is allocated
by MALLOC, but only some elements of it being set after allocation. Fix is to
memset to zero after allocation.
Jeremy.
2010-02-18 12:21:10 -08:00
Jeremy Allison
df13b1303a
Fix bug #7154 - mangling method = hash can crash storing a name not containing a '.'
...
Fix use of uninitialized variable. This can lead to crashes if
mangling = hash processes names with no '.'.
Jeremy.
2010-02-18 11:22:44 -08:00
Günther Deschner
0bf9c5ecf6
testprogs: add RPC_S_PROCNUM_OUT_OF_RANGE error.
...
Guenther
2010-02-18 16:41:59 +01:00
Günther Deschner
0a8011aa98
spoolss: use ndr_push_spoolss_PrinterInfo2 hand-marshalled version (moves devmode relative pointer down to sd).
...
Guenther
2010-02-18 15:47:59 +01:00
Günther Deschner
2881742493
spoolss: add spoolss_security_descriptor.
...
Guenther
2010-02-18 15:47:59 +01:00
Günther Deschner
70f8b34f51
s3: re-run make samba3-idl.
...
Guenther
2010-02-18 15:47:59 +01:00
Günther Deschner
f10a2d773d
security: make two bitmaps public.
...
Guenther
2010-02-18 15:47:58 +01:00
Günther Deschner
8c4ff98ea1
spoolss: make two bitmaps public.
...
Guenther
2010-02-18 15:47:58 +01:00
Stefan Metzmacher
8f52957369
spoolss: make all security descriptors and devicemodes 4 byte aligned and add missing subcontexts.
...
Guenther
2010-02-18 15:47:57 +01:00
Günther Deschner
6d0a39741d
spoolss: set NDR_RELATIVE_REVERSE flag for various unions that have relative pointers.
...
Guenther
2010-02-18 15:47:57 +01:00
Stefan Metzmacher
2059a165ee
ndr_spoolss_buf: use LIBNDR_FLAG_NO_NDR_SIZE in NDR_SPOOLSS_SIZE_*
...
metze
2010-02-18 15:47:57 +01:00
Stefan Metzmacher
a4c3aeb793
spoolss: use subcontext in NDR_SPOOLSS_PUSH_ENUM_OUT macro.
...
metze
2010-02-18 15:47:56 +01:00
Stefan Metzmacher
8310f02414
libndr: fix ndr_size_* calculation with relative reverse buffers
...
metze
2010-02-18 15:47:52 +01:00
Stefan Metzmacher
4a76d29374
libndr: for now align reverse relative pointers to 2 bytes by default.
...
This is just a hack and we should let the callers use FLAG_ALIGN2
explicit in future.
metze
2010-02-18 13:44:04 +01:00
Stefan Metzmacher
31c7780c16
libndr: implement LIBNDR_RELATIVE_REVERSE handling
...
This is based on Guenther's initial code.
metze
2010-02-18 13:44:03 +01:00
Günther Deschner
05347754ee
libndr: store a subcontext buffer size in ndr_push_subcontext_start.
...
Guenther
2010-02-18 13:44:03 +01:00
Stefan Metzmacher
b5f9c44da5
libndr: give an error when ndr_push_relative_ptr2_start()/_end() is used with the RELATIVE_REVERSE flag
...
metze
2010-02-18 13:44:03 +01:00
Günther Deschner
a2c34296fa
libndr: add LIBNDR_FLAG_NO_RELATIVE_REVERSE so that relative reverse processing
...
can be disabled for single structure elements.
Guenther
2010-02-18 13:44:02 +01:00
Günther Deschner
ee13a51b05
libndr: add LIBNDR_FLAG_RELATIVE_REVERSE flag.
...
Guenther
2010-02-18 13:44:02 +01:00
Günther Deschner
c9fa97b017
libndr: change subcontext buffer allocation to allocate on subcontext_start.
...
Guenther
2010-02-18 13:44:01 +01:00
Stefan Metzmacher
98e143cd31
librpc/ndr: make ndr_push_relative_ptr2() static
...
metze
2010-02-18 13:44:01 +01:00
Stefan Metzmacher
e03591111a
librpc/ndr_krb5pac: use ndr_push_relative_ptr2_start()/_end()
...
metze
2010-02-18 13:44:01 +01:00
Stefan Metzmacher
b423bd2115
librpc/ndr_drsblobs: use ndr_push_relative_ptr2_start()/_end()
...
metze
2010-02-18 13:44:00 +01:00
Günther Deschner
bfd6edb3e9
spoolss: fix relative pointers in ndr_push_spoolss_DriverInfo101.
...
Guenther
2010-02-18 13:44:00 +01:00
Günther Deschner
c869328b16
s3: re-run make full_idl.
...
Guenther
2010-02-18 13:44:00 +01:00
Günther Deschner
a049d75193
pidl: use ndr_push_relative_ptr2_start and ndr_push_relative_ptr2_end.
...
Guenther
2010-02-18 13:43:59 +01:00
Günther Deschner
bc20d3446a
libndr: add ndr_push_relative_ptr2_start and ndr_push_relative_ptr2_end.
...
Guenther
2010-02-18 13:43:59 +01:00
Karolin Seeger
494819773d
s3-docs: Remove trailing whitespaces and fix a typo.
...
Karolin
2010-02-18 13:10:21 +01:00
Björn Jacke
37115f91ae
s3:docs: add some advice for usage of strict allocate
2010-02-18 13:01:28 +01:00
Günther Deschner
b3c2b2260a
s3-spoolss: Fix _spoolss_EnumPrinters servername handling.
...
Guenther
2010-02-18 12:40:36 +01:00
Günther Deschner
b6f58e25b5
s3-selftest: fix return code for modprinter.pl -a.
...
Background is: the SetPrinter level 2 calls "addprinter command" an fails if a
share already existed (and the addprinter command returned a non-0 return code).
Removing the non-0 return code is fine, as in AddPrinter{Ex}, we have checks to
see if a share already exists before calling out the addprinter command.
Maybe one day, we need to have a "changeprinter command"...
Guenther
2010-02-18 11:23:59 +01:00
Stefan Metzmacher
c42d9c4ec4
tsocket/bsd: fix comment in tdgram_bsd_recvfrom_handler()
...
metze
2010-02-18 09:38:00 +01:00
Jeremy Allison
9abce9f7c9
Revert "Got back to 16-byte padding on auth RPC. S3 clients and servers now cope with this. Jeremy"
...
This reverts commit 38c50c7027
.
As tridge requested, we need this to work with older S3
servers, not just for smbtorture4.
Jeremy.
2010-02-17 19:42:49 -08:00
Günther Deschner
867daf6e0a
s3-selftest: finally enable RPC-SPOOLSS-PRINTER against Samba 3.
...
Guenther
2010-02-18 02:27:08 +01:00
Günther Deschner
34ad5da5cd
s3-selftest: include addprinter/deleteprinter command.
...
Guenther
2010-02-18 02:27:04 +01:00
Günther Deschner
43e3d8f51d
s3-spoolss: fix return code of spoolss_DeletePrinter.
...
When the printer has been removed by the "deleteprinter command", we need to
check if it is still there and then fail, not fail if we successfully removed
it (found by RPC-SPOOLSS-PRINTER).
Guenther
2010-02-18 02:19:59 +01:00
Günther Deschner
8ce66fba03
s3-spoolss: in spoolss_EnumPrinters r->in.server is a *unique* pointer!
...
Guenther
2010-02-18 02:19:50 +01:00
Günther Deschner
2d2db2a822
s3-spoolss: more AddPrinter{Ex} checks.
...
Windows will allow to add a non-shared printer that is returned by EnumPrinters.
Samba has no notion of non-shared local printers yet, so just make sure to
behave like we do elsewhere: a printer autoloaded by samba or added to samba is
shared.
Guenther
2010-02-18 02:19:42 +01:00
Günther Deschner
5cff7e1692
s3-spoolss: add some printer info validation for AddPrinter calls.
...
Guenther
2010-02-18 02:19:33 +01:00
Günther Deschner
9ff2c1ea64
testprogs: print SDDL string of printer security descriptors
2010-02-18 02:18:59 +01:00
Günther Deschner
6cf10cc102
s3-modules: fix get_acl_blob in the acl_tdb VFS module.
...
Shuttle-reviewed by jra :)
Guenther
2010-02-18 02:17:50 +01:00
Günther Deschner
998a7b4e3f
s4-smbtorture: skip printer info cross tests against samba 3 for now.
...
Not even w2k8r2 passes them atm.
Guenther
2010-02-18 01:49:02 +01:00
Günther Deschner
97d36377d3
s4-smbtorture: try more combinations to find printers in test_EnumPrinters_findname().
...
Also take a note of servers returning full UNC printer paths although we did not
set the servername.
Guenther
2010-02-18 01:48:52 +01:00