1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-13 13:18:06 +03:00
Commit Graph

17262 Commits

Author SHA1 Message Date
Jeremy Allison
7ade7f947b r17461: Ensure we never save a NULL SID mapping. || should be &&.
Found by Whitfield school.
Jeremy.
(This used to be commit f8584a4758)
2007-10-10 11:38:35 -05:00
Volker Lendecke
4d6d92400c r17460: First step at fixing the build breakage with the groupmapping test. On Linux,
F_RDLCK is defined to 0, for example NetBSD has it at 1.

Still does not work fully though. Still investigating.

This might also be interesting to Samba4.

Volker
(This used to be commit a1c3774e01)
2007-10-10 11:38:35 -05:00
Simo Sorce
3bb5b15801 r17459: As by Jerry's word commit this without his review.
This patch add some missing async functions to
solve UID/GID -> SID requests not just out of the cache,
but down the remote idmap if necessary.

This patch solves the problem of servers not showing users/groups names
for allocated UID/GIDs when joined to a group of servers that share a
prepopulated idmap backend.

Also correctly resolve UID/GIDs to SIDs when looking ACLs from the
windows security tab on teh same situation.

Simo.
(This used to be commit b8578bfab6)
2007-10-10 11:38:35 -05:00
Volker Lendecke
21da07ba1f r17457: Add a test to do some operations on group mapping.
Volker
(This used to be commit 68db058fdf)
2007-10-10 11:38:35 -05:00
Günther Deschner
72c605b4fc r17454: Adding dfs_EnumEx for rpcclient (Samba4 IDL to follow).
Guenther
(This used to be commit 8c1198c159)
2007-10-10 11:38:35 -05:00
Günther Deschner
11673dc07a r17453: Fix msdfs RPC management (this broke with the autogenerated dfs rpcs).
* Remove "unknown" from dfs_Enum (samba4 dfs IDL updates to follow).

* When encountering an unsupported infolevel the rpc server must reply
with a dfs_info_0 structure and WERR_OK (observed from w2k3 when talking
to nt4).

Guenther
(This used to be commit f9bef1f08f)
2007-10-10 11:38:34 -05:00
Volker Lendecke
70660495b3 r17452: Some C++ warnings
(This used to be commit e4b8c79a9d)
2007-10-10 11:38:34 -05:00
Volker Lendecke
ff7c0a7c35 r17451: Change pdb_getgrsid not to take a DOM_SID but a const DOM_SID * as an
argument.

Volker
(This used to be commit 873a5a1211)
2007-10-10 11:38:34 -05:00
Volker Lendecke
175aa92e9e r17446: Fix some C++ warnings and two memleaks found by Coverity, IDs 304 and 305.
Volker
(This used to be commit 4f6605a488)
2007-10-10 11:38:34 -05:00
Jeremy Allison
6cab0fbb8b r17439: Fix logic error in checking TALLOC return. Spotted by Volker.
Jeremy.
(This used to be commit 06aea05c52)
2007-10-10 11:38:33 -05:00
Jeremy Allison
a8627a8576 r17431: Fix bug #4003, reported by dale-keyword-samba.c7b741@codefu.org.
NTcancel doesn't send a reply, so in this case the signing
sequence number is only incremented by 1, not 2.
Jeremy.
(This used to be commit 85841a0198)
2007-10-10 11:38:33 -05:00
Volker Lendecke
ac9628de48 r17425: Add the multi-key wrapper. If it's necessary to add general blobs as keys,
this can trivially be added later.

Volker
(This used to be commit 6915adb978)
2007-10-10 11:38:33 -05:00
Simo Sorce
ab75c56370 r17408: Let us use netgroups even without a NIS domain but just using files
(This used to be commit c065341d3f)
2007-10-10 11:38:32 -05:00
Jeremy Allison
43c7f6d1d1 r17407: Don't do strchr_m twice when once will do.
Jeremy.
(This used to be commit b5f0b1b644)
2007-10-10 11:38:32 -05:00
Volker Lendecke
6361d151a4 r17406: We need to do a translation of winbind separator -> '\\' in
lookup_name_smbconf, otherwise

force user = domain+administrator

can not work. Also attempt to fix the 'valid users = domain+group' bug at the
same time.

Volker
(This used to be commit 255475901c)
2007-10-10 11:38:32 -05:00
Volker Lendecke
7cc7fc51c6 r17404: Is this XP (extreme programming)? :-)
With lp_workgroup we end up with remote names again...

Volker
(This used to be commit 250b9f3531)
2007-10-10 11:38:32 -05:00
Gerald Carter
f8aa6abb68 r17403: add a helpful debug msg
(This used to be commit 63325b3687)
2007-10-10 11:38:32 -05:00
Jeremy Allison
f8aa1c75f4 r17402: Added lookup_name_smbconf() to be called when looking
up names from smb.conf. If the name is unqualified it
causes the lookup to be done in WORKGROUP\name, then
"Unix [users|groups]"\name rather than searching the
domain. Should fix the problems with "force user"
selecting a domain user by preference.
Jeremy.
(This used to be commit 1e1fcb5eb2)
2007-10-10 11:38:31 -05:00
Gerald Carter
61d5d8ca2b r17401: BUG 3855: remove bits of XML and SQL checks from aclocal.m4
(This used to be commit 92ccdec33f)
2007-10-10 11:38:31 -05:00
Volker Lendecke
749c8d587c r17399: Some C++ warnings
(This used to be commit d12b08fc61)
2007-10-10 11:38:31 -05:00
Jeremy Allison
4905106778 r17393: Remove Volker's ASSERT that num_groupsids > 0.
For guest connection they may well be zero.
This should fix up the buildfarm (fingers
crossed).
Jeremy.
(This used to be commit 16ebccbc58)
2007-10-10 11:38:31 -05:00
Jeremy Allison
87b2b16cbf r17392: Commit Volker's fix for the valid users problem.
Let's look at the build farm now... :-).
Jeremy.
(This used to be commit 6d822b8567)
2007-10-10 11:38:31 -05:00
Jeremy Allison
74ee62a45b r17391: Revert the second part of the valid users fix - the
netlogon code uses pdb_get_group_sid() which could
return a S-1-1-22 unix sid. Who knew.... :-(.
I'm going to test Volker's fix instead. Once
3.0.23b is out we *have* to rip out the pdb_set_group_sid()
code....
Jeremy.
(This used to be commit 65003e1b25)
2007-10-10 11:38:31 -05:00
Jeremy Allison
ba5f9c4ef9 r17388: Fix the "valid users"/token issue for now. Volker,
please come in and fix it in a less ugly way once
you have some time. Thanks,
Jeremy.
(This used to be commit 79b1e668e2)
2007-10-10 11:38:30 -05:00
Gerald Carter
22c9a3151e r17386: fix inverted logic pointed out by Volker. When deleting a printer return access denied if the printer still exists after the delete_printer_hook() is called
(This used to be commit c05e2bdc0c)
2007-10-10 11:38:30 -05:00
Gerald Carter
e5f6544df1 r17383: Patch from Michael Adams <ma@sernet.de> to catch
some memory leaks on error paths in net_ads_join()
(This used to be commit 24de2d83ff)
2007-10-10 11:38:29 -05:00
Jeremy Allison
dca7d08e61 r17378: Fix the issues people have been having with mapped
users (username map) and failure to connect to a
share. Essentially, even on a standalone system
we were going into the create_token_from_username()
code (I think by mistake) if the username was mapped.
Fixes bug #3991.

Volker & Jerry - please go over this with a very careful eye
and let me know if this isn't correct (I think it is,
but this isn't my code and it's a dangerous area for
me to be playing in :-).

Jeremy
(This used to be commit 0b5b2b53ec)
2007-10-10 11:38:29 -05:00
Jeremy Allison
f569db1c06 r17376: Fix bug #3985 - ensure in msdfs we check for our
netbios aliases. Reported by Björn Jacke <bjoern@j3e.de>.
Probably needs to be in 3.0.23b (if Björn approves
of the fix).
Jeremy.
(This used to be commit e9e711fe37)
2007-10-10 11:38:29 -05:00
Volker Lendecke
8e1fec05cb r17375: If a field containts only whitespace, we need to do base64 as well.
Volker
(This used to be commit 795d06f427)
2007-10-10 11:38:29 -05:00
Volker Lendecke
280e3895b6 r17374: Get rid of a silly "System User" default for "description", also fetch the
sambaProfilePath.

Volker
(This used to be commit 61e7ed593b)
2007-10-10 11:38:29 -05:00
Jeremy Allison
d42a96b3ec r17367: Reverting the ab code. Note I'm not saying this
code is wrong or bad or anything, just that it
needs to be discussed & reviewed on the samba-technical
list before we add a platform-specific NFSv4 mapping.
That way lies a lot of future pain :-).
Jeremy.
(This used to be commit 330899ec30)
2007-10-10 11:38:29 -05:00
Günther Deschner
ec17ea6b06 r17366: Save the logon script path from the info3 in the PAM session allowing
other PAM modules to pick it up from there.

Guenther
(This used to be commit b3ac5a586b)
2007-10-10 11:38:28 -05:00
Günther Deschner
41449a85e6 r17365: Fix memleak.
Guenther
(This used to be commit 62a8e0b089)
2007-10-10 11:38:28 -05:00
Volker Lendecke
8eebd925b2 r17364: Another NT4 join bug: The idealx tools set the primary group sid, and if we do
an update_sam_account later on, we want to also set it using the delete/add
method. As the idealx tools use the replace method, they don't care about what
has been in there before.

Jerry, this is a likely 3.0.23b candidate. Not merging, it's your call :-)

Volker
(This used to be commit f002a36338)
2007-10-10 11:38:28 -05:00
Volker Lendecke
467ec2a32b r17363: Some C++ warnings
(This used to be commit fd82f185a2)
2007-10-10 11:38:28 -05:00
Alexander Bokovoy
fbd04d65c5 r17358: Re-add JFS2 NFS4 ACLs support, move readme for it into AIX-specific examples directory.
(This used to be commit c085355c32)
2007-10-10 11:38:28 -05:00
Volker Lendecke
7c2b79ea48 r17356: Also transfer the sambaHomePath attribute.
Volker
(This used to be commit 49ad0d4d0e)
2007-10-10 11:38:28 -05:00
Alexander Bokovoy
16bf23d973 r17354: Revert -r 17353 per Volker request while gpfs compatibility layer code will be released.
(This used to be commit 5b1db01514)
2007-10-10 11:38:27 -05:00
Alexander Bokovoy
4cf5769331 r17353: Add support for JFS2 NFS4/AIXC and GPFS acls based on NFSv4 ACLs.
(This used to be commit 72312cb2e2)
2007-10-10 11:38:27 -05:00
Volker Lendecke
430fa0eba0 r17348: Some C++ warnings
(This used to be commit ae6b9b34e5)
2007-10-10 11:38:27 -05:00
Volker Lendecke
e7952e9c14 r17347: Some C++ warnings -- 271 left
(This used to be commit 641dac4f85)
2007-10-10 11:38:27 -05:00
Jeremy Allison
49001a5b1b r17346: Add optimisation vl needs for the cluster code where
we don't get the chainlock when getting the byte range
lock record read-only.
Jeremy.
(This used to be commit fcd798ca0c)
2007-10-10 11:38:27 -05:00
Volker Lendecke
fd8bae8b16 r17345: Some C++ warnings
(This used to be commit 21c8fa2fc8)
2007-10-10 11:38:26 -05:00
Alexander Bokovoy
5fbe298b5a r17338: Add support for multiple shares test inspired by Samba 4 torture's --unclist option. Triggered by -b sharelist_file option.
Based on Peter Samogyi's work. I'm not sure what concept for fstring replacement is currently in place though (talloc-ed strings? or it was for pstring only?)
(This used to be commit c9f8fafad6)
2007-10-10 11:38:26 -05:00
Volker Lendecke
175ac9f7db r17335: Some more fixes to net rpc vampire ldif. Still not good though :-(
Volker
(This used to be commit e947f4bd91)
2007-10-10 11:38:26 -05:00
Volker Lendecke
1cf1e648fe r17334: Some C++ warnings
(This used to be commit 8ae7ed1f3c)
2007-10-10 11:38:26 -05:00
Volker Lendecke
02eea79624 r17333: Some C++ warnings
(This used to be commit be9aaffdac)
2007-10-10 11:38:26 -05:00
Volker Lendecke
e23781b3b3 r17316: More C++ warnings -- 456 left
(This used to be commit 1e4ee728df)
2007-10-10 11:38:25 -05:00
Volker Lendecke
5a5deade6e r17315: Make talloc and tdb C++-warning-free. Would this also be interesting in talloc
and tdb "upstream"?

Volker
(This used to be commit 68c43191c8)
2007-10-10 11:38:25 -05:00
Jeremy Allison
2c6030415e r17314: Optimisation for POSIX locking. If we're downgrading
a POSIX lock (applying a read-lock) and we overlap
pending read locks then send them an unlock message,
we may have allowed them to proceed.
Jeremy.
(This used to be commit a7a0b6ba50)
2007-10-10 11:38:25 -05:00
Volker Lendecke
4e9df2fba3 r17313: Non-Ascii attribute values need to be encoded as base64, with an attribute
name attr:: instead of attr:

German domains tend to have umlauts in group names.

More to come tomorrow.

Volker
(This used to be commit 94cdd5d64c)
2007-10-10 11:38:24 -05:00
Volker Lendecke
3fa73aa04d r17312: Do some reformatting on net rpc samsync ldif. Not doing this checkin easily,
as this puts me into svn blame in places I'm not sure I want my name to show
up....

Volker
(This used to be commit d00e73c49b)
2007-10-10 11:38:24 -05:00
Jelmer Vernooij
ffb9443c20 r17307: Add datarootdir setting (required for newer autoconfs)
(This used to be commit 86687b804a)
2007-10-10 11:38:24 -05:00
Jeremy Allison
981350a03c r17296: Replace the understandable parts of the quota
code with become_root_uid_only()/unbecome_root_uid_only()
pairs. This code needs working on.....
Jeremy.
(This used to be commit 0661d4e266)
2007-10-10 11:38:24 -05:00
Jeremy Allison
5b3d559aa8 r17295: Back out the become_root_uid_only change on the POSIX
acls code. I'm pretty sure this was safe, but become_root()
does other things to the token stack that become_root_uid_only()
does not, and as we're going into a vfs redirectred function
I decided it wasn't safe for now.
Jeremy.
(This used to be commit b3e0f45488)
2007-10-10 11:38:24 -05:00
Jeremy Allison
e4e2be0d8b r17294: Make the code a little cleaner. Instead of using the two
calls make it :

become_root_uid_only()
operation
unbecome_root_uid_only()

saving errno across the second call. Most of our internal
change calls can be replaced with these simple calls.

Jeremy
(This used to be commit 4143aa83c0)
2007-10-10 11:38:24 -05:00
Jeremy Allison
a093a76dc1 r17293: After the results from the cluster tests in Germany,
fix the messaging code to call the efficient calls :

save_re_uid()
set_effective_uid(0);

messaging_op

restore_re_uid();

instead of using heavyweight become_root()/unbecome_root()
pairs around all messaging code. Fixup the messaging
code to ensure sec_init() is called (only once) so that non-root
processes still work when sending messages.

This is a lighter weight solution to become_root()/unbecome_root()
(which swaps all the supplemental groups) and should be more
efficient. I will migrate all server code over to using this
(a similar technique should be used in the passdb backend
where needed).

Jeremy.
(This used to be commit 4ace291278)
2007-10-10 11:38:24 -05:00
Jeremy Allison
321b0a3a63 r17292: Try and fix bug #3967 - signing problems on trans
calls introduced by signing code simplification.
Please test if you've seen signing problems with
3.0.23a.
Jeremy.
(This used to be commit f462daf02c)
2007-10-10 11:38:23 -05:00
Jeremy Allison
9d9c90f31a r17291: Fix memory leaks on early exit path.
Jeremy.
(This used to be commit deaac5bd46)
2007-10-10 11:38:23 -05:00
Volker Lendecke
d30bcf9c48 r17279: conn->cnum is the tid we've given to the client. This has nothing to do with
our internal share number.

Funny that it worked at all :-)

Volker
(This used to be commit afa6e90946)
2007-10-10 11:38:23 -05:00
Jeremy Allison
54cdd1dfe2 r17276: Don't change the POSIX lock ref count if posix locking = no.
Jeremy.
(This used to be commit 42dec2192c)
2007-10-10 11:38:23 -05:00
Gerald Carter
9bfa22a502 r17271: Fix a regression in the ldapsam uri syntax.
Allow multiple LDAP URIs to be grouped by  ""
(This used to be commit 21d69dcb3c)
2007-10-10 11:38:23 -05:00
Jeremy Allison
8f93665bb5 r17262: After messages from Metze and traces from Karolin Seeger,
turns out that EDQUOTA must map to NT_STATUS_DISK_FULL
for Windows apps to work correctly. My mistake.
Jeremy.
(This used to be commit de1e3f7a7a)
2007-10-10 11:38:23 -05:00
Gerald Carter
2681f88fbc r17260: remove extra ;SAMBA_3_0_23/source/utils/netlookup.c
(This used to be commit c152d20e90)
2007-10-10 11:38:22 -05:00
Gerald Carter
20c09b75fa r17258: Cleanup the 'net ads help join' output and document createupn
and createcomputer options
(This used to be commit 87be77bf35)
2007-10-10 11:38:22 -05:00
Volker Lendecke
31802698db r17254: Simple flattening of an if-statement, no logic change.
Jeremy, I'm sure you will look at this nevertheless :-)

Volker
(This used to be commit 3ef34468b5)
2007-10-10 11:38:22 -05:00
Jeremy Allison
999b1e01e1 r17249: Ensure we only set the FILE_WRITE_DATA on O_TRUNC
in one place.
Jeremy.
(This used to be commit f326bae3e2)
2007-10-10 11:38:22 -05:00
Jeremy Allison
f6aeba37ff r17248: Ensure we definately add the WRITE_DATA on O_TRUNC.
Jeremy.
(This used to be commit 8eed82d5d5)
2007-10-10 11:38:22 -05:00
Jeremy Allison
f43522856b r17247: When we map generic to specific we need to remember
to copy over the copy of the access_mask, open_access_mask.
Jerry - this is a definate fix for a 3.0.23b and should also
be on the patches page. CIFSFS breaks without this.
Jeremy.
(This used to be commit d11e71ebcc)
2007-10-10 11:38:22 -05:00
Gerald Carter
382b088193 r17246: BUG 3964: lower case username prior to getpwnam() call in smbpasswd
(This used to be commit dc4fec1f7d)
2007-10-10 11:38:22 -05:00
Jeremy Allison
29a4d666ba r17245: Second part of fix for #3962. Don't do a double
free in the infolevel2 case. Free both queue and
NT_PRINTER_INFO_LEVEL in the same place.
Jeremy.
(This used to be commit 6ac3a4ce78)
2007-10-10 11:38:21 -05:00
Jeremy Allison
9d4fa2b27b r17244: There were several error paths where NT_PRINTER_INFO_LEVEL
wasn't being freed - also one enum jobs case where the
NT_PRINTER_INFO_LEVEL and queue weren't being freed.
Strange that Coverity or Klokwork didn't pick these up.
Hopefully will fix #3962.
Jeremy.
(This used to be commit bb26412387)
2007-10-10 11:38:21 -05:00
Gerald Carter
1a0b57b5f5 r17242: BUG 3957: make sure to zero memory in the SRV hostlist in case there is not an A record for each SRV name
(This used to be commit 42608b8bb9)
2007-10-10 11:38:21 -05:00
Gerald Carter
18feaab9d5 r17239: BUG 3959: patch from William Charles <william@charles.name> to fix a segv in the DNS SRV lookups dur to calling rand()
(This used to be commit be12519fd8)
2007-10-10 11:38:21 -05:00
Jeremy Allison
74cd692d9b r17234: Fix error mappings for EQUOTA and ENOBUFS.
Based on an idea from Shlomi Yaakobovich <Shlomi@exanet.com>.
Jeremy.
(This used to be commit 9c440925f8)
2007-10-10 11:38:21 -05:00
Volker Lendecke
7ad912c264 r17231: Some patch cosmetics
(This used to be commit 736e55101b)
2007-10-10 11:38:21 -05:00
Volker Lendecke
9bbe29ad13 r17229: Indent-style reformatting -- getting used to the code again :-)
(This used to be commit 2e400fb007)
2007-10-10 11:38:20 -05:00
Volker Lendecke
0e6e3c90c9 r17228: Modest reformatting
(This used to be commit 640b4297a4)
2007-10-10 11:38:20 -05:00
Jeremy Allison
120422f723 r17220: If we're going to fail a write with an errno, make
sure we return -1.
Jeremy.
(This used to be commit 89b83237b0)
2007-10-10 11:38:19 -05:00
Gerald Carter
8cc35cc8da r17217: Fix a couple of "smbldap_open(): Cannot open when not root" bugs
when viewing or modifying local group membership.
(This used to be commit 41e30a9666)
2007-10-10 11:38:19 -05:00
Andrew Bartlett
fe348fdb28 r17216: From Kai Blin <kai.blin@gmail.com>:
A patch to make ntlm_auth recognize three new commands in
ntlmssp-client-1 and squid-2.5-ntlmssp:

The commands are the following:

Command: SF <hex number>
Reply: OK
Description: Takes feature request flags similar to samba4's
gensec_want_feature() call. So far, only NTLMSSP_FEATURE_SESSION_KEY,
NTLMSSP_FEATURE_SIGN and NTLMSSP_FEATURE_SEAL are implemented, using the same
values as the corresponding GENSEC_FEATURE_* flags in samba4.

Command: GF
Reply: GF <hex number>
Description: Returns the negotiated flags.

Command: GK
Reply: GK <base64 encoded session key>
Description: Returns the negotiated session key.

(These commands assist a wine project to use ntlm_auth for signing and
sealing of bulk data).

Andrew Bartlett
(This used to be commit bd3e06a0e4)
2007-10-10 11:38:19 -05:00
Volker Lendecke
aac411b7dd r17199: Add comment to the RID/SID miracle
(This used to be commit 4c4ae01c67)
2007-10-10 11:38:19 -05:00
Alexander Bokovoy
528477effa r17198: Fix wins_nss dependencies
(This used to be commit c005049043)
2007-10-10 11:38:19 -05:00
Volker Lendecke
dc833fa694 r17194: To run rpc-samba3-lsa in the build farm, we can't rely on geteuid()==0. Adapt
it to other "Am I root?" checks.

Jerry, Jeremy, please check this!

Thanks,

Volker
(This used to be commit f777b2d294)
2007-10-10 11:38:19 -05:00
Volker Lendecke
e85be720a3 r17192: Make this actually survive valgrind. We NEED pidl here...
Maybe bzr is not such a bad idea, then you would probably see less spam on
samba-cvs, sorry for that... :-)

Volker
(This used to be commit 41456b498a)
2007-10-10 11:38:19 -05:00
Volker Lendecke
e5b6fea73e r17191: Forgotten file, sorry!
(This used to be commit 32fbf66a4b)
2007-10-10 11:38:18 -05:00
Volker Lendecke
3785912b7d r17190: Remove a warning from "opi", a 64-bit machine
(This used to be commit 844c98eab4)
2007-10-10 11:38:18 -05:00
Volker Lendecke
19cc80b40f r17188: Dump lsa_lookupsids3. I could not make it work at all against W2k3, the
rpc-lsa test even considers NT_STATUS_RPC_PROTSEQ_NOT_SUPPORTED not to be an
error.

Before someone re-activates this, show me a working sniff please :-)

Volker
(This used to be commit b185fb9fa6)
2007-10-10 11:38:18 -05:00
Volker Lendecke
aab62d24e1 r17184: Attempt to get rid of some warnings on HP/UX. Without _XOPEN_SOURCE_EXTENDED
#defined getsockopt uses an int* as socklen parameter.

Volker
(This used to be commit 0b78da62f7)
2007-10-10 11:38:18 -05:00
Gerald Carter
efc7ac209d r17183: LsaLookupSids() shoudl return the string form of a SID when
it cannot be mapped and not the hex of the RID.  Who wrote that?
(This used to be commit 4e51cf34cf)
2007-10-10 11:38:18 -05:00
Jeremy Allison
7f5f781fe9 r17181: Fix the build farm RAW-READ bug. When making a copy
of the lock array in order to delete them individually
it's also important to make a copy of the *size* of
this array. Otherwise the unlock decrements the termination
index of your for loop :-). Doh ! Big thanks to Volker
for showing me how to set up the build farm to track
this one down. This is not a 3.0.23a issue.
Jeremy.
(This used to be commit 2c82a159ae)
2007-10-10 11:38:18 -05:00
Jim McDonough
ba72b0242e r17179: Merge the vl-posixacls tmp branch into mainline. It
modularizes our interface into the special posix API used on
the system. Without this patch the specific API flavor is
determined at compile time, something which severely limits
usability on systems with more than one file system. Our
first targets are AIX with its JFS and JFS2 APIs, at a later
stage also GPFS. But it's certainly not limited to IBM
stuff, this abstraction is also necessary for anything that
copes with NFSv4 ACLs. For this we will check in handling
very soon.

Major contributions can be found in the copyright notices as
well as the checkin log of the vl-posixacls branch. The
final merge to 3_0 post-3.0.23 was done by Peter Somogyi
<psomogyi@gamax.hu>
(This used to be commit ca0c73f281)
2007-10-10 11:38:17 -05:00
Volker Lendecke
e0c68d0a1d r17177: Get rid of a global variable by adding a private data pointer to
share_mode_forall().

Volker
(This used to be commit f97f6cedff)
2007-10-10 11:38:17 -05:00
Gerald Carter
bd8556c8dd r17162: Fix typo small typos noticed by Paul Green.
(This used to be commit 1a58745886)
2007-10-10 11:38:17 -05:00
Gerald Carter
2d91ea9a3b r17159: Bug 3920: Restore wnibind use default domain behavior for domain groups.
This break local users and 'winbind nested groups' on domain members.
Cannot be helped.

My plans is to move the default domain crud to the client code (pam and
nss libraries) in 3.0.24.
(This used to be commit 8ee22eeab5)
2007-10-10 11:38:17 -05:00
Gerald Carter
188e7ac756 r17158: Add two new options to 'net ads join'
* createupn=[host_upn@realm]
  * createcomputer=<ou path top to bottom> (this was previously
    the only arg)
(This used to be commit 75054e984e)
2007-10-10 11:38:17 -05:00
Jeremy Allison
dc5f6687e4 r17152: Don't handle the delete pending here, await
reschedule.
Jeremy.
(This used to be commit 11bab9d579)
2007-10-10 11:38:16 -05:00
Gerald Carter
518c4877dd r17151: revert a few accidental commits to the Makefile
(This used to be commit 3fea233802)
2007-10-10 11:38:16 -05:00
Gerald Carter
9f6fb43eee r17150: MMC User & group plugins fixes:
* Make sure to lower case all usernames before
  calling the create, delete, or rename hooks.
* Preserve case for usernames in passdb
* Flush the getpwnam cache after renaming a user
* Add become/unbecome root block in _samr_delete_dom_user()
  when trying to verify the account's existence.
(This used to be commit bbe11b7a95)
2007-10-10 11:38:16 -05:00
Gerald Carter
02f272f3c6 r17149: Fail the join if we cannot set any SPNs for the machine account.
Disable the one we created and whine.
(This used to be commit 1a7e81a4a8)
2007-10-10 11:38:16 -05:00
Gerald Carter
bdfeaf2bcf r17148: the wins service should not accept any controls so that a GUI can grey it out as not remotely manageable
(This used to be commit 859c51cf25)
2007-10-10 11:38:16 -05:00
Gerald Carter
5ac15bc63a r17147: Install fixes for libraries
(This used to be commit 72bac13f21)
2007-10-10 11:38:16 -05:00
Gerald Carter
f3550d82a7 r17146: Starting to cleanout my local tree some
* add code to lookup NS records (in prep for later coe that
  does DNS updates as part of the net ads join)
(This used to be commit 36d4970646)
2007-10-10 11:38:15 -05:00
Jeremy Allison
201bd24ac3 r17142: Ensure we record the correct can_read/can_write
from the client requested access mask.
Jeremy.
(This used to be commit 12490fafc7)
2007-10-10 11:38:15 -05:00
Jeremy Allison
dada5b4853 r17140: Get rid of the lock release/reacquire code ! Turns out
that create dispositions that cause O_TRUNC break
oplocks. This simplifies the code - although we have
to keep separate the client requested access mask and
the access mask we actually use to open the file.
Jeremy.
(This used to be commit 3bcd52a475)
2007-10-10 11:38:15 -05:00
Volker Lendecke
0e2f7c0ea4 r17138: In preparation for the cluster merge, add an empty configure option :-)
Volker
(This used to be commit 906720649b)
2007-10-10 11:38:14 -05:00
Volker Lendecke
8cfb182bdb r17136: Fix alignment on lsaquery. This broke in particular level 6, where the client
tried to figure out which role we are.

Needs to go into 23a.

Thanks to Karolin for insisting and setting up the test case :-)

Volker
(This used to be commit 3482bb1ef5)
2007-10-10 11:38:14 -05:00
Volker Lendecke
5faee071cb r17134: Fix a debug message
(This used to be commit 40e2679811)
2007-10-10 11:38:14 -05:00
Jeremy Allison
48e1e45183 r17131: Optimisation - when doing a stat open don't open the
file unless we really have to (ie. O_CREAT and file
doesn't exist).
Jeremy.
(This used to be commit 788aa15ea2)
2007-10-10 11:38:14 -05:00
Jeremy Allison
addc07be7d r17130: Remove unneeded unlock call.
Jeremy.
(This used to be commit b3b5aec0ee)
2007-10-10 11:38:14 -05:00
Jeremy Allison
4815e2c344 r17128: Missed a logic error in my last patch. Ensure we deal with any
oplocks that were granted when we had released the lock. Fix
strange case where stat open grants a batch oplock on file
create, but grants no oplock on file open.
Jeremy.
(This used to be commit b7374835e6)
2007-10-10 11:38:14 -05:00
Jeremy Allison
0e292222c3 r17125: Drastic problems require drastic solutions. There's
no way to get all the cases where kernel oplocks are
on and we can't open the file and get the correct
semantics (think about the open with truncate with
an attribute only open - we'd need a vfs change to
add the truncate(fname, len) call). So always drop
the share mode lock before doing any real fd opens and
then re-acquire it afterwards. We're already dealing
with the race in the create case, and we deal with
any other races in the same way. Volker, please
examine *carefully* :-). This should fix the problems
people reported with kernel oplocks being on.
Jeremy.
(This used to be commit 8171c4c404)
2007-10-10 11:38:13 -05:00
Andrew Tridgell
f2faf11204 r17124: fixed a bug which caused resolve_ads() to spin forever if one of the
DCs isn't resolvable in DNS. The fix is to leave that DC out of the
returned list of DCs. I think the original code intended that anyway,
just didn't quite get it right ('i' wasn't incremented in that code
path, so the loop didn't terminate)
(This used to be commit d7ec9f3cc0)
2007-10-10 11:38:13 -05:00
Gerald Carter
97c665db90 r17123: Fix 32bit/64bit portability issues again.
NO NOT change the winbindd response or request structures
*unless* you test a 32bit wbinfo against a 64bit winbindd.
The structure sizes MUST be the same on 32bit and 64 bit
platforms.

The way to test is to build a 64bit version of Winbind as normal.
Then build a 32bit version using gcc -m32.  Now install the 64bit and
32bit versions of libnss_winbindd.so and launch the 64bit winbindd.
Make sure that the responses from both 32bit and 64bit versions
of wbinfo match.

If you don't understand the previous paragraph you don't need to
be changing nsswitch/winbindd_nss.h
(This used to be commit bc03141429)
2007-10-10 11:38:13 -05:00
Gerald Carter
ccee54b605 r17122: remove unused global var from idmap_ad
(This used to be commit c8b7952843)
2007-10-10 11:38:13 -05:00
Volker Lendecke
d3ec0beb14 r17116: Jerry, I can't reach you right now, but r17110 broke the build.
Please check.

Volker
(This used to be commit 8c7d6cab19)
2007-10-10 11:38:13 -05:00
Gerald Carter
018044a4b2 r17111: cleanup the idmap_ad initialization after review by gd
(This used to be commit 6c0a690f0a)
2007-10-10 11:38:13 -05:00
Gerald Carter
8e99b53461 r17110: revert a bad merge from the old trunk
(This used to be commit 2c7448e43e)
2007-10-10 11:38:12 -05:00
Jeremy Allison
1cd8d56fda r17108: Make the default timeout parameter for lock waiting
be lp_lock_spin(). lock spin count is no longer
used. I'll update the man pages.
Jeremy.
(This used to be commit 0451a170c9)
2007-10-10 11:38:12 -05:00
Jeremy Allison
38af904c31 r17107: Make the 200 ms timeout value tunable in local.h...
Might need to be a parameter ?
Jeremy.
(This used to be commit 98d8d9399b)
2007-10-10 11:38:12 -05:00
Jeremy Allison
a456a31309 r17106: Match Windows timing values on locks.
Jeremy.
(This used to be commit b5aaff6659)
2007-10-10 11:38:12 -05:00
Jeremy Allison
b737f26764 r17105: Fix the race Volker found - we had a non-locked
region between detecting a pending lock was needed
and when we added the blocking lock record. Make
sure that we hold the lock over all this period.
Removed the old code for doing blocking locks on
SMB requests that never block (the old SMBlock
and friends).
Discovered something interesting about the strange
NT_STATUS_FILE_LOCK_CONFLICT return. If we asked
for a lock with zero timeout, and we got an error
of NT_STATUS_FILE_LOCK_CONFLICT, treat it as though
it was a blocking lock with a timeout of 150 - 300ms.
This only happens when timeout is sent as zero and
can be seen quite clearly in ethereal. This is the
real replacement for old do_lock_spin() code.
Re-worked the blocking lock select timeout to correctly
use milliseconds instead of the old second level
resolution (far too coarse for this work).
Jeremy.
(This used to be commit b81d6d1ae9)
2007-10-10 11:38:12 -05:00
Günther Deschner
94ad8543bd r17102: Fix segfault in libnss_wins [bugzilla #3937].
Guenther
(This used to be commit d73d0ec3d0)
2007-10-10 11:38:12 -05:00
Jeremy Allison
8d6c41a75a r17100: Ooops. Fix the build...
Jeremy.
(This used to be commit b21ca265a2)
2007-10-10 11:38:11 -05:00
Jeremy Allison
e1da1fcf12 r17098: Samba3 now cleanly passes Samba4 RAW-LOCK torture
test. Phew - that was painful :-). But what it means
is that we now implement lock cancels and I can add
lock cancels into POSIX lock handling which will fix
the fast/slow system call issue with cifsfs !
Jeremy.
(This used to be commit f1a9cf075b)
2007-10-10 11:38:11 -05:00
Volker Lendecke
4c713703d0 r17097: Move share_access_check from rpc_server/srv_srvsvc_nt.c to lib/sharesec.c
(This used to be commit 220dd43330)
2007-10-10 11:38:11 -05:00
Volker Lendecke
283b74fce5 r17096: Simplify share_access_check a bit: It takes the sharename instead of the snum,
and the decision which token to use (conn or vuser) does not really belong
here, it is better done in the two places where this is called.

Volker
(This used to be commit 0a138888ad)
2007-10-10 11:38:11 -05:00
Volker Lendecke
03f477b8a6 r17095: Activate RPC-SAMBA3-SHARESEC
(This used to be commit bcb196d21e)
2007-10-10 11:38:11 -05:00
Volker Lendecke
846e939260 r17089: Fix a possible null dereference and some memleaks.
Jerry, please check.

Thanks,

Volker
(This used to be commit b87c495221)
2007-10-10 11:38:11 -05:00
Günther Deschner
9c160dd9a7 r17086: Re-add ability to contact remote domain controllers with the "net ads"
toolset.

In 3.0.23 all those commands have been limited to the DC of our primary
domain. Also distinguish calls that may go to remote DCs (search, info,
lookup, etc.) from those that should only go to our primary domain
(join, leave, etc.).

Guenther
(This used to be commit d573e64781)
2007-10-10 11:38:10 -05:00
Jeremy Allison
6954377403 r17080: Remove traces of the wrepld directory (now
deleted).
Jeremy.
(This used to be commit 58e5e270d2)
2007-10-10 11:38:10 -05:00
Volker Lendecke
514af16de5 r17078: Ouch....
(This used to be commit 1d928f783a)
2007-10-10 11:38:10 -05:00
Volker Lendecke
95fd775e81 r17077: Activate RPC-SAMBA3-GETUSERNAME in the build farm
(This used to be commit 8c6088f2bd)
2007-10-10 11:38:10 -05:00
Volker Lendecke
d2b11041b2 r17075: Even without talloc_steal you can still create memory problems.... ;-)
(This used to be commit 03e9924f5c)
2007-10-10 11:38:10 -05:00
Volker Lendecke
f512695ea4 r17064: lsa_GetUserName needs to return the name for S-1-5-7 on an anonymous login.
Found that because I want to play around with setsharesecurity, for this I
need the "whoami" call figuring out the SID of the currently connected user.

Not activating this test yet until the build farm has picked up the new samba4
revision.

Volker
(This used to be commit 5cfe482841)
2007-10-10 11:38:10 -05:00
Volker Lendecke
5fe140babc r17060: Some c++ warnings
(This used to be commit 2e7afa9e19)
2007-10-10 11:19:22 -05:00
Volker Lendecke
4f33673b41 r17047: Fix a typo and a possible NULL dereference
(This used to be commit c0d9114706)
2007-10-10 11:19:22 -05:00
Jeremy Allison
354e444ee3 r17046: Ensure we're using the right pointers ...
Jeremy.
(This used to be commit a8df1863bf)
2007-10-10 11:19:22 -05:00
Jeremy Allison
ad673ea988 r17043: Fix memleak when processing CIFS POSIX lock/unlock
requests. Maybe the Linux kernel OOM killer will
be kinder to smbd now :-). Back to tdbtorture
tests on cifsfs.
Jeremy.
(This used to be commit 1201383e7a)
2007-10-10 11:19:21 -05:00
Jeremy Allison
d22d540c32 r17041: Trying to track down a *big* memory leak in the new lock code.
Fix a small one first.... (easy to valgrind).
Jeremy
(This used to be commit 43d24fbd41)
2007-10-10 11:19:21 -05:00
Volker Lendecke
2203228c79 r17039: Eliminate snum from enumshares and getshareinfo. Get rid of some pstrings.
Volker
(This used to be commit c5e393d5ed)
2007-10-10 11:19:21 -05:00
Volker Lendecke
5b474afa74 r17033: Restructure init_srv_share_info_ctr so that there's only one loop, not a dozen
or so. Next step will be to eliminate the explicit snum reference.

Volker
(This used to be commit 6e98f8d6c6)
2007-10-10 11:19:21 -05:00
Volker Lendecke
1f2419d9f8 r17032: I thought I had already merged this from trunk:
> r16959 | vlendec | 2006-07-11 23:10:44 +0200 (Di, 11 Jul 2006) | 1 line
>
> get_share_security does not need snum, activate RPC-SAMBA3-SRVSVC

Volker
(This used to be commit c89471e157)
2007-10-10 11:19:21 -05:00
Jeremy Allison
2a2d67f5ad r17030: Partially fix standalone build of tdb directory
(tdbtool still fails).
Jeremy.
(This used to be commit 50dbb66d73)
2007-10-10 11:19:21 -05:00
Jeremy Allison
5f0e9cc4e6 r17025: Remove one blank line - test checking in to two
branches simultaneously.....
Jeremy.
(This used to be commit 13e7fe540a)
2007-10-10 11:19:21 -05:00
Gerald Carter
f57c18b946 r17023: security = server should not be considerd ROLE_DOMAIN_MEMBER
(This used to be commit 6eb77442a5)
2007-10-10 11:19:20 -05:00
Volker Lendecke
413ec64f27 r17022: Fix the build farm -- maybe this is the real fix, testing more
(This used to be commit 19d0269000)
2007-10-10 11:19:20 -05:00
Gerald Carter
0ea9508d53 r17021: remove unsupported smbwrapper code
(This used to be commit 07c67fbfc0)
2007-10-10 11:19:20 -05:00
Gerald Carter
803748b15d r17017: BUG 3916: fix pam config file parsing in pam_winbind.
Patch from Dietrich Streifert <dietrich.streifert@visionet.de>
(This used to be commit 8d62188258)
2007-10-10 11:19:20 -05:00
Volker Lendecke
f8004328f4 r17016: Different and smaller fix for the valid users = username problem.
If no winbind is around, the best we can do to get the user's token correct is
to ask unix via create_token_from_username. More investigation is needed if
this also fixes the +groupname for unmapped groups problems more cleanly.

Volker
(This used to be commit f6e3ee147f)
2007-10-10 11:19:20 -05:00