Jeremy Allison
1e315b0013
Fix coverity #910 , uninitialized variable.
...
Jeremy.
2009-04-23 01:38:21 -07:00
Volker Lendecke
8bc88aae5d
Move serverinfo_to_SamInfo3() to rpc_server/
...
Normally I hate moving around stuff, but this function is only called from the
RPC server side and it pulls in passdb when trying to link in our rpc client
routines. That seems unnecessary to me.
2009-04-22 12:33:46 +02:00
Jelmer Vernooij
f4195183a4
s3: Use common security_descriptor_equal().
2009-04-21 18:17:40 +02:00
Volker Lendecke
4024abb0a8
Remove "struct samr_info"
2009-04-21 14:18:34 +02:00
Volker Lendecke
3f39df75d8
Fix _samr_QuerySecurity
2009-04-21 14:18:34 +02:00
Volker Lendecke
512cf3ea24
Fix samr_SetSecurity
2009-04-21 14:18:34 +02:00
Volker Lendecke
922f836b82
Convert the alias handles to type-safe policy handles
2009-04-21 12:02:28 +02:00
Volker Lendecke
228c56f8ec
Convert the group handles to type-safe policy handles
2009-04-21 12:02:28 +02:00
Volker Lendecke
95a76d3c98
Convert the user handles to type-safe policy handles
2009-04-21 12:02:28 +02:00
Andrew Bartlett
a11ecbbff0
Merge branch 'master' of ssh://git.samba.org/data/git/samba into libcli-auth-merge-without-netlogond
2009-04-20 17:19:45 +02:00
Andrew Bartlett
6c9caed481
Merge commit 'origin/master' into libcli-auth-merge-without-netlogond
2009-04-20 16:53:02 +02:00
Volker Lendecke
e3db09cf02
Do not vasprint stuff where not necessary
2009-04-20 16:51:44 +02:00
Jeremy Allison
86b0d56897
Fix warning in use of talloc_set_name.
...
Jeremy.
2009-04-20 04:05:12 -07:00
Volker Lendecke
4afcde91b9
Convert the domain handles to type-safe policy handles
2009-04-20 08:27:23 +02:00
Volker Lendecke
dd073a333e
Make force_flush_samr_cache use a dom_sid to find what to flush
2009-04-19 22:58:06 +02:00
Volker Lendecke
46317ce214
Remove flag "builtin_domain" from disp_info
2009-04-19 11:39:47 +02:00
Volker Lendecke
bf196df52f
Remove flag "builtin_domain" from samr_info
2009-04-19 09:27:15 +02:00
Volker Lendecke
386511b8e1
Make get_samr_info_by_sid use recent coding conventions
2009-04-19 09:27:15 +02:00
Volker Lendecke
35e6a0e618
Add "uint32_t access_granted" to policy handles
...
All policy handles have a mask of allowed operations attached that were
calculated at creation time, so they should carry this mask. This is the basis
for consolidating all our policy handle access checks.
If you want to do your own more complicated access checks further down, just
pass "0" to policy_handle_find.
2009-04-19 09:27:15 +02:00
Volker Lendecke
9b3f2e69f7
Make "struct policy" private to srv_lsa_hnd.c
2009-04-19 09:27:14 +02:00
Volker Lendecke
fa4ff87acd
Convert the samr connect_handles to type-safe calls
2009-04-18 13:58:48 +02:00
Volker Lendecke
c9bc1728f9
Add type-safe policy_handle_create/find
2009-04-18 13:58:48 +02:00
Volker Lendecke
fd558b37f6
Add some const
2009-04-18 13:58:48 +02:00
Günther Deschner
81b18464be
s3-spoolss: remove some direct checks for 0 uid in AddForm,SetForm,DelForm.
...
Also add some become_root()/unbecome_root() pairs which were missing IMHO.
Guenther
2009-04-17 23:20:22 +02:00
Günther Deschner
6900d61d36
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 6.
...
Guenther
2009-04-17 17:27:32 +02:00
Günther Deschner
5e563ee508
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 5.
...
Guenther
2009-04-17 17:27:26 +02:00
Günther Deschner
d76837f6da
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 4.
...
Guenther
2009-04-17 17:27:18 +02:00
Günther Deschner
0ba833f3ee
s3-samr: set the builtin_domain bool flag in get_samr_dispinfo_by_sid().
...
Volker, please check.
Found by torture test RPC-SAMR-PASSWORDS-PWDLASTSET (which we pass with
this fix).
Guenther
2009-04-17 11:21:20 +02:00
Günther Deschner
14304fc5e5
s3-lsa: Fix Bug #6263 . Unexpected LookupSids reply crashes XP pre-SP3.
...
LookupSids needs to bounce back string sids in case of NT_STATUS_NONE_MAPPED.
Guenther
(cherry picked from commit 1c9266c8ca
)
2009-04-16 01:52:56 +02:00
Jeremy Allison
d9804ae3cc
Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+
...
What a difference a name makes... :-). Just because something is missnamed
SAMR_ACCESS_OPEN_DOMAIN, when it should actually be SAMR_ACCESS_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
2009-04-15 15:40:00 -07:00
Andrew Bartlett
4678d1c6f4
Merge branch 'master' of ssh://git.samba.org/data/git/samba into libcli-auth-merge-without-netlogond
2009-04-15 14:36:13 +10:00
Günther Deschner
4721be488c
s3-spoolss: Fix format of description string in spoolss_PrinterInfo1.
...
This is what windows does and should get us closer to show the appropriate
printer location string in explorer.
Guenther
2009-04-14 23:21:47 +02:00
Günther Deschner
fa302020ee
s3-svcctl: fix memcpy in _svcctl_EnumServicesStatusW().
...
Make sure we are not copying more than what we have as valid data.
Fix from Jeremy. Thanks a lot for watching this so closely!
Guenther
2009-04-14 12:13:24 +02:00
Andrew Bartlett
f28f113d8e
Rework Samba3 to use new libcli/auth code (partial)
...
This commit is mostly to cope with the removal of SamOemHash (replaced
by arcfour_crypt()) and other collisions (such as changed function
arguments compared to Samba3).
We still provide creds_hash3 until Samba3 uses the credentials code in
netlogon server
Andrew Bartlett
2009-04-14 16:23:35 +10:00
Günther Deschner
a79e1ce048
s3-spoolss: fix typo in fill_printer_driver_info3().
...
Guenther
2009-04-13 23:45:12 +02:00
Günther Deschner
3ef0b8671d
s3-spoolss: Fix permission checks for _spoolss_AddForm,SetForm and DelForm.
...
Found by smbtorture test.
Guenther
2009-04-13 16:15:32 +02:00
Günther Deschner
97ffd709f8
s3-spoolss: use enumprinterdrivers_level() for level 3 enum.
...
Guenther
2009-04-13 16:12:56 +02:00
Günther Deschner
9b3d3e8aeb
s3-spoolss: use enumprinterdrivers_level() for level 2 enum.
...
Guenther
2009-04-13 16:12:49 +02:00
Günther Deschner
f325c34203
s3-spoolss: use enumprinterdrivers_level() for level 1 enum.
...
Guenther
2009-04-13 16:12:42 +02:00
Günther Deschner
0393c99302
s3-spoolss: add generic enumprinterdrivers_level function.
...
Guenther
2009-04-13 16:12:35 +02:00
Günther Deschner
bc5cd07764
s3-spoolss: implement dummy _spoolss_AddPort().
...
Guenther
2009-04-10 13:25:09 +02:00
Günther Deschner
65ee4ae30b
s3-spoolss: add support for level 8 in _spoolss_GetPrinter().
...
Guenther
2009-04-10 13:25:01 +02:00
Günther Deschner
bcd042e595
s3-eventlog: implement _eventlog_FlushEventLog().
...
Guenther
2009-04-10 13:15:25 +02:00
Günther Deschner
9b585a1282
s3-eventlog: implement _eventlog_GetLogInformation().
...
Guenther
2009-04-10 13:15:24 +02:00
Günther Deschner
b7caf13851
s3-ntsvcs: fix _PNP_GetDeviceList and _PNP_GetDeviceListSize.
...
Guenther
2009-04-10 01:06:57 +02:00
Günther Deschner
76da89daaa
s3-svcctl: minor fix for _svcctl_EnumDependentServicesW().
...
Guenther
2009-04-09 16:42:28 +02:00
Günther Deschner
8b9f2abfcb
s3-svcctl: Fix invalid buffer memset in _svcctl_QueryServiceObjectSecurity().
...
Found by torture-test.
Guenther
2009-04-09 15:08:29 +02:00
Günther Deschner
acd7fef984
s3-svcctl: Fix _svcctl_Set/GetServiceObjectSecurity after IDL changes.
...
Guenther
2009-04-09 14:51:21 +02:00
Günther Deschner
d8a6ea8141
s3-svcctl: Fix _svcctl_EnumServicesStatusW (again).
...
The final plan is to use the same macro based code that we have in spoolss to
handle the buffers and calculate the buffer-sizes.
Guenther
2009-04-08 23:23:17 +02:00
Günther Deschner
98d703a6b7
s3-eventlog: move rpc_server/srv_eventlog_lib.c out of rpc_server.
...
Guenther
2009-04-08 19:45:57 +02:00