Volker Lendecke
1e50f9a5c2
charconv: Fix the slow-path character conversions
...
This reverts a part of 0189087e25
. That one might have fixed the fast path,
but it broke the slow path. convert_string_internal returns 0/-1 despite the
size_t result type and the misleading comment. If you follow the path to
smb_iconv and for example iconv_copy(), you will see that this routine returns
0 even after it copied something.
How to check: Use German locale, and do an smbclient "allinfo" on a file
modified in march (März in German). Notice the "ä". Before 0189087
this printed
correctly, after 0189087
it cut off the fields after the M for März.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Mar 29 19:17:41 CEST 2011 on sn-devel-104
2011-03-29 19:17:41 +02:00
Günther Deschner
52ff0dde37
s3-libsmb: remove duplicate NTSTATUS variable.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 29 17:00:26 CEST 2011 on sn-devel-104
2011-03-29 17:00:26 +02:00
Günther Deschner
6a27928ced
s3-waf: fix spoolssd compile.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:54 +02:00
Andreas Schneider
2cb797456a
s3-rpc_server: Fixed rpc_pipe_open_internal documentation.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:54 +02:00
Andreas Schneider
8dc5805738
s3-rpc_server: Only allow embedded, daemon and external server type.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:53 +02:00
Andreas Schneider
991fa3a5fe
s3-spoolssd: Start the spoolss service correctly.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:53 +02:00
Andreas Schneider
28b2046015
s3-spoolssd: Register spoolssd endpoints.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:53 +02:00
Andreas Schneider
8c635b669c
s3-epmap: Make rpc_ep_setup_register an internal function.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:52 +02:00
Andreas Schneider
80fe8fa8d0
s3-spoolssd: Fixed logfile creation.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:52 +02:00
Andreas Schneider
a956c57cf9
s3-spoolssd: Added missing include.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:52 +02:00
Andreas Schneider
c1b7c0c2b7
s3-spoolssd: Pass down event and messanging context.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:52 +02:00
Andreas Schneider
851f95b121
s3-spoolssd: Fixed reopening of logs.
...
Everytime the log was reopened a .spoolssd has been appended which
resulted in long file names.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:51 +02:00
Simo Sorce
fe0e079bc1
s3:spoolssd Start spoolss from smbd
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:51 +02:00
Simo Sorce
043942720c
s3:spoolssd Initialize the spoolss rpc interfaces
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:51 +02:00
Simo Sorce
0c130105f5
s3:spoolssd Add spoolss own signal handlers
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:50 +02:00
Simo Sorce
0b7b8414dd
s3:spoolssd handle smb.conf reloads directly
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:50 +02:00
Simo Sorce
2d333ae8bc
s3:spoolssd Create our own log file
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:50 +02:00
Simo Sorce
99941eb92b
s3:spoolssd Add skeleton for spoolss daemon
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:50 +02:00
Simo Sorce
1d33474dad
s3:printing Make print_queue_receive public
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-29 16:03:49 +02:00
Andrew Tridgell
bd9b2727ef
ldb: detect eof on ldif files
...
use feof() to detect parsing errors in ldif files
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Mar 29 08:24:04 CEST 2011 on sn-devel-104
2011-03-29 08:24:03 +02:00
Andrew Tridgell
daeb6a02ea
s4-dsdb: allow modification of linked attribute targets with relax
...
this is used to help recover a corrupt database.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 07:37:04 +02:00
Andrew Tridgell
af31bf6bf5
debug: ignore debug_set_logfile() with a blank string
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Mar 29 07:03:58 CEST 2011 on sn-devel-104
2011-03-29 07:03:58 +02:00
Andrew Tridgell
3351897924
s4-cmdline: moved loadparm init after fault setup
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 06:17:03 +02:00
Andrew Tridgell
77cc1610e0
s4-param: set a default logfile
...
setup a logfile for when one is not specified in smb.conf
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 06:17:03 +02:00
Andrew Tridgell
8d2d0ef0eb
lib: removed a spurios declaration of 'logfile'
...
we don't have a global logfile variable any more
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 06:17:03 +02:00
Jeremy Allison
bae14fba52
Remove two unused labels.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Mar 29 02:23:02 CEST 2011 on sn-devel-104
2011-03-29 02:23:02 +02:00
David Disseldorp
db966efe8a
=?UTF-8?q?alpha=5Fstrcpy()=20is=20a=20utility=20function=20which=20reportedly:
...
=20Strips=20out=20all=20but=20'a-Z0-9'=20and=20the=20character=20in=20other=5Fsafe=5Fchars=20and
=20replaces=20with=20'=5F'.
=20This=20statement=20does=20not=20currently=20hold=20true=20in=20all=20cases=20(e.g.=20src=20=3D
=20"=D0=A2=D0=90=D0=9D=D0=A6=D0=95=D0=92=D0=90=D0=A2=D0=AC").?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
2011-03-29 01:35:23 +02:00
Michael Adam
e0681441af
s3:rpc_client: fix argument order of call to lsa_open_policy2 in rpccli_lsa_open_policy2
...
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Mar 29 01:34:28 CEST 2011 on sn-devel-104
2011-03-29 01:34:28 +02:00
Andrew Bartlett
2c0d80259a
s3-selftest Fix test_smbclient_auth.sh
...
The -N in the command line meant that all the logins were as the
guest, not as the user specified.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Mar 29 00:47:50 CEST 2011 on sn-devel-104
2011-03-29 00:47:50 +02:00
Andrew Bartlett
29fabfd3ea
s3-selftest Allow LM passwords and turn of NTLMv2 for security=share test
2011-03-29 00:00:23 +02:00
Andrew Bartlett
c8bc7089f5
s3-selftest Add tests for security=server
...
Andrew Bartlett
2011-03-29 00:00:23 +02:00
Andrew Bartlett
2839391c7d
s3-selftest unconditionaly include subunit.sh
...
we no longer . this file into other shell scripts, so we don't need
this check any more.
Andrew Bartlett
2011-03-29 00:00:23 +02:00
Andrew Bartlett
53ddac3f27
wintest New snapshot for my wintest VMs
2011-03-29 00:00:23 +02:00
Andrew Tridgell
ef44794097
s4-fsmo: say which role is being transferred
...
this is particularly useful for "samba-tool fsmo transfer --role=all"
2011-03-29 00:00:23 +02:00
Andrew Tridgell
3600f2e250
s4-fsmo: samba-tool fsmo transfer now gets full error code
...
We now wait for the transfer to succeed or fail
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 00:00:22 +02:00
Andrew Tridgell
b32f155bae
s4-dsdb: perform FSMO transfers asynchronously
...
this gives the administrator a proper error message on the command
line
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 00:00:22 +02:00
Andrew Tridgell
358892e836
s4-fsmo: make rootDSE modify for FSMO transfer async
...
this gives the ldap client the error code from the transfer
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 00:00:22 +02:00
Andrew Tridgell
f4e3ccfe9e
s4-fsmo: nicer error messages on failed FSMO transfers
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 00:00:22 +02:00
Andrew Tridgell
07b6f75bc1
s4-drs: default hostname in samba-tool drs command
...
default to our hostname
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 00:00:22 +02:00
Andrew Tridgell
fdd9540187
s4-dsdb: only allow administrators to trigger FSMO role transfers
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 00:00:22 +02:00
Andrew Tridgell
f4d581468c
s4-fsmo: samba-tool fsmo takes a URL, not a hostname
...
better to call the option --url
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 00:00:22 +02:00
Andrew Tridgell
9eb9b11bfd
wintest: added a "ipconfig /flushdns"
...
w2k3 doesn't flush its DNS cache on a dynamic update
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 00:00:22 +02:00
Andrew Tridgell
22cbd04fd7
wintest: fixed syntax highlighting with emacs
2011-03-29 00:00:22 +02:00
Andrew Tridgell
b85bb3e386
wintest: ensure we startup the w2k3 DC VM
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 00:00:22 +02:00
Jeremy Allison
67aa53a1e1
Be a little clearer about when and when not to set this option.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Mar 28 23:59:47 CEST 2011 on sn-devel-104
2011-03-28 23:59:47 +02:00
Jeremy Allison
52602e4f5a
Fix inspired by work done by David Disseldorp for bug #8040 - smbclient segfaults when a Cyrillic netbios name or workgroup is configured.
...
Change msrpc_gen to return NTSTATUS and ensure everywhere this is
used it is correctly checked to return that status.
Jeremy.
2011-03-28 23:12:07 +02:00
Volker Lendecke
fbe19ba398
s3: Fix Coverity ID 2143: DEADCODE
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Mar 28 12:06:19 CEST 2011 on sn-devel-104
2011-03-28 12:06:19 +02:00
Volker Lendecke
05dac2b7e6
s3: Fix Coverity ID 2143: DEADCODE
2011-03-28 11:16:55 +02:00
Volker Lendecke
6e9b69fb07
s3: Fix Coverity ID 2173: FORWARD_NULL
2011-03-28 11:16:55 +02:00
Stefan Metzmacher
dc36d75d5f
Revert "Change strict allocate to default to true.
...
This reverts commit ecf48af135
.
This makes Samba unusable on systems without Linux and
a modern Filesystem.
This was discussed with Jeremy on IRC:
http://irclog.samba.org/2011/01/20110126-Wed.log
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Mar 28 09:00:09 CEST 2011 on sn-devel-104
2011-03-28 09:00:09 +02:00