Jeremy Allison
1fb1c67fb9
Patch from SATOH Fumiyasu <fumiyas@osstech.co.jp> for bug #5202 . Re-activate "acl group control"
...
parameter and make it only apply to owning group. Also added man page fix.
Jeremy.
(This used to be commit e98e080bad
)
2008-07-03 10:24:12 -07:00
Volker Lendecke
b611fd9550
Remove an unused variable
...
(This used to be commit 454cb852e0
)
2008-07-03 16:44:13 +02:00
Volker Lendecke
352b5c1857
Remove gencache_[un]lock_entry
...
Günther agreed that it might be unnecessary in dsgetdcname_cache_store() :-)
(This used to be commit 7a5a575ffe
)
2008-07-03 16:40:46 +02:00
Volker Lendecke
c4503f5658
Return timed out entries from gencache_get if timeout param != NULL
...
net cache get was the only one interested in the timeout. That single caller
can take care of the timeout itself then.
With this API change idmap_cache.c can be converted to gencache.
(This used to be commit 2954b2be56
)
2008-07-03 15:59:19 +02:00
Volker Lendecke
962beb2872
Pass NULL to gencache_get when we are not interested in the timeout value
...
(This used to be commit 16062dfc3d
)
2008-07-03 15:17:58 +02:00
Volker Lendecke
47f1090de7
Fix indentation
...
(This used to be commit c4e6de9e34
)
2008-07-03 15:17:58 +02:00
Günther Deschner
b74c0fa10f
netapi: fix doxygen warning.
...
Guenther
(This used to be commit cfd59383d6
)
2008-07-03 12:13:11 +02:00
Günther Deschner
2c703ec720
libnetjoin: fix Bug #5570 .
...
Thanks to Atte Peltomäki.
Guenther
(This used to be commit 144d374ad9
)
2008-07-03 12:02:01 +02:00
Günther Deschner
968c91b883
Fix build warning.
...
Thanks to Thorkil Olesen.
Guenther
(This used to be commit 3130aa63fd
)
2008-07-03 11:10:21 +02:00
Volker Lendecke
d1635687ae
Don't scream, better explain a bit in comments
...
(This used to be commit dcc39ed004
)
2008-07-03 11:08:51 +02:00
Volker Lendecke
abb42b267b
Make use of sid_check_is_in_unix_users/groups
...
Don't replicate code unnecessarily
(This used to be commit cd8e63b2b4
)
2008-07-03 11:08:51 +02:00
Jeremy Allison
12f0163e26
Remove worrying warning message when safe_strcpy tries to copy a pseaudo interface
...
name that's too long. Reported by James Kosin <JKosin@intcomgrp.com>.
Jeremy.
(This used to be commit 3a7542fd49
)
2008-07-02 16:31:16 -07:00
Jeremy Allison
7cd752bce3
Canonicalize servername in the printer functions to remove leading '\\' characters. Ensure we always return consistent names.
...
Jeremy.
(This used to be commit fc2178b047
)
2008-07-02 16:11:59 -07:00
Jeremy Allison
4b88ff157d
Fix bug #5578 , reported by sendel2000@hotbox.ru. Bad (non-Samba) use of strlcat gives error.
...
Jeremy.
(This used to be commit d7c82997bd
)
2008-07-02 11:57:13 -07:00
Jeremy Allison
765c3b953d
Ensure consistent use of pdb_get_nt_passwd instead of pdb_get_lanman_passwd.
...
Reported by hongbing Zhang <hongbing.zhang@gmail.com>.
Jeremy.
(This used to be commit ade27d8baa
)
2008-07-02 10:51:45 -07:00
Volker Lendecke
ec7aa52a3b
Fix typo
...
(This used to be commit fe79c8a5b7
)
2008-07-02 15:13:14 +02:00
Volker Lendecke
7207b41a5e
Tiny logic simplification: Remove an unnecessary else branch
...
(This used to be commit 6009ae3293
)
2008-07-02 15:13:01 +02:00
Volker Lendecke
e467fae948
Fix nonempty whitespace only lines
...
(This used to be commit cc77db2acb
)
2008-07-02 15:04:46 +02:00
Volker Lendecke
ec77a06a5d
fix typos
...
(This used to be commit e0957c6f4b
)
2008-07-02 14:54:59 +02:00
Volker Lendecke
62dddd04f4
Fix nonempty whitespace only lines
...
(This used to be commit 0da9d0d0f9
)
2008-07-02 14:18:15 +02:00
Volker Lendecke
69b9cffe6e
Fix indentation
...
(This used to be commit 954556b527
)
2008-07-02 14:18:10 +02:00
Volker Lendecke
d6ab71f06c
Fix a debug msg, this was probably a leftover from gencache
...
(This used to be commit daa171552d
)
2008-07-02 14:18:05 +02:00
Volker Lendecke
dd7691ce68
Fix typo
...
(This used to be commit fe58926283
)
2008-07-02 14:18:01 +02:00
Volker Lendecke
1999791b7c
Make idmap_init() static
...
This is called only from idmap_alloc_init, which feels kindof weird.
Digging deeper in the code...
(This used to be commit c8d1bbfddc
)
2008-07-02 13:34:09 +02:00
Volker Lendecke
ab57861686
Fix two memory leaks in an error path in idmap.c
...
(This used to be commit 7cec389e19
)
2008-07-02 13:34:09 +02:00
Darshan Purandare
065760ede0
MSG_DEBUG now forwarded to all the winbindd children by parent.
...
smbcontrol winbindd debug level would only set the debug level of the
parent winbindd process and not the child processes. This patch adds
the functionality of broadcasting the debug message to all winbindd
children. Now the debug level message is propagated to all the winbindd
processes that includes parent and children.
(This used to be commit cfbcfc3ffe
)
2008-07-01 17:52:24 -07:00
Jeremy Allison
570d5ecdbd
Jim Brown <jim.brown@miami.edu> was right, this needs to be a signed int or
...
the loop never terminates.
Jeremy.
(This used to be commit 80e547665d
)
2008-07-01 15:51:54 -07:00
Jeremy Allison
4a09c5a09f
Two more fixes from Jim Brown <jim.brown@miami.edu> for SGI compiler warnings.
...
Jeremy.
(This used to be commit d85cbdbe29
)
2008-07-01 15:39:41 -07:00
Jeremy Allison
4a8b39974b
Fix problem noticed by Jim Brown <jim.brown@miami.edu>. When reverse searching decrement index,
...
not increment. Michael please check !
Jeremy.
(This used to be commit d89f9d404f
)
2008-07-01 15:28:13 -07:00
Karolin Seeger
3b1de7f7f4
Revert "winbind cache: Don't create SN cache entries during name-to-sid queries."
...
This reverts commit b58e4f6b3d
.
Details can be found on the samba-technical mailing list.
Karolin
(This used to be commit 534a445df4
)
2008-07-01 10:34:22 +02:00
Günther Deschner
9b0e3bb0c3
net_vampire: add code to vampire to a Kerberos keytab file using DRSUAPI.
...
Guenther
(This used to be commit 0ef420c3a4
)
2008-07-01 10:02:01 +02:00
Günther Deschner
fc836440a5
net_vampire: keep keytab context and flush keytab only after the last query.
...
Guenther
(This used to be commit 48efe7dbce
)
2008-07-01 10:00:57 +02:00
Jeremy Allison
4aaa3a0fac
Fix from Atte Peltomki - atte.peltomaki@f-secure.com to correctly check
...
error code in winbindd group expansion.
Jeremy.
(This used to be commit e321377174
)
2008-06-30 09:20:05 -07:00
Günther Deschner
16e44ee112
kerberos: allow to keep entries with old kvno's while creating keytab.
...
Guenther
(This used to be commit 6194244bd9
)
2008-06-30 12:38:40 +02:00
Günther Deschner
52635c6f58
kerberos: rename smb_krb5_kt_add_entry to smb_krb5_kt_add_entry_ext.
...
Guenther
(This used to be commit 48600a0019
)
2008-06-30 12:38:32 +02:00
Volker Lendecke
7b3541f39b
Fix a file descriptor leak in add_port_hook
...
This was probably cut&paste from add_printer_hook which further down has the
unconditional close(fd). In add_port_hook() we're not interested in the output
of 'addport command', so don't create the out fd.
(cherry picked from commit 0c5ca2127a
)
(This used to be commit 9fe09398b7
)
2008-06-28 16:10:50 +02:00
Gerald W. Carter
893e3522fc
Return NULL in sitename_fetch() if gencache_init() fails. Not false
...
(This used to be commit 8704c2ab37
)
2008-06-28 09:36:30 -04:00
Volker Lendecke
cf9665016f
Let send_trans_reply work on only the inbuf
...
It does not really need the whole smb_request
(This used to be commit d3facf4cbd
)
2008-06-28 10:38:51 +02:00
Volker Lendecke
5cd8a42720
Factor out create_outbuf, creating an outbuf just given an inbuf
...
(This used to be commit 50427cbf63
)
2008-06-28 10:38:51 +02:00
Volker Lendecke
3353565faf
Fix the build
...
(This used to be commit 242077f714
)
2008-06-28 10:38:51 +02:00
Jeremy Allison
f083c1f57e
Fix bug #5568 net rpc trustdom add broken !
...
net rpc trustdom add was broken. The default 10second timeout can be too short
to create an account on a Samba DC (calling out to a script), error message
reporting was poor, and more importantly the new marshalling code for
user_info23 was broken (maps onto a user_info21 but doesn't clear the
user_info23 struct before marshalling, leaving an uninitialized size field -
give "alloc failure").
Jeremy.
(This used to be commit e072b3667e
)
2008-06-27 17:26:41 -07:00
Jeremy Allison
23e4a41362
Fix usage message for net rpc trustdom add.
...
Jeremy.
(This used to be commit 20e59faf6e
)
2008-06-27 15:28:45 -07:00
Volker Lendecke
15ac8b6bc1
Do not segfault if corepath is not set up properly
...
(This used to be commit 41d1b9541c
)
2008-06-27 16:57:12 +02:00
Gerald W. Carter
9ff1ffcbee
libads: Add API call to connect to a global catalog server.
...
Extends ads_connect() to a new call ads_connect_gc() which connects on port
3268 rather than port 389. Also makes ads_try_connect() static and
only used internally to ldap.c
(This used to be commit f4c37dbe2c
)
2008-06-27 10:26:11 -04:00
Karolin Seeger
e08943f8d8
Fix warnings on SuSE 9.0.
...
The macros "[un]likely" are already defined on SuSE 9.0.
Patch from Volker.
(This used to be commit 30d181c924
)
2008-06-27 15:51:35 +02:00
Karolin Seeger
006515d889
Revert "build: add symbol versioning when we build with gnu ld"
...
This reverts commit cb5492978b
.
For more information, please have a look at the discussion on
samba-technical starting with [1].
[1] http://lists.samba.org/archive/samba-technical/2008-June/059511.html
Karolin
(cherry picked from commit 1e5aeb96f9
)
(This used to be commit d06baf0e74
)
2008-06-27 13:46:26 +02:00
Volker Lendecke
34dc60a74f
Fix two IBM checker warnings
...
Steve, please check!
Thanks,
Volker
(This used to be commit 5222b8db3f
)
2008-06-27 11:23:20 +02:00
Volker Lendecke
2a5dee2892
Fix an "invalid operation involving NULL pointer" found by the IBM checker
...
Jerry, please check!
Volker
(This used to be commit eb6096a2d4
)
2008-06-27 11:23:20 +02:00
Volker Lendecke
f287cdb1f0
Remove a strlen check that will never kick in
...
strlen(str)<2 will be caught by the explicit tests for str[0] and str[1] in the
lines above this.
Jerry, please check!
Volker
(This used to be commit 44a9e5b713
)
2008-06-27 11:23:20 +02:00
Jeremy Allison
799252f635
Fix the non-LDAP, non-krb5 build, fix gcc -O3 warnings.
...
Jeremy.
(This used to be commit 9e2ab30d3c
)
2008-06-26 19:46:18 -07:00