1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-31 17:18:04 +03:00
Commit Graph

24837 Commits

Author SHA1 Message Date
Volker Lendecke
f1cd0bdbcc Remove reference to current_user from reply.c
(This used to be commit e895e44cc7)
2008-06-19 18:51:38 +02:00
Volker Lendecke
40f5eab5eb Wrap the unix token info in a unix_user_token in auth_serversupplied_info
No functional change, this is a preparation for more current_user ref removal
(This used to be commit dcaedf345e)
2008-06-19 18:51:37 +02:00
Volker Lendecke
e40b6e296a Remove the "current_user" arg from fsp_belongs_conn
fsp_belongs_conn only used the vuid struct member anyway, and this is available
in the smb_request structure as well.
(This used to be commit 64e9372ab9)
2008-06-19 18:51:37 +02:00
Volker Lendecke
49ca8efa91 Remove the "current_user" arg from check_fsp
check_fsp only used the vuid struct member anyway, and this is available in the
smb_request structure as well.
(This used to be commit 8d364c4c33)
2008-06-19 18:51:37 +02:00
Michael Adam
769646efc6 loadparm: use the return value of the special handlers in lp_load().
Up to now, the bool return value was silently ignored.

Michael
(This used to be commit c65d425fec)
2008-06-19 17:22:27 +02:00
Michael Adam
09d769057e loadparm: don't treat a missing include file as an error in handle_include().
Michael
(This used to be commit a8ef8870be)
2008-06-19 17:22:27 +02:00
Michael Adam
0f32b22031 testsuite: enable the testparm_s3 tests.
Michael
(This used to be commit 0f5c13e573)
2008-06-19 17:22:27 +02:00
Michael Adam
24de341973 testsuite: add a testparm_s3 test script.
This is a first testparm/lp_load test that runs testparm on a couple
of configuration files. The main purpose for now is to test the options
that have special handlers (to check whether the handlers succeed).
In particular, all the Macro expansions that are available via
alloc_sub_basic() are tested with the include handler. This is to
catch such crashbugs as #5548 where %m expansion led to a segfault.

The tests now are very simple. Just check if testparm completes
successfully on the given config files. This can (and should) be
elaborated in the future.

Michael
(This used to be commit eb28146d40)
2008-06-19 17:22:27 +02:00
Michael Adam
b0c3f1459d testsuite: update introductory comment to test_net_regsistry.sh
This is now used to test rpc and local access depending on
command line parameters.

Michael
(This used to be commit 73c17b6303)
2008-06-19 17:22:27 +02:00
Volker Lendecke
39479c9ee6 Remove current_user_info reference from vfs_recycle.c
(This used to be commit fdc03c0a5b)
2008-06-19 15:53:43 +02:00
Volker Lendecke
3283a5d0de Remove current_user_info reference from vfs_fake_perms.c
(This used to be commit a227181e8d)
2008-06-19 15:53:43 +02:00
Volker Lendecke
ff215c4f81 Remove current_user_info reference from vfs_expand_msdfs.c
(This used to be commit 05a66980a9)
2008-06-19 15:53:43 +02:00
Volker Lendecke
17885401b8 current_user is not used in vfs_aixacl2.c
(This used to be commit 407136abdf)
2008-06-19 15:53:43 +02:00
Volker Lendecke
156cd09899 RWX on a file does not imply DELETE access
Without this the changed checks in can_delete_file_in_directory give DELETE
access where there is none. So we can end up granting the ntcreate&x preparing
the unlink where we should not, which leads to a NT_STATUS_ACCESS_DENIED at
close time later, which in turn does *not* give the access denied error message
in the Windows GUI.

can_delete_file_in_directory will grant access now by looking at the directory
permissions.
(This used to be commit 51b5364c2a)
2008-06-19 15:27:41 +02:00
Volker Lendecke
066f6c856f Fix checks in can_delete_file_in_directory()
With at least NFSv4 ACLs around the write permission for the owner is a bogus
check if we can delete a file in a directory. Like in Windows, there are two
ways which can grant us such: First, the DELETE permission on the file itself,
or if that does not help, the DELETE_CHILD permission on the directory. It
might be a bit more code that runs, but essentially we should end up with the
same set of syscalls in the non-acl case.
(This used to be commit daa9b05664)
2008-06-19 15:27:41 +02:00
Volker Lendecke
7df309c339 Remove some code
Did not measure it, but I think a single write is better than a read and a
conditional branch
(This used to be commit abe1bed665)
2008-06-19 12:03:31 +02:00
Volker Lendecke
809b992b17 Fix typo
(This used to be commit 2eef2c682c)
2008-06-19 12:02:12 +02:00
Volker Lendecke
bdc9391021 Fix the build on FreeBSD 4.6.2
(This used to be commit 4f50cb63e9)
2008-06-19 12:02:12 +02:00
Jeremy Allison
33aa758bf3 Fix 'make distclean'. delheaders: no longer exists as a dependency.
Jeremy.
(This used to be commit 8b26afdcdd)
2008-06-18 12:56:36 -07:00
Derrell Lipman
6398f945e8 Remove prototype of unimplemented smbc_chown() function.
(This used to be commit 0e84e3bb80)
2008-06-18 11:00:46 -04:00
Volker Lendecke
2b7fca9e79 Revert "Fix a memleak in svcctl_init_keys()"
This reverts commit b1afb31f3c.

This one is very strange: I need to investigate why valgrind showed it as
leaking, and why in my initial tests this did not fail.
(cherry picked from commit 24730f5981)
(This used to be commit b1e8e5d173)
2008-06-18 16:31:35 +02:00
Michael Adam
1917b38873 Fix Bug #5548 (segfauls in handle_include with %m macro expansion).
In alloc_sub_basic, when expanding '%m', substitute "" instead of
NULL for remote_machine when this is NULL. Else a NULL string
is returned.

Michael
(This used to be commit c65b456c6a)
2008-06-18 14:50:53 +02:00
Michael Adam
aedce263a8 file_access: add a function header comment for can_access_file_acl().
Michael
(This used to be commit 7d5fb873bd)
2008-06-18 00:06:46 +02:00
Michael Adam
24e7f40687 smbd/dir.c: remove unneeded stat buf parameter from user_can_read_file()
This is not needed anymore since user_can_access_file_acl() ist used.

Michael
(This used to be commit 3c349f773a)
2008-06-18 00:02:28 +02:00
Michael Adam
b172eb1d47 file_access: remove unneeded stat buf parameter from can_access_file_acl().
This is a security descriptor level function only.

Michael
(This used to be commit 5931540fa1)
2008-06-17 23:58:49 +02:00
Michael Adam
92c983292e net sam: fix typo in comment
Michael
(This used to be commit b9f6904044)
2008-06-17 23:57:26 +02:00
Michael Adam
00168e4d5a net sam: fix typo in debug message.
Michael
(This used to be commit 6d7f64c348)
2008-06-17 23:56:42 +02:00
Michael Adam
ba3eee6cf8 testsuite: give admin rights to testuser only for the "net rpc registry" test.
Remove the user from BUILTIN\Administrators at the end of the tests.
Note: BUILTIN\Administrators is not deletet at the end because that
functionality is not implemented.

Michael
(This used to be commit 1734f9305a)
2008-06-17 23:54:15 +02:00
Michael Adam
aeec9c7f55 testsuite: don't give the testuser administrative rights globally.
It breaks RPC-SAMBA3-GETUSERNAME for reasons I have not quite
understood yet. Somhow loosing rights fails when the user
belogns to BUILTIN\Administrators at some point.

Michael
(This used to be commit 9fe99c69f3)
2008-06-17 23:51:23 +02:00
Volker Lendecke
c8dfed63a6 Fix a brown paper bag segfault in clitar
Thanks to "No Body is Perfect" from gmail, whoever that is :-)

Volker
(cherry picked from commit 679d8dfa39)
(This used to be commit b8e1d62b8e)
2008-06-17 21:14:47 +02:00
Günther Deschner
8fd045f918 rpcclient: add more generic internal dscracknames call.
Guenther
(This used to be commit 2351b0845c)
2008-06-17 20:01:51 +02:00
Günther Deschner
44e153e3c1 netapi: use NetUserEnum filter in example code.
Guenther
(This used to be commit ad10517768)
2008-06-17 20:00:11 +02:00
Günther Deschner
b330ea29c7 netapi: add NetUserEnum filter constants to public headers.
Guenther
(This used to be commit 32a66131eb)
2008-06-17 20:00:00 +02:00
Günther Deschner
d0b7bccf6d netapi: implement NetUserEnum filters.
Guenther
(This used to be commit 0bd69df770)
2008-06-17 19:59:50 +02:00
Günther Deschner
68064b8101 re-run make idl.
Guenther
(This used to be commit 383636aaca)
2008-06-17 19:59:38 +02:00
Günther Deschner
a040b8be7d netapi: add NetUserEnum filter constants to IDL.
Guenther
(This used to be commit 12669b12c2)
2008-06-17 19:59:22 +02:00
Günther Deschner
08cf0bb878 netapi: some IDL cosmetics.
Guenther
(This used to be commit 4fd6bc61d0)
2008-06-17 19:58:39 +02:00
Günther Deschner
ffba83d22d netapi: add NetRemoteTOD example code.
Guenther
(This used to be commit 2b82779a40)
2008-06-17 19:58:11 +02:00
Günther Deschner
a2290e5e00 netapi: implement NetRemoteTOD().
Guenther
(This used to be commit 76877680a8)
2008-06-17 19:58:01 +02:00
Günther Deschner
feca006232 netapi: make NetRemoteTOD() headers public.
Guenther
(This used to be commit 1262ab1843)
2008-06-17 19:57:06 +02:00
Günther Deschner
ebbeddfdcd netapi: add NetRemoteTOD() skeleton.
Guenther
(This used to be commit 78bc98cb55)
2008-06-17 19:56:44 +02:00
Günther Deschner
de7de69530 re-run make idl.
Guenther
(This used to be commit 782ab0f1c1)
2008-06-17 19:56:27 +02:00
Günther Deschner
db1db7da92 netapi: add NetRemoteTOD() to IDL.
Guenther
(This used to be commit 8dd1a5fabf)
2008-06-17 19:56:16 +02:00
Günther Deschner
fefcb70f87 net_vampire: add error and result_message to samsync_context.
Guenther
(This used to be commit e0b1172004)
2008-06-17 19:55:16 +02:00
Günther Deschner
49b269f50f net_vampire: add domain_name to samsync_context.
Guenther
(This used to be commit 7e7f07ec59)
2008-06-17 19:55:10 +02:00
Günther Deschner
0447e6a0a7 libads: add ads_get_machine_kvno() to make ads_get_kvno() a bit more generic.
Guenther
(This used to be commit cb7ace209c)
2008-06-17 19:54:09 +02:00
Günther Deschner
fd288b4110 clikrb5: remove unrequired create_kerberos_key_from_string_direct() prototype.
Guenther
(This used to be commit ec86852fc6)
2008-06-17 19:51:52 +02:00
Günther Deschner
513bc4e791 dsgetdcname: allow to use NULL mem_ctx.
Guenther
(This used to be commit d20353d30c)
2008-06-17 19:51:24 +02:00
Günther Deschner
3688eeafa3 libads: fix logic error in ads_get_kvno().
Guenther
(This used to be commit 132b038581)
2008-06-17 19:51:14 +02:00
Volker Lendecke
04e697891b Fix a memleak in svcctl_init_keys()
(This used to be commit 675bb53398)
2008-06-17 16:09:22 +02:00
Volker Lendecke
6f66dbcda6 Fix a segfault in wbcLookupRids
The done: part could access uninitialized memory if intermediate
BAIL_ON_WBC_ERROR fire.

Jerry, please check!

Thanks,

Volker
(cherry picked from commit 31f4c33dcc)
(This used to be commit 5b12d8aa51)
2008-06-17 15:22:13 +02:00
Volker Lendecke
7f9acfae73 Fix a segfault in wbcLookupSid
If the BAIL_ON_WBC_ERROR directly after wbcRequestResponse kicks in, *domain
and *name have not been initialized yet. So the cleanup routine in the done:
part of the routine (which did not check for domain!=NULL etc) would access
uninitialized memory.

Jerry, please check!

Thanks,

Volker
(cherry picked from commit 3d7e0cc40b)
(This used to be commit ac5ba26bb0)
2008-06-17 15:22:04 +02:00
Andrew Bartlett
08d63adc61 Merge branch 'v3-3-test' of ssh://git.samba.org/data/git/samba into 3-3-abartlet
(This used to be commit a09ed6016a)
2008-06-17 22:46:34 +10:00
Andrew Bartlett
086de4ddb5 Without stdlib.h we don't get a prototype for free().
This test fails if GCC emits any warnings (presumably to detect the
function propertly), but unless we include this message then free()
fail.  Why we need to call free in a configure test is probably
something to blame on valgrind...

Andrew Bartlett
(This used to be commit d013f6fadc)
2008-06-17 22:45:29 +10:00
Volker Lendecke
c8ac22111e Replace a very unusual variable declaration by a more conventional one
(This used to be commit 9c1f334af3)
2008-06-17 14:35:44 +02:00
Volker Lendecke
8349e02b0b Fix a memleak in wbcAuthenticateUserEx()
(cherry picked from commit 72b381689a)
(This used to be commit 20110ee5f1)
2008-06-17 13:10:18 +02:00
Volker Lendecke
ee281b7479 Revert "Fix a memleak caused by a crappy get_sorted_dc_list() API"
This reverts commit 2ea03a1e95.
(This used to be commit 80c2e8295a)
2008-06-17 12:21:03 +02:00
Volker Lendecke
aaa2a4f447 Revert "Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails"
This reverts commit df8d089bc6.
(This used to be commit 342f885820)
2008-06-17 12:20:54 +02:00
Günther Deschner
4500f1d584 netapi: Fix Bug #5545 (libnetapi_init without $USER)
Based on patch from Erik van Pienbroek.

Guenther
(This used to be commit 71f4cf7730)
2008-06-17 10:49:38 +02:00
Günther Deschner
45bce6e505 net_vampire: fix samsync_process_database().
Turns out the password hashes are not rid encrypted in the samsync reply.

Guenther
(This used to be commit 7d8d60bcba)
2008-06-17 10:49:14 +02:00
Günther Deschner
0d0043697d net_vampire: fix build warning.
Guenther
(This used to be commit eb4232fec0)
2008-06-17 10:49:14 +02:00
Günther Deschner
16eb846fa5 net_vampire: use generic output filename and use correct argv element.
Guenther
(This used to be commit e0843e631e)
2008-06-17 10:49:13 +02:00
Günther Deschner
51fec7863b net_vampire: move ldif code out of net_rpc_samsync.c
Guenther
(This used to be commit 1d5758ec3a)
2008-06-17 10:49:13 +02:00
Günther Deschner
ccdcbc2efe net_vampire: move some samsync functions to libnet.
Guenther
(This used to be commit b3b6af0a3e)
2008-06-17 10:49:13 +02:00
Volker Lendecke
d314f7eab5 Add some debug to notify
(This used to be commit 4394235378)
2008-06-17 10:48:40 +02:00
Karolin Seeger
99e73df8e8 Remove references to SVN.
Karolin
(This used to be commit 9d69a809e3)
2008-06-17 10:43:19 +02:00
Michael Adam
e1732fae33 Remove reference to current_user from modules/nfs4_acls.c .
Michael
(This used to be commit 50fbfa0348)
2008-06-17 10:33:12 +02:00
Karolin Seeger
a7cf0bd32a idmap: Fix typos in comments.
Karolin
(This used to be commit 94a4d7fa32)
2008-06-17 10:30:19 +02:00
Karolin Seeger
98ed31a107 Fix typo.
arguements -> arguments

Karolin
(This used to be commit 16b5b772d2)
2008-06-17 09:46:17 +02:00
Karolin Seeger
13eab02679 winbind cache: Don't create SN cache entries during name-to-sid queries.
Clients can request name-to-sid queries for different combinations of
upper and lower case names. We don't want to create the reverse caching
entries for each combination used.

This avoids inconsistent answers on sid-to-name queries.

Please review!

Karolin
(This used to be commit b58e4f6b3d)
2008-06-16 15:21:28 +02:00
Volker Lendecke
fdcf760d1c Fix bug 5500 -- thanks to mathion at thorrovydeti.com for reporting
(cherry picked from commit 996c3ce6f0)
(This used to be commit 1f86c7a2a1)
2008-06-16 13:27:47 +02:00
Volker Lendecke
9c1f5894a5 Add forgotten protoypes
(This used to be commit dee60935d4)
2008-06-15 18:46:10 +02:00
Volker Lendecke
b6c125e4e0 Remove the current_user references from open.c
current_user_info was "only" used in a debug msg, and current_user.ut.uid is
also available via conn->server_info
(This used to be commit d0386914ff)
2008-06-15 13:41:16 +02:00
Volker Lendecke
d49de28f11 Remove the current_user reference from fake_file.c
The current vuid is not only available there, it is also in the current
smb_request structure.
(This used to be commit c8fd5eef32)
2008-06-15 13:37:53 +02:00
Volker Lendecke
3a5e1cacf1 Remove unused "extern struct current_user" from dir.c
(This used to be commit b92cfd19b4)
2008-06-15 11:40:33 +02:00
Volker Lendecke
704c99f340 Remove the reference to current_user from file_access.c
conn holds the current user info
(This used to be commit 093bc5f2b3)
2008-06-15 11:39:31 +02:00
Volker Lendecke
3fde7f5979 Fix an uninitialized variable found by the IBM checker
BAIL_ON_PTR_ERROR jumps to done: which will access extra_data before it's
initialized.

Stefan, please check!

Volker
(cherry picked from commit b59636f78d)
(This used to be commit 5663587e5e)
2008-06-15 00:24:18 +02:00
Volker Lendecke
cd7d7e1e82 Fix group parsing in libwbclient's copy_group_entry()
This (also) fixes a flaw pointed out by the IBM checker. When verifying that I
found out that the parsing was not working as I would have expected it to.

Jerry, please check!
(cherry picked from commit c2c7790155)
(This used to be commit 26c05a52b7)
2008-06-15 00:17:27 +02:00
Volker Lendecke
101162257c Move connection-specific vuid cache clear to uid.c
(This used to be commit 1025f68791)
2008-06-14 19:49:49 +02:00
Volker Lendecke
82d4806ce6 Slight refactoring for check_user_ok: It only needs vuid and server_info
(This used to be commit 68944ea1ea)
2008-06-14 19:49:49 +02:00
Volker Lendecke
ee6ee96af2 Group the access checks together in check_user_ok()
(This used to be commit 45662b5e8b)
2008-06-14 19:49:49 +02:00
Volker Lendecke
b935f4a2dc Consistently use snum in check_user_ok
Most already used it, these two still used SNUM(conn), where the only caller of
this routine (change_to_user) had set snum = SNUM(conn).
(This used to be commit b14e59bfdb)
2008-06-14 19:49:49 +02:00
Volker Lendecke
ad538bf0ab Compare the pointer "vuser" to NULL, not 0
(This used to be commit 5c916549f0)
2008-06-14 19:49:49 +02:00
Volker Lendecke
e7530f567c Use the correct cups-devel test for HAVE_IPRINT also
(This used to be commit a42d7e1146)
2008-06-14 11:10:13 +02:00
Volker Lendecke
c08611a6c5 Correctly check for presence of cups-devel
On SuSE at least cups-config belongs to cups-libs which does not contain the
headers which are in cups-devel.
(This used to be commit 2408d2493f)
2008-06-14 10:39:25 +02:00
Günther Deschner
2d23da2cff net_vampire: rename process_database to samsync_process_database.
Guenther
(This used to be commit cf382a8760)
2008-06-13 23:39:09 +02:00
Günther Deschner
fb0a11d1ec net_vampire: fix ldif_init_context().
Guenther
(This used to be commit 94d45b1bb9)
2008-06-13 23:39:09 +02:00
Günther Deschner
8049d3aa8e net_vampire: split out rpc_vampire_ldif().
Guenther
(This used to be commit bcc6d3a0eb)
2008-06-13 23:39:09 +02:00
Günther Deschner
fe43a56788 net_vampire: add samsync_init_context().
Guenther
(This used to be commit 63ca4414b6)
2008-06-13 23:39:09 +02:00
Günther Deschner
cb293f50fc net_vampire: add samsync_debug_str().
Guenther
(This used to be commit bbfe5bcaf5)
2008-06-13 23:39:08 +02:00
Günther Deschner
7a1fa41dca net_vampire: restructure internal code more.
Guenther
(This used to be commit 9557504d70)
2008-06-13 23:39:08 +02:00
Günther Deschner
339d868b17 net_vampire: start using talloc for the ldif vampire code.
Guenther
(This used to be commit ae179e4f3f)
2008-06-13 23:39:08 +02:00
Günther Deschner
4cae70e548 net_vampire: join dump and process function into one callback.
Guenther
(This used to be commit e9b79f34d5)
2008-06-13 23:39:08 +02:00
Günther Deschner
93880610b4 net_vampire: let fetch_database and fetch_database_to_ldif use sid pointers.
Guenther
(This used to be commit 0707d32042)
2008-06-13 23:39:08 +02:00
Günther Deschner
26694e6fa0 net_vampire: let dump_database() return NTSTATUS.
Guenther
(This used to be commit b5a0e2d18f)
2008-06-13 23:39:08 +02:00
Volker Lendecke
1bc1b1ac0a Fix a handle leak for error returns in ldb_try_load_dso
Coverity ID 464
(cherry picked from commit 496d44d2f2)
(This used to be commit f30bc6503d)
2008-06-13 16:15:12 +02:00
Volker Lendecke
c404c8950d Fix a crash in _winreg_QueryValue
Coverity ID 474, value_length and type are both unique, not ref pointers and
can thus be NULL.

Karolin, please merge this to -stable.

Thanks,

Volker
(cherry picked from commit 999533c0cc)
(This used to be commit 7e07ec68f1)
2008-06-13 15:33:51 +02:00
Günther Deschner
813ca8d705 samsync: add prototype for samsync_fix_delta_array().
Guenther
(This used to be commit 6c1904f8be)
2008-06-13 12:30:36 +02:00
Günther Deschner
6ce0c85172 net: Fix bug #5542 (samsync contains empty passwords).
Guenther
(cherry picked from commit 1a22e975dd)
(This used to be commit ad8392cf7c)
2008-06-13 12:23:57 +02:00
Günther Deschner
61b68fc43c samsync: add samsync_fix_delta_array()
This code is vastly based on samba4 code.

Guenther
(cherry picked from commit 5b68be9699)
(This used to be commit 2c53d87de4)
2008-06-13 12:23:50 +02:00
Kai Blin
8f1f62af28 net: Fix net_ads.c build for the HAVE_ADS == 0 case.
Thanks to Karolin for catching this one.
(This used to be commit 7f52998f54)
2008-06-12 15:46:12 +02:00
Volker Lendecke
de7e6e070a AIX build fixes from William Jojo -- thanks
(cherry picked from commit cb91a47576)
(This used to be commit 90d7bc6da3)
2008-06-12 13:17:44 +02:00
Volker Lendecke
67f3ee618b Add -brtl to the AIX linker flags
Thanks to William Jojo
(cherry picked from commit 74b195b544)
(This used to be commit 5ffad12d68)
2008-06-12 13:17:37 +02:00
Karolin Seeger
49a81672d2 net: Fix several typos in comments.
-argc -> argv (where argv is meant)
-destoyed -> destroyed
-compleation -> completion
-aquired -> acquired
-Unify spelling of some words like rpc-server -> RPC server.
-Add missing punctuation marks.

Karolin
(This used to be commit f4850c37df)
2008-06-12 10:59:02 +02:00
Christoph Zauner
8d15371de4 Fix typos.
(This used to be commit b2390aa738)
2008-06-12 09:25:07 +02:00
Volker Lendecke
5b8259c112 Fix max_fd calculation in event_loop_once
For some bugs I really wonder how they can go undetected for so long.

Fix a bug reported by Mathias Dietz. No samba bugzilla entry, but still 100%
needed for 3-2-stable.

Volker
(cherry picked from commit 82c994dabc)
(This used to be commit 91c73e093a)
2008-06-11 18:58:26 +02:00
Günther Deschner
95a1f88d93 rpc_client: fix some valgrind warnings.
Guenther
(This used to be commit 0352682a35)
2008-06-11 10:47:21 +02:00
Günther Deschner
79fbc59cfc re-run make idl.
Guenther
(This used to be commit 3a73fe564f)
2008-06-11 10:46:46 +02:00
Günther Deschner
2d5e4708e9 idl: fix drsuapi_DsGetNCChanges.
Guenther
(This used to be commit 652af123b2)
2008-06-11 10:46:37 +02:00
Günther Deschner
2816e86b06 net: remove some dead code.
Guenther
(This used to be commit cdd1ce797a)
2008-06-11 10:46:26 +02:00
Günther Deschner
8e240c460b pam_winbind: Update cached creds during password change.
Fix is from Bo Yang @ Novell.

Thanks!
(This used to be commit e4eb9d347d)
2008-06-11 09:52:56 +02:00
Günther Deschner
9883567fa7 rpcclient: add more useful comments what sign/seal commands are doing.
Guenther
(This used to be commit ec278d8bc8)
2008-06-10 22:51:04 +02:00
Volker Lendecke
dc45718f32 Correctly find a [u]int32_t replacement
(cherry picked from commit 346375cda5)
(This used to be commit 15a53945c9)
2008-06-10 17:21:31 +02:00
Volker Lendecke
f3ddf2b23f Fix some scary FC9 warnings
(cherry picked from commit 6b0fed09ea)
(This used to be commit f1e85ff2bc)
2008-06-10 17:21:23 +02:00
Stefan Metzmacher
5380fd800d socket_wrapper: truncate packets to a 1500 byte payload
Truncate sendto(), recvfrom(), send() and recv() to 1500 bytes
so that're getting a correctly formatted pcap file and the result
look more like real network traffic.

metze
(cherry picked from commit 5b01206f1b)
(This used to be commit eb8c37a1ca)
2008-06-10 11:38:11 +02:00
Stefan Metzmacher
d57b8280d6 socket_wrapper: sync missing stuff from v4-0-test
metze
(This used to be commit b03c279354)
2008-06-10 11:38:05 +02:00
Jelmer Vernooij
e2fe170423 Factor out IP marshalling into separate function.
(cherry picked from commit 2548c2a1e7)
(This used to be commit e4e015caac)
2008-06-10 11:36:39 +02:00
Stefan Metzmacher
a7967bc84c r25783: socket_wrapper: don't include "includes.h"
metze
(cherry picked from commit 47f865165e)
(This used to be commit 4d5bfcc731)
2008-06-10 11:36:39 +02:00
Stefan Metzmacher
9b7b444e35 r23420: try to make the IBM checker happy
metze
(cherry picked from commit 96f1a0dfaa)
(This used to be commit 801ed0b799)
2008-06-10 11:36:39 +02:00
Stefan Metzmacher
c8eccf5381 r22236: Update to Heimdal's socket_wrapper, which supports IPv6.
To make this pass, I needed to add support for 6 and 17 as valid
protocol values to socket().

Andrew Bartlett
(partly cherry picked from commit 2254e61a1e)

metze
(This used to be commit 66b9f6f372)
2008-06-10 11:36:38 +02:00
Jelmer Vernooij
2359150639 r21729: Some more tests
(cherry picked from commit d2baa8218c)
(This used to be commit cf6d815ba8)
2008-06-10 11:36:38 +02:00
Stefan Metzmacher
bd793fb235 r21671: Add initial simple tests for socket wrapper
(partly cherry picked from commit 872e2ad541)

metze
(This used to be commit 8003f00a28)
2008-06-10 11:36:38 +02:00
Love Hörnquist Åstrand
1410d8e799 r19409: Pull in <sys/time.h> for struct timeval for non samba build (don't
depend on namespace pollution)
(cherry picked from commit 5052d2d106)
(This used to be commit d22701b196)
2008-06-10 11:36:37 +02:00
Love Hörnquist Åstrand
4084b467c5 r19367: Solaris needs <sys/filio.h> for FIONREAD.
(cherry picked from commit e2866ce788)
(This used to be commit 3db8b246c8)
2008-06-10 11:36:37 +02:00
Kai Blin
255bdb2602 net: Rename functable3 to functable, get rid of old functables
(This used to be commit bb7c5fc4ec)
2008-06-10 09:48:21 +02:00
Kai Blin
cd06703a3f net: Make "net sam" use functable3
(This used to be commit b161fb7cfe)
2008-06-10 09:48:14 +02:00
Kai Blin
3d7a927ece net: Make "net rpc registry" use functable3
(This used to be commit 08dd5f5311)
2008-06-10 09:48:10 +02:00
Kai Blin
22b1926f24 net: Make "net registry" use functable3
(This used to be commit 47f7308e4e)
2008-06-10 09:48:07 +02:00
Kai Blin
1be1be3334 net: Make "net conf" use a functable similar to functable3
(This used to be commit b8382bc3af)
2008-06-10 09:48:03 +02:00
Kai Blin
66432dd06c net: Use d_printf() instead of printf() in net_ads_gpo.c
(This used to be commit d0d1346f20)
2008-06-10 09:47:59 +02:00
Kai Blin
e0f2f8d57e net: Make "net rpc service" use functable3
(This used to be commit aa06cd5cb2)
2008-06-10 09:47:55 +02:00
Kai Blin
edf23f17fd net: Make "net rpc rights" use functable3
(This used to be commit b0e373e595)
2008-06-10 09:47:48 +02:00
Kai Blin
238c7d0be3 net: Make "net rpc audit" use functable3
(This used to be commit c47ff2bff6)
2008-06-10 09:47:34 +02:00
Kai Blin
c51ca559c1 net: Make "net rpc" use functable3
(This used to be commit 428b56863c)
2008-06-10 09:47:28 +02:00
Kai Blin
98b9b5b7f3 net: Make "net rap" use functable3
(This used to be commit 7a2364518c)
2008-06-10 09:47:25 +02:00
Kai Blin
c19700fc07 net: Make "net ads gpo" use functable3
(This used to be commit 4418b4da61)
2008-06-10 09:47:21 +02:00
Kai Blin
54bc155736 net: Make "net ads" use functable3
(This used to be commit 64e3dc6396)
2008-06-10 09:47:15 +02:00
Kai Blin
67fee7a79a net: Make "net usershare" use functable3
(This used to be commit b45ada159e)
2008-06-10 09:47:03 +02:00
Kai Blin
7870908a0d net: Fix comment for net_time_zone()
(This used to be commit aea3466d12)
2008-06-10 09:46:57 +02:00
Kai Blin
b1ef38de9f net: Make "net time" use functable3
(This used to be commit 28991ad74a)
2008-06-10 09:46:53 +02:00
Kai Blin
6468d36716 net: Make "net idmap" use functable3
(This used to be commit 9c88b16beb)
2008-06-10 09:46:46 +02:00
Kai Blin
f3d86100b8 net: Make "net groupmap" use functable3
(This used to be commit c328b3e30b)
2008-06-10 09:46:42 +02:00
Kai Blin
7ba0724f80 net: Make "net dom" use functable3
(This used to be commit 11d692de73)
2008-06-10 09:46:37 +02:00
Kai Blin
6b9c815bcc net: Make "net cache" use functable3
(This used to be commit 60ac59fb8a)
2008-06-10 09:46:26 +02:00
Kai Blin
2eaef96387 net: Make "net afs" use functable3
(This used to be commit aa60f3c0d5)
2008-06-10 09:46:24 +02:00
Kai Blin
b0d8162525 net: Make "net status" use functable3
(This used to be commit e4b4fb4c39)
2008-06-10 09:46:12 +02:00
Kai Blin
6e8d46d40d net: Don't try to look up a server if net time is called with a command.
(This used to be commit 37ef7c2816)
2008-06-10 09:46:03 +02:00
Kai Blin
8efc535a4a net: Add net_display_usage_from_functable()
(This used to be commit de0e15b35e)
2008-06-10 09:45:55 +02:00
Kai Blin
0f1b3ed5c0 net: Autogenerate "net help" output from net's functable.
(This used to be commit 0feb40bc84)
2008-06-10 09:45:36 +02:00
Kai Blin
2ca10c462d net: Use functable3
(This used to be commit 122dfe876d)
2008-06-10 09:45:34 +02:00
Kai Blin
223d1bce77 net: Use functable2 to give a short help text for top-level functions.
(This used to be commit e9be24a2cb)
2008-06-10 09:45:28 +02:00
Kai Blin
44c260743c net: Add net_run_function3
(This used to be commit ba1108f06a)
2008-06-10 09:45:19 +02:00
Kai Blin
6fd35d25bf net: Move net_run_function/net_run_function2 to net_util.c
(This used to be commit 73fb5f392d)
2008-06-10 09:45:14 +02:00
Kai Blin
4d9748e44d net: Move includes to net.h
(This used to be commit 1943e2752d)
2008-06-10 09:45:09 +02:00
Jim McDonough
13b2f59383 Don't reset password last set time just because the expired flag
is set to 0.  If the account wasn't expired but autolocked,
using "net user /dom <username> /active:y" would clear this,
incorrectly setting the current time as the new "password last set"
time.
(This used to be commit 0f292d70f6)
2008-06-09 11:49:29 -04:00
Volker Lendecke
b76f967300 shrink ldbtools
Thanks to Björn Jacke for noticing :-)
(cherry picked from commit 8faee1cee8)
(This used to be commit 49f99fcf12)
2008-06-09 16:31:42 +02:00
Volker Lendecke
7910caec2b Fix the compile on NetBSD -- missing prototypes
(cherry picked from commit 11236d266e)
(This used to be commit d25408f83d)
2008-06-09 15:01:50 +02:00
Volker Lendecke
aeb9eb85eb Fix the compile on NetBSD -- readlink and read are macros there
(cherry picked from commit 435b80a9a2)
(This used to be commit 055bb54fa6)
2008-06-09 15:01:42 +02:00
Stefan Metzmacher
7932e475a5 libreplace: only include AC_USE_SYSTEM_EXTENSIONS fallback if required
This fixes ./autogen.sh with autoconf-2.62

metze
(cherry picked from commit 72bb01dda4)
(This used to be commit 85111dc2b6)
2008-06-09 11:06:17 +02:00
Stefan Metzmacher
e2a393701c libreplace: fix warnings with autoconf-2.62 rename ac_ => libreplace_cv_
AC_CACHE_VAL() variables must contain _cv_ to be cached.

metze
(cherry picked from commit 67e43860b4)
(This used to be commit d786bfc48e)
2008-06-09 11:06:08 +02:00
Stefan Metzmacher
b19587b464 configure: we require autoconf 2.54
I've tested with autoconf from 2.53 to 2.62.

metze
(This used to be commit a268a6d251)
2008-06-09 11:05:06 +02:00
Stefan Metzmacher
4461f0a6ee configure: fix warnings with autoconf-2.62 rename SMB_BUILD_ => samba_cv_
AC_CACHE_VAL() variables must contain _cv_ to be cached.

metze
(This used to be commit 89663ab4d1)
2008-06-09 11:04:56 +02:00
Stefan Metzmacher
7f70c126b2 configure: fix warnings with autoconf-2.62 rename samba_stat_hires => samba_cv_stat_hires
AC_CACHE_VAL() variables must contain _cv_ to be cached.

metze
(This used to be commit 426b1e36e2)
2008-06-09 11:04:50 +02:00
Stefan Metzmacher
2c0360fe26 configure: fix warnings with autoconf-2.62 rename smb_krb5_ => smb_krb5_cv_
AC_CACHE_VAL() variables must contain _cv_ to be cached.

metze
(This used to be commit 38a03d61ec)
2008-06-09 11:04:45 +02:00
Jeremy Allison
1db2dc1931 Bugfix noticed by Herb. On using the again: tag as a
goto target we were not reinitializing the array counts.

From Herb:

This is in the file nsswitch/winbindd_cm.c (samba-3.0.30) line 1236

We have a label again: where we keep trying to find the name of the DC
from the list of IPs returned by get_dcs. If we fail to figure out the
name we do a goto again at the end of the function. The problem is we
don't reset the num_dcs, num_addrs, etc and free the memory in the
various arrays. This seems wrong to me. I have a winbindd core where
I have 9 IPs returned for the DCs but at the time of the crash num_dcs
is 87 and if I look through the array dcs it keeps repeating entries
from the same group of 9

Jerry, Volker and Guenther please check.

Jeremy.
(This used to be commit 15f464321a)
2008-06-08 14:19:44 -07:00
Volker Lendecke
d1e0c7f0c1 Add STREAMINFO op to vfs_full_audit
Fix Coverity ID 552 and 553
(This used to be commit c46e10d260)
2008-06-07 09:04:03 +02:00
Volker Lendecke
0e7d1aae2f Fix a memleak in secrets_fetch_afs_key
Coverity ID 570
(This used to be commit 0f52dc3f7e)
2008-06-07 08:51:35 +02:00
Volker Lendecke
8c98f5af6f Fix a memleak in secrets_fetch_trust_account_password_legacy
Coverity ID 571
(This used to be commit a551773e34)
2008-06-07 08:50:02 +02:00
Volker Lendecke
32452565be Fix a memleak in fetch_ldap_pw
Fix Coverity ID 572, also fix the error check for secrets_fetch failing
(This used to be commit 2663c81a78)
2008-06-07 08:48:13 +02:00
Volker Lendecke
dd30dd2a14 Fix a crash in add_failed_connection_entry
(This used to be commit 2a689aa66a)
2008-06-07 08:16:23 +02:00
Volker Lendecke
e252b0504a Add prototype for delete_negative_conn_cache
(This used to be commit 097446c3c8)
2008-06-07 08:16:23 +02:00
Volker Lendecke
a191f3d2fe Make the gencache based conncache use talloc_tos()
(This used to be commit f7f912a478)
2008-06-07 08:16:23 +02:00
Marc VanHeyningen
d4cbc4408e Negative conn cache uses gencache
(This used to be commit 8765eb8ad7)
2008-06-07 08:16:23 +02:00
Günther Deschner
f4e93883c9 pam_winbind: fix pam_sm_chauthtok for storing modified cached creds.
Thanks to Bo Yang for pointing this out.

Guenther
(This used to be commit 516a067016)
2008-06-06 16:00:34 +02:00
Günther Deschner
a3353677d3 netapi: use NetGroupSetInfo() for "net rpc group rename".
Guenther
(This used to be commit 8a4577ebb0)
2008-06-06 13:59:09 +02:00
Jeremy Allison
48a2a3780b More correct fix (hopefully :-) for any memory leaks.
Jerry promised to check :-). Vl also please review.
Jeremy.
(This used to be commit 8abc6e7421)
2008-06-05 14:27:26 -07:00
Günther Deschner
66a5cbaf8b netdomjoin-gui: enable NetGetJoinInformation() call after successfull joining.
Now that libnetjoin reloads configuration after joining, we can rely on the
NetGetJoinInformation() output and use it for displaying the new domain name and
type.

Guenther
(This used to be commit cc1b8de263)
2008-06-05 19:39:24 +02:00
Günther Deschner
de89de4b58 netdomjoin-gui: fix more gtk runtime warnings.
Guenther
(This used to be commit 521ea68719)
2008-06-05 19:39:17 +02:00
Günther Deschner
e3e1172979 libnetjoin: add libnet_join_rollback().
This is required now if the join verify failed and we already
modified the local configuration.

Guenther
(This used to be commit 2870fe50af)
2008-06-05 19:34:30 +02:00
Günther Deschner
387706a49d libnetjoin: First store configuration and then verify the join.
Jerry, this fixes the issues while joining with "config backend = registry".

Guenther
(This used to be commit b3d47f0992)
2008-06-05 19:34:06 +02:00
Günther Deschner
21e759ef64 mailslot: always pull a command 25 type reply.
Guenther
(This used to be commit 1ce726b951)
2008-06-05 19:09:30 +02:00
Günther Deschner
20ec11ac28 net: fix debuglevel handling.
Kai, that one actually needs to stay a global external variable in order to
support debuglevel definition only on the commandline for net.

Guenther
(This used to be commit f6ba7333ab)
2008-06-05 18:49:21 +02:00
Volker Lendecke
bde7cbf4a7 Fix a memleak caused by a crappy get_sorted_dc_list() API
(This used to be commit 2ea03a1e95)
2008-06-05 10:56:18 +02:00
Volker Lendecke
d261e16cfd Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails
This is really not a proper place to fix this, but as get_gc_list() and friends
are about to be replaced anyway, just work around the broken existing API
(This used to be commit df8d089bc6)
2008-06-05 10:56:18 +02:00
Günther Deschner
19e5ee0e09 netdomjoin-gui: disable annoying "reboot now" dialog.
Guenther
(This used to be commit 8f0c5f1bed)
2008-06-05 01:11:23 +02:00
Günther Deschner
bb58d33b6d libnetjoin: correctly copy returned lsa policy sid.
Guenther
(This used to be commit f9e5450c94)
2008-06-04 18:05:15 +02:00
Günther Deschner
7d35e4e294 netdomjoin-gui: some minor fixes + hunting down typecast bugs.
Guenther
(This used to be commit 0fa6c8c6a3)
2008-06-04 18:00:54 +02:00
Günther Deschner
913a323623 net: fix popt context memleak.
Guenther
(This used to be commit 60bce92574)
2008-06-04 02:44:24 +02:00
Günther Deschner
dddc5725db libnetjoin: only close existing policy handles while unjoining.
Guenther
(This used to be commit 6dbed6e7b7)
2008-06-04 02:43:41 +02:00
Günther Deschner
aa8bfd39eb libnetjoin: delete possible "realm" leftover parameter.
Guenther
(This used to be commit d7ba98cc3f)
2008-06-04 01:35:44 +02:00
Günther Deschner
d7772433bf net: print NBT_SERVER_X_SECRET_DOMAIN_6 flags in "net ads lookup".
Guenther
(This used to be commit 420390ba0e)
2008-06-04 01:35:43 +02:00
Günther Deschner
d4c5a1d504 util_str: add talloc_asprintf_strlower_m().
Guenther
(This used to be commit 7f8b0b4d15)
2008-06-04 01:35:43 +02:00
Günther Deschner
12281d02ae netapi: remove unrequired headers.
Guenther
(This used to be commit f8fec49ce1)
2008-06-04 01:35:43 +02:00
Volker Lendecke
2cfacbaacb Always set "registry shares = yes" for "include = registry"
This fixes the case where "include = registry" is set in the smb.conf text file
and *only* shares (no [global] settings) are present in the registry.

Michael, please check!

Thanks,

Volker
(This used to be commit 6c80362e29)
2008-06-03 21:36:56 +02:00
Günther Deschner
dcdeab4d4e build: fix build warning.
Guenther
(This used to be commit 62fcad0c05)
2008-06-03 20:41:55 +02:00
Günther Deschner
4f6ea219d6 build: fix the build (missing protoype for lp_ldap_connection_timeout()).
Guenther
(This used to be commit 06b597213a)
2008-06-03 20:41:29 +02:00
Gerald W. Carter
dd7cf3464d winbindd_cm: Replace the use of lp_realm() with our_domain->alt_name.
Reduce the use of config parameters with run time information after discussion
with Guenther.
(This used to be commit 57d596395d)
2008-06-03 11:21:02 -05:00
Björn Jacke
d8b234648c Add ldap connection timeout for OpenLDAP and Netscape LDAP libs. This can be controlled via the ldap connection timeout parameter. This fixes fallbacks to secondary LDAP servers in multi LDAP server setups like in #4544
(This used to be commit 8e59a2fedc)
2008-06-03 16:32:31 +02:00
Andreas Schneider
8c7e21679b Fix empty input fields in SWAT; [#5515].
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit e1579c90fb)
2008-06-03 15:35:41 +02:00
Andreas Schneider
0d556eabde Fix saving of the config file in SWAT; [#5516].
The strlen of the source string passed to convert_string_allocate was too
short :)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit ac3597ef8b)
2008-06-03 15:35:41 +02:00