1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

75593 Commits

Author SHA1 Message Date
Jeremy Allison
218cccfdf1 Fix bug Bug 8422 - Infinite loop in ACL module code.
Missing assignment means this loop will never terminate. Need to be applied
to 3.5.x and 3.6.1.
2011-08-29 16:46:15 -07:00
Volker Lendecke
f7f6992a20 s4: Mark the winsreplication test as knownfail
This continues to break my autobuild even if I just check something into
source3.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Aug 29 21:04:06 CEST 2011 on sn-devel-104
2011-08-29 21:04:06 +02:00
Volker Lendecke
71dcb84e61 s3: Fix getent group if trusted domains are not reachable 2011-08-29 19:29:37 +02:00
Michael Adam
498e32bbac s3:rpc_server: fix two debug messages in svcctl_add_service()
(copy and paste from eventlog?)

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Aug 29 15:30:33 CEST 2011 on sn-devel-104
2011-08-29 15:30:33 +02:00
Andreas Schneider
b8c3bfa55b s3-lib: If we create a pipe socket, don't start to listen.
The create_pipe_sock() function should only create the socket as the
name states and not start to listen on it too. We should start to listen
on in the individual places as we need different backlog values.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Mon Aug 29 13:21:43 CEST 2011 on sn-devel-104
2011-08-29 13:21:43 +02:00
Stefan Metzmacher
92b7e3ee58 s3:libsmb: make cli_session_request_send/recv() static
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Aug 28 20:29:01 CEST 2011 on sn-devel-104
2011-08-28 20:29:01 +02:00
Stefan Metzmacher
74adebe8d9 s3:libsmb: move cli_session_request*() to smbsock_connect.c
metze
2011-08-28 17:23:49 +02:00
Stefan Metzmacher
ab0a1cc5c6 s3:libsmb: move cli_smb_oplock_break_waiter*() to clioplock.c
metze
2011-08-28 17:16:51 +02:00
Stefan Metzmacher
1e43bacd5e s3:libsmb: use cli_smb_req_set_mid() in cli_smb_oplock_break_waiter_send()
metze
2011-08-28 17:16:50 +02:00
Stefan Metzmacher
9e0d975512 s3:libsmb: let cli_smb_req_mid() return the mid set by cli_smb_req_set_mid()
metze
2011-08-28 16:32:19 +02:00
Jelmer Vernooij
8bd71350ab dnspython: Update to latest upstream snapshot.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Aug 27 17:40:39 CEST 2011 on sn-devel-104
2011-08-27 17:40:39 +02:00
Jelmer Vernooij
bd01a8e79f subunit: Update to latest upstream snapshot. 2011-08-27 16:07:38 +02:00
Jelmer Vernooij
dd56d27d74 testtools: Update to latest upstream snapshot. 2011-08-27 16:07:25 +02:00
Jeremy Allison
ef3bb09db6 RAW_SFILEINFO_RENAME_INFORMATION_SMB2 sends 4 bytes of uninitialized data out on the network.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Aug 27 07:48:30 CEST 2011 on sn-devel-104
2011-08-27 07:48:29 +02:00
Volker Lendecke
ed058f4dc3 s3: Fix a winbind race leading to 100% CPU
This fixes a race condition that leads to the winbindd_children list becoming
corrupted. It happens when on a busy winbind SIGCHLD is a bit late.

Imagine a winbind with multiple requests in the queue for a single child. Child
dies, and before the SIGCHLD handler is called we find the socket to be dead.
wb_child_request_done is called, receiving an error from wb_simple_trans_recv.
It closes the socket. Then immediately the wb_child_request_trigger will do
another fork_domain_child before the signal handler is called. This means that
we do another fork_domain_child, we have child->sock==-1 at this point.
fork_domain_child will do a DLIST_ADD(winbindd_children, child) a second time
where the child is already part of that list. This corrupts the list. Then the
signal handler kicks in, spinning in

for (child = winbindd_children; child != NULL; child = child->next) {

forever. Not good. This patch makes sure that both conditions (sock==-1 and not
part of the list) for a winbindd_child struct match up.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Aug 26 18:51:24 CEST 2011 on sn-devel-104
2011-08-26 18:51:24 +02:00
Volker Lendecke
b72944fea7 s3: Fix two int/enum mixups 2011-08-26 16:36:17 +02:00
Andrew Bartlett
e8aed9472a s4-drsuapi Allow DsAddEntry of normal objects
We previously only allowed objects of class ntDSDSA

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Aug 26 15:34:21 CEST 2011 on sn-devel-104
2011-08-26 15:34:21 +02:00
Andrew Bartlett
9a137311f1 s4-messaging ensure we do not segfault on a NULL msg context in cleanup 2011-08-26 14:06:07 +02:00
Andrew Bartlett
1f181476b4 selftest: Allow a krb5.conf to be generated that covers multiple realms 2011-08-26 14:06:07 +02:00
Andrew Bartlett
c8f13dab6b build: Add dcerpc-binding to dcerpc.pc
This will help projects like OpenChange that depend on
this code, now that it has been split between two libraries.

Andrew Bartlett
2011-08-26 14:06:07 +02:00
Andrew Bartlett
f81bb8df67 s4-dsdb Return ACL errors as ldb_errstring()
This string is reported to the caller, which makes debugging much easier.

Andrew Bartlett
2011-08-26 14:06:07 +02:00
Andrew Bartlett
607d7c5cdf s4-provision Use samba.dns_name_to_dn 2011-08-26 14:06:07 +02:00
Amitay Isaacs
322b5253f4 s3-passdb: Allocate talloc stackframe before calling pdb_get_group_sid()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 14:06:07 +02:00
Amitay Isaacs
8c466c1411 s3-param: Allocate talloc stackframe before calling s3 param routines
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 14:06:07 +02:00
Volker Lendecke
e0e3d215b1 s3: Use sys_write in fork_domain_child
Counterpart for last checkin. A lot less likely, but not impossible in a child.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Aug 26 13:14:27 CEST 2011 on sn-devel-104
2011-08-26 13:14:27 +02:00
Volker Lendecke
964e809ce2 s3: Use sys_read in fork_domain_child
I've seen

[2011/08/26 01:44:10.872057,  1] winbindd/winbindd_dual.c:1336(fork_domain_child)
  fork_domain_child: Could not read child status: nread=-1, error=Interrupted system call

on a customer box. Not good.
2011-08-26 11:42:35 +02:00
Amitay Isaacs
099b9db404 py-samba3-test: Copy sample database in tempdir before running test
Samba3 python module using passdb api modifies the database files, to
upgrade them to latest version. So copy the sample database before
running tests on it.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Aug 26 07:04:15 CEST 2011 on sn-devel-104
2011-08-26 07:04:15 +02:00
Amitay Isaacs
7a8565fc59 samba3dump: Update the code using modified samba3 module with passdb api
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 13:32:11 +10:00
Amitay Isaacs
76ff9bffd8 s3_upgrade: Set lock directory to correct directory
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 10:07:36 +10:00
Amitay Isaacs
eebb37c9b2 py-samba3-test: Set lock directory to the datadir
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 10:07:28 +10:00
Amitay Isaacs
7017e6b882 testdata: Set netbios name in the samba3 configuation
To correctly find the domain sid, passdb api uses netbios name to
look up secrets database. If no nebios name is configured, passdb uses
current hostname and adds entry for hostname in secrets and uses that
instead of the intended one.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 10:06:33 +10:00
Amitay Isaacs
d8465f2a91 s3_upgrade: Update commandline options and use updated samba3 python module
upgrade_from_s3 script now requires samba3 configuration file and target
directory for samba4 database. In addition, it either uses --libdir option
or --testparm option to correctly guess the paths for samba3 databases
(private dir and state directory).

Usage: upgrade_from_s3 [options] <configuration_file> <targetdir>

Input arguments are:
  <configuration_file> - path to existing smb.conf
  <targetdir>          - directory in which samba4 database will be created

In addition, specify either samba3 database directory (with --libdir) or
samba3 testparm utility (with --testparm).

Before using passdb interface, initialize s3 loadparm context using
correct path settings for private dir and state directory.

Export account policy from s3 to s4.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 10:06:33 +10:00
Amitay Isaacs
d2536b3120 py-samba3: Use passdb/param wrapper for samba3 module
Instead of parsing samba3 database files (password, group mapping,
account policy, secrets), use passdb python wrapper.

Similarly for parsing configuration, use samba3 param python wrapper.

Other databases (idmap, registry, wins) are still parsed in python.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 10:06:33 +10:00
Amitay Isaacs
17c74e5dfd s3-passdb: Make domain_sid argument optional for search_aliases method
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 10:06:33 +10:00
Amitay Isaacs
0cfeb65a0b s3-passdb: Return assigned number of hours and not MAX_HOURS_LEN
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 10:06:33 +10:00
Amitay Isaacs
a38a3b16e1 s3-passdb: Convert lm_pw and nt_pw to python string using length
lm_pw and nt_pw are fixed length strings and convert them to python
strings as fixed length strings.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 10:06:32 +10:00
Amitay Isaacs
b2068162f7 script: Fix the name of the script in autogenerated header file
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 10:06:32 +10:00
Amitay Isaacs
b5da5f7379 s4-param: Use s3 dump method if s3 context is defined
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 10:06:32 +10:00
Amitay Isaacs
d847f62161 s3-param: Add a dump() method to output parameters
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 10:06:32 +10:00
Amitay Isaacs
7f67d7b5ca s3_upgrade: Let python generate backtrace for unknown exceptions
Catch known exceptions only.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 10:06:32 +10:00
Amitay Isaacs
886203f3bc s3_upgrade: Add document strings for python methods
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26 10:06:32 +10:00
Michael Adam
a3538b92d3 werror: remove duplicate definition of WERR_INVALID_OWNER
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Aug 26 01:23:52 CEST 2011 on sn-devel-104
2011-08-26 01:23:52 +02:00
Michael Adam
9d3fa10c35 s3:dbwrap_tdb: correctly catch the error from the return code of tdb_parse in db_tdb_fetch() 2011-08-25 23:55:06 +02:00
Michael Adam
316834cf42 s3:smbd: remove an unused variable in dptr_create() 2011-08-25 23:55:06 +02:00
Michael Adam
1e09f12d1f s3:registry: fix the v2_to_v3 upgrade code so that it does not create value list security records for the INFO/version key ... 2011-08-25 23:55:06 +02:00
Michael Adam
9b46798b11 s3:registry: fix the v1_to_v2 upgrade code so that it does not normalize the INFO/version key ... 2011-08-25 23:55:06 +02:00
Michael Adam
b4cb969e40 s3:registry: define a constant REGDB_VERSION_KEYNAME for the key INFO/version (and use it) 2011-08-25 23:55:06 +02:00
Michael Adam
b1a94b66cc s3:registry: hand db context in to v2_to_v3 upgrade code via private_data
This also fixes the earlier faulty handing in of a useless stackframe
memory context via private_data.
2011-08-25 23:55:06 +02:00
Michael Adam
48f08011e5 s3:registry: fix broken use of dbwrap store record in v1_to_v2 upgrade code
This also fixes broken private_data parameter for the traverse function
(making use of it): Originally a memory context was handed in but was not used.
2011-08-25 23:55:06 +02:00
SATOH Fumiyasu
faa769ec19 s3: Fix the build of vfs_aixacl2.c
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Aug 25 23:06:12 CEST 2011 on sn-devel-104
2011-08-25 23:06:11 +02:00