1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-09 08:58:35 +03:00

54846 Commits

Author SHA1 Message Date
Tim Prouty
23c703a01e s3: Remove unnecessary callers of get_full_smb_filename
This often times means explicitly denying certain operations on a stream
as they are not supported or don't make sense at a particular level.  At
some point in the future these can be enabled, but for now it's better to
remove ambiguity
2009-07-21 12:04:59 -07:00
Tim Prouty
00e267008d s3: Remove the now unused fname parameter from filename_convert() 2009-07-21 12:04:59 -07:00
Tim Prouty
4860fc4951 s3: Fix RENAME_FLAG_RENAME path to stop calling unix_convert twice 2009-07-21 12:04:59 -07:00
Tim Prouty
78ce9dd471 s3: Remove unnecessary fname argument from callers of filename_convert 2009-07-21 12:04:59 -07:00
Tim Prouty
6b49f28592 s3: Plumb smb_filename through map_open_params_to_ntcreate 2009-07-21 12:04:58 -07:00
Stefan Metzmacher
424e763695 frsrpc.idl: make the chunk array in frsrpc_CommPktChunkCtr dynamic
We add an extra num_chunks to the frsrpc_CommPktChunkCtr structure
and use hand modified ndr_push/pull functions to let it not appear
on the wire.

metze
2009-07-21 19:11:24 +02:00
Stefan Metzmacher
9d148f75c7 frsrpc.idl: almost complete the idl for the frsrpc_FrsSendCommPkt() function
TODO: The amount of chunks is dynamic, we need to fix that

metze
2009-07-21 19:11:22 +02:00
Stefan Metzmacher
b91156d4ae frsapi.idl: fill the frsapi_WriterCommand() function
metze
2009-07-21 19:11:22 +02:00
Stefan Metzmacher
1436256613 frsapi.idl: fix some unknown field names
metze
2009-07-21 19:11:21 +02:00
Christian Ambach
8b6ec5b82c do not log chdir with level 0 if reason is access denied
this changes the level of logs caused by users trying to access shares
or subdirectories for which they do not have access to in the ACL

this can fill up the samba log even with log level 0 and is more an
expected kind of logs that IMHO should not be logged with such a high
level.

All other errors while chdir() will still be logged with level 0

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2009-07-21 10:05:21 -07:00
Michael Adam
319a97bce9 s3:dbwrap: use the transaction wrapper in dbwrap_trans_store().
Now dbwrap_util.c contains only one call to each of
transaction_start, transaction_commit and transaction_cancel.

Michael
2009-07-21 12:40:34 +02:00
Michael Adam
d5efb38151 s3:dbwrap: use the transaction wrapper in dbwrap_trans_delete().
Michael
2009-07-21 12:40:34 +02:00
Rusty Russell
760104188d tdb: fix locking error
54a51839ea65aa788b18fce8de0ae4f9ba63e4e7 "Make tdb transaction lock
recursive (samba version)" was broken: I "cleaned it up" and prevented
it from ever unlocking.

To see the problem:
	$ bin/tdbtorture -s 1248142523
	tdb_brlock failed (fd=3) at offset 8 rw_type=1 lck_type=14 len=1
	tdb_transaction_lock: failed to get transaction lock
	tdb_transaction_start failed: Resource deadlock avoided

My testcase relied on the *count* being correct, which it was.  Fixing that
now.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Michael Adam <obnox@samba.org>
2009-07-21 10:21:53 +02:00
Tim Prouty
8e04c69e02 s3: Add some asserts to the filename util functions
In the smb_filename struct stream_name must equal NULL if there
is no stream name.  These asserts should catch any future offenders
of this invariant early.
2009-07-20 17:26:57 -07:00
Tim Prouty
f4530f6d2a s3: Plumb smb_filename through open_fake_file 2009-07-20 17:26:57 -07:00
Tim Prouty
841efce8b5 s3: Separate out a new file: filename_utils.c
This is to ease the linking pain of everything that links LOCKING_OBJ
2009-07-20 17:26:57 -07:00
Tim Prouty
82c3f505fe s3: Move is_ntfs_stream*() to filename.c 2009-07-20 17:26:57 -07:00
Tim Prouty
c9b8a01714 s3: Finish plumbing the fsp->fsp_name smb_fname conversion through the modules. 2009-07-20 17:26:57 -07:00
Tim Prouty
5a8d70d465 s3: Change fsp->fsp_name to be an smb_filename struct! 2009-07-20 17:26:56 -07:00
Tim Prouty
635e5e7ff0 s3 onefs oplocks: Replace static fstring with talloc'd dbg_ctx() 2009-07-20 17:26:56 -07:00
Tim Prouty
12a5db45e2 s3: Change file_structs to be allocated with talloc instead of malloc 2009-07-20 17:26:56 -07:00
Tim Prouty
04c3dfde0f lib util: Fix const warning 2009-07-20 16:08:24 -07:00
Jeremy Allison
9357049171 Make cli_send_mailslot() static. Preparing to do away with unexpected.tdb....
Jeremy.
2009-07-20 15:15:08 -07:00
Rusty Russell
54a51839ea Make tdb transaction lock recursive (samba version)
This patch replaces 6ed27edbcd3ba1893636a8072c8d7a621437daf7 and
1a416ff13ca7786f2e8d24c66addf00883e9cb12, which fixed the bug where traversals
inside transactions would release the transaction lock early.

This solution is more general, and solves the more minor symptom that nested
traversals would also release the transaction lock early.  (It was also suggestd in
Volker's comment in 6ed27ed).

This patch also applies to ctdb, if the traverse.c part is removed (ctdb's tdb
code never received the previous two fixes).

Tested using the testsuite from ccan (adapted to the samba code).  Thanks to
Michael Adam for feedback.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Michael Adam <obnox@samba.org>
2009-07-20 22:17:20 +02:00
Jelmer Vernooij
c80783eafd Re-add accidently removed shares test. 2009-07-20 13:34:50 +02:00
Andrew Bartlett
09135ee5a0 s4:kdc Add in a simple check for constrained delegation to self
To do this properly, we must use the PAC, but for now this is enough
to check that we are delegating to another name on the same host
(which must be safe).

(Windows 7 does this a lot, also noted in bug 6273)

Andrew Bartlett
2009-07-20 14:21:18 +10:00
Matthias Dieter Wallnöfer
2fc5331e5c [SAMBA 4 directory] Refactoring and clean up of directory structure
- Adds more system objects which make sense to have them in SAMBA 4 also to
  have them when we add more and more services related to the directory (volume
  support, DFS, replication service, COM...)
- Make sure that "isCriticalSystemObject" and "showInAdvancedViewOnly" attributes
  are set correctly on each object
2009-07-20 14:21:09 +10:00
Jelmer Vernooij
7889823783 pidl: Print actual type names in errors about unknown origins rather than 'HASH(0x....)'. 2009-07-19 21:12:56 +02:00
Jelmer Vernooij
54a2f51d57 pidl: Print proper errors when arrays don't have a specified size rather than spewing pages of perl warnings. 2009-07-19 20:42:52 +02:00
Jelmer Vernooij
54670bb400 Remove unused parameter setting. 2009-07-19 18:58:22 +02:00
Jelmer Vernooij
478446f96d Remove unnecessary imports. 2009-07-19 18:51:15 +02:00
Jelmer Vernooij
8557d14f65 Merge branch 'master' of git://git.samba.org/samba 2009-07-19 17:39:23 +02:00
Jelmer Vernooij
4447bd96b9 Include ntsvc NDR in libndr-standard. 2009-07-19 17:18:04 +02:00
Jelmer Vernooij
de2a9fb607 Remove unused variable. 2009-07-19 17:17:23 +02:00
Slava Semushin
11fa3ed9ee source4/lib/registry/patchfile.c(reg_diff_load): fixed possible resource leak.
File descriptor leaks when write(2) fails and we are returning from
function.

Found by cppcheck:
[./source4/lib/registry/patchfile.c:319]: (error) Resource leak: fd
2009-07-19 16:01:12 +02:00
Slava Semushin
5f8df16471 lib/util/util_file.c(file_save): fixed file descriptor leak when read(2) fails.
Found by cppcheck:
[./lib/util/util_file.c:383]: (error) Resource leak: fd
2009-07-19 16:00:39 +02:00
Matthieu Patou
a817cff5a0 Fix broken password quality check
This fixes broken password tests when the passwords contain non ASCII characters
(e.g. accentuated chars like ('e, `e, ...)
2009-07-19 16:00:19 +02:00
Matthias Dieter Wallnöfer
295c3724a3 Fix typo 2009-07-19 16:00:14 +02:00
Matthias Dieter Wallnöfer
cb53b78080 [SAMBA 4] Some cosmetic changes for the LDB modules
Some corrections which make the code a bit more readable (no functional changes here)
2009-07-19 15:59:13 +02:00
Matt Kraai
dbedfc318e include unix.h if it's available 2009-07-19 15:59:03 +02:00
Matthias Dieter Wallnöfer
5b4cb31ef1 Cosmetic correction
Changes the order of two commands. First set up the "priv" structure, then
assign it to the "ntvfs" structure.
2009-07-19 15:58:45 +02:00
Jelmer Vernooij
de04e00ec2 Merge more ndr interfaces into libndr-standard. 2009-07-19 15:39:52 +02:00
Jelmer Vernooij
63a6ca084d librpc: Integrate some subsystems now part of libndr-standard and integrate ndr_dfs in libndr-standard. 2009-07-19 13:41:04 +02:00
Jelmer Vernooij
28d155499a Add missing includes. 2009-07-19 13:39:38 +02:00
Jelmer Vernooij
7a765b65b7 provision: Remove unused imports. 2009-07-19 13:19:54 +02:00
Jelmer Vernooij
d8ce8f9b61 Create libndr-standard, which includes the NDR marshalling code for
the "standard" set of DCE/RPC interfaces found on Windows.
2009-07-19 12:41:09 +02:00
Jelmer Vernooij
04c1d02021 Remove unnecessary include, update README. 2009-07-19 12:15:59 +02:00
Jelmer Vernooij
5bf6203bc2 Remove outdated status file about samba3 -> samba4 upgrade project. 2009-07-19 12:10:47 +02:00
Volker Lendecke
ce378e7c51 Fix a few type errors in VFS modules 2009-07-19 02:36:59 +02:00
Jelmer Vernooij
27087e6a87 VFS examples: Update copy of config.{guess,sub}. 2009-07-18 20:04:11 +02:00