1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-13 13:18:06 +03:00
Commit Graph

152 Commits

Author SHA1 Message Date
Simo Sorce
dc2ed4c830 r19986: ooops
(This used to be commit 97f150fbbb)
2007-10-10 12:16:17 -05:00
Simo Sorce
c81c8cb4a7 r19984: Must have been drunk yesterday.
Freeing memctx is all we need, fix double free stupidity
(This used to be commit 2a7454959e)
2007-10-10 12:16:17 -05:00
Simo Sorce
cb0402c2d3 r19980: Implement pam account stack checks when obey pam restrictions is true.
It was missing for security=server/domain/ads

Simo.
(This used to be commit 550f651499)
2007-10-10 12:16:17 -05:00
Simo Sorce
ef8d6bf5f7 r19979: Fix memleak on pw and change talloc_destroy to TALLOC_FREE for mem_ctx
(This used to be commit defa0a352b)
2007-10-10 12:16:17 -05:00
Jeremy Allison
28800c54dc r18907: W00t. My original fix was correct after all :-).
Re-checking it in.
Fix bug #4095 - username composed into domain\user
twice in spnego path.
Jeremy.
(This used to be commit 0c77046751)
2007-10-10 12:14:45 -05:00
Jeremy Allison
68a2430c52 r18403: Revert until we get this sorted out correctly.
Jeremy.
(This used to be commit d0fdd5eb1e)
2007-10-10 11:51:22 -05:00
Jeremy Allison
c432bfc14b r18398: Fix bug #4095 - username composed into domain\user
twice in spnego path. Jerry please check.
Jeremy.
(This used to be commit e872bacf28)
2007-10-10 11:51:21 -05:00
Gerald Carter
545353b062 r17909: ensure we do not call map_username() twice on Krb5 session setups
(This used to be commit 779eba0a7c)
2007-10-10 11:38:58 -05:00
Jeremy Allison
ce61fb21d9 r16397: Fix Klocwork #11767 and drasticly simplify the
logic in smbd/process.c. All interested (Volker,
Jerry, James etc). PLEASE REVIEW THIS CHANGE.
The logic should be identical but *much* easier
to follow and change (and shouldn't confuse Klockwork :-).
Jeremy.
(This used to be commit d357f8b335)
2007-10-10 11:18:52 -05:00
Volker Lendecke
ee7b4b47cb r15589: While trying to understand the vuid code I found that security=share is broken
right now. r14112 broke it, in 3.0.22 register_vuid for security=share returns
UID_FIELD_INVALID which in current 3_0 is turned into an error condition. This
makes sure that we only call register_vuid if sec!=share and meanwhile also
fixes a little memleak.

Then I also found a crash in smbclient with sec=share and hostmsdfs=yes.

There's another crash with sec=share when coming from w2k3, but I need sleep
now.

Someone (jerry,jra?) please review the sesssetup.c change.

Thanks,

Volker
(This used to be commit 8059d0ae39)
2007-10-10 11:17:02 -05:00
Günther Deschner
f777697508 r15523: Honour the time_offset also when verifying kerberos tickets. This
prevents a nasty failure condition in winbindd's pam_auth where a tgt
and a service ticket could have been succefully retrieved, but just not
validated.

Guenther
(This used to be commit a75dd80c62)
2007-10-10 11:16:55 -05:00
Volker Lendecke
dc9f30b8b0 r15475: Ugly and disgusting patch to fix the username map problem I created by
changing the token generation. I *hate* this code!

Jerry, you have been looking at this as well, can you double-check that I did
not screw it up?

Thanks,

Volker
(This used to be commit 2765c4ff8d)
2007-10-10 11:16:52 -05:00
Volker Lendecke
83e4ea7e85 r15472: Remove an unused function parameter
(This used to be commit d2f39ae7fe)
2007-10-10 11:16:52 -05:00
Jeremy Allison
f2e788ca37 r15467: Ensure every exit error path calls nt_status_squash.
Jeremy.
(This used to be commit e9b016ced6)
2007-10-10 11:16:51 -05:00
Jeremy Allison
6ca1ba3814 r15115: Fix error return on sessionsetup. Ensure no
data blob is added if the logon call failed.
Jeremy.
(This used to be commit 71d0191c31)
2007-10-10 11:16:24 -05:00
Jeremy Allison
75c965d3a4 r14790: Fix possible null deref. Coverity #277.
Jeremy.
(This used to be commit 2454af392a)
2007-10-10 11:15:48 -05:00
Jeremy Allison
5f224c2c26 r14170: Paranioa fix for sesssetup.
Fix Coverity bug #26. Guard against NULL ref.
Jeremy.
(This used to be commit c0f906ac8d)
2007-10-10 11:15:15 -05:00
Jeremy Allison
47a11f8a4c r14168: Fix Coverity #219. I think this is a false coverity
warning as it seems to get confused with assignment
and comparison. Clarify the code anyway.
Jeremy.
(This used to be commit 754818f8cc)
2007-10-10 11:15:14 -05:00
Günther Deschner
c077d363a4 r14130: Remove make_server_info_pac alltogether, make_server_info_info3 does
already do what we need.

Guenther
(This used to be commit 773e33c971)
2007-10-10 11:11:14 -05:00
Gerald Carter
1de2983de4 r14112: * fix checks on return code from register_vuid() which could actually
fail and we would still return success in the SMBsesssetup reply :-(
* Make sure to create the local token for the server_fino struct
  in reply_spnego_kerberos() so that register_vuid() does not fail.
  (how did this ever work?)
(This used to be commit 8dafa45b97)
2007-10-10 11:11:13 -05:00
Jeremy Allison
7104002cf8 r13604: Fix for bug #3512 "use spnego=no" and "server signing=auto" cause client to disconnect after negprot"
We missed one case of ignoring "BSRSPYL ".
Merge for 3.0.21c.
Jeremy.
(This used to be commit 7d21cf420f)
2007-10-10 11:10:19 -05:00
Gerald Carter
0af1500fc0 r13316: Let the carnage begin....
Sync with trunk as off r13315
(This used to be commit 17e63ac4ed)
2007-10-10 11:06:23 -05:00
Volker Lendecke
1bfb5b734b r11909: Implement 'reset on zero vc'. This kills other connections when a session
setup comes in with the vc (virtual connection) field set to zero. This is
done by Windows, probably you can tweak that by some registry key.

	This boolean option controls whether an incoming session setup
	should kill other connections coming from the same IP. This matches
        the default Windows 2003 behaviour.

	Setting this parameter to yes becomes necessary when you have a flaky
	network and windows decides to reconnect while the old connection
	still has files with share modes open. These files become inaccessible
	over the new connection.

	The client sends a zero VC on the new connection, and Windows 2003
	kills all other connections coming from the same IP. This way the
	locked files are accessible again.

	Please be aware that enabling this option will kill connections behind
	a masquerading router.

Volker
(This used to be commit 5629ca1623)
2007-10-10 11:05:34 -05:00
Günther Deschner
90603cb3cd r11846: Destroy the TALLOC_CTX on error in the Kerberos session setup and give a
more precise inline comment why PAC verification may fail.

Guenther
(This used to be commit 43b57715e9)
2007-10-10 11:05:29 -05:00
Gerald Carter
a4d729bdfa r11661: Store the INFO3 in the PAC data into the netsamlogon_cache.
Also remove the mem_ctx from the netsamlogon_cache_store() API.

Guenther, what should we be doing with the other fields in
the PAC_LOGON_INFO?
(This used to be commit 8bead2d282)
2007-10-10 11:05:23 -05:00
Gerald Carter
9d9fe2d58d r11655: Two small fixes
* remove redundant call to sub_set_smb_name() in session setup code.
* Fix lockup when running 'wbinfo -t' on a Samba PDC.  Cause
  was new authenticated session setup from winbindd which
  resulted in a mangled username (machine_) that was not found
  in the local files and so was queiued up to nss_winbindd.
  Deadlock....
  So now make sure to keep the trailing '$' for machine account
  names when calling sub_set_smb_name().
(This used to be commit b0a2d43b60)
2007-10-10 11:05:23 -05:00
Günther Deschner
ad7cd4096f r11213: Fix the build
Guenther
(This used to be commit 908ac0c9ec)
2007-10-10 11:05:06 -05:00
Günther Deschner
ad93243f23 r11183: add small helper function to return a PAC_LOGON_INFO.
Guenther
(This used to be commit a8d5d6b845)
2007-10-10 11:05:06 -05:00
Gerald Carter
54abd2aa66 r10656: BIG merge from trunk. Features not copied over
* \PIPE\unixinfo
* winbindd's {group,alias}membership new functions
* winbindd's lookupsids() functionality
* swat (trunk changes to be reverted as per discussion with Deryck)
(This used to be commit 939c3cb5d7)
2007-10-10 11:04:48 -05:00
Andrew Bartlett
f31965b549 r8913: Fix memory leak in -r 8912: Free the right thing, rather than blob1 'twice'.
Andrew Bartlett
(This used to be commit 7adeba4036)
2007-10-10 11:00:20 -05:00
Andrew Bartlett
a3947eaa4e r8912: Samba 3.0 was failing from a Vista client, because it was using 'raw'
NTLMSSP (not wrapped in SPNEGO).  We really should have supported this
anyway, but we got away with it for a while...

Andrew Bartlett
(This used to be commit 78f0640a4b)
2007-10-10 11:00:19 -05:00
Gerald Carter
dae78e57e2 r8472: abartlet's patch for parallel ntlmssp supporttrunk/source/smbd/sesssetup.c
(This used to be commit aab17a7095)
2007-10-10 11:00:06 -05:00
Jeremy Allison
f2f55d703d r7963: Add aio support to 3.0.
Jeremy.
(This used to be commit 1de27da470)
2007-10-10 10:58:05 -05:00
Jeremy Allison
19ca97a70f r7882: Looks like a large patch - but what it actually does is make Samba
safe for using our headers and linking with C++ modules. Stops us
from using C++ reserved keywords in our code.
Jeremy
(This used to be commit 9506b8e145)
2007-10-10 10:58:00 -05:00
Gerald Carter
dacdfbc98c r7398: commiting abartlet's patch for kerberos authentication when using a keytab and security != ads
(This used to be commit 3faaa5c3eb)
2007-10-10 10:57:08 -05:00
Gerald Carter
377f947930 r7395: * new feature 'map to guest = bad uid' (based on patch from
aruna.prabakar@hp.com).

This re-enables the Samba 2.2 behavior where a user that was
successfully authenticated by a remote DC would be mapped
to the guest account if there was not existing UNIX account
for that user and we could not create one.
(This used to be commit b7455fbf81)
2007-10-10 10:57:08 -05:00
Gerald Carter
b279ee16e9 r7372: abartet's patch for BUG 2391 (segv caused by free a static pointer)
(This used to be commit 4cda2bd035)
2007-10-10 10:57:06 -05:00
Gerald Carter
f24d88cf9d r7139: trying to reduce the number of diffs between trunk and 3.0; changing version to 3.0.20pre1
(This used to be commit 9727d05241)
2007-10-10 10:57:02 -05:00
Gerald Carter
cc6df2e9cf r7024: reverting mistaken commit
(This used to be commit c70c5c4ee9)
2007-10-10 10:57:00 -05:00
Gerald Carter
af52df2f1f r7020: fixing printer ace values and getting rid of false compiler warning about unitialized variable
(This used to be commit 3a91b20e4b)
2007-10-10 10:57:00 -05:00
Herb Lewis
978ca84860 r6225: get rid of warnings from my compiler about nested externs
(This used to be commit efea76ac71)
2007-10-10 10:56:30 -05:00
Derrell Lipman
9840db418b r6149: Fixes bugs #2498 and 2484.
1. using smbc_getxattr() et al, one may now request all access control
   entities in the ACL without getting all other NT attributes.
2. added the ability to exclude specified attributes from the result set
   provided by smbc_getxattr() et al, when requesting all attributes,
   all NT attributes, or all DOS attributes.
3. eliminated all compiler warnings, including when --enable-developer
   compiler flags are in use.  removed -Wcast-qual flag from list, as that
   is specifically to force warnings in the case of casting away qualifiers.

Note: In the process of eliminating compiler warnings, a few nasties were
      discovered.  In the file libads/sasl.c, PRIVATE kerberos interfaces
      are being used; and in libsmb/clikrb5.c, both PRIAVE and DEPRECATED
      kerberos interfaces are being used.  Someone who knows kerberos
      should look at these and determine if there is an alternate method
      of accomplishing the task.
(This used to be commit 994694f7f2)
2007-10-10 10:56:24 -05:00
Jeremy Allison
5415480d7e r6020: Never do NT status codes with protocols before NT1 as we don't get client caps.
Jeremy.
(This used to be commit 4868e42027)
2007-10-10 10:56:16 -05:00
Gerald Carter
4b831f8e16 r5952: BUG 2469: patch from Jason Mader to cleanup compiler warning when not using krb5
(This used to be commit 19a639ac46)
2007-10-10 10:56:11 -05:00
Jeremy Allison
2257618d7f r5290: Fix for bug #2323 - plaintext problem with WinXP.
Jeremy.
(This used to be commit 3e10c36cb5)
2007-10-10 10:55:36 -05:00
Jeremy Allison
482f14871d r3946: Fix for bugid #2085 reported by Jason Mader <jason@ncac.gwu.edu>. Use consistent
enum type for Protocol extern.
Jeremy.
(This used to be commit 65dfae7ea4)
2007-10-10 10:53:26 -05:00
Gerald Carter
600e904aa1 r1370: BUG 1297 - prevent map_username() from being called twice during logon
(This used to be commit e1364ff774)
2007-10-10 10:52:08 -05:00
Andrew Bartlett
3542b99cf1 r1122: As spotted by lha@stacken.kth.se we don't actually use this variable any more.
Andrew Bartlett
(This used to be commit 9d5821d5ee)
2007-10-10 10:51:56 -05:00
Jeremy Allison
8c0db1bbc4 r786: Memory leak fixes in (mostly) error code paths from
kawasa_r@itg.hitachi.co.jp. A couple of mem leak fixes in
mainline code paths though :-).
Jeremy.
(This used to be commit 4695cc95fe)
2007-10-10 10:51:38 -05:00
Andrew Bartlett
d17425ed52 r69: Global rename of 'nt_session_key' -> 'user_session_key'. The session key could
be anything, and may not be based on anything 'NT'.  This is also what microsoft
calls it.
(This used to be commit 724e8d3f33)
2007-10-10 10:51:06 -05:00