1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00

19910 Commits

Author SHA1 Message Date
Jeremy Allison
2b8abc030b r16644: Fix bug reported by jason@ncac.gwu.edu
by converting the lookup_XX functions to correctly
return SID_NAME_TYPE enums.
Jeremy.
(This used to be commit ee2b2d96b60c668e37592c79e86c2fd851e15f69)
2007-10-10 11:19:05 -05:00
Jeremy Allison
79eaa709a0 r16642: Fix show-stopper bug . Double-free in wins
server code. Jerry please merge for 3.0.23.
Jeremy.
(This used to be commit d354b430ff0473764db8ea492a68d10946dadc23)
2007-10-10 11:19:05 -05:00
Jeremy Allison
b2ddb4626c r16640: Fix bug reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 76cc25a37e145fb48a8a81df37e790690b5dceac)
2007-10-10 11:19:05 -05:00
Jeremy Allison
4471ce9a68 r16638: Fix bug , reported by jason@ncac.gwu.edu. Use
the correct enumerated type in the macro.
Jeremy.
(This used to be commit 63ad19f71c6b9474042f4ea9d5859e2849a73da8)
2007-10-10 11:19:05 -05:00
Jeremy Allison
7d6856240b r16636: Fix bug reported by jason@ncac.gwu.edu
Jeremy.
(This used to be commit 7580eb947cdeb786be00efa5da727e32b28c99d6)
2007-10-10 11:19:05 -05:00
Jeremy Allison
6a9b101dd6 r16634: Fix bug reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit d04462f1d8cf009985b9112f093306a64689af64)
2007-10-10 11:19:04 -05:00
Jeremy Allison
8322d26276 r16632: Fix bug reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 6b39f53e43572fe29fc037a36328387a0b1bb423)
2007-10-10 11:19:04 -05:00
Jeremy Allison
9e13d35092 r16630: Fix bug , reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit ec0a47b94c12b64d351ca8e6bdd467578528f3da)
2007-10-10 11:19:04 -05:00
Jeremy Allison
6c94466d7b r16628: Fix bug , reported by jason@ncac.gwu.edu
by ensuring we return the correct enum for sid
type, not a uint32.
Jeremy.
(This used to be commit 98a5e20ff4ceacda65dcc0ce5498ed4ffde520f8)
2007-10-10 11:19:04 -05:00
Jeremy Allison
57ba729fac r16626: Fix bug . Reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 4c3019eb99d0a18a33ef1fa90d01b9c99c0b25c3)
2007-10-10 11:19:04 -05:00
Jeremy Allison
5887885da3 r16624: Fix bug , reported by jason@ncac.gwu.edu
Jeremy.
(This used to be commit 1f52b8b40619679242da663f5e5e7836d547f0a2)
2007-10-10 11:19:04 -05:00
Jeremy Allison
3e626e6107 r16616: Klocwork . Stop null deref. I actually don't
think this can happen in real life but the code is
too complicated to be sure....
Jerry please merge this for 3.0.23.
Jeremy.
(This used to be commit 1e5042d4c0d1a0d0a5cfbcb0d47815e1510ee52a)
2007-10-10 11:19:03 -05:00
Jeremy Allison
2ef834cdd8 r16614: Klocwork . memleak on error path.
Jeremy.
(This used to be commit 58b9adb849854610e7167e8aa02a02bd15b0bf00)
2007-10-10 11:19:03 -05:00
Jeremy Allison
8413a18a58 r16612: Klocwork fix . memleak on error path.
Jeremy.
(This used to be commit b4e9475d2ac65f72cab0d5c8276da27cf1aeb791)
2007-10-10 11:19:03 -05:00
Jeremy Allison
61578c2308 r16610: Subtle one from Klocwork . If multiple flags
are set in a winbindd request it might overwrite existing
state->response.extra_data.data values without freeing.
Jeremy.
(This used to be commit 4e7262c81ad2945048cb8d0789af032a05008988)
2007-10-10 11:19:03 -05:00
Jeremy Allison
c1dbb16945 r16608: Klocwork . Null deref (bit of a stretch... :-).
Jeremy.
(This used to be commit 7d7a98208b1b514da60486fcbbb7b6d04df4ffac)
2007-10-10 11:19:03 -05:00
Jeremy Allison
95a81a3351 r16606: Klocwork . Malloc the correct size.
Jeremy.
(This used to be commit d1a1c4e092877a6ea0f98eed2a37a96d42c36323)
2007-10-10 11:19:03 -05:00
Jeremy Allison
5fb4cc9dff r16603: Klockwork . Fix null deref on error path.
Jeremy.
(This used to be commit 067feef34388e93ded8db7fd3b4a6a4b752a3059)
2007-10-10 11:19:03 -05:00
Jeremy Allison
107698dd0e r16601: Klocwork . Fix memleak on error path.
Jeremy.
(This used to be commit 934dddb2fa9fb60a87c0b0be81db97f2b59c7cb0)
2007-10-10 11:19:02 -05:00
Jeremy Allison
fc77e332e3 r16599: Make it clear to Klocwork we're not dereferencing. Issue .
Jeremy.
(This used to be commit 9402bf0d4cc6d04283ed69a6dedac7767df84626)
2007-10-10 11:19:02 -05:00
Jeremy Allison
9f4c335401 r16597: Klocwork . Fix possible null deref.
Jeremy.
(This used to be commit 9b73385d6b90c7806d8ccfc1f2354ede761fad61)
2007-10-10 11:19:02 -05:00
Jeremy Allison
35a57320f8 r16595: Klocwork . Fix possible memleak on error exit.
Jeremy.
(This used to be commit 1d21a3dec9ea061ce900ad1223f7c2a43c064600)
2007-10-10 11:19:02 -05:00
Jeremy Allison
8e274e8661 r16593: Make the invarient explicit to Klocwork. Bug .
Jeremy.
(This used to be commit 720a9172050beb158a25fbb826676ba19cdcef20)
2007-10-10 11:19:02 -05:00
Jeremy Allison
8beeeffd6e r16591: Belt and braces approach to shut Klocwork up - bug .
Jeremy.
(This used to be commit d5c1028498de0346b7a35cc132b8081e04e639cc)
2007-10-10 11:19:02 -05:00
Jeremy Allison
49f6498a6f r16589: Fix Klocwork . Although it should be impossible to
get duplicate OID's returned in the oids_out list it is
still good programming practice to clear out a malloc'ed
string before re-writing it (especially in a loop).
Jeremy
(This used to be commit ae02c05bfca46eb6a8ba25b124c18a358a759cb5)
2007-10-10 11:19:02 -05:00
Jeremy Allison
67af7a8c43 r16587: Fix Klocwork . Memleak on reusing x_dbf.
Jeremy.
(This used to be commit 16b0617cb0f91fbe1ce53dcb601fe5ed9e51bddf)
2007-10-10 11:19:01 -05:00
Jeremy Allison
f18df87fe9 r16585: Fix Klocwork . Possible null deref.
Jeremy.
(This used to be commit a912ef0d9724373966e77f9e8928be462de8df4a)
2007-10-10 11:19:01 -05:00
Jeremy Allison
d1014c1cdf r16582: Fix Klocwork and all generic class of problems
where we don't correctly check the return from memdup.
Jeremy.
(This used to be commit ce14daf51c7ee2f9c68c77f7f4674e6f0e35c9ca)
2007-10-10 11:19:01 -05:00
Jeremy Allison
5a1a08d428 r16581: Fix Klocwork . Possible null deref.
Jeremy.
(This used to be commit 6967fd4cefa84a7b7b5e14467bfa8152907d55c9)
2007-10-10 11:19:01 -05:00
Jeremy Allison
d70803ebe3 r16579: Fix Klocwork . Possible null deref.
Jeremy.
(This used to be commit f6d5bae4a105eee1b1d5b1aaa70a675705345d9e)
2007-10-10 11:19:01 -05:00
Jeremy Allison
9a7adde8a3 r16576: Fix Klocwork . Possible null deref.
Jeremy.
(This used to be commit 9cbfaf62a3c4bb7d2e594e412449506ab0af4063)
2007-10-10 11:19:01 -05:00
Christopher R. Hertel
98118545c1 r16570: Corrected the copyright notice. I had requested and received permission
from my management at the University to release under my own copyright.
My mistake for entering the wrong info.
(This used to be commit c65ebeb02810fb4039555c55779ec62a4a8de564)
2007-10-10 11:19:00 -05:00
Jeremy Allison
b000e8f083 r16554: Sorry, just had to change this. Don't use int when
you're passing a BOOL parameter, don't use "clever"
code in while statement - make things easier and
clearer to understand when triggering something
with an if.
Jeremy.
(This used to be commit b1fc2d8b99e0402c0e8fe954d9f9563dc4dc2812)
2007-10-10 11:19:00 -05:00
Derrell Lipman
9220a7bb7b r16552: Fix bug 3849.
Added a next_token_no_ltrim() function which does not strip leading separator
characters.  The new function is used only where really necessary, even though
it could reasonably be used in many more places, to avoid superfluous code
changes.

Derrell
(This used to be commit d90061aa933f7d8c81973918657dd72cbc88bab5)
2007-10-10 11:19:00 -05:00
Derrell Lipman
9718506d35 r16550: Fix bug 3866. Thanks for the report!
Although I've never met a computer or compiler that produced pointers to
functions which are a different size than pointers to data, I suppose they
probably exist.  Assigning a pointer to a function is technically illegal in C
anyway.

Change casts of the option_value based on the option_name to use of variable
argument lists.

For binary compatibility, I've maintained but deprecated the old behavior of
debug_stderr (which expected to be passed a NULL or non-NULL pointer) and
added a new option debug_to_stderr which properly expects a boolean (int)
parameter.

Derrell
(This used to be commit c1b4c510530ca3118d1eccb9615a8cad732c7373)
2007-10-10 11:18:59 -05:00
Jeremy Allison
ad6f4f14ad r16548: Fix bug reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 2b8d72f09c6d79d5d41421545b538da573adcd9d)
2007-10-10 11:18:59 -05:00
Jeremy Allison
7d187fe7e0 r16546: Fix bug reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit be888a3cda637149c3183418c6e721c6fef1b652)
2007-10-10 11:18:59 -05:00
Jeremy Allison
24814867c3 r16544: Fix bug reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 16e42b446bea171c3ad848aefaa92c7404aade42)
2007-10-10 11:18:59 -05:00
Jeremy Allison
429cd6db0b r16542: Fix , reported by jason@ncac.gwu.edu
Jeremy.
(This used to be commit cde8323fdc4d4ddaa30e8c59bec89dc130fe26a6)
2007-10-10 11:18:59 -05:00
Jeremy Allison
fe28eb2e41 r16541: Fix reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 09e11dcb2304eec9656e76c24921c82f4a870914)
2007-10-10 11:18:58 -05:00
Jeremy Allison
a24c404967 r16537: Fix for bug , all files in a directory not
being deleted when hide unreadable set to true.

Here's the scoop.

This one is really interesting. The pattern of deleting a directory is to do a
findfirst to get the first part of the list, then for each name returned it
does a open/set delete on close/close -> thus deleting the file. Then it does a
findnext with the last file name THAT IT JUST DELETED ! Now we can handle this
in the findnext in the case where hide unreadable is set to false as we look
back in our cache of names and just seek to the right point. The bug is
actually fixed in the first hunk of this patch - the one that removes the
is_visible_file() check after SearchDir returns false. We don't actually need
it and in this case it's causing the delete to be aborted because it can't find
the name (doh ! it was just deleted). We don't need it as SearchDir is only
ever called from findnext, and findnext should only ever be returning names we
gave it.

The rest of the patch are the debugs I used to find
the problem but they're generically useful.

Phew - that one took a while to track down.....

Jerry, please merge for 3.0.23 final.

Jeremy.
(This used to be commit cd048cb775f0a8525fc19aa463db07c477521f5b)
2007-10-10 11:18:57 -05:00
Gerald Carter
6612988d09 r16528: Self-confidence is plummeting. How could one person goof
the same change 3 times......

Fix pam_winbind compilation again.
(This used to be commit f3d2bbf0d222794bbb39b51a0f19167c6e8add1a)
2007-10-10 11:18:57 -05:00
Günther Deschner
72bc37cfa4 r16521: Fix different extended_dn handling for win2k/2k3 (thanks to Frederic
Brin at Novell).

Guenther
(This used to be commit f19f781e15da98cfaa94c71fc455fe095dac7b4d)
2007-10-10 11:18:57 -05:00
Gerald Carter
7e76f785f8 r16510: fix from Nicholas Brealey <nick@brealey.org> for building pam_winbind.so
(This used to be commit 4490fbdfc27eab02bf0140d3ffb70402858423e1)
2007-10-10 11:18:57 -05:00
Volker Lendecke
1d21b9659b r16490: Fix a memleak and two typos
(This used to be commit 8cf364e602eea408fd9cd6acd12f2b72971361ae)
2007-10-10 11:18:57 -05:00
Gerald Carter
505f6b42c9 r16486: fix RedHat init scripts to rely on OS provided killproc() function
(This used to be commit 164cdf69f395236ffef9ecc202543d53b5eda2da)
2007-10-10 11:18:57 -05:00
James Peach
00a0b0cbf3 r16484: Bugzilla 3805. Only define _ABS if it is not already defined.
(This used to be commit 09fb20f4fe26a5ec82e2f296bf033ab0864af669)
2007-10-10 11:18:57 -05:00
James Peach
ae412ebe71 r16483: Turn off some useless MIPSPro warnings be default.
(This used to be commit a22bf28bcab6ef3c4addaf57fdeb2020625ead0e)
2007-10-10 11:18:56 -05:00
James Peach
d2864af2e7 r16482: Fix bugzilla 3801 by forcing MIPSPro warning 1035 to be an error.
(This used to be commit 2131ddd7a13f078be471d327c8d73300facf8def)
2007-10-10 11:18:56 -05:00
Günther Deschner
e9b3f293ae r16480: (Ugly) workaround before the set_dc_type_flags & friends cleanup:
When trying to login using krb5 with a trusted domain account, we
need to make sure that our and the remote domain are AD.

Guenther
(This used to be commit 5853525f111c0ab6a97b081d5964f778e7c36565)
2007-10-10 11:18:56 -05:00