sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code
124,688 Commits 60 Branches 1,144 Tags 452 MiB
2b9ba992b6
Commit Graph

124688 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Volker Lendecke
2b9ba992b6 lib: Simplify parse_guid_string() and ndr_syntax_id_from_string() 
Return "bool" instead of NTSTATUS, use hex_byte() instead of
read_hex_bytes(). And parse directly into a struct GUID instead of the
components. 99 lines less code.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
 2021-01-28 16:58:35 +00:00
Samuel Cabrero
522ef9e6a5 s4-torture: Add a test for ndr_syntax_id_from_string() 
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
 2021-01-28 16:58:35 +00:00
Samuel Cabrero
15934ace71 s4-torture: Add a test for GUID_from_data_blob 
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
 2021-01-28 16:58:35 +00:00
Volker Lendecke
064eab8b25 dsdb: Avoid an unneeded #include 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
 2021-01-28 16:58:35 +00:00
Volker Lendecke
fcf60f155a librpc: Simplify dcerpc_binding_set_abstract_syntax() 
It might be a question of style, but I find it simpler this way.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
 2021-01-28 16:58:35 +00:00
Volker Lendecke
eed1257268 librpc: Use ndr_syntax_id_buf_string() in dcerpc_binding_set_abstract_syntax() 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
 2021-01-28 16:58:35 +00:00
Volker Lendecke
243ce60212 librpc: Use ndr_syntax_id_buf_string() in dcerpc_sec_vt_pctx_check() 
"mem_ctx" is no longer needed

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
 2021-01-28 16:58:35 +00:00
Volker Lendecke
a35c8a0ec2 librpc: Add ndr_syntax_id_buf_string() 
Same pattern as GUID_buf_string()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
 2021-01-28 16:58:35 +00:00
Volker Lendecke
2e3e297b25 librpc: Add a NULL check to dcerpc_binding_build_tower() 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
 2021-01-28 16:58:35 +00:00
Volker Lendecke
9374313f03 libndr: Simplify ndr_print_GUID() 
Fix a small memleak of the tmp GUID_string

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
 2021-01-28 16:58:35 +00:00
Ralph Boehme
c8c2aef0ac vfs: restore platform specific POSIX sys_acl_set_file() functions 
92b1499542 removed SMB_VFS_SYS_ACL_SET_FILE() and
all the VFS module implementations. But sys_acl_set_file() in vfs_default calls
into sys_acl_set_file() in sysacls.c which calls back into platform specific
modules.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14619

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Jan 28 15:21:02 UTC 2021 on sn-devel-184
 2021-01-28 15:21:02 +00:00
Ralph Boehme
9f08ddf663 vfs: update status of SMB_VFS_UNLINKAT() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jan 28 09:16:30 UTC 2021 on sn-devel-184
 2021-01-28 09:16:30 +00:00
Ralph Boehme
ba2e691faf s3/libadouble: use real dirfsp in ad_convert_delete_adfile() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
00ec67eb0c s3/libadouble: remove dirfsp arg from ad_convert_delete_adfile() 
Going to open a dirfsp in the function itself in a later commit.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
d2acd9629e s3/libadouble: remove dirfsp arg from ad_convert() 
ad_convert() doesn't really need the dirfsp in most places. Only
ad_convert_delete_adfile() would use it, so instead open a dirfsp internally for
this function in a later commit.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
0f3db9b6b5 smbd: use real dirfsp for SMB_VFS_UNLINKAT() in py_smbd_unlink() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
e5262e2804 smbd: use real dirfsp for SMB_VFS_UNLINKAT() in remove_msdfs_link() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
b3375098ac vfs: update status of SMB_VFS_CREATE_DFS_PATHAT() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
1c60b516a1 smbd: use real dirfsp for SMB_VFS_CREATE_DFS_PATHAT() in create_msdfs_link() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
f6f4baf919 smbd: use real dirfsp for SMB_VFS_UNLINKAT() in create_msdfs_link() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
5f4592d184 smbd: use real dirfsp with SMB_VFS_UNLINKAT() in rmdir_internals() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
065f39a3d0 smbd: reduce indentation in rmdir_internals() 
No change in behaviour. Best viewed with

$ git show -w

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
60ddee64f6 smbd: simplify rmdir_internals() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
d579394db3 smbd: README.Coding fixes in rmdir_internals() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
a1ca5740aa smbd: use real dirfsp for SMB_VFS_UNLINKAT() in recursive_rmdir() 
Also use synthetic_pathref() to ensure atname->fsp has a valid pathref as some
backends may make use of it.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
21859695fc smbd: add dir_hnd_fetch_fsp() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
640683990e smbd: add some space in recursive_rmdir() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
007a352c7b smbd: simplify recursive_rmdir() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
0831369aef smbd: use real dirfsp and atname when deleting file in close_remove_share_mode() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
2995e0d57c pysmbd: use parent_pathref() in py_smbd_mkdir() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
02dd66bf4b smbd: use parent_pathref() in smb_set_file_unix_link() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
65c90e6231 smbd: use parent_pathref() in smb_unix_mknod() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
9b8b62a840 smbd: use parent_pathref() in mkdir_internal() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
6085f6c856 smbd: add parent_pathref() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
dd42681fe9 s4/torture: move deletion out of close loop in torture_smb2_maxfid() 
A subsequent commit is changing the delete-on-close code in the fileserver to
open a handle on the parent directory of the file that is to be deleted.

If we've consumed all available handles, that open would fail causing a test
failure. As it's not really needed for the test semantics, don't set
delete-on-close when closing the handles, instead let the subsequent
smb2_deltree() do the cleanup.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
de85bccef2 vfs_fruit: support real dirfsps in fruit_unlinkat() 
Now that all callees are updated, we can remove the assert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
951fefeca8 vfs_fruit: support real dirfsps in fruit_unlink_rsrc_adouble() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
c231d88655 vfs_fruit: support real dirfsps in fruit_unlink_rsrc_stream() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
cb90a8dc79 vfs_fruit: use SMB_VFS_FREMOVEXATTR() in fruit_unlink_meta_netatalk() 
Use the pathref fsp from the caller.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
8e155cbe4a vfs_acl_common: support real dirfsps in acl_common_remove_object() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
5abc1e7af6 vfs_xattr_tdb: support real dirfsps in xattr_tdb_unlinkat() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
39f432ac5d vfs_virusfilter: support real dirfsps in virusfilter_vfs_unlinkat() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
2d31aef937 vfs_unityed_media: support real dirfsps in um_unlinkat() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
f81bec1b7f vfs_time_audit: support real dirfsps in smb_time_audit_unlinkat() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
7bc983f5d5 vfs_fruit: use synthetic_pathref() in delete_invalid_meta_stream() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
ffd6bcdf37 vfs_fruit: fix use after free in delete_invalid_meta_stream() 
sname is used in the DBG_ERR message.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
274ed8c012 vfs_streams_xattr: use pathref in streams_xattr_unlink_internal() 
All callers now pass an smb_fname that has a valid pathref fsp.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
f1607cda38 smbd: use synthetic_pathref() in delete_all_streams() 
This ensures backends can use the pathref fsp as needed.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
bc1070d241 printing: use synthetic_pathref() in driver_unlink_internals() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00
Ralph Boehme
1032bf08dd vfs_fruit: use synthetic_pathref() in readdir_attr_meta_finderi_stream() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2021-01-28 08:11:49 +00:00