1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-26 10:04:02 +03:00

29194 Commits

Author SHA1 Message Date
Günther Deschner
3130aa63fd Fix build warning.
Thanks to Thorkil Olesen.

Guenther
2008-07-03 11:10:21 +02:00
Volker Lendecke
dcc39ed004 Don't scream, better explain a bit in comments 2008-07-03 11:08:51 +02:00
Volker Lendecke
cd8e63b2b4 Make use of sid_check_is_in_unix_users/groups
Don't replicate code unnecessarily
2008-07-03 11:08:51 +02:00
Jeremy Allison
3a7542fd49 Remove worrying warning message when safe_strcpy tries to copy a pseaudo interface
name that's too long. Reported by James Kosin <JKosin@intcomgrp.com>.
Jeremy.
2008-07-02 16:31:16 -07:00
Jeremy Allison
fc2178b047 Canonicalize servername in the printer functions to remove leading '\\' characters. Ensure we always return consistent names.
Jeremy.
2008-07-02 16:11:59 -07:00
Jeremy Allison
d7c82997bd Fix bug #5578, reported by sendel2000@hotbox.ru. Bad (non-Samba) use of strlcat gives error.
Jeremy.
2008-07-02 11:57:13 -07:00
Jeremy Allison
ade27d8baa Ensure consistent use of pdb_get_nt_passwd instead of pdb_get_lanman_passwd.
Reported by hongbing Zhang <hongbing.zhang@gmail.com>.
Jeremy.
2008-07-02 10:51:45 -07:00
Volker Lendecke
fe79c8a5b7 Fix typo 2008-07-02 15:13:14 +02:00
Volker Lendecke
6009ae3293 Tiny logic simplification: Remove an unnecessary else branch 2008-07-02 15:13:01 +02:00
Volker Lendecke
cc77db2acb Fix nonempty whitespace only lines 2008-07-02 15:04:46 +02:00
Volker Lendecke
e0957c6f4b fix typos 2008-07-02 14:54:59 +02:00
Volker Lendecke
0da9d0d0f9 Fix nonempty whitespace only lines 2008-07-02 14:18:15 +02:00
Volker Lendecke
954556b527 Fix indentation 2008-07-02 14:18:10 +02:00
Volker Lendecke
daa171552d Fix a debug msg, this was probably a leftover from gencache 2008-07-02 14:18:05 +02:00
Volker Lendecke
fe58926283 Fix typo 2008-07-02 14:18:01 +02:00
Volker Lendecke
c8d1bbfddc Make idmap_init() static
This is called only from idmap_alloc_init, which feels kindof weird.

Digging deeper in the code...
2008-07-02 13:34:09 +02:00
Volker Lendecke
7cec389e19 Fix two memory leaks in an error path in idmap.c 2008-07-02 13:34:09 +02:00
Darshan Purandare
cfbcfc3ffe MSG_DEBUG now forwarded to all the winbindd children by parent.
smbcontrol winbindd debug level would only set the debug level of the
parent winbindd process and not the child processes. This patch adds
the functionality of broadcasting the debug message to all winbindd
children. Now the debug level message is propagated to all the winbindd
processes that includes parent and children.
2008-07-01 17:52:24 -07:00
Jeremy Allison
80e547665d Jim Brown <jim.brown@miami.edu> was right, this needs to be a signed int or
the loop never terminates.
Jeremy.
2008-07-01 15:51:54 -07:00
Jeremy Allison
d85cbdbe29 Two more fixes from Jim Brown <jim.brown@miami.edu> for SGI compiler warnings.
Jeremy.
2008-07-01 15:39:41 -07:00
Jeremy Allison
d89f9d404f Fix problem noticed by Jim Brown <jim.brown@miami.edu>. When reverse searching decrement index,
not increment. Michael please check !
Jeremy.
2008-07-01 15:28:13 -07:00
Karolin Seeger
534a445df4 Revert "winbind cache: Don't create SN cache entries during name-to-sid queries."
This reverts commit b58e4f6b3d73294d8448c0dff4341183c52e5b7c.

Details can be found on the samba-technical mailing list.

Karolin
2008-07-01 10:34:22 +02:00
Günther Deschner
0ef420c3a4 net_vampire: add code to vampire to a Kerberos keytab file using DRSUAPI.
Guenther
2008-07-01 10:02:01 +02:00
Günther Deschner
48efe7dbce net_vampire: keep keytab context and flush keytab only after the last query.
Guenther
2008-07-01 10:00:57 +02:00
Jeremy Allison
e321377174 Fix from Atte Peltomki - atte.peltomaki@f-secure.com to correctly check
error code in winbindd group expansion.
Jeremy.
2008-06-30 09:20:05 -07:00
Günther Deschner
6194244bd9 kerberos: allow to keep entries with old kvno's while creating keytab.
Guenther
2008-06-30 12:38:40 +02:00
Günther Deschner
48600a0019 kerberos: rename smb_krb5_kt_add_entry to smb_krb5_kt_add_entry_ext.
Guenther
2008-06-30 12:38:32 +02:00
Volker Lendecke
9fe09398b7 Fix a file descriptor leak in add_port_hook
This was probably cut&paste from add_printer_hook which further down has the
unconditional close(fd). In add_port_hook() we're not interested in the output
of 'addport command', so don't create the out fd.
(cherry picked from commit 0c5ca2127ac6e3c71e369242376d27429c3aee5e)
2008-06-28 16:10:50 +02:00
Gerald W. Carter
8704c2ab37 Return NULL in sitename_fetch() if gencache_init() fails. Not false 2008-06-28 09:36:30 -04:00
Volker Lendecke
d3facf4cbd Let send_trans_reply work on only the inbuf
It does not really need the whole smb_request
2008-06-28 10:38:51 +02:00
Volker Lendecke
50427cbf63 Factor out create_outbuf, creating an outbuf just given an inbuf 2008-06-28 10:38:51 +02:00
Volker Lendecke
242077f714 Fix the build 2008-06-28 10:38:51 +02:00
Jeremy Allison
e072b3667e Fix bug #5568 net rpc trustdom add broken !
net rpc trustdom add was broken. The default 10second timeout can be too short
to create an account on a Samba DC (calling out to a script), error message
reporting was poor, and more importantly the new marshalling code for
user_info23 was broken (maps onto a user_info21 but doesn't clear the
user_info23 struct before marshalling, leaving an uninitialized size field -
give "alloc failure").
Jeremy.
2008-06-27 17:26:41 -07:00
Jeremy Allison
20e59faf6e Fix usage message for net rpc trustdom add.
Jeremy.
2008-06-27 15:28:45 -07:00
Volker Lendecke
41d1b9541c Do not segfault if corepath is not set up properly 2008-06-27 16:57:12 +02:00
Gerald W. Carter
f4c37dbe2c libads: Add API call to connect to a global catalog server.
Extends ads_connect() to a new call ads_connect_gc() which connects on port
3268 rather than port 389.  Also makes ads_try_connect() static and
only used internally to ldap.c
2008-06-27 10:26:11 -04:00
Karolin Seeger
30d181c924 Fix warnings on SuSE 9.0.
The macros "[un]likely" are already defined on SuSE 9.0.
Patch from Volker.
2008-06-27 15:51:35 +02:00
Karolin Seeger
d06baf0e74 Revert "build: add symbol versioning when we build with gnu ld"
This reverts commit cb5492978b6b157f529806afb2f5fc6202888129.

For more information, please have a look at the discussion on
samba-technical starting with [1].

[1] http://lists.samba.org/archive/samba-technical/2008-June/059511.html

Karolin
(cherry picked from commit 1e5aeb96f92fef8056ec9010e125f4d0d31dd90e)
2008-06-27 13:46:26 +02:00
Volker Lendecke
5222b8db3f Fix two IBM checker warnings
Steve, please check!

Thanks,

Volker
2008-06-27 11:23:20 +02:00
Volker Lendecke
eb6096a2d4 Fix an "invalid operation involving NULL pointer" found by the IBM checker
Jerry, please check!

Volker
2008-06-27 11:23:20 +02:00
Volker Lendecke
44a9e5b713 Remove a strlen check that will never kick in
strlen(str)<2 will be caught by the explicit tests for str[0] and str[1] in the
lines above this.

Jerry, please check!

Volker
2008-06-27 11:23:20 +02:00
Jeremy Allison
9e2ab30d3c Fix the non-LDAP, non-krb5 build, fix gcc -O3 warnings.
Jeremy.
2008-06-26 19:46:18 -07:00
Günther Deschner
22bdee7fe0 libnet_dssync: add last_query flag to processing routine.
Guenther
2008-06-27 02:01:15 +02:00
Günther Deschner
c16e1820f8 libnet_dssync: add output filename and dns_domain_name to dssync struct.
Guenther
2008-06-27 02:01:03 +02:00
Günther Deschner
fa1976e23a net_vampire: use bool for last_query information in samsync.
Guenther
2008-06-27 01:59:26 +02:00
Günther Deschner
69d8442bf3 net_vampire: separate keytab code from samsync code.
Guenther
2008-06-27 01:58:39 +02:00
Jeremy Allison
5188f28611 From Steve Danneman @ Isilon.
Attached is the companion patch to
(037b9689d9042a398cb91e4628a82fcdfa913c21), which
made handling of WINBINDD_LIST_GROUPS asynchronous.

Because most all of the list_groups code was reusable, I abstracted it,
and implemented both list_groups and list_users on top of it.

On my large test domain a "wbinfo -u" call went from 70 seconds to 30
seconds with this patch.  Plus, the parent process is no longer blocked
from receiving new requests during that time.

Steven Danneman | Software Development Engineer
Isilon Systems    P +1-206-315-7500     F +1-206-315-7501
www.isilon.com
2008-06-26 14:02:39 -07:00
Jeremy Allison
384052f546 Fix return of uninitialized variable.
Jeremy.
2008-06-26 13:19:40 -07:00
Günther Deschner
cbff970fac libnet_dssync: pass down drsuapi_DsReplicaOIDMapping_Ctr to callback.
Guenther
2008-06-26 18:36:35 +02:00
Günther Deschner
6eedd167e7 libnet_dssync: always decrypt attributes before passing them to the processing routine.
Guenther
2008-06-26 18:35:54 +02:00