1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Commit Graph

54020 Commits

Author SHA1 Message Date
Günther Deschner
381f88f081 s3-examples: fix usage for eventlog example script.
Guenther
2009-06-08 19:56:50 +02:00
Günther Deschner
6f4044cae9 s3-samr: fix enum_acb_mask type (uint32 instead of uint16).
Guenther
2009-06-08 19:47:43 +02:00
Günther Deschner
2c84de40b3 s3-rpcclient: allow to set query size for samr enum calls.
Guenther
2009-06-08 19:47:26 +02:00
Stefan Metzmacher
18c340b924 s3:Makefile.in: use LIBDL as make variable instead of a shell variable
metze
2009-06-08 13:20:54 +02:00
Timur I. Bakeyev
ef9773c8e7 Fix make test_pam_modules
In Samba3 there is a very handy Makefile target 'test_pam_modules'. It let
quickly veryfy, that obtained PAM module actually is loadable and doesn't
miss any dependency libs. the only problem that on FreeBSD it doesn't work
OOTB, as it unconditionally adds -ldl to the list of libraries when FreeBSD
doesn't have it and doesn't need it.

This small patch fixes the problem for FreeBSD and, I hope, still valid
for othe systems, where -ldl is required. Has to be tested there though.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-06-08 13:20:54 +02:00
Timur I. Bakeyev
a7cd66728b Small fix to SMB_LIBRARY macro
It seems, that SMB_LIBRARY macro has small bug in the logic, when showing
if shall the SHARED version of the library be build.

If the default value is given as a parameter, it reports "yes" when library
is going to be build(?).

This small patch makes report consistent.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-06-08 13:20:53 +02:00
Timur I. Bakeyev
96eaa412e6 SIGRTMIN additions
In addition to [FreeBSD 14] there is another place, where we (re)define
SIGRTMIN - in SMB_IF_RTSIGNAL_BUG macro in /source3/m4/aclocal.m4.

Here is another small patch.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-06-08 13:20:53 +02:00
Timur I. Bakeyev
ab88f9017c Set SIGRTMIN to NSIG
In the includes we define SIGRTMIN to 32 if it's not defined already. This
value could be fairly low and it's better to use NSIG(number of defined
signals) as the lower mark for the available signals.

We have similar defenition in the source3/smbd/aio.c, which can be safely
removed, as it comes from includes.h then.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-06-08 13:20:52 +02:00
Timur I. Bakeyev
16f5aedea0 Check for dmalloc at the end of the configure
Enabling dmalloc in Samba3 build leads to the wrong detection of the
strndup() function - there isn't one in FreeBSD prior to 7.2, but
dmalloc defines it, so, farther tests with -ldmalloc added wrongly
find it. the cheapest fix is to move dmalloc detection and inclusion
to the bottom of configure, so it can't affect detection of the system
capabilities.

Here is the patch.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-06-08 13:20:52 +02:00
Timur I. Bakeyev
40178dd81e Add langinfo.h to the system/locale.h
This patch for Samba4. It's not really inspired by any real need, just
for the consistency. We define replace/system/locale.h as a generic
header, that includes all locale related headers and we are using
nl_langinfo at least in Samba3. So, it would be consistent to add yet
another locale-related header to the set of locale.h headers.

Here is the patch.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-06-08 13:20:51 +02:00
Timur I. Bakeyev
11332e106c Make tunable for modulesdir
This patch is for Samba4. It adds configure tunable for modulesdir -
location, where modules should be installed. In the case, when no
FHS compliance is used and libdir is redefined, modulesdir still
points to $PREFIX/modules. In some installations it may be not desired.
I'd rather set it myself :)

So, here is the patch.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-06-08 13:20:51 +02:00
Timur I. Bakeyev
c41a12f8ba rl_event_hook detection
This patch is relevant for Samba4 source mostly. The way, how readline
compiled under FreeBSD makes it require stdio.h to get all the necessary
declarations. Without this addition rl_event_hook is not properly detected.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-06-08 13:20:51 +02:00
Günther Deschner
029e8e6314 s3-test: finally enable RPC-SAMR against samba3.
We now pass it :-)

Guenther
2009-06-08 13:06:53 +02:00
Günther Deschner
bc091e7847 s3-winbindd: workaround alias enumeration in expand_groups().
alias enumeration in NSS is not done properly done atm and needs to be fixed.

Guenther
2009-06-08 13:06:25 +02:00
Günther Deschner
9ac7e78041 s3-selftest: forward NSS_WRAPPER_WINBIND_SO_PATH env to tests.
Guenther
2009-06-08 11:03:07 +02:00
Günther Deschner
bb6cb7ea12 test: add NSS_WRAPPER_WINBIND_SO_PATH to make test.
Guenther
2009-06-08 11:02:59 +02:00
Günther Deschner
89616420d8 s3-samr: support _samr_SetGroupInfo level 2.
Guenther
2009-06-08 10:45:20 +02:00
Günther Deschner
9e4b510504 s4-smbtorture: exclude oem_information checking for s3 in RPC-SAMR.
Guenther
2009-06-08 10:45:11 +02:00
Günther Deschner
fb6e835543 s3-charcnv: always talloc_free in convert_string_talloc() error path.
Guenther
2009-06-08 10:44:50 +02:00
Günther Deschner
2775c52baa s3-charcnv: remove remaining malloc references in convert_string_talloc().
Guenther
2009-06-08 10:26:40 +02:00
Günther Deschner
7e8b3d8c06 nss_wrapper: add my copyright.
Guenther
2009-06-08 10:26:39 +02:00
Volker Lendecke
b5ac1068d1 Further fix for 6449
Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> for reporting!
2009-06-08 10:08:33 +02:00
Volker Lendecke
054ef88b03 Fix a valgrind error in "net rap user add" 2009-06-08 09:53:20 +02:00
Volker Lendecke
bb4cffbd97 Fix bug 6449
Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> for reporting!
2009-06-08 09:53:20 +02:00
Stefan Metzmacher
bccef82516 replace: add fallback define for IOV_MAX
This hopefully fixes the build on IRIX.

metze
2009-06-08 09:40:11 +02:00
Stefan Metzmacher
eff9bcc9c7 talloc: try to fix the source4 build on AIX
metze
2009-06-08 09:40:11 +02:00
Stefan Metzmacher
faabc97c9a async_sock: try fix the source4 build on FreeBSD, Solaris, SLES8
metze
2009-06-08 09:40:06 +02:00
Andrew Bartlett
9726e76028 Update WHATSNEW for an alpha8 release this week.
Please update this file with things you have worked on, if you want
them to be mentioned in the release.

Andrew Bartlett
2009-06-08 12:54:15 +10:00
Volker Lendecke
4de4c0318d Add "net sam createdomaingroup" 2009-06-07 23:14:40 +02:00
Volker Lendecke
e2611e2b12 More pdb_ads stuff 2009-06-07 23:14:40 +02:00
Volker Lendecke
bee9fda243 Add tldap_pull_uint32 2009-06-07 23:14:40 +02:00
Jeff Layton
27fcab98e7 mount.cifs: update the mount.cifs manpage
Add a new section entitled FILE AND DIRECTORY OWNERSHIP AND PERMISSIONS
that attempts to cover information about this topic. Change the uid=
and gid= options to refer to that section. Add new varlistentries for
forceuid, forcegid and dynperm.

Also update the information about how the program behaves when installed
as a setuid binary.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
2009-06-07 08:38:25 -04:00
Volker Lendecke
14a2974092 Make "net sam list" work for groups, aliases and builtins 2009-06-07 12:32:29 +02:00
Volker Lendecke
f3b227c0d2 Return full info in pdb_ads_search_users() 2009-06-07 12:32:25 +02:00
Volker Lendecke
83dee900bc Fix syntax of sending a delete request 2009-06-07 11:50:50 +02:00
Volker Lendecke
d8f331778f req_del and req_abandon are ASN1_APPLICATION_SIMPLE
Ok, ASN1_APPLICATION everywhere was too easy :-)
2009-06-07 11:50:48 +02:00
Volker Lendecke
35492ada90 Fix after making tldap independent of ldap.h 2009-06-07 11:29:44 +02:00
Günther Deschner
f5e9e1954c s3-groupdb: fix enum_aliasmem in ldb branch.
It is totally valid to have an alias with no members.

Tridge, please check.

Found by RPC-SAMR torture test.

Guenther
2009-06-07 11:25:21 +02:00
Günther Deschner
fbb1e990ab s3-samr: fix return code of _samr_LookupRids when run with pdb_ldap.
when _samr_LookupRids is called with no rids, it needs to return
NT_STATUS_NONE_MAPPED (not NT_STATUS_NO_MEMORY).

Found by RPC-SAMR torture test.

Guenther
2009-06-07 02:24:21 +02:00
Günther Deschner
a783b1e4da s3-samr: SetGroupInfo level 1 should not return NT_STATUS_INVALID_INFO_CLASS.
Found by RPC-SAMR torture test.

Guenther
2009-06-07 02:24:21 +02:00
Jeff Layton
cc7b62269e mount.cifs: properly check for mount being in fstab when running setuid root (try#3)
This is the third attempt to clean up the checks when a setuid
mount.cifs is run by an unprivileged user. The main difference in this
patch from the last one is that it fixes a bug where the mount might
have failed if unnecessarily if CIFS_LEGACY_SETUID_CHECK was set.

When mount.cifs is installed setuid root and run as an unprivileged
user, it does some checks to limit how the mount is used. It checks that
the mountpoint is owned by the user doing the mount.

These checks however do not match those that /bin/mount does when it is
called by an unprivileged user. When /bin/mount is called by an
unprivileged user to do a mount, it checks that the mount in question is
in /etc/fstab, that it has the "user" option set, etc.

This means that it's currently not possible to set up user mounts the
standard way (by the admin, in /etc/fstab) and simultaneously protect
from an unprivileged user calling mount.cifs directly to mount a share
on any directory that that user owns.

Fix this by making the checks in mount.cifs match those of /bin/mount
itself. This is a necessary step to make mount.cifs safe to be installed
as a setuid binary, but not sufficient. For that, we'd need to give
mount.cifs a proper security audit.

Since some users may be depending on the legacy behavior, this patch
also adds the ability to build mount.cifs with the older behavior.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
2009-06-06 19:46:24 -04:00
Günther Deschner
93e7970647 s3-samr: fix _QueryDisplayInformation r->out.returned_size.
*r->out.returned_size needs to be 0 if nothing was enumerated.

Found by RPC-SAMR torture test.

Guenther
2009-06-07 00:56:04 +02:00
Günther Deschner
c3f1f6cac9 s3-samr: remove total_data_size variable in _samr_QueryDisplayInfo.
Guenther
2009-06-07 00:55:45 +02:00
Günther Deschner
ee059e33d5 s3-samr: let _samr_SetGroupInfo level 3 just pass with success.
Guenther
2009-06-07 00:55:16 +02:00
Günther Deschner
6544264ac1 s3-samr: _samr_EnumDomain{Users,Groups} need to return an emtpy array even for builtin domain.
Found by RPC-SAMR torture test.

Guenther
2009-06-07 00:55:06 +02:00
Günther Deschner
0845db66e0 s4-smbtorture: skip samr MultipleMember alias tests for 3 as well as we do already for s4.
Guenther
2009-06-07 00:54:57 +02:00
Günther Deschner
447fe57584 s3-samr: cosmetic fixes for _samr_QueryDisplayInfo.
use the variables of the struct samr_QueryDisplayInfo directly to make
it easier to track where variables are defined from.

Guenther
2009-06-07 00:53:28 +02:00
Slava Semushin
3f5403220f testsuite/nsswitch/get{gr,pw}ent_r.c(dump_{gr,pw}ent): fixed wrong condition.
When fopen() fails it return NULL, so condition where return value
less than zero never evaluated to truth.

Found by cppcheck.
2009-06-06 22:45:02 +02:00
Slava Semushin
497b9e460b lib/tdb/tools/tdbtorture.c: fixed memory leak.
Found by cppcheck:
[lib/tdb/tools/tdbtorture.c:326]: (error) Memory leak: pids
2009-06-06 22:33:39 +02:00
Karolin Seeger
0fee798552 s3/docs: Fix example.
The 'ldap suffix' is not added automatically to the 'ldap admin dn'.
This fixes bug #5584.
Thanks to Stefan Bauer <stefan.bauer [at] plzk.de> for reporting!

Karolin
2009-06-06 15:59:07 +02:00