Michael Adam
33d20f93dc
s4:client: fix O3 error unused result of of chdir and system
...
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
2016-05-13 00:16:16 +02:00
David Disseldorp
664dca2b44
s4/client: add FS_SECTOR_SIZE_INFORMATION query support
...
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2015-03-18 18:57:20 +01:00
Stefan Metzmacher
83bd478c9b
s4:client: fix some compiler warnings
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
2014-02-13 11:54:13 +01:00
Andreas Schneider
90cbfc96d1
Make sure to set umask() before calling mkstemp().
...
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Wed Mar 6 01:16:34 CET 2013 on sn-devel-104
2013-03-06 01:16:34 +01:00
Andreas Schneider
1e4f4f6d92
s4-client: Make sure entry is a valid string.
...
Reviewed-by: David Disseldorp <ddiss@samba.org>
2013-03-05 23:29:58 +01:00
Andreas Schneider
cf8be08968
s4-client: Don't leak memory.
...
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22 16:36:14 +01:00
Andreas Schneider
b91a20f704
s4-client: Don't leak file descriptor.
...
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22 16:36:13 +01:00
Andreas Schneider
34ad9756d7
s4-client: Don't leak resource handle.
...
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22 16:36:13 +01:00
Andreas Schneider
8631a9090b
s4-client: Check return codes in do_connect().
...
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-21 13:55:59 +01:00
Andreas Schneider
34a18865d6
s4-client: Make sure we have a valid count if we goto cleanup.
...
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-12 15:00:02 +01:00
Stefan Metzmacher
4877be53df
s4:libcli: move smbcli_transport_establish() logic into smbcli_socket_connect()
...
metze
2011-11-30 13:41:08 +01:00
Günther Deschner
2d390991bd
s4: add some missing header dependencies.
...
Guenther
2011-11-03 18:35:08 +01:00
Andrew Tridgell
be4f188128
s4-client: added close command in smbclient
...
this matches the existing open command, and also gives you error codes
on both open and close
useful for testing share mode locking
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Sep 19 23:59:28 CEST 2011 on sn-devel-104
2011-09-19 23:59:28 +02:00
Andrew Bartlett
907cdb5de7
s4-modules Remove lp_ctx from init functions that no longer need it
...
Now that we don't allow the smb.conf to change the modules dir, many
functions that simply load modules or initialise a subsytem that may
load modules no longer need an lp_ctx.
Andrew Bartlett
2011-06-06 17:37:51 +10:00
Andrew Bartlett
3892112e7b
lib/util Rename ms_fnmatch() to ms_fnmatch_protocol() to avoid dup symbol
...
This verison of the function takes a protcol as argument to determine
matching rules.
Andrew Bartlett
2011-05-06 07:51:24 +02:00
Jeremy Allison
017e0c8d95
Fix simple uses of safe_strcpy -> strlcpy. Easy ones where we just remove -1.
2011-05-04 12:12:13 -07:00
Andrew Bartlett
2742ec0e34
Remove strlower_m() and strupper_m() from source4 and common code.
...
This function is problematic because a string may expand in size when
changed into upper or lower case. This will then push characters off
the end of the string in the s3 implementation, or panic in the former
s4 implementation.
Andrew Bartlett
2011-05-03 07:37:07 +02:00
Matthias Dieter Wallnöfer
0c8cf666fc
s4:client/client.c - fix Solaris warning by a type cast
2010-12-06 11:28:58 +01:00
Günther Deschner
0ff7e0c998
samba: share readline wrappers among all buildsystems.
...
Guenther
2010-10-01 22:30:22 +02:00
Matthias Dieter Wallnöfer
07af8f2514
s4:client/client.c - fix wrong return codes in "do_connect"
...
Detected by the Solaris cc compiler.
2010-09-10 22:45:50 +02:00
Andrew Tridgell
6b266b85cf
s4-loadparm: 2nd half of lp_ to lpcfg_ conversion
...
this converts all callers that use the Samba4 loadparm lp_ calling
convention to use the lpcfg_ prefix.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-16 18:24:27 +10:00
Matthias Dieter Wallnöfer
76f804af10
s4:client/client.c - we don't need "&ctx" for talloc calls
...
Simply use "ctx".
2010-05-28 10:39:54 +02:00
Matthias Dieter Wallnöfer
3318459fdc
s4:client/client.c - fix "asprintf"s
...
Fix the result values or change them into "talloc_asprintf"s where possible
see bug #6404
2010-05-28 10:04:45 +02:00
Jelmer Vernooij
f9ca9e46ad
Finish removal of iconv_convenience in public API's.
2010-05-18 11:45:30 +02:00
Stefan Metzmacher
dea7c4f999
s4:client: make use of dcerpc_binding_handle stubs
...
metze
2010-03-12 15:25:50 +01:00
Matt Kraai
d8071e7ed7
Change uint_t to unsigned int in source4
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-02-02 07:18:18 +01:00
Andrew Tridgell
090fbdce7d
s4: ran minimal_includes.pl on source4/client
2009-10-20 16:04:59 +11:00
Matthias Dieter Wallnöfer
44df2488e3
s4: fix various warnings (not "const" related ones)
2009-10-02 15:33:48 +02:00
Sam Liddicott
9d824dc115
s4:client
...
Put was assuming that the remote name was always absolute, and not relative to
the current remote directory.
Signed-off-by: Sam Liddicott <sam@liddicott.com>
2009-08-21 16:54:49 +02:00
Slava Semushin
ef45b31886
source4/client/client.c: Possible memory leaks
...
Patch for bug #6446
cppcheck found 2 possible memory leaks:
[./source4/client/client.c:3305]: (error) Memory leak: base_directory
[./source4/client/client.c:3305]: (error) Memory leak: desthost
Patch in attach.
2009-06-18 13:49:26 +10:00
Stefan Metzmacher
07e01f8405
s4:smbclient: correct initialize smbclient_context
...
Found by valgrind.
metze
2009-01-07 06:36:23 +01:00
Stefan Metzmacher
183c379fe5
s4:lib/tevent: rename structs
...
list=""
list="$list event_context:tevent_context"
list="$list fd_event:tevent_fd"
list="$list timed_event:tevent_timer"
for s in $list; do
o=`echo $s | cut -d ':' -f1`
n=`echo $s | cut -d ':' -f2`
r=`git grep "struct $o" |cut -d ':' -f1 |sort -u`
files=`echo "$r" | grep -v source3 | grep -v nsswitch | grep -v packaging4`
for f in $files; do
cat $f | sed -e "s/struct $o/struct $n/g" > $f.tmp
mv $f.tmp $f
done
done
metze
2008-12-29 20:46:40 +01:00
Jelmer Vernooij
ff36c52d8c
Remove another use of global_loadparm.
...
Eventually, we should move some of these parameters into a separate
struct (perhaps into smb_transport_options?), to avoid the long lists of
parameters.
2008-11-02 16:07:28 +01:00
Jelmer Vernooij
3ebc574be4
Fix the build.
2008-11-02 02:30:21 +01:00
Jelmer Vernooij
57a60f0920
Move lp_*() calls a bit higher up the calls tack.
2008-11-01 22:13:47 +01:00
Jelmer Vernooij
af2940459d
Fix prototype for attrib_string().
2008-11-01 16:00:41 +01:00
Günther Deschner
7204deac82
s4-srvsvc: merge srvsvc_NetShareEnumAll from s3 idl.
...
Guenther
2008-10-31 02:44:34 +01:00
Jelmer Vernooij
0218669d62
Remove include/local.h and move defines to more appropriate places.
2008-10-24 17:53:38 +02:00
Jelmer Vernooij
8b06312f7e
Eliminate another instance of global_loadparm.
2008-10-24 13:13:27 +02:00
Jelmer Vernooij
09065795d6
Remove unused constants from local.h.
2008-10-23 18:13:25 +02:00
Jelmer Vernooij
218f482fbf
Use common strlist implementation in Samba 3 and Samba 4.
2008-10-12 00:56:56 +02:00
Jelmer Vernooij
9565999755
Fix include paths to new location of libutil.
2008-10-11 21:31:42 +02:00
Jelmer Vernooij
235b729309
Cope with API changes.
2008-09-30 03:07:08 +02:00
Simo Sorce
2daf2897d5
Use a custom init function for samba4 that sets a samba4
...
specific debug function.
By default do not debug, this is the most appropriate action for a library
as we cannot assume what stderr is use for in the main app.
The main app is responsible to set ev_debug_stderr if they so desire.
(This used to be commit e566a2f308
)
2008-06-14 13:00:53 -04:00
Andrew Tridgell
0abc2e2020
use a newer fsinfo level in smbclient, to support larger disks
...
(This used to be commit 1acc8077fb
)
2008-05-15 20:45:30 +10:00
Andrew Bartlett
9b65a7c38f
Remove unused KANJI and terminal code options.
...
Someone can re-add this with tests and an actual implementation.
Andrew Bartlett
(This used to be commit 62136febe7
)
2008-04-24 11:49:41 +01:00
Simo Sorce
4e83011f72
Remove more event_context_init() uses from function calls within deep down the code.
...
Make sure we pass around the event_context where we need it instead.
All test but a few python ones fail. Jelmer promised to fix them.
(This used to be commit 3045d39162
)
2008-04-21 18:12:33 -04:00
Jelmer Vernooij
1efbd5fbf6
Remove event context tracking from the credentials struct.
...
(This used to be commit 4d7fc946b2
)
2008-04-17 01:03:18 +02:00
Jelmer Vernooij
afe3e8172d
Install public header files again and include required prototypes.
...
(This used to be commit 47ffbbf674
)
2008-04-02 04:53:27 +02:00
Jelmer Vernooij
dcc282590b
r26654: libcli/smb_composite: Rather than specifying each of the gazillion options for SMB individually, just specify the smbcli_options struct.
...
(This used to be commit 8a97886e24
)
2008-01-03 12:33:36 -06:00