1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-05 09:18:06 +03:00
Commit Graph

19291 Commits

Author SHA1 Message Date
Gerald Carter
41a0da4cfc r14457: Add a few more special cases for RID 513 in the samr code.
Now that I know what all the requirements for this group are
I can generalize the code some more and make it cleaner.
But at least this is working with lusrmgr.msc on XP and 2k now.
(This used to be commit d2c1842978)
2007-10-10 11:15:31 -05:00
Jeremy Allison
c17e40be33 r14454: Janitor for tridge - same code exists in Samba3 and 4.
Jeremy.
-----------------------------
fixed an hmac-md5 error for keys longer than 64 (using deallocated
stack variable)
(This used to be commit f3879dd6bb)
2007-10-10 11:15:31 -05:00
Gerald Carter
14b07dccc0 r14452: Sorry. Need more coffee....
* Fix sprintf() args when createing the group search filter.
(This used to be commit 0b7549997a)
2007-10-10 11:15:31 -05:00
Gerald Carter
5133ab016e r14451: In order to get pdb_ldap searching for SID_NAME_ALIAS
groups in the ${MACHINESID} and S_1-5-32 domains correctly,
I had to add a substr search on sambaSID.

* add substr matching rule to OpenLDAP schema
  (we need to update the other schema as will since this
  is a pretty important change).  Sites will need to
  - install the new schema
  - add 'indea sambaSID   sub' to slapd.conf
  - run slapindex

* remove uses of SID_NAME_WKN_GRP in pdb_ldap.c
(This used to be commit 2c0a46d731)
2007-10-10 11:15:30 -05:00
Gerald Carter
36f622acea r14450: Fix more get_md4pw() breakage caused by missing "breaks"
in the switch statement which matched the schannel type
against the account type.
(This used to be commit 57c705ea63)
2007-10-10 11:15:30 -05:00
Gerald Carter
a199498213 r14449: fix the build (sorry everyone)
(This used to be commit e49ca3af8c)
2007-10-10 11:15:30 -05:00
Gerald Carter
0f0ad2992e r14448: * protect against NULL cli_state* pointers in cli_rpc_pipe_open()
* Fix inverted logic check for machine accounts in get_md4pw()
(This used to be commit a36529535d)
2007-10-10 11:15:30 -05:00
Günther Deschner
24961b173b r14443: rework get_md4pw() to ease debugging. The only functional change is that
we now check wheter the sec_channel_type matches the trust account type.

Guenther
(This used to be commit c35eb44937)
2007-10-10 11:15:30 -05:00
Gerald Carter
f39c02e945 r14432: Give in and grant BUILT\Administrators all privileges
(This used to be commit b617091060)
2007-10-10 11:15:30 -05:00
James Peach
d6eebce490 r14428: Call fill_share_mode_entry with NO_OPLOCK instead of 0.
(This used to be commit a39cbaa699)
2007-10-10 11:15:30 -05:00
Gerald Carter
8723178048 r14421: This does two things
* Automatically creates the BUILTIN\Users group similar to
  how BUILTIN\Administrators is done.  This code does need to
  be cleaned up considerably.  I'll continue to work on this.

* The important fix is for getusergroups() when dealing with a
  local user and nested groups.  Now I can run the following
  successfully:

    $ su - jerry -c groups
    users BUILTIN\users
(This used to be commit f54d911e68)
2007-10-10 11:15:29 -05:00
Jeremy Allison
a48baaa935 r14418: Try and fix Coverity #39 and #40 by making the
implicit function contract explicit.
Jeremy.
(This used to be commit 6de5e9ae46)
2007-10-10 11:15:29 -05:00
Jeremy Allison
fa57a318b4 r14416: Remove deadcode. Coverity #198.
Jeremy.
(This used to be commit 7fc61f5a63)
2007-10-10 11:15:29 -05:00
Jim McDonough
0e0d21dd3d r14408: More on fix for coverity #36. The previous fix would cause us to
marshall a buffer based on an unknown size.  Zero out the sec_desc
buffer to prevent this.  This is still not getting proper results for
a registry security descriptor (everything gets ACCESS DENIED), but
at least we aren't blowing out memory now...
(This used to be commit cb370cc28c)
2007-10-10 11:15:29 -05:00
Jeremy Allison
fa42d65a47 r14406: Disable this call until we can sort out how this
should be done correctly. Fix coverity #37.
Jeremy.
(This used to be commit d241f74e06)
2007-10-10 11:15:29 -05:00
Jeremy Allison
55648eb948 r14405: Fix the build when nscd_flush_cache is detected
(variable definition was missing).
Jeremy.
(This used to be commit 48594f0270)
2007-10-10 11:15:29 -05:00
Gerald Carter
0ce53f8ba5 r14403: * modifies create_local_nt_token() to create a BUILTIN\Administrators
group IFF sid_to_gid(S-1-5-32-544) fails and 'winbind nested groups = yes'

* Add a SID domain to the group mapping enumeration passdb call
  to fix the checks for local and builtin groups.  The SID can be
  NULL if you want the old semantics for internal maintenance.
  I only updated the tdb group mapping code.

* remove any group mapping from the tdb that have a
  gid of -1 for better consistency with pdb_ldap.c.
  The fixes the problem with calling add_group_map() in
  the tdb code for unmapped groups which might have had
  a record present.

* Ensure that we distinguish between groups in the
  BUILTIN and local machine domains via getgrnam()
  Other wise BUILTIN\Administrators & SERVER\Administrators
  would resolve to the same gid.

* Doesn't strip the global_sam_name() from groups in the
  local machine's domain (this is required to work with
  'winbind default domain' code)

Still todo.

* Fix fallback Administrators membership for root and domain Admins
  if nested groups = no or winbindd is not running

* issues with "su - user -c 'groups'" command

* There are a few outstanding issues with BUILTIN\Users that
  Windows apparently tends to assume.  I worked around this
  presently with a manual group mapping but I do not think
  this is a good solution.  So I'll probably add some similar
  as I did for Administrators.
(This used to be commit 612979476a)
2007-10-10 11:15:28 -05:00
Jeremy Allison
568f28284a r14399: Fix deadcode coverity bug #3.
Jeremy.
(This used to be commit 3799f18b35)
2007-10-10 11:15:28 -05:00
Jeremy Allison
85d3b74844 r14397: Fix deadcode in coverity error #1.
Jeremy.
(This used to be commit 4a4953c4d2)
2007-10-10 11:15:28 -05:00
Jeremy Allison
be2bc3147c r14395: Fix coverity bug #55. Ensure no unsigned/signed comparisons.
Jeremy.
(This used to be commit cd3ad3f1a6)
2007-10-10 11:15:28 -05:00
Jeremy Allison
a1c56e451f r14393: Fix a couple of AIX warnings.
Jeremy.
(This used to be commit 8444c997bd)
2007-10-10 11:15:28 -05:00
Günther Deschner
a8dd32649b r14392: Use KRB5_TGS_NAME.
Guenther
(This used to be commit 4cfd737cc1)
2007-10-10 11:15:28 -05:00
Jeremy Allison
e6676a9a69 r14387: Try and fix the coverity issues (#53, #54) with negative
sink by ensuring all uses of rpcstr_push are consistent
with a size_t dest size arg.
Jeremy.
(This used to be commit f65d7afe19)
2007-10-10 11:15:27 -05:00
Simo Sorce
be738dd31d r14377: Fix coverity #4 for 3_0 too
(This used to be commit aa26642ee1)
2007-10-10 11:15:27 -05:00
Günther Deschner
81e4340fd4 r14368: Remove redundant set of logon flags (now in rpc_netlogon.h).
Guenther
(This used to be commit 8d4290cb8e)
2007-10-10 11:15:27 -05:00
Volker Lendecke
5c1e6f0a9e r14367: Not that I fully understand what's going on here, but the code as it was here
was clearly buggy as Coverity showed with bug id #36.

According to samba4 idl the sec_desc_buf is [in,out,ref], so we _have_ to ship
it in the request.

Volker
(This used to be commit 075e784491)
2007-10-10 11:15:27 -05:00
Jeremy Allison
9c046e7ad9 r14365: As solaris nss includes includes.h, make sure we use
the correct malloc-macros.
Jeremy.
(This used to be commit 412dc6f5db)
2007-10-10 11:15:27 -05:00
Jeremy Allison
c1bcddd803 r14359: Try and fix Coverity #176 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
(This used to be commit a3b8bee3ff)
2007-10-10 11:15:26 -05:00
Jeremy Allison
b5c2c5cd25 r14357: Try and fix Coverity #169 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
 line, and those below, will be ignored--

M    source/smbd/posix_acls.c
(This used to be commit b8397c9f33)
2007-10-10 11:15:26 -05:00
Jeremy Allison
846c4520ce r14355: Try and fix Coverity #158 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
(This used to be commit 7ada96a1cf)
2007-10-10 11:15:26 -05:00
Jeremy Allison
d1684fa82e r14353: Fix coverity bugs #61 and #62. Remember to divide by
the size of the data table. Clean up the struct a little.
Jeremy.
(This used to be commit 338538410d)
2007-10-10 11:15:26 -05:00
Jeremy Allison
8f96b1bf0f r14351: Ensure we use the minimum of PATH_MAX and sizeof(pstring).
Fix Coverity #59.
Jeremy.
(This used to be commit d793e1550c)
2007-10-10 11:15:26 -05:00
Jeremy Allison
f6071a90c7 r14345: Fix Coverity #71. We don't currently propagate *any*
alloc error back up the stack from smbldap_set_mod()
so ensure we abort correctly.
Jeremy.
(This used to be commit 9a1e35079a)
2007-10-10 11:15:26 -05:00
Jeremy Allison
ca9be7c92b r14342: Fix coverity #68, resource leak on error path.
Jeremy.
(This used to be commit 7520a8d2a1)
2007-10-10 11:15:26 -05:00
Jeremy Allison
abafc0d887 r14340: Fix coverity #78, resource leak in error path.
Jeremy.
(This used to be commit 76c4f2c4dc)
2007-10-10 11:15:26 -05:00
Jeremy Allison
bd1e853c19 r14338: Fix coverity #55 by explicit cast.
Jeremy.
(This used to be commit 1fece52da4)
2007-10-10 11:15:25 -05:00
Jeremy Allison
ed5095a490 r14336: Try and quieten coverity #53 and #54. Make it obvious
we're using -1 as a special size_t case by casting.
Jeremy.
(This used to be commit 415530bd08)
2007-10-10 11:15:25 -05:00
Jeremy Allison
53019f5a16 r14333: Fix coverity #77, ensure we can't exit after allocation.
Jeremy.
(This used to be commit 15d78ab1fc)
2007-10-10 11:15:25 -05:00
Lars Müller
cc41fa4ad7 r14331: Add a comment on top of test_pam_modules about what we're testing.
(This used to be commit 90eb092083)
2007-10-10 11:15:25 -05:00
Günther Deschner
0be0bc1151 r14329: Fix the build on systems without libcom_err.
Guenther
(This used to be commit 44fcd3113b)
2007-10-10 11:15:25 -05:00
Lars Müller
fe9ddcace9 r14326: First catch of make test_pam_modules.
Testing pam_smbpass pam_winbind
dlopen() of "./bin/pam_smbpass.so" succeeded.
dlopen() of "./bin/pam_winbind.so" failed: ././bin/pam_winbind.so:
undefined symbol: secrets_fetch_domain_sid
make: *** [test_pam_modules] Error 1
(This used to be commit 4b545e0ce6)
2007-10-10 11:15:25 -05:00
Lars Müller
9b27791644 r14325: Add pam_modules rule which builds the configure(d) pam modules. This is
called as part of the all rule (again only if pam modules are requested
by configure).

Add pam_winbind rule.

Ensure proto_exists before we build the pam modules.

Add test_pam_modules rule to test if the built pam modules have any
unresolved symbols.  For test_pam_modules we use script/tests/dlopen.sh
which was written by Nalin Dahyabhai <nalin@redhat.com>.  Thanks Nalin!
RedHat and SuSE use this script to test nss and pam modules since
several years.
(This used to be commit 71b2eb55ad)
2007-10-10 11:15:25 -05:00
Günther Deschner
b97a69dce3 r14321: When we have libnscd and winbindd comes (back) online, try to flush the
nscd caches so that NSS-calls can deliver accurate information.

Guenther
(This used to be commit a32a423a0e)
2007-10-10 11:15:24 -05:00
Lars Müller
b372fd2cff r14317: Use source/bin as dir to link pam_winbind instead of source/nsswitch/
The intention is to have the resulting binaries at one place.  This is
also usefull for upcoming changes to provide a test_pammodules rule.

With these changes I even got aware of
testsuite/nsswitch/pam_winbind_syms.exp  But this only covers
pam_winbind.
(This used to be commit 9883957b74)
2007-10-10 11:15:24 -05:00
Jeremy Allison
d72bb5627c r14303: Fix coverity #223. In a loop we were forgetting to free
resources on error exit path.
Jeremy.
(This used to be commit f71aa3ab8f)
2007-10-10 11:15:24 -05:00
Jeremy Allison
ad838bf65e r14301: Fix coverity #224. In a loop we were forgetting to free
resources on error exit path.
Jeremy.
(This used to be commit f1a5e5aefe)
2007-10-10 11:15:24 -05:00
Jeremy Allison
860015db1f r14299: Fix coverity #225. In a loop we were forgetting to free
resources on error exit path.
Jeremy.
(This used to be commit 1c0b4ed0ac)
2007-10-10 11:15:24 -05:00
Volker Lendecke
659eb9b71f r14298: The other half of Coverity # 217
(This used to be commit b9fb3fc0e3)
2007-10-10 11:15:24 -05:00
Jeremy Allison
432490a4b8 r14292: Janitor for tridge (samba3 talloc is almost identical
to Samba4 talloc).
Jeremy

 - make the snprintf call in talloc portable to older solaris boxes

 - fixed an error found sing the beam analyser
(This used to be commit 1e1bae7afd)
2007-10-10 11:15:23 -05:00
Jeremy Allison
19879eba83 r14289: Fix coverity #101, resource leak on error code path.
Jeremy.
(This used to be commit d9e1d6fed0)
2007-10-10 11:15:23 -05:00