Jeremy Allison
459dc8f39c
Change access_check_samr_object -> access_check_object.
...
Make map_max_allowed_access global. Change lsa_get_generic_sd
to add Everyone:LSA_POLICY_READ|LSA_POLICY_EXECUTE, not just
LSA_POLICY_EXECUTE.
Jeremy.
2009-05-18 15:44:03 -07:00
Günther Deschner
d06051cc51
s3-lsa: let _lsa_OpenPolicy() just call _lsa_OpenPolicy2().
...
Guenther
2009-05-19 00:16:26 +02:00
Günther Deschner
9e741b34b2
s3-selftest: enable RPC-SAMR-USERS-PRIVILEGES.
...
Guenther
2009-05-18 23:36:57 +02:00
Jeremy Allison
ada1af41ea
Fix SAMR server for winbindd access. Ensure we allow
...
MAX_ACCESS to be mapped to what we're giving Everyone.
Jeremy.
2009-05-18 14:26:37 -07:00
Günther Deschner
6ab0c83570
s3-lsa: let _lsa_GetSystemAccessAccount() call into _lsa_EnumPrivsAccount().
...
Inspired by lsa server from Samba 4.
Just removing a user in SAMR does not remove a user in LSA. If you use
usermanager from windows, the "User Rights" management gui gets unaccessable as
soon as you delete a user that had privileges granted. With this fix, that
no longer existing user would properly appear as an unknown account in the GUI
(as it does while using usermanager with windows domains).
This almost makes Samba3 pass the RPC-SAMR-USERS-PRIVILEGES test.
Guenther
2009-05-18 23:08:13 +02:00
Günther Deschner
4724fef897
s3-lsa: start a very basic implementation of _lsa_DeleteObject().
...
Certainly not the full story but this gets us closer to pass the
RPC-SAMR-USERS-PRIVILEGES test.
Guenther
2009-05-18 22:58:31 +02:00
Günther Deschner
0a9049be87
s4-smbtorture: add RPC-SAMR-USERS-PRIVILEGES test.
...
This test demonstrates the independence of the lsa and samr accounts while
remove a samr users that still has privileges granted.
Guenther
2009-05-18 22:54:14 +02:00
Volker Lendecke
5fb3b8e377
Move down the become_root()/unbecome_root() calls into the VFS modules
...
The aio_fork module does not need this, as it does not communicate via signals
but with pipes. Watching a strace log with those become_root() calls in aio.c
is absolutely awful, and it does affect performance.
2009-05-18 13:38:56 +02:00
Volker Lendecke
bbbf9f13ad
Fix bug 5681: Do not limit the number of network interfaces
...
Jeremy as far as I can see there is no real technical reason to limit the
number of interfaces. If you like this patch, can you please merge it to 3.4?
If you don't please tell me :-)
Thanks,
Volker
2009-05-18 13:38:55 +02:00
Volker Lendecke
67a2e62991
In aio_fork, we have to close all fd's, we might hold a gpfs share mode
...
Keeping such an fd open prohibits another open of that same file.
2009-05-18 10:42:22 +02:00
Volker Lendecke
22085c59cb
Add "file_walk_table" to do stuff with all open files
2009-05-18 10:42:22 +02:00
Volker Lendecke
8b9c5f0483
Fix a race condition in vfs_aio_fork with gpfs share modes
2009-05-18 10:42:22 +02:00
Volker Lendecke
f140bf2e65
Fix broken pipe handling
...
Metze is right: If we have *any* error at the socket level, we just can
not continue.
Also, apply some defensive programming: With this async stuff someone else
might already have closed the socket.
2009-05-18 07:13:04 +02:00
Volker Lendecke
795b896ab0
Fix a type-punned warning
2009-05-18 07:13:04 +02:00
Bo Yang
aa70e44cd0
s3: tevent_req_poll() loops forever when pipe is broken
...
Signed-off-by: Bo Yang <boyang@samba.org>
2009-05-19 01:13:36 +08:00
Michael Adam
2722dd357c
s3:fix bug #6371 , unsuccessful net conf setparm leaves empty share
...
Wrap creation of share and setting of parameter into a transaction.
Michael
2009-05-17 22:19:24 +02:00
Volker Lendecke
834fc3786e
s3-events: Not only timed, also immediate events generate a timeout return
2009-05-17 11:45:22 +02:00
Simo Sorce
4112bb2428
Move smb_create_user() in samsync
...
It is not used anywhere else, so make it also static and remove
it from proto.h
2009-05-16 15:30:48 -04:00
Jelmer Vernooij
72b744f38e
tevent: Define TALLOC_FREE() if it's not defined yet, to allow building
...
with released versions of talloc.
2009-05-16 20:31:59 +02:00
Volker Lendecke
31a2347a0a
Fix static linking of vfs_notify_fam
2009-05-16 19:22:03 +02:00
Volker Lendecke
91aea36bbf
Fix a typo
2009-05-16 19:22:03 +02:00
Volker Lendecke
ad91ef7f96
s3-events: If immediate requests are pending, the timeout is 0
2009-05-16 19:22:03 +02:00
Volker Lendecke
ebb79e27dc
Fix the merged build -- thanks jelmer for the hint!
2009-05-16 19:22:03 +02:00
Jelmer Vernooij
5065cf70f8
tevent: Remove python module.
...
This module didn't have any functionality that we actually used yet, and
it was quite small.
Tevent is quite low level and perhaps doesn't make much sense to expose
directly as a Python module. It was also causing build problems when used with a
system-tevent. We can always back later if necessary.
2009-05-16 14:56:37 +02:00
Jelmer Vernooij
857c3f8322
tevent: Install tevent_internal.h in the standalone build.
...
This is not ideal, but at least it fixes the build of samba-gtk for now.
I've also added a warning about API guarantees at the top of the header.
2009-05-16 04:14:21 +02:00
Samuel Thibault
a0caffd446
Fix linker flags on non-Linux GNU platforms.
...
(e.g. Debian GNU/kFreeBSD)
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2009-05-16 04:05:53 +02:00
Jelmer Vernooij
6230eb94af
Update copies of config.guess and config.sub.
2009-05-16 04:03:12 +02:00
Jelmer Vernooij
06864b4469
tevent: Don't install headers, since we don't install a shared lib
...
either (from Samba).
2009-05-16 01:54:10 +02:00
Günther Deschner
dccecdf338
s3-privileges: add privilege_delete_account().
...
Guenther
2009-05-16 01:27:51 +02:00
Günther Deschner
118f343b05
s3-privileges: remove trailing whitespace from privileges codes.
...
Guenther
2009-05-16 01:27:51 +02:00
Jeremy Allison
0a8bb37fa2
Oops. Forgot to delete now unused local from the previous patch.
...
Jeremy.
2009-05-15 16:16:47 -07:00
Ole Hansen
ad7dca471a
Fix bug #6359 - smbclient -L does not list workgroup for hosts with both IPv4 and IPv6 addresses
2009-05-15 16:13:59 -07:00
Michael Adam
f5c96e54c6
s3:build: fix linking with --disable-shared-libs
...
Michael
2009-05-15 23:46:02 +02:00
Jeremy Allison
8b4e491ab0
Ensure users with SeAddUser privs get full access to
...
groups/aliases when opening.
Jeremy.
2009-05-15 14:20:00 -07:00
Jeremy Allison
5adb3b8841
Add extra abilities for a user with SeAddUsers, so they
...
can manipulate groups and aliases.
Jeremy.
2009-05-15 13:36:43 -07:00
Jeremy Allison
2b784738d7
DeleteUser doesn't need the priv checks, this is done at OpenUser time.
...
Jeremy.
2009-05-15 13:13:01 -07:00
Günther Deschner
4027fde97c
s3-samr: Fix samr access checks in _samr_RemoveMemberFromForeignDomain().
...
Guenther
2009-05-15 21:18:23 +02:00
Volker Lendecke
7d85bf2a42
Fix bug 6361: Make --rcfile work in smbget
...
Thanks to j scott <gl@arlut.utexas.edu> for reporting!
2009-05-15 21:05:31 +02:00
Jeff Layton
b0c399ce60
mount.cifs: directly include sys/stat.h in mtab.c
...
This file is mysteriously getting included when built via the makefile,
but when you try to build mtab.o by hand it fails to build. Directly
include it to remove any ambiguity.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2009-05-15 14:31:28 -04:00
Günther Deschner
d800ee5033
s3-netdomjoin-gui: allow to switch between workgroups/domains with the same name.
...
Guenther
2009-05-15 19:51:03 +02:00
Günther Deschner
8c74d31962
s3-netdomjoin-gui: cosmetic fix for empty hostnames.
...
Guenther
2009-05-15 19:51:02 +02:00
Günther Deschner
473bf41d20
s3-netdomjoin-gui: only gray out labels when not root and not connecting to
...
remote machines.
Guenther
2009-05-15 19:51:02 +02:00
Michael Adam
c085c8311d
s3:swat: hide "config backend" from swat
...
Michael
2009-05-15 18:01:40 +02:00
Michael Adam
00297b74ac
s3:param: prevent includes from being dumped in dump_*() functions.
...
This fixes bug #4271 : testparm should not print includes.
Michael
2009-05-15 17:00:22 +02:00
Michael Adam
a62e72b825
s3:build: add install-dbwrap_tool target
...
Michael
2009-05-15 17:00:22 +02:00
Michael Adam
b4131ecf81
s3:build dbwrap_tool with make everything
...
Michael
2009-05-15 17:00:21 +02:00
Jelmer Vernooij
88876ac571
errormap: Remove wbc -> NTSTATUS error map for now. It is not used.
...
This was breaking the Samba 4 installation since it added dependencies
on header files we weren't installing.
Confirmed with Kai.
2009-05-15 16:05:37 +02:00
Günther Deschner
cd421ff2fc
s3-samr: Fix samr access checks in _samr_SetUserInfo().
...
Guenther
2009-05-15 15:38:22 +02:00
Günther Deschner
7dcf5d4bcf
s3-samr: Fix samr access checks in _samr_QueryUserInfo().
...
Guenther
2009-05-15 15:38:13 +02:00
Günther Deschner
59192bf03f
s3-samr: in _samr_QueryUserInfo() make sure to not return any info in error case.
...
Guenther
2009-05-15 15:37:50 +02:00