1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-24 02:04:21 +03:00

60188 Commits

Author SHA1 Message Date
Andrew Bartlett
4ab3e220c4 Move prototype to header of common code for set_sockaddr_port 2010-03-11 11:27:47 +11:00
Andrew Bartlett
5ed18fad00 s4/rpc_server Don't segfault over replPropertyMetaData contents
The replPropertyMetaData may contain attrid values that we don't yet
have in the local schema.  We need to deal with this - it is a serious
error, but we should not segfault.

Andrew Bartlett
2010-03-11 11:27:47 +11:00
SATOH Fumiyasu
c1fb657afc vfs_netatalk: Segfault if hide files or veto files has no ".AppleDouble" 2010-03-10 16:11:26 -08:00
Günther Deschner
3fd5ac6344 s4-smbtorture: only look at DATA_BLOB pointer when einfo[0].data_length > 0.
Guenther
2010-03-11 00:09:04 +01:00
Jeremy Allison
20d85d5d54 Added regression test for bug #7234 - Symlink delete fails but incorrectly reports success.
Ensure we can delete a symlink by path.

Jeremy.
2010-03-10 14:40:20 -08:00
Günther Deschner
01801f3f94 s4-smbtorture: while testing PrinterDataEx also compare Get and Enum results.
Guenther
2010-03-10 23:10:44 +01:00
Jeremy Allison
367ddc3d1b Fix bug #7234 - Symlink delete fails but incorrectly reports success to client.
Typo called LSTAT instead of STAT in the unlink by pathname path.

Jeremy.
2010-03-10 14:08:30 -08:00
Günther Deschner
25d27ff576 Revert "s4-smbtorture: disable winreg QueryValue test for today."
This reverts commit 420e3b8553c9e721fba27dd64eb78b2c7105ce64.
2010-03-10 22:04:02 +01:00
Björn Jacke
61bf804e8f ѕ4: EDQUOT needs to be mapped to NT_STATUS_DISK_FULL 2010-03-10 21:00:47 +01:00
Matthias Dieter Wallnöfer
ec6843402c s4:libnet - change variables to "unsigned" where needed 2010-03-10 20:23:43 +01:00
Matthias Dieter Wallnöfer
af72a63cff s4:libnet_become_dc - change counter variables to "unsigned" where they count LDB objects 2010-03-10 20:22:06 +01:00
Matthias Dieter Wallnöfer
5d10676b3b s4:winreg RPC - fix up the "QueryValue" call to work against the enhanced torture test
Found out by gd's updated torture test.
2010-03-10 19:49:25 +01:00
Matthias Dieter Wallnöfer
490c0cefeb s4:registry/ldb.c - if "name" isn't set we should return WERR_INVALID_PARAM 2010-03-10 18:50:00 +01:00
Stefan Metzmacher
667e8d8fc6 nsswitch: build libnss_winbind.so with SOVERSION = 2
metze
2010-03-10 17:12:14 +01:00
Stefan Metzmacher
3d70a3f78d nsswitch: don't use socket_wrapper for winbind client code
metze
2010-03-10 17:12:13 +01:00
Stefan Metzmacher
0b4ad41973 nsswitch: build libnss_winbindd.so only for the non merged build
metze
2010-03-10 17:12:12 +01:00
Stefan Metzmacher
65e92c6ffe s4:build/m4/public.m4: add realname argument to SMB_BUILD_LIBRARY()
metze
2010-03-10 17:12:12 +01:00
Stefan Metzmacher
bb1d81bab7 s4:rpc_server/wkssvc: don't reset [out,ref] pointer to 0
r->out.total_entries = 0; should be *r->out.total_entries = 0;

Otherwise we fail to marshall the reponse or crash if we run with
log level = 10 and trigger the ndr_print functions.

All out elements are already setup and initialized by the pidl generated code.

metze
2010-03-10 17:12:11 +01:00
Stefan Metzmacher
21326d48d7 s4:rpc_server/wkssvc: remove unneeded talloc_reference()
metze
2010-03-10 17:12:10 +01:00
Stefan Metzmacher
00ce349ad1 s4:rpc_server/wkssvc: avoid ZERO_STRUCT(r->out) and use already allocated [out,ref] memory
metze
2010-03-10 17:12:10 +01:00
Stefan Metzmacher
11a402afa8 s4:rpc_server/srvsvc: remove unused ZERO_STRUCT(r->out);
Here it doesn't matter, but it's a bad example for other code
as it might reset the [out,ref] pointers which are already
generated by the pidl generated code.

metze
2010-03-10 17:12:09 +01:00
Kamen Mazdrashki
7db0109bfe idl: Regenerate DRSUAPI idl files
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:08 +01:00
Kamen Mazdrashki
6853f452b4 s4/idl: drsuapi_QuerySitesByCostCtr1 'unknown' member is now known
and this it is a reserved fields for future flags - 'flags_reserver'
Must be 0 and is currently ignored.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:08 +01:00
Kamen Mazdrashki
14fd25ae82 s4/idl: QuerySitesByCost - switch types should be unsigned
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:07 +01:00
Kamen Mazdrashki
e76d6e9454 s4/idl: DsGetMemberships2 - switch types should be unsigned
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:06 +01:00
Kamen Mazdrashki
6321b26361 s4/drs: DsRemoveDSServer - Propagating IDL changes to source code
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:06 +01:00
Kamen Mazdrashki
1ad805e04f s4/idl: DsRemoveDSServer - switch types should be unsigned
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:05 +01:00
Kamen Mazdrashki
28cb274220 s4/drs: DsWriteAccountSpn - Propagating IDL changes to source code
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:04 +01:00
Kamen Mazdrashki
d07883ed86 s4/idl: DsWriteAccountSpn - switch types should be unsigned
Changes also propagated into source code as they are
too minor to be done in separate commit

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:03 +01:00
Kamen Mazdrashki
88494b2b62 s3/drs: DsCrackNames - Propagating IDL changes to source code
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:03 +01:00
Kamen Mazdrashki
2483ed362b s4/drs: DsCrackNames - Propagating IDL changes to source code
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:02 +01:00
Kamen Mazdrashki
d22eaddf95 s4/idl: DsCrackNames - switch types should be unsigned
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:02 +01:00
Kamen Mazdrashki
00135d83f4 s4/idl: DsGetMemberships - switch types should be unsigned
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:01 +01:00
Kamen Mazdrashki
890d408fea s4/idl: DsReplicaMod - switch types should be unsigned
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:00 +01:00
Kamen Mazdrashki
4ea818e349 s4/idl: DsReplicaDel - switch types should be unsigned
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:12:00 +01:00
Kamen Mazdrashki
9f71ffb06c s4/idl: DsReplicaAdd - switch types should be unsigned
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:11:59 +01:00
Kamen Mazdrashki
62b4b675fd s4/idl: DsReplicaUpdateRefs - switch types should be unsigned
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:11:58 +01:00
Kamen Mazdrashki
feb4c8a3e3 s3/drs: DsGetNCChanges - Propagating IDL changes to source code
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:11:57 +01:00
Kamen Mazdrashki
9f21787131 s4/drs: DsGetNCChanges - Propagating IDL changes to source code
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:11:57 +01:00
Kamen Mazdrashki
89f8c35ac4 s4/idl: DsGetNCChanges - switch types should be unsigned
Converting those types to unsigned should help in
creating DRSUAPI dissector for Wireshark also.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:11:56 +01:00
Kamen Mazdrashki
163cc1a02d s4/idl: drsuapi_DsReplicaSyncOptions flags are no more used
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:11:55 +01:00
Kamen Mazdrashki
d142d9fb64 doxygen: talloc_get_type name fixed in Doxygen documentation
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10 17:11:55 +01:00
Günther Deschner
c5ba525748 s3-winreg: add some debug statements to _winreg_QueryValue().
Guenther
2010-03-10 16:12:22 +01:00
Günther Deschner
52ca26a820 s4-smbtorture: do full winreg QueryValue test for values we created.
Guenther
2010-03-10 16:12:22 +01:00
Günther Deschner
420aac7538 s4-smbtorture: check for non existing value under version key in RPC-WINREG.
Guenther
2010-03-10 16:12:22 +01:00
Volker Lendecke
89c785c47a s3: Fix a long-standing problem with recycled PIDs
When a samba server process dies hard, it has no chance to clean up its entries
in locking.tdb, brlock.tdb, connections.tdb and sessionid.tdb.

For locking.tdb and brlock.tdb Samba is robust by checking every time we read
an entry from the database if the corresponding process still exists. If it
does not exist anymore, the entry is deleted. This is not 100% failsafe though:
On systems with a limited PID space there is a non-zero chance that between the
smbd's death and the fresh access, the PID is recycled by another long-running
process. This renders all files that had been locked by the killed smbd
potentially unusable until the new process also dies.

This patch is supposed to fix the problem the following way: Every process ID
in every database is augmented by a random 64-bit number that is stored in a
serverid.tdb. Whenever we need to check if a process still exists we know its
PID and the 64-bit number. We look up the PID in serverid.tdb and compare the
64-bit number. If it's the same, the process still is a valid smbd holding the
lock. If it is different, a new smbd has taken over.

I believe this is safe against an smbd that has died hard and the PID has been
taken over by a non-samba process. This process would not have registered
itself with a fresh 64-bit number in serverid.tdb, so the old one still exists
in serverid.tdb. We protect against this case by the parent smbd taking care of
deregistering PIDs from serverid.tdb and the fact that serverid.tdb is
CLEAR_IF_FIRST.

CLEAR_IF_FIRST does not work in a cluster, so the automatic cleanup does not
work when all smbds are restarted. For this, "net serverid wipe" has to be run
before smbd starts up. As a convenience, "net serverid wipedbs" also cleans up
sessionid.tdb and connections.tdb.

While there, this also cleans up overloading connections.tdb with all the
process entries just for messaging_send_all().

Volker
2010-03-10 16:07:10 +01:00
Volker Lendecke
184afeb57d s3: Make TLDAP_IS_ALPHA and TLDAP_IS_ADH static functions 2010-03-10 14:37:35 +01:00
Karolin Seeger
7fdbbddf42 s3-passdb: Fix typo in debug message.
Karolin
2010-03-10 12:08:27 +01:00
Günther Deschner
eeb8c36326 s4-spoolss: remove unsed iconv handle from dcesrv_spoolss_GetPrinterData().
Guenther
2010-03-10 11:16:20 +01:00
Matthias Dieter Wallnöfer
eeb05bf746 s4:winreg RPC - don't crash when incoming data wasn't correctly specified
Also found by the WINREG torture test enhancements by gd.
2010-03-10 09:26:17 +01:00