sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code
115,265 Commits 60 Branches 1,144 Tags 452 MiB
4c46333499
Commit Graph

122 Commits

Author SHA1 Message Date
Chris Lamb
093003e061 Correct "perfom" typos. 
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
 2017-02-22 08:26:22 +01:00
Günther Deschner
de38834516 werror: replace WERR_REG_IO_FAILURE with WERR_REGISTRY_IO_FAILED in source3/registry/ 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:24 +02:00
Günther Deschner
118ba610b9 werror: replace WERR_INVALID_PARAM with WERR_INVALID_PARAMETER in source3/registry/ 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:22 +02:00
Günther Deschner
f19dcbbb58 werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/registry/ 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:18 +02:00
Günther Deschner
22a514f992 werror: replace WERR_BADFILE with WERR_FILE_NOT_FOUND in source3/registry/ 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:17 +02:00
Richard Sharpe
07d3ba435a Change the registry subsystem to use uint32_t from uint32. Also change session.h. 
Signed-off-by: Richard Sharpe <rsharpe@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr 16 00:37:28 CEST 2015 on sn-devel-104
 2015-04-16 00:37:28 +02:00
Volker Lendecke
4237138c46 registry: Don't leave dangling transactions 
When a createkey fails due to access denied, we need to do a
transaction_cancel. Otherwise the lock on the db will stay around.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
 2014-10-08 15:54:04 +02:00
Günther Deschner
53bff63383 s3-registry: fix typo in DEBUG statement. 
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-01-07 16:59:37 +01:00
Gregor Beck
f7564cae4c s3:registry accept windows like long hivenames 
Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Christian Ambach <ambi@samba.org>

Autobuild-User(master): Christian Ambach <ambi@samba.org>
Autobuild-Date(master): Wed Mar 20 17:08:52 CET 2013 on sn-devel-104
 2013-03-20 17:08:51 +01:00
Michael Adam
5ba91fff94 s3:registry: untangle assignment from check in reg_enumkey() 
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Jul  5 17:57:16 CEST 2012 on sn-devel-104
 2012-07-05 17:57:16 +02:00
Michael Adam
e481afc0fe s3:registry: untangle assignment from check in reg_enumvalue() 2012-07-05 16:07:40 +02:00
Gregor Beck
35eccd0f53 s3:registry: silence net_deletekey_recursive 
WERR_BADFILE may not be an error for the caller because the result is the same.

Signed-off-by: Michael Adam <obnox@samba.org>
 2012-06-26 19:57:18 +02:00
Volker Lendecke
05456aca34 s3: Remove an unused variable 
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Apr 26 12:17:14 CEST 2012 on sn-devel-104
 2012-04-26 12:17:13 +02:00
Michael Adam
c333885fa1 s3:registry: replace call to reg_openkey() in reg_createkey() by accesscheck. 
Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:12 +02:00
Michael Adam
7f205bcbf2 s3:registry: remove a superfluous fill_subkey_cache() in reg_createkey() 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:12 +02:00
Michael Adam
4b7817aa80 s3:registry: use fill_subkey_cache to check exsistence in regkey_open_onelevel(). 
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:12 +02:00
Michael Adam
be2cb08e40 s3:registry: let fill_subkey_cache return WERR_BADFILE when the subkey list could not be loaded 
WERR_NO_MORE_ITEMS seems inappropriate.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:12 +02:00
Michael Adam
1703e6fe09 s3:registry: convert reg_openkey() to use talloc instead of SMB_STRDUP etc 
Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:12 +02:00
Michael Adam
323ec9f9b4 s3:registry untangle an assignment from the check in regkey_open_onelevel() 
Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:12 +02:00
Michael Adam
640cecab19 s3:registry: untangle assignment from check in regkey_open_onelevel() 
Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:11 +02:00
Michael Adam
8c7047b0e7 s3:registry: wrap reg_deletekey() into a transaction 
This is wrong layering but fixes a race condition.

Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:11 +02:00
Michael Adam
32ac4f4b34 s3:registry: wrap reg_createkey() in a transaction 
This is wrong layering (calling into regdb_transaction* in the reg_api code)
but fixes a potential race. It makes the multi-step create procedure atomic.

This should completely be done in the backend.

Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:10 +02:00
Michael Adam
1af68be008 s3:registry: untangle assignments from checks in reg_createkey() 
Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:10 +02:00
Michael Adam
8d19ac7474 s3:registry: wrap reg_deletevalue() in a transaction 
This is at the wrong layer, but if fixes a race potentially causing
data corruption by concurrent access.

Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:10 +02:00
Michael Adam
97bf05871a s3:registry: untangle assignment from check in reg_deletevalue() 
Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:10 +02:00
Michael Adam
8ddc2aa0e1 s3:registry: fix race in reg_setvalue that could lead to data corruption 
(there was no lock around fetching the values and storing them)

The layering is wrong in that it uses regdb transactions in reg_api

Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:10 +02:00
Michael Adam
705ea5b8c2 s3:registry: untangle assignment from check and add a debugmessage in reg_setvalue() 
Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:10 +02:00
Michael Adam
04aa303fb1 s3:registry: don't leak the old contents when updating the value cache 
Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:31:09 +02:00
Michael Adam
6c016734aa s3:registry:reg_api: fix reg_queryvalue to not fail when values are modified while it runs 
Signed-off-by: Andreas Schneider <asn@samba.org>
 2012-04-25 14:23:05 +02:00
Michael Adam
689f42af29 s3:registry: enhance debugging of deletekey_recursive 
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Aug 15 19:34:44 CEST 2011 on sn-devel-104
 2011-08-15 19:34:44 +02:00
Gregor Beck
356ed8644c s3:registry avoid updating keys which are going to be deleted in 
reg_deletekey_recursive

this changes the complexity from O(n^2) to O(n) and reduces the time of
a 'net conf drop' with 10000 shares from 6min to 1.5s

Signed-off-by: Michael Adam <obnox@samba.org>
 2011-08-08 15:27:07 +02:00
Gregor Beck
7e3d7505dd s3:registry avoid leaking an old regsubkey_ctr on regsubkey_ctr_init 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-14 21:48:12 +02:00
Andrew Bartlett
ad0a07c531 s3-talloc Change TALLOC_ZERO_P() to talloc_zero() 
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_P isn't standard talloc.
 2011-06-09 12:40:08 +02:00
Andrew Bartlett
da662b82b8 s3-lib Replace StrnCaseCmp() with strncasecmp_m() 
strncasecmp_m() never needs to call to talloc, and via next_codepoint()
still has an ASCII fast-path bypassing iconv() calls.

Andrew Bartlett
 2011-05-18 16:12:08 +02:00
Günther Deschner
fa8471a616 s3-registry: remove some unused headers. 
Guenther
 2011-03-18 13:22:07 +01:00
Volker Lendecke
4b354e67fc s3-amend: Don't overwrite existing values 
This saves a ton of tdb transactions on smbd startup

Andreas, Günther, please check!

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Feb 15 19:11:25 CET 2011 on sn-devel-104
 2011-02-15 19:11:25 +01:00
Michael Adam
b1f800a0d1 s3:registry: in deletekey_recursive, fix return code upon error. 
correctly keep the werr from inside the transaction when the opearation
inside the transaction fails.

What is the correct behaviour if the cancel operation fails?
 2011-01-30 14:09:04 +01:00
Michael Adam
7a25d13742 s3:registry: remove unneeded TALLOC_CTX argument from reg_deletekey_recursive 2010-09-22 06:30:01 +02:00
Michael Adam
b11cc30508 s3:registry: move the reg_api prototypes to their own header. 2010-09-21 08:52:06 +02:00
Michael Adam
e4eda5f9bc s3:registry:reg_api: update (C) 2010-09-21 08:52:05 +02:00
Michael Adam
8eb487caba s3:registry: move (commented out) hilvl util functions to reg_api_util.c 2010-09-20 19:58:01 +02:00
Michael Adam
0f7e503d21 s3:registry: move higher level function reg_open_path to new module reg_api_util 
The reg_api.c code should just export functions that direclty relate to winreg
api calls.
 2010-09-20 19:58:01 +02:00
Günther Deschner
91e8f8ded2 s3-registry: move regf based reg_api calls into own file. 
Guenther
 2010-09-20 02:27:41 +02:00
Günther Deschner
323f729df0 s3-registry: add reg_querymultiplevalues to reg_api matching table. 
Guenther
 2010-09-20 02:27:41 +02:00
Andrew Bartlett
4bfc8d3b1a s3-auth Change struct nt_user_token -> struct security_token 
This common structure is defined in security.idl

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2010-09-11 18:46:05 +10:00
Günther Deschner
786198e523 s3-registry: remove unused reg_util_marshalling code. 
Guenther
 2010-07-02 10:50:21 +02:00
Günther Deschner
b381fba089 s3-registry: avoid using registry_value union. 
Just pull and push data as is.

Guenther
 2010-07-02 10:50:21 +02:00
Günther Deschner
74721bf706 s3-registry: fix malloc/talloc mismatch upon free in reg_enumvalue(). 
Guenther
 2010-07-01 01:22:11 +02:00
Günther Deschner
21869f5ed0 s3-registry: add reg_querymultiplevalues() to reg_api. 
Guenther
 2010-06-30 21:46:08 +02:00
Andreas Schneider
15bacaf3c5 s3-registry: Convert registry key delimiter from slash to backslash. 
This is needed to support keynames containing a '/' like TCP/IP. Which
is used in serveral standard paths.

Signed-off-by: Michael Adam <obnox@samba.org>
 2010-06-25 17:35:41 +02:00