1
0
mirror of https://github.com/samba-team/samba.git synced 2025-07-21 12:59:09 +03:00
Commit Graph

48 Commits

Author SHA1 Message Date
7a50f089e0 s4-libregistry: Improve NULL handling of name.
Reviewed-by: David Disseldorp <ddiss@samba.org>
2013-03-05 23:30:11 +01:00
2aca90b9a0 s4-libregistry: Make sure we don't dereference a NULL pointer.
Reviewed-by: David Disseldorp <ddiss@samba.org>
2013-03-05 23:30:01 +01:00
042372bc20 s4:lib/registry/regf.c - always generate debug messages on error cases
We need to know what is going on.

Reviewed-by: Jelmer
2011-11-03 20:10:06 +01:00
a8adadbe5b Fix issues addressed by Jelmer:
* Add a comment about why the reg_strhex_to_data_blob was added
 * Fix int which should've been a boolean

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-10-03 15:31:38 +02:00
2d4500deea Fix registry editor to be compatible with Windows 7.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-10-03 15:31:37 +02:00
90d82870b0 5 uint32_t's should be set, not 5 bytes.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-10-03 15:31:37 +02:00
b3d2345bd1 The root key should be created as a root key, not subkey.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-10-03 15:31:37 +02:00
a23aa3f5f1 Make sure that regf only writes to disk every five seconds or when flushed or destroyed
Brings speed up on a large .reg import from 17.5s to 0.95s, over 18 times faster

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-10-03 15:31:37 +02:00
7efcb3ca66 Fix file corruption (non-updated header) on new allocation.
Also fixes debug messages to use hex offsets.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-09-19 12:34:54 -07:00
d0cef92532 Fix crash when no subkeys exist. Fix writing outside of buffer error by regf backend.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-09-19 12:34:54 -07:00
05f31c3f6d s4:registry/regf.c - add some casts to suppress build warnings on Solaris 2010-06-20 22:33:02 +02:00
f9ca9e46ad Finish removal of iconv_convenience in public API's. 2010-05-18 11:45:30 +02:00
ef3490e799 s4:registry - "REGF backend" - don't ignore wrong-sized REG_DWORD/REG_DWORD_BIG_ENDIAN values 2010-04-08 15:29:40 +02:00
79fccc45bc s4:registry - "regf backend" - fix it up regarding REG_DWORD/REG_DWORD_BIG_ENDIAN_VALUES
This is needed to make it platform independently work (also on big endian
platforms as little endian).

Also add a size check before storing a DWORD.
2010-04-07 20:22:57 +02:00
dc17292f1a s4:registry - add more "W_ERROR_HAVE_NO_MEMORY" invocations (on talloc'ed stuff) 2010-03-22 22:31:05 +01:00
43170dafbc s4:registry - adaptions for "add memory contexts for delete value/key functions" 2010-03-22 22:31:00 +01:00
89ab6818e1 s4:libregistry - change counters to be "unsigned"
Also the s4 registry library has to have "unsigned" counters like the Windows
one.
2010-03-06 17:48:25 +01:00
91bf841c2e s4:registry/regf.c - specify the context when freeing the "regf" variable
Otherwise we get a "talloc_free with references" warning.
2010-02-22 22:15:03 +01:00
5ab6a8d077 s4-registry: fixed byte order assumptions
the registry tests were broken on big-endian systems
2010-02-07 18:41:59 +11:00
8067bf629c Fix unintentional free of the last value when adding a new value to a key.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-01-20 09:59:18 +13:00
45bb24e939 Fix trailing garbage in the hbin block.
This specifically fixes a problem showing extra bytes of garbage in list and
print in regshell, even though the vk.data_length has the correct size.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2009-11-15 19:26:50 +01:00
169ff6efea registry: Fix warning freeing talloc pointer with multiple parents. 2009-09-26 15:41:22 +02:00
2627c6c0c2 Fixed some uninitialised variables
I tried hard to not change the program logic. Should fix bug #6439.
2009-06-19 11:32:01 +10:00
4cb9ccd841 s4:lib/registry: fix c++ warnings
metze
2009-02-05 17:48:10 +01:00
793f1cdbd9 Changed code to use proper talloc context instead of NULL to control memory leak. 2009-01-02 20:55:20 +01:00
de58ef45ac Fixes uninitialised access as reported by valgrind. 2009-01-02 20:55:20 +01:00
23302413b3 Remove unused include param/param.h. 2008-10-24 16:37:56 +02:00
1b99d8fbb5 Use common util_file code. 2008-10-12 17:34:43 +02:00
12147fca2b Add support for security descriptors. Also patched the regf backend to support this.
Did not touch the ldb, dir and rpc backends yet.
(This used to be commit c4626f21a8)
2008-04-14 22:52:51 +02:00
ec7394e7d2 Merge hive.h into registry.h
(This used to be commit 3ca14fdf74)
2008-04-02 13:59:48 +02:00
c7dc53b851 Merge branch 'v4-0-test' into id10ts-registry
(This used to be commit f98b59021a)
2008-03-03 00:23:09 +01:00
79eea32976 registry: Implement recursive deletes for regf-backed registry.
When deleting a registry key that contains subkeys or values, Windows performs a
recursive deletion that removes any subkeys or values.  This update makes
deletes for an regf-backed registry consistent with Windows.

The regf-backed registry does not have transactional integrity when performing
multiple operations.  Therefore, if an error occurs during the recursive
deletion, the regf-backed registry may be left in an inconsistent state.
(This used to be commit b0321bad29)
2008-02-26 19:27:14 -06:00
c38c2765d1 Remove yet more uses of global_loadparm.
(This used to be commit e01c1e87c0)
2008-02-21 17:17:37 +01:00
55ad09a01b registry: Use correct return values.
(This used to be commit 98ebdbe52f)
2008-01-18 03:42:00 +01:00
85d60d2d09 registry: Improve error codes and update tests.
Rather than map the error returned by the registry to the correct error,
return the correct error in the first place.

Also deal with the fact that the right error code is now returned in a
couple of places.
(This used to be commit 1e31fcb8a0)
2008-01-18 03:41:59 +01:00
47f6bbf8cf r26689: registry: Return max_subkeynamelen, max_valnamelen and max_valbufsize in getkeyinfo().
(This used to be commit b06896d237)
2008-01-07 08:18:07 -06:00
7d5f0e0893 r26639: librpc: Pass iconv convenience on from RPC connection to NDR library, so it can be overridden by OpenChange.
(This used to be commit 2f29f80e07)
2008-01-01 16:12:15 -06:00
86dc05e99f r26638: libndr: Require explicitly specifying iconv_convenience for ndr_struct_push_blob().
(This used to be commit 61ad78ac98)
2008-01-01 16:12:11 -06:00
45015eda24 r26451: Janitorial: fix warnings in lib/registry/
This does not fix the discarded qualifier warnings in tests, as the test data
is currently passed as const. Jelmer wants to provide a test function that
passes non-const test data, thus allowing for a cleaner way to fix those
warnings.
(This used to be commit 46dfa63d4f)
2007-12-21 05:50:16 +01:00
96a200511e r26443: Remove global_loadparm instances.
(This used to be commit 8242c69623)
2007-12-21 05:50:11 +01:00
27b21a386e r26439: Require tdr_pull users to specify a smb_iconv convenience context.
(This used to be commit 76fd57be29)
2007-12-21 05:50:07 +01:00
5e00673a40 r26438: Store iconv convenience in tdr push contexts.
(This used to be commit dffef31627)
2007-12-21 05:50:07 +01:00
529763a9aa r25920: ndr: change NTSTAUS into enum ndr_err_code (samba4 callers)
lib/messaging/
lib/registry/
lib/ldb-samba/
librpc/rpc/
auth/auth_winbind.c
auth/gensec/
auth/kerberos/
dsdb/repl/
dsdb/samdb/
dsdb/schema/
torture/
cluster/ctdb/
kdc/
ntvfs/ipc/
torture/rap/
ntvfs/
utils/getntacl.c
ntptr/
smb_server/
libcli/wrepl/
wrepl_server/
libcli/cldap/
libcli/dgram/
libcli/ldap/
libcli/raw/
libcli/nbt/
libnet/
winbind/
rpc_server/

metze
(This used to be commit 6223c7fddc)
2007-12-21 05:45:02 +01:00
cc8f4eb3cd r25544: Cleanup some more indents in lib/registry.
Guenther
(This used to be commit 0d9826dc54)
2007-10-10 15:07:51 -05:00
7e297ecfa4 r25047: Fix more warnings.
(This used to be commit 69de86d2d2)
2007-10-10 15:05:49 -05:00
cd962355ab r25000: Fix some more C++ compatibility warnings.
(This used to be commit 08bb1ef643)
2007-10-10 15:05:27 -05:00
6ca1390269 r24684: Be a bit less verbose
(This used to be commit 7a7af62dc4)
2007-10-10 15:02:42 -05:00
b409d4120f r24667: Finally merge the registry improvements that Wilco Baan Hofman and I have
been working on for at least half a year now. Contains the following
improvements:

 * proper layering (finally!) for the registry library. Distinction is
   now made between 'real' backends (local, remote, wine, etc) and
   the low-level hive backends (regf, creg, ldb, ...) that are only used
   by the local registry backend
 * tests for all important hive and registry operations
 * re-enable RPC-WINREG tests (still needs more work though, as
							   some return values aren't checked yet)
 * write support for REGF files
 * dir backend now supports setting/reading values, creating keys
 * support for storing security descriptors
 * remove CREG backend as it was incomplete, didn't match the data model
   and wasn't used at all anyway
 * support for parsing ADM files as used by the policy editor (see lib/policy)
 * support for parsing PREG files (format used by .POL files)
 * new streaming interface for registry diffs (improves speed and memory usage
	for regdiff/regpatch significantly)

   ... and fixes a large number of bugs in the registry code
(This used to be commit 7a1eec6358)
2007-10-10 15:02:34 -05:00