Volker Lendecke
5006dcff4e
idmap-autorid: Slightly simplify idmap_autorid_get_domainrange
...
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:37 +01:00
Volker Lendecke
3947845041
idmap-autorid: Slightly simplify idmap_autorid_get_domainrange
...
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:37 +01:00
Volker Lendecke
6e9fb07958
idmap-autorid: Remove an unused variable
...
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:37 +01:00
Volker Lendecke
10953c60bd
idmap-autorid: Use talloc_tos() in idmap_autorid_id_to_sid
...
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
6ba85beeec
idmap-autorid: Remove an else branch
...
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
6ab0d8b998
idmap-autorid: Remove an unused variable
...
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
d1970a8da9
idmap-autorid: Remove an unused parameter
...
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
f0abb3f3f8
idmap-autorid: Use talloc_tos() in idmap_autorid_sids_to_unixids
...
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
db3f8ae2bf
idmap-autorid: Not necessary to talloc domaincfg
...
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
a94cc222bd
idmap-autorid: Not necessary to talloc domainsid
...
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
3e4879f3bd
s3: Cope with 192.168.1.1/24 in smbcontrol ip-dropped
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Mar 18 14:56:38 CET 2011 on sn-devel-104
2011-03-18 14:56:38 +01:00
Günther Deschner
4e0521300f
s3-waf: enable nss_winbind in make test for nss_wrapper.
...
Guenther
2011-03-18 13:22:07 +01:00
Günther Deschner
fa8471a616
s3-registry: remove some unused headers.
...
Guenther
2011-03-18 13:22:07 +01:00
Stefan Metzmacher
2f048e458b
s3:locking: simplify the non cluster case of brl_get_locks_readonly()
...
Pair-Programmed-With: Michael Adam <obnox@samba.org>
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Mar 18 13:00:51 CET 2011 on sn-devel-104
2011-03-18 13:00:51 +01:00
Stefan Metzmacher
e8411d6f9f
s3:locking: brl_get_locks_internal() should not expose a write lock if the caller wants read_only
...
This triggered deadlocks in the cluster case of brl_get_locks_readonly().
Pair-Programmed-With: Michael Adam <obnox@samba.org>
metze
2011-03-18 07:51:46 +01:00
Günther Deschner
de5cec48a4
s4-smbtorture: add netsessiongetinfo() test.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar 18 02:11:38 CET 2011 on sn-devel-104
2011-03-18 02:11:38 +01:00
Günther Deschner
9ef1a8cf4c
s4-smbtorture: add test for rap_NetUserDelete().
...
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
5def6f0eca
s3-net: make sure we set correct default user flags in rap_user_add().
...
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
249340c9c8
s4-smbtorture: add test for rap_NetUserAdd().
...
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
faf8becf22
s3-utils: run minimal_includes.pl over utils/*.c
...
Guenther
2011-03-18 01:24:06 +01:00
Jeremy Allison
066fecd315
The searches struct is still being used and idled in SMB2 - move it to the global
...
section until we decide if we want to idle SMB2 directory handles.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Mar 18 01:13:53 CET 2011 on sn-devel-104
2011-03-18 01:13:53 +01:00
Jeremy Allison
4c77d620e6
Fix crash bug on smbd shutdown when using FOPENDIR() found by Volker.
...
The key was allowing the dptr_idle code to be triggered. We were
closing the dirp->dir handle without updating the underlying fd
in the open fsp.
Jeremy.
2011-03-17 15:55:15 -07:00
Volker Lendecke
9bc10bde14
s3: Expose num_opens via api_RNetSessionEnum
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 17 22:05:10 CET 2011 on sn-devel-104
2011-03-17 22:05:10 +01:00
Jeremy Allison
fdb98fbdd8
Nulling out the op_mid is never the right thing to do. We depend on
...
this value when searching for specific share mode entries.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Mar 17 19:59:51 CET 2011 on sn-devel-104
2011-03-17 19:59:51 +01:00
Jeremy Allison
3d6a92a37b
Fix compiler warning in debug message.
2011-03-17 10:35:10 -07:00
Stefan Metzmacher
ef078307d9
s3:Makefile.in: make sure we rebuild bin/smbtorture4 if there where changes
...
and bin/ndrdump4...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Mar 17 16:31:45 CET 2011 on sn-devel-104
2011-03-17 16:31:45 +01:00
Simo Sorce
5d55ae0a29
lib-util: put data_blob back in the public library
...
data_blob is defined ina public header, so it needs to be exposed in the public
library.
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Thu Mar 17 15:39:08 CET 2011 on sn-devel-104
2011-03-17 15:39:08 +01:00
Günther Deschner
1413af95fc
s3-waf: add --with-pam_smbpass configure option.
...
We build pam_smbpass independent from this configure option though.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 17 14:52:33 CET 2011 on sn-devel-104
2011-03-17 14:52:33 +01:00
Günther Deschner
7bc381bdc5
s3-waf: move HAVE_LDAP_SASL_WRAPPING define to the HAVE_LDAP block.
...
Guenther
2011-03-17 14:05:48 +01:00
Sumit Bose
4562a7914d
s3:net Find uid before using it
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-17 13:57:28 +01:00
Günther Deschner
1d516f0d76
s3-username: rename static getpwnam_alloc to getpwnam_alloc_cached.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 17 00:32:40 CET 2011 on sn-devel-104
2011-03-17 00:32:40 +01:00
Günther Deschner
3aa9d3005a
s3-build: only include asn1 headers where actually needed.
...
Guenther
2011-03-16 23:46:18 +01:00
Volker Lendecke
ab37eae79c
s3: Fix Coverity ID 2231, REVERSE_INULL
...
No point in checking for !ctx after dereferencing it
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 22:51:52 CET 2011 on sn-devel-104
2011-03-16 22:51:52 +01:00
Volker Lendecke
889e03617d
s3: Fix Coverity ID 2232, REVERSE_INULL
...
No point checking for !cli after dereferencing it
2011-03-16 22:07:24 +01:00
Volker Lendecke
37870e28ab
s3: Fix Coverity ID 2233, REVERSE_INULL
...
We have dereferenced h already in dcerpc_lsa_open_policy2 in line 425
2011-03-16 22:07:24 +01:00
Volker Lendecke
dacb392db6
s3: Fix Coverity ID 2234: REVERSE_INULL
...
We have dereferenced "b" already in dcerpc_samr_Connect2 in line 521
2011-03-16 22:07:24 +01:00
Volker Lendecke
fb47b7fd67
s3: Fix Coverity ID 2140, DEADCODE
...
This routine was never executed after f0dcc90f because "netname" was always
NULL.
Jeremy, please check!
2011-03-16 22:07:24 +01:00
Volker Lendecke
dd3d6a160c
s3: Fix Coverity ID 2144, DEADCODE
...
We could never have assigned the real value in line 481.
Andreas, please check!
2011-03-16 22:07:24 +01:00
Volker Lendecke
4f46ad96f2
s3: Fix Coverity ID 2147, FORWARD_NULL
...
How could this ever have worked???
2011-03-16 22:07:24 +01:00
Volker Lendecke
2581cb7ada
s3: Fix Coverity ID 1402: PASS_BY_VALUE
...
There's no point in passing GROUP_MAP on the stack
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 21:58:08 CET 2011 on sn-devel-104
2011-03-16 21:58:08 +01:00
Volker Lendecke
a7a638c3cf
s3: Fix Coverity ID 2213, PASS_BY_VALUE
...
There's little point to pass a copy of this structure on the stack.
Günther, please check!
2011-03-16 21:14:58 +01:00
Volker Lendecke
a282455978
s3: Fix Coverity ID 1012, CHECKED_RETURN
...
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
2011-03-16 21:14:58 +01:00
Volker Lendecke
9c9ed33cb7
s3: Fix Coverity ID 1013, CHECKED_RETURN
...
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
2011-03-16 21:14:58 +01:00
Volker Lendecke
3835d77795
s3: Fix Coverity ID 1017, CHECKED_RETURN
...
Günther, please check!
2011-03-16 21:14:58 +01:00
Volker Lendecke
920b2fddc6
s3: Fix Coverity ID 1018, CHECKED_RETURN
2011-03-16 21:14:58 +01:00
Volker Lendecke
4668ac8b16
s3: Fix Coverity ID 1034, CHECKED_RETURN
...
In all other places we check the result of secrets_init.
2011-03-16 21:14:58 +01:00
Volker Lendecke
7bb76bc7c7
s3: Fix Coverity ID 2100, BAD_SIZEOF
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 18:52:18 CET 2011 on sn-devel-104
2011-03-16 18:52:18 +01:00
Volker Lendecke
df79b3ba76
s3: Fix Coverity ID 2317: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-16 18:08:51 +01:00
Volker Lendecke
329fcd4e34
s3: Fix Coverity ID 2318: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-16 18:08:51 +01:00
Volker Lendecke
d8068b5a4b
s3: Fix Coverity ID 2319: Uninitialized read
...
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-16 18:08:51 +01:00