1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-25 06:04:04 +03:00

22395 Commits

Author SHA1 Message Date
Volker Lendecke
501d97c653 r23426: Correct a comment. The default timeout is not 1min, but 30s. While
there, do some reformatting.

Jeremy, I think we should also kill the child. It might hang in
something (an fcntl lock for example) that the next child might run into
immediately again.
(This used to be commit 6729a4df4b57f638161ec55f9b1edd0bc8bb947e)
2007-10-10 12:23:15 -05:00
Jeremy Allison
9ae6e51616 r23425: Volker noticed this obvious fix for the wins server
code :-). Thanks Volker !
Jeremy.
(This used to be commit e3f33a2a503ada232aa1165e2321822584a026bd)
2007-10-10 12:23:15 -05:00
Jeremy Allison
24e05d4df2 r23424: Thanks to Jerry, we finally tracked down the :
winbindd: Exceeding 200 client connections, no idle connection found"
bug #3204. This fixes it in Jerry's testing !
Jeremy.
(This used to be commit 0c7ce6a68286fa98258828545fc869aaac19a028)
2007-10-10 12:23:15 -05:00
James Peach
0d5265e9d4 r23423: Use the correct structure types in the NT_ACL operations. It's not
clear to my why the catia module feels it's necessary to implement
these operations, but at least they're now the right type.
(This used to be commit b5be0c7403195d2bd503fb1512cb46e65587adc4)
2007-10-10 12:23:15 -05:00
Simo Sorce
c99449016b r23411: We were missing displayName and that was preventing us
from successfully deleting an entry when "account" is
the STRUCTURAL objectclass used for users and machines.
"account" is used each time the user entry is in /etc/passwd
and we have only the samba attributes in ldap, as well
as for rfc2307(bis) standard based directories.
(This used to be commit e6399f1aa1c98d2d6e700245bb95c84f7e173236)
2007-10-10 12:23:15 -05:00
Volker Lendecke
de565785f5 r23410: Merge the core of the cluster code.
I'm 100% certain I've forgotten to merge something, but the main code
should be in. It's mainly in dbwrap_ctdb.c, ctdbd_conn.c and
messages_ctdbd.c.

There should be no changes to the non-cluster case, it does survive make
test on my laptop.

It survives some very basic tests with ctdbd enables, I did not do the
full test suite for clusters yet.

Phew...

Volker
(This used to be commit 15553d6327a3aecdd2b0b94a3656d04bf4106323)
2007-10-10 12:23:14 -05:00
Volker Lendecke
b05c7b9783 r23408: Remove a bogus comment
(This used to be commit 0442e680eeacb56852e200fdf6f78e4972ecad68)
2007-10-10 12:23:14 -05:00
Simo Sorce
6250b82014 r23407: While verifying a bug I found out that for some reason
the code to add a machine was different then the one used
to add a user, the old code led to the machine SID not being
built out correctly allocationg a new RID out of the passdb
but instead by using the old algorithmic method.
This may easily end up in creating duplicated SID when the
RID counter get close to the values built by the algorithmic method.

Simo.
(This used to be commit e077142aa39ad927a16e0d04874857bbc171ce07)
2007-10-10 12:23:14 -05:00
Simo Sorce
22a7d90bfe r23406: Evn if not strictly currently necessary do check for correct
init also in idmap_nss and idmap_passdb for coherency and to
prevent errors in future if we change the init functions to
actually do something and not just return NT_STATUS_OK
(This used to be commit 86f532c1b0cf7961b8331bb212c3ed2084fda3fc)
2007-10-10 12:23:13 -05:00
Simo Sorce
6c5805aa70 r23404: Fix wrong (and missing) action on error condition in ldap reply evaluation loop
Fixes one of the segfaults in bug #4667
(This used to be commit 176e1c0b692b9509a29bbbb2b35ad821dfb0d5aa)
2007-10-10 12:23:13 -05:00
Jeremy Allison
f461e53e7a r23402: Got bitten by a talloc hierarchy. Make sure we alloc
off the pipe ctx now ->names is part of the containing
struct.
Jeremy.
(This used to be commit 02fd43490212e9ff8f784ce4d33d64566d58fd82)
2007-10-10 12:23:13 -05:00
Jeremy Allison
2e6deee020 r23400: Fix lsa crash bug #4683. The "names" enum struct
in a lookup_sidX reply isn't optional - like the
lookup_sidX query it needs to be defined in the
struct.
All this will go away with PIDL (thank goodness....).
Jerry - I think this is a showstopper to be merged
for 3.0.25b.
I'll be watching the build farm to see if anything broke.
Jeremy.
(This used to be commit 9300b92f7a51eb80fdc039d8dad23ea9ce82aa8f)
2007-10-10 12:23:13 -05:00
James Peach
bde0642ab4 r23398: Support membership of >16 groups on Darwin by making sure we opt in to the
dynamic group resolution mechanism when switching UNIX credentials.
(This used to be commit b5cb21e951550fe836b0ef5febc037af9a7f51ec)
2007-10-10 12:23:13 -05:00
James Peach
0ae0d33a3a r23396: Make VFS callbacks static. Mark operations as OPAQUE because they
do not pass through.
(This used to be commit b9d6eee5d4d0894ded88455675a470cbf04d8f45)
2007-10-10 12:23:13 -05:00
James Peach
74c74f8dcc r23393: Support BSD group semantics by making sure that the effective GID is always
passed as the first GID when calling setgroups(2).
(This used to be commit 6ebaf856c1d27f2fbfa0444a5c6c17c4331d2780)
2007-10-10 12:23:12 -05:00
Jeremy Allison
0a1f5d71e4 r23391: Second part of the patch for Apple.
Change the sequence :

gain_root();
sys_setgroups(ngroups, groups);
become_id(uid, gid);

to a function call :

set_unix_security_ctx(uid_t uid, gid_t gid, int ngroups, gid_t *groups)

James - should be safe for you to create a Darwin-specific
version of this function now.

Jeremy.
(This used to be commit 8ee982b3678be41ce8b4f4c1df428dcbf897ccbe)
2007-10-10 12:23:12 -05:00
Jeremy Allison
334c961cc5 r23390: First part of the patch to make Apple's life easier.
Doing this in two stages to make it very easy to
review. Context switching must look like :

gain_root();
sys_setgroups(ngroups, groups);
become_id(uid, gid);

Re-arrange order so these three calls are always
seen together.

Next will be to turn these into a function.

Jeremy.
(This used to be commit eb537185ee4a3f460709267c843c9303a9bb61b5)
2007-10-10 12:23:12 -05:00
Michael Adam
19dbef7ca4 r23389: Disabling ACL support on Darwin/Mac OS X for now.
Current configure check detects posix ACL support
but compile of modules/vfs_posixacl.c fails due
to missing defines in sys/acl.h:
ACL_USER, ACL_USER_OBJ, ACL_GROUP, ACL_GROUP_OBJ, ACL_OTHER,
ACL_MASK, ACL_WRITE, ACL_READ

It has to be investigated, if this can be fixed within
the posixacl vfs module or if we need a darwinacl module.

Michael
(This used to be commit f275991c2fc92cf1e140e4cf8f8bc1a7fbcbbb0c)
2007-10-10 12:23:12 -05:00
Michael Adam
e0cdcf065f r23387: 1. This unifies the POSIX ACL detection code:
Linux, FreeBSD and other (which?) ACL implementations
are now checked in the same block instead of in three
separate blocks. This was inspired by Timur Bakeyev
in Bug #4543. Since bugzilla is currently unavailable
this patch is probably slightly different from Timurs
original patch. This should finally fix Bug #4543.

2. The default of the --with-acl-support configure
option is changed to "auto" (which is actually the
same as "yes"). So configure tries to detect acl
support by default. This had been discussed with
Metze and others.

Michael
(This used to be commit 234b32c7bc18b3e450329dbee496d9f600a642ee)
2007-10-10 12:23:12 -05:00
Günther Deschner
1ea5dfae04 r23380: netr_getdcname returns WERROR not NTSTATUS.
Guenther
(This used to be commit 5e75ea7f2b568d76c8ced5f43171741532cc97c2)
2007-10-10 12:23:12 -05:00
Michael Adam
774ceeea50 r23379: Whitespace cosmetics, to reduce irritating diffs...
Michael
(This used to be commit df30f8d5c2999590aabe1e87f92fbdbafa7052aa)
2007-10-10 12:23:11 -05:00
Gerald Carter
544b376d1a r23377: Patch from Bjoern Jacke <bjoern@j3e.de> to deal
with non-GNU implementations of tr in autogen.sh
(This used to be commit ccc466c56a93906ef5dfa1079796b1a8a44b43c0)
2007-10-10 12:23:11 -05:00
Volker Lendecke
423dfd6707 r23376: More warnings
(This used to be commit a8ec53f022ff66053231818d4a60568675079ede)
2007-10-10 12:23:11 -05:00
Volker Lendecke
075a5dfdc4 r23375: Fix a 64-bit warning
(This used to be commit c592b562fa793c9fb3bd0d84074d4ffaa8f63b64)
2007-10-10 12:23:11 -05:00
Jeremy Allison
713ee9242a r23372: Remove restriction on string length for rpcclient commands.
Jeremy.
(This used to be commit a2cf87f58a0a1dbc468a78347880a2f07443b1d8)
2007-10-10 12:23:11 -05:00
Jeremy Allison
5b11268609 r23371: Fix the misleading comment I added - it really *should*
say "locks chain and returned record", not
"and returns record"
Jeremy.
(This used to be commit bf951e3d7f0310cc624abab11a7fb04c50770425)
2007-10-10 12:23:11 -05:00
Jeremy Allison
68f2b1d9f6 r23370: Traverse in tdb wasn't consistently using the
travlocks.lock_rw for lock read/write types, it
was sometimes using it (tdb_next_lock) and
sometimes explicitly using F_WRLCK instead.
Change this to consistently use travlocks.lock_rw
only.
I'm pretty sure about this fix (else I woudn't
be checking this in :-) but tridge and Volker
please review.
Jeremy.
(This used to be commit d0b64567630ec02eb437aa713847bb23a8be8a60)
2007-10-10 12:23:10 -05:00
Volker Lendecke
4a99ee0236 r23368: Make "winbind:rpc only" a full blown parameter. Thanks to Karolin for
the patch :-)
(This used to be commit 07b71a02aef15b75d281cabeb7140db1bc0bb283)
2007-10-10 12:23:10 -05:00
Andrew Tridgell
422722aad2 r23367: check the "use mmap" option for ldb too
(This used to be commit 15345bbc73b28d07c069fde33d3d4c1f21f107d3)
2007-10-10 12:23:10 -05:00
Michael Adam
c9e21d8770 r23363: Activate rep_pread and rep_pwrite in lib/replace/replace.h.
This fixes the build on a SuSE 6.1. :-)
I guess this had been merely forgotten.

But beware: The implementations of rep_pread and rep_pwrite are
not thread safe.

Michael
(This used to be commit 5f5b93149216eb57872e4291336685b96948681e)
2007-10-10 12:23:10 -05:00
Volker Lendecke
cc2b76b644 r23362: Respect "use mmap" in tdb_wrap_open(). Tridge, you might want to merge
this in your tree.
(This used to be commit c0f40eb5846f617d9c421136b0e1ea593c8d8458)
2007-10-10 12:23:10 -05:00
Jeremy Allison
86d628147c r23359: Fix bug #4537, fix from jens.nissen@gmx.net.
Jeremy.
(This used to be commit 6ea7127f8e592f989a6263e360e809dcfdf98ef0)
2007-10-10 12:23:10 -05:00
Jeremy Allison
55ac16ba74 r23358: Fix from Justin Maggard <jmaggard@infrant.com> - ensure we don't
expire a password if it's explicitly set as ACB_PWNOTREQ.
Jeremy.
(This used to be commit 2ea5a6bd334e31201aa6f93f5c51e42924d36ebd)
2007-10-10 12:23:09 -05:00
Jeremy Allison
51ea3a2d00 r23357: timespec_current() was returning the wrong ns time
(multiplying tv_sec, not tv_usec).
Jeremy.
(This used to be commit bafd3b93f9ce74d7a8e2d6b36735f0977a22882c)
2007-10-10 12:23:09 -05:00
Simo Sorce
34bc0e1883 r23356: We missed to add the 'c' character to the list of valid ones for
shell escaping.

I hate this kind of bugs more than how Jeremy hates off by ones :(

Simo.
(This used to be commit 42d846ff870f93b7eaca316f04c12104330bbca8)
2007-10-10 12:23:09 -05:00
Günther Deschner
454de808a2 r23355: Fix some more build warnings.
Guenther
(This used to be commit 23e25bba8fafb31492b517d63f0a00c5ec07d5da)
2007-10-10 12:23:09 -05:00
Günther Deschner
3e3e359d12 r23354: Fix build warning.
Guenther
(This used to be commit 4ad456e988f0b9b65890b4cf6a4f1b63ef1585b8)
2007-10-10 12:23:09 -05:00
James Peach
a3d1d85a19 r23352: Don't generate stamp-h. AFAICT it is never used.
(This used to be commit d47d1a44e74b3cd02cddf1cf2f22460987102b66)
2007-10-10 12:23:09 -05:00
Jeremy Allison
0ff54fb41d r23349: Fix from Steve Langasek <vorlon@debian.org> to
allow SIGTERM to cause nmbd to exit on awaiting
an interface to come up. Debian bug #168079
Jeremy.
(This used to be commit 9ee310f3d68426da552f084ebcffef6b8ebbf612)
2007-10-10 12:23:08 -05:00
Jeremy Allison
cff8d01a41 r23348: Fix connection reporting on SIGUSR2 (noticed by
Herb).
Jeremy.
(This used to be commit dcb617e550c98de8a4bdcb9b1f7f78ba008fc138)
2007-10-10 12:23:08 -05:00
Jeremy Allison
902daae1c7 r23347: Fix Coverity 363. Dead code elimination.
Jeremy.
(This used to be commit 4524ee2dbcd5c1c66085032de67c6d083f91cb8a)
2007-10-10 12:23:08 -05:00
Jeremy Allison
72e76cb90b r23346: Fix offline caching with XP/Vista. It was an off-by-one
in storing the access mask. I shouldn't have made this
mistake. Damn. Fixes bug #4673.
Jeremy
(This used to be commit 84801d4e83786b9de3d0875a317ca9ed8ff5b3e4)
2007-10-10 12:23:08 -05:00
Jeremy Allison
45dc5e1b92 r23345: Stop Coverity from getting confused.
Jeremy.
(This used to be commit 8e83e4267260201777c753c4e3849d65fd20ae8f)
2007-10-10 12:23:08 -05:00
Volker Lendecke
3f0f678154 r23344: Better error message
(This used to be commit 4042d2cdd2797e2f675ddeb0d288327ca55d9f5b)
2007-10-10 12:23:08 -05:00
Volker Lendecke
f96193a2cb r23343: Fix error return
(This used to be commit 0014ee44b87a4a109c897ffec5f9c38eea442571)
2007-10-10 12:23:07 -05:00
Jeremy Allison
227ba79af9 r23342: Stop Coverity from getting confused.
Jeremy.
(This used to be commit 34144c63ad0d776c0b01f6bd3ce378921f2d31cd)
2007-10-10 12:23:07 -05:00
Jeremy Allison
feb4e7fe4d r23341: pdb interfaces should be versioned. As SAMBA_3_0 and SAMBA_3_0_26
are now identical, use the same version number (16) for both.
Jeremy.
(This used to be commit f2ac311ed408e1f17f468945b34289d4c6b915cc)
2007-10-10 12:23:07 -05:00
Michael Adam
c8883bed7f r23340: Fix typo in debug ouput. Found by Karolin Seeger <ks@sernet.de>.
Michael
(This used to be commit 81c7d152b2cb8fafa3d510c3d35fb86bae1e0856)
2007-10-10 12:23:07 -05:00
Stefan Metzmacher
9bf4687932 r23337: fix a crash bug...I wonder why only HP-UX 11.00 ans 11.11 noticed
it via a SIGBUS...

I missed to remove the samba3 specifc code path to tdb_open_ex()
when I synced lib/tdb/ with samba4. The explicit cast in on tdb_open_ex()
dropped the compiler warning :-(

metze
(This used to be commit 815d2101715d6646fc15ac9f2853cf727cf7fcd8)
2007-10-10 12:23:07 -05:00
Stefan Metzmacher
9d71e20363 r23335: as not all source files include replace.h/config.h
before unistd.h we need to pass -D_FILE_OFFSET_BITS=64
together with -Dpread=pread64 -Dpwrite=pwrite64

metze
(This used to be commit 1716613cc7ab8dec739adadeadbf18937682cd5c)
2007-10-10 12:23:07 -05:00