1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-04 17:47:26 +03:00

19714 Commits

Author SHA1 Message Date
Gerald Carter
564529b91a r16079: How embarassing. :-( Broke the build.
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
(This used to be commit f3bd1c8c7de93917787e7341f759699c8399f006)
2007-10-10 11:17:20 -05:00
Gerald Carter
6b1b66904d r16078: Patch from Aleksey Fedoseev <fedoseev@ru.ibm.com> to correctly
set the type of 'acl compatibility from string to integer
after the changes in r14207.
(This used to be commit b01f289f1a788fe8f62a213b67a73a9bfee01bb1)
2007-10-10 11:17:20 -05:00
Jeremy Allison
f897e7094f r16076: Fix for machine password timeout overflow from Shlomi Yaakobovich
<Shlomi@exanet.com>.
Jeremy.
(This used to be commit 5cd234a1fff1e9d025eea6600649e56c997eafc2)
2007-10-10 11:17:19 -05:00
Volker Lendecke
efdc5b72fd r16065: Re-add a strlower_m(account) in samr_create_user that was dropped for no
reason but to increase fidelity with W2k3. Tom Bork has raised valid concerns
that Unix scripts might rely on the account names being lower-case, so keep
that. We might later decide to only lower-case the unix name passed to
'add [user|group] script' but keep the passdb entry upper-case. But there are
enough user-visible changes in 3_0 already so that we should push this off to
a later date.

Tom, waiting for more bug reports from you ;-))

Thanks for insisting!

Volker
(This used to be commit bc78cca290559c5ca7623b9f6d9933e32668b9c4)
2007-10-10 11:17:19 -05:00
Volker Lendecke
40dc4e2d1a r16064: Bug fix for another one Tom Bork has reported:
'valid users = +unixgroup' failed with smbpasswd if 'unixgroup' has a
(non-algorithmic) group mapping.

Thanks a lot!

People out there listening, please test current code, this release is

	   **BIG**

:-)

Volker
(This used to be commit 8f9ba5f96c9b506623ef97b7ed3d84f39d914a3c)
2007-10-10 11:17:19 -05:00
Volker Lendecke
c594a5519d r16060: This is one of the more dirty patches I've put in lately. Parse enough of
SetUserInfo level 25 to survive the join method XP uses if the user did not
exist before. For good taste this contains way too much cut&paste, but for a
real fix there is just not enough time.

Up to 3.0.22 we completely ignored that a full level 21 is being sent together
with level 25, but we got away with that because on creation we did not set
the "disabled" flag on the workstation account. Now we correctly follow W2k3
in this regard, and we end up with a disabled workstation after join.

Man, I hate rpc_parse/. The correct fix would be to import PIDL generated samr
parsing, but this is would probably be a bit too much for .23...

Thanks to Tom Bork for finding this one.

Volker
(This used to be commit 5a37aba10551456042266443cc0a92f28f8c3d0d)
2007-10-10 11:17:18 -05:00
James Peach
777c22b300 r16057: Coalesce the DMAPI configure tests into a single macro. Add
a more specific probe to try and eliminate old, incompatible
DMAPI implementations provided by IRIX 6.4 and AIX 4.3.
(This used to be commit aafd4db457ce8a60c628d54a3ace3b97c8885dca)
2007-10-10 11:17:18 -05:00
Jeremy Allison
656d8c30db r16054: Janitor for Volker ? Volker - some reason you didn't
fix this in 3.0 ?
Jeremy.

We had no way to return NT_STATUS_OK from the netlogon serverpwset,
although
we successfully set the machine password...

One thing the samba3 join test found.

Volker
(This used to be commit e5b7acc9b5cb6e8cf3d03c9d392fad06e0d282d9)
2007-10-10 11:17:18 -05:00
Jim McDonough
9291391885 r16047: Remove unnecessary line, as this value is set in either branch of the
'if' below.  Spotted by Aleksey Fedoseev.
(This used to be commit 00eb42791abf3e34dc42a2067f07b8549ea31abb)
2007-10-10 11:17:18 -05:00
Volker Lendecke
fbd296f2f6 r16046: Hmmm. I don't fully understand popt, but this is necessary for smbclient to
show a prompt again :-)

James, could you check that this is ok? I think this was part of your Revision
15848.

Thanks,

Volker
(This used to be commit 91534146b4718206f0e2a7f456154a0497277dfd)
2007-10-10 11:17:18 -05:00
Stefan Metzmacher
fd1b550851 r16025: make sure the samba4's smbtorture can be executed
metze
(This used to be commit bed220afb816138a3e806c5d20e812667f6994ae)
2007-10-10 11:17:18 -05:00
Jeremy Allison
863aa313c1 r16019: This should not be a level zero message - it's harmless
and can happen though misconfiguration.
Jeremy.
(This used to be commit 4b9cf399a691ba4a7392caca558d0e98b4d19104)
2007-10-10 11:17:18 -05:00
Jeremy Allison
56460288bf r16017: Add Samba4 replacement for timegm to work
on Solaris.
Jeremy.
(This used to be commit b65c6468651282879a39fa8029c190f2d1a91a28)
2007-10-10 11:17:17 -05:00
Jeremy Allison
3d4d799eee r16016: Add debug to be symetrical with reading from
cache.
Jeremy.
(This used to be commit da26565a2e85dc36b283f6b81378a706f3ae5f26)
2007-10-10 11:17:17 -05:00
Volker Lendecke
d7dbf37825 r16014: Correctly set the group RID in init_sam_from_buffer.
BIG THANKS to Tom Bork for reporting that Bug!

Volker
(This used to be commit 40339fdcced67d62e449ba6f19329d89c808e139)
2007-10-10 11:17:17 -05:00
Jeremy Allison
61d2dfcd30 r15997: Fix bug in OS/2 Warp - it doesn't set the ff_last
offset correctly when doing info level 1 directory
scans. Thanks to Guenter Kukkukk <Guenter.Kukkukk@kukkukk.com>
for reporting this problem and testing the fix.
Jeremy.
(This used to be commit 65d4dfbd6045a4e3f9eaf520c70ef29ff7ddee82)
2007-10-10 11:17:17 -05:00
Jeremy Allison
4fe9d1f897 r15995: Make smbldap obey config tests. Patch from "John E. Malmberg"
<wb8tyw@qsl.net>.
Jeremy.
(This used to be commit 93dd476a9108adde42de422e1886bbaee75b952b)
2007-10-10 11:17:17 -05:00
Stefan Metzmacher
5c9e031adb r15989: try to make timelimit.c more portable
Patch from Bjoern Jacke (Thanks!)

metze
(This used to be commit b9d1440f46f443851607300e31b123d6afa81c06)
2007-10-10 11:17:17 -05:00
Günther Deschner
22a543f5bb r15985: Adding "own-domain" switch to wbinfo which is handy from time to time.
Guenther
(This used to be commit 3c9416c2bedeec7f075e94d45d08f37ae6dd41d1)
2007-10-10 11:17:16 -05:00
Günther Deschner
a6f5c79980 r15984: Correctly handle the case when there is no configuration file for
pam_winbind.

Guenther
(This used to be commit 29758ea1c4e1b9b57d27765d539306058299fcd1)
2007-10-10 11:17:16 -05:00
Günther Deschner
9f8adde941 r15983: Honour the krb5 principal name change (of the new ads join code) in the
kerberized winbind pam_auth.

Guenther
(This used to be commit 216125fe132fa6b886b99139e38988725beb88f0)
2007-10-10 11:17:16 -05:00
Günther Deschner
bb09655e84 r15982: Fix confusing order of DEBUG statements in winbindds pam_auth.
Guenther
(This used to be commit 3f5a2e49c108bfe8f8b875af9e69d5ad3b0567ee)
2007-10-10 11:17:16 -05:00
Günther Deschner
2b7b5e9ece r15980: Correctly destroy talloc_ctx when the LDAP posix attribute query has
failed. Noticed by Bob Gautier.

Guenther
(This used to be commit 7327f94546a90df25c688dcafd42e0993133057a)
2007-10-10 11:17:16 -05:00
Günther Deschner
b283a205da r15977: Fillup the password_policy method in winbindd for winbindd_passdb. This
should make pam_winbind work again on a Samba PDC (and fix Bug #3800).

Guenther
(This used to be commit 4addabd054a2627133d3fff71234db18cf2c822c)
2007-10-10 11:17:16 -05:00
Günther Deschner
690d117b25 r15976: Set our internal domains to "online" by default in winbindd.
Guenther
(This used to be commit 2678582c6cc7fb100cb3bfd867816878461ae7b4)
2007-10-10 11:17:16 -05:00
Gerald Carter
1a850a4f37 r15975: Only call the printer publishing calls if 'security = ads'
(prevent a segv)
(This used to be commit a2ef525d9e3b4f050cb4e02fad67808d3e916373)
2007-10-10 11:17:15 -05:00
Simo Sorce
c2ff57e326 r15971: Obey the manpage description and make changesecretpw accept a password via stdin
(This used to be commit 60d4aabc3205aa80f8d49c3c2db95927c61a81a5)
2007-10-10 11:17:15 -05:00
Stefan Metzmacher
92307d5b17 r15967: enable RAW-OPLOCK in samba3 make test
metze
(This used to be commit 6d35268639a7796583f5cc7bee12cf884a207af2)
2007-10-10 11:17:15 -05:00
Simo Sorce
7e5ab96290 r15965: Pam modules install fix, thanks to Ryan Novosielski for spotting this one
(This used to be commit 8f5b198acaca5ce14ab1098d86f34df9a67619d4)
2007-10-10 11:17:15 -05:00
Jeremy Allison
73cc5f1e25 r15960: Don't double-free (ensure we always free file_fsp in
the same place on error - I missed the extra free in
delay_for_oplocks).
Jeremy.
(This used to be commit 146a2648156563b41642d42c46aff401e435a42b)
2007-10-10 11:17:15 -05:00
Jeremy Allison
b990e78866 r15959: Ooops. Use the right file_free call...
Jeremy.
(This used to be commit 1117a327bd4fb425d25ea63df782095701fb83bb)
2007-10-10 11:17:15 -05:00
Jeremy Allison
7361c7a883 r15958: Make us pass RAW-OPLOCK with kernel oplocks off.
This allows a requestor to set FORCE_OPLOCK_BREAK_TO_NONE
to ensure we don't break to level 2. Fixed a couple
of resource leaks in error paths in open_file_ntcreatex.
Jeremy.
(This used to be commit c7c9adcce7f13d01445f31b07fb28a76f0a1d6df)
2007-10-10 11:17:14 -05:00
Jeremy Allison
bef4969247 r15951: oplock_request must be an int, not a BOOL. We
were getting away with mixing types. Not cool.
Jeremy.
(This used to be commit ad3bc112a21afd3a04449ec3f604e017d753c224)
2007-10-10 11:17:14 -05:00
Jeremy Allison
41f139c0bb r15949: Patch for bug #3308 to stop us returning duplicate
mid replies on path based set-eof trans2 calls.
Needs modification for HEAD (as in head open_file_ntcreateX
properly returns NTSTATUS - I'll fix this tomorrow my
time). Secondly it still fails the Samba4 RAW-OPLOCK
smbtorture because of an interesting case. Our oplock
code always returns "break to level 2" if it can.
In this case (path-based set-eof or set-allocation size
on an exclusive oplocked file) W2K3 always sends a
break-to-none. We send the break to none (from level2)
after we've done the write for eof or allocation size.
I need to work out some way of telling our break code
to always break to none (might need to extend the message
field).
Jeremy.
(This used to be commit ad9895c654f400e242adcd4099f7cd004521ee92)
2007-10-10 11:17:14 -05:00
James Peach
0a1ca7fa3d r15943: Update misleading DEBUG statements and comments that refer to
open_file_shared.
(This used to be commit 784126edff942d1c2f79f7c9feb59980426f331e)
2007-10-10 11:17:14 -05:00
Jeremy Allison
803eed1062 r15936: Fix memory leak on error exit path. Trying to
track down #3308.
Jeremy.
(This used to be commit e39c11c91153c1ed547bc635d02769a1cdf3ecc0)
2007-10-10 11:17:14 -05:00
James Peach
5f8eb11651 r15928: When we search for clock_gettime, we might find it in librt, but librt
might pull in libpthread. This is quite bad, firstly because it can
cause oplock signals on Linux to go wonky, and secondly because merely
linking with pthreads can cause performance degradations due to implicit
locking requirements.

The solution is to only search for clock_gettime if --with-profiling-data
was specified. If we do end up searching for it, then we test whether
linking with librt pulled in libpthread, and we only allow the definition
for clock_gettime to succeed if libpthread was NOT linked in.

Problem reported by Thomas Bork and diagnosed by Volker Lendecke.
(This used to be commit 5712644fcc00939b9101b2e3143674d2cbdf1e12)
2007-10-10 11:17:13 -05:00
Volker Lendecke
4c411c9bb9 r15924: Ok, the Solaris fix broke AIX. Next try :-)
Volker
(This used to be commit 53bd3fa30ad1f8bada4a49e4c79ea7ff70188174)
2007-10-10 11:17:13 -05:00
Volker Lendecke
096061c212 r15918: Attempt to bring Solaris into make test. The Solaris shell does not like the
isolated !.

Metze, can you check this?

Thanks,

Volker
(This used to be commit c9542c64ce2a21671b8f4e30780e8a6e07ab6632)
2007-10-10 11:17:13 -05:00
Volker Lendecke
9b19549fd6 r15917: Activate RPC-AUTHCONTEXT in "make test"
(This used to be commit 17f701ab4f46502ca7a957d3e79b005a0acebdc1)
2007-10-10 11:17:13 -05:00
Volker Lendecke
263b01ecb9 r15911: Make us survive rpc-authcontext committed next
(This used to be commit c24bfdce625782637b5f4d11a5117ef795ddfc2f)
2007-10-10 11:17:13 -05:00
Volker Lendecke
c334de0435 r15910: vfs_full_audit does not need current_user
(This used to be commit 09f3c7a86f931371dc6f886edccc15d3f5437d34)
2007-10-10 11:17:13 -05:00
Volker Lendecke
8135f23112 r15909: Implement recycle:subdir_mode
(This used to be commit 4dd8694a250e4d064a790fe8f422c965ab533880)
2007-10-10 11:17:12 -05:00
Gerald Carter
883241c76b r15906: smbpasswd help text for -W option (patch from Aruna Prabakar <aruna.prabakar@hp.com>
(This used to be commit 0a81af4fef5b794fea257d9e3e11b16c3a4de12f)
2007-10-10 11:17:12 -05:00
Volker Lendecke
0e1cd9eaef r15904: This does two things:
Fix more potential segfaults when something on our way to a DC connection
fails.

We can not continue if dcip_to_name() fails. With

192.168.234.100 nt4pdc
192.168.234.100 windows#1c
192.168.234.100 windows#1b

in the lmhosts file when nt4pdc is rebooted, we do find the DC's IP address,
we can connect to TCP 139 while it is booting but anything else fails. So we
fall back to put the IP address into domain->dcname. When the DC is fully up
later on we try to do the auth2 against \\192.168.234.100 which gives
INVALID_COMPUTER_NAME. And we never get out of this loop again.

Fix this.

Jerry, maybe you can take a look.

Thanks,

Volker
(This used to be commit b1244e79068af9e287252b2dfbb8d612e717674a)
2007-10-10 11:17:12 -05:00
Jeremy Allison
865e13aea1 r15895: Ensure all new rid allocation goes through
the same function (deals with races).
Jeremy.
(This used to be commit 4962548dfe8ec2854e209217066556f339d3186e)
2007-10-10 11:17:12 -05:00
Jeremy Allison
fdb68ec206 r15890: Use correct enum type (bug #3722) from Jason Mader <jason@ncac.gwu.edu>.
Jeremy.
(This used to be commit a8eb1186a12b44178a28b013373f6f8a4356d9ec)
2007-10-10 11:17:12 -05:00
Jeremy Allison
a835b9500a r15888: Fix bug #3804 from jason@ncac.gwu.edu
Invalid comparisons.
Jeremy.
(This used to be commit 9890a31c5f4a8911b0f56eee67cfbcc46f15ee43)
2007-10-10 11:17:12 -05:00
Jeremy Allison
9f6631b469 r15887: Ensure we use sys_write so we're not interrupted.
Jeremy.
(This used to be commit c66620770d2154543a6ec99d369771b339df5463)
2007-10-10 11:17:12 -05:00
Jeremy Allison
9a38c05154 r15884: Fix bug #3803 from jason@ncac.gwu.edu - bad comparison.
Jeremy.
(This used to be commit 1d9dbe3b662ea757224ca4d8c991ae73bb92ae8d)
2007-10-10 11:17:11 -05:00