1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-05 09:18:06 +03:00
Commit Graph

2747 Commits

Author SHA1 Message Date
Günther Deschner
635b8070b6 s3-spoolss: use macros for _spoolss_EnumForms and split out level 1 enum.
Guenther
2009-03-13 09:25:20 +01:00
Günther Deschner
b2b3cfbe31 s3-spoolss: use macros for _spoolss_GetPrintProcessorDirectory.
Guenther
2009-03-13 09:25:20 +01:00
Günther Deschner
75d88f460f s3-spoolss: use macros for _spoolss_GetPrinterDriverDirectory.
Guenther
2009-03-13 09:25:19 +01:00
Günther Deschner
dfe71b05a7 s3-spoolss: use macros for _spoolss_EnumMonitors.
Guenther
2009-03-13 09:25:19 +01:00
Günther Deschner
8d6c719a4b s3-spoolss: use macros for _spoolss_EnumPrintProcDataTypes.
Guenther
2009-03-13 09:25:19 +01:00
Günther Deschner
c6e9dc11e5 s3-spoolss: use macros for _spoolss_EnumPorts.
Guenther
2009-03-13 09:25:19 +01:00
Günther Deschner
facf66b40c s3-spoolss: use macros for _spoolss_EnumPrintProcessors.
Guenther
2009-03-13 09:25:19 +01:00
Günther Deschner
84b38c8598 s3-spoolss: add macros from s4 spoolss server.
Guenther
2009-03-13 09:25:19 +01:00
Günther Deschner
4b57f6dd34 s3-spoolss: make jobname a const char * in print_job_start().
Guenther
2009-03-12 14:47:31 +01:00
Volker Lendecke
fe486d7b9f Add "queue" to writev_send
Unless higher levels queue themselves somehow, writev will *always* be queued.
So the queueing should be done at the right level.
2009-03-08 11:20:59 +01:00
Volker Lendecke
46bcb10b5a Shape up pdb_search a bit by making it a talloc ctx with a destructor 2009-03-07 17:51:21 +01:00
Günther Deschner
2561b2d2e2 s3-spoolss: use pidl for _spoolss_EnumMonitors.
Guenther
2009-03-07 00:55:38 +01:00
Günther Deschner
03f1bec6ce s3-spoolss: use pidl for _spoolss_EnumPorts.
Guenther
2009-03-07 00:55:36 +01:00
Günther Deschner
3cf22a8856 s3-spoolss: use pidl for _spoolss_EnumPrintProcDataTypes.
Guenther
2009-03-07 00:49:51 +01:00
Günther Deschner
f48ccec957 s3-spoolss: use pidl for _spoolss_EnumPrintProcessors.
Guenther
2009-03-07 00:42:58 +01:00
Günther Deschner
5ce523bbed s3-spoolss: Fix Coverity ID #891 (UNINIT).
Guenther
2009-03-06 14:58:49 +01:00
Günther Deschner
8614ce5ca7 s3-spoolss: remove old _spoolss_EnumForms.
Guenther
2009-03-06 14:32:46 +01:00
Günther Deschner
f9bf09e255 s3-spoolss: use pidl for _spoolss_EnumForms.
Guenther
2009-03-06 14:32:15 +01:00
Jeremy Allison
67d12e9c6b Get the sense of the integer wrap test the right way around. Sorry.
Jeremy.
2009-03-05 22:00:22 -08:00
Jeremy Allison
4e74d811aa Now we're allowing a lower bound for auth_len, ensure we
also check for an upper one (integer wrap).
Jeremy.
2009-03-05 21:06:48 -08:00
Volker Lendecke
2544ba6a0a Complete the fix for bug 6100
According to [MS-RPCE].pdf, section 2.2.2.11:

----
A client or a server that (during composing of a PDU) has allocated more space
for the authentication token than the security provider fills in SHOULD fill in
the rest of the allocated space with zero octets. These zero octets are still
considered to belong to the authentication token part of the PDU.<36>
----

RPC implementations are allowed to send padding bytes at the end of an auth
footer. Windows 7 makes use of this.

Thanks to Nick Meier <nmeier@microsoft.com>

Volker
2009-03-05 22:28:07 +01:00
Simo Sorce
67d41d0fc7 Make struct tevent_req opaque
Move struct tevent_req in tevent_internal, and ad getters and setters
for private data and the callback function.
This patch also renames 'private_state' into 'data'. What is held in this
pointer is in fact data and not a state like enum tevent_req_state.
Calling it 'state' is confusing.

The functions addedd are:
tevent_req_set_callback() - sets req->async.fn and req->async.private_data
tevent_req_set_print_fn() - sets req->private_print
tevent_req_callback_data() - gets req->async.private_data
tevent_req_data() - gets rea->data

This way it is much simpler to keep API/ABI compatibility in the future.
2009-03-02 11:02:09 -05:00
Tim Prouty
9b0df441e1 s3: Fix incompatible type warnings 2009-03-01 16:40:17 -08:00
Günther Deschner
670a22852c s3-spoolss: use DSPRINT flags instead of SPOOLS_DS flags.
Guenther
2009-02-27 13:33:15 +01:00
Günther Deschner
44ceff4d01 s3-spoolss: fix search_notify(). sorry...
Guenther
2009-02-26 13:19:24 +01:00
Günther Deschner
54b529a44e s3-spoolss: job status defines moved to IDL.
Guenther
2009-02-26 13:17:23 +01:00
Günther Deschner
3e25d3bb15 s3-spoolss: remove some unused defines and structs.
Guenther
2009-02-26 13:17:22 +01:00
Günther Deschner
9e54f4151c s3-spoolss: fix _spoolss_AddJob behaviour.
Guenther
2009-02-25 23:48:30 +01:00
Günther Deschner
03efdcb7cb s3-spoolss: make us pass the RPC-SPOOLSS torture test w.r.t. directory calls.
Guenther
2009-02-25 21:18:09 +01:00
Volker Lendecke
5d653f69de Replace read_pkt by read_packet in np_read 2009-02-24 20:40:47 +01:00
Volker Lendecke
70f788ba7e Use async_writev in np_write 2009-02-24 20:40:47 +01:00
Günther Deschner
00173c6ce6 s3-spoolss: merge path handling in _spoolss_PrintProcessorDirectory and
_spoolss_PrinterDriverDirectory.

Guenther
2009-02-24 11:03:28 +01:00
Jeremy Allison
2033b44c3f More warning fixes for Solaris.
Jeremy.
2009-02-23 15:44:34 -08:00
Günther Deschner
c1e76d0dd9 s3-spoolss: use pidl for _spoolss_RemoteFindFirstPrinterChangeNotifyEx.
Guenther
2009-02-23 16:17:38 +01:00
Günther Deschner
b3f6d69108 s3-spoolss: use spoolss_NotifyOption and spoolss_NotifyType instead of SPOOL_NOTIFY_OPTION and SPOOL_NOTIFY_OPTION_TYPE.
Guenther
2009-02-23 16:17:37 +01:00
Günther Deschner
2efa7cf6d9 s3-spoolss: add dup_spoolss_NotifyOption.
Guenther
2009-02-23 16:17:37 +01:00
Günther Deschner
418691c2e7 s3-spoolss: use more idl types in spoolss server.
Guenther
2009-02-23 16:17:36 +01:00
Günther Deschner
9b453f9248 s3-spoolss: fix memleak of spoolss_Notify array in _spoolss_RouterRefreshPrinterChangeNotify.
Guenther
2009-02-23 16:17:35 +01:00
Günther Deschner
9af13015b2 s3-spoolss: use rpccli_spoolss_RouterReplyPrinterEx.
Guenther
2009-02-23 16:17:35 +01:00
Günther Deschner
5116f50eb8 s3-spoolss: use pidl for _spoolss_RouterRefreshPrinterChangeNotify.
Guenther
2009-02-23 16:17:35 +01:00
Günther Deschner
6259fac904 s3-spoolss: use struct spoolss_NotifyInfo instead of SPOOL_NOTIFY_INFO.
Guenther
2009-02-23 16:17:35 +01:00
Günther Deschner
03a15f2381 s3-spoolss: use struct spoolss_Notify instead of SPOOL_NOTIFY_INFO_DATA.
Guenther
2009-02-23 16:17:34 +01:00
Günther Deschner
d3372c6a9e s3-spoolss: fix _spoolss_GetPrinterDriverDirectory and spoolss_GetPrintProcessorDirectory.
Both calls need to return NULL in the error case to avoid ndr encoding problems.
(found by smbtorture spoolss test).

Guenther
2009-02-21 21:14:20 +01:00
Günther Deschner
762b92e285 s3-eventlog: fix rpcclient and server stub for eventlog_GetLogInformation.
Guenther
2009-02-21 21:14:11 +01:00
Volker Lendecke
4aed9abbf8 Remove the static "chal" from ntlmssp.c:get_challenge() 2009-02-21 14:04:14 +01:00
Günther Deschner
669617036e s3-spoolss: fix vista fallback in _spoolss_AddPrinterDriverEx.
Martin Zielinski, if you're reading this, please have a look. Vista nicely takes
just a WERR_UNKNOWN_LEVEL here and retries with a level 6 add.

Guenther
2009-02-19 19:27:07 +01:00
Günther Deschner
0470feeb7f s3-spoolss: use pidl for _spoolss_AddPrinterDriver{Ex}.
Guenther
2009-02-19 19:26:44 +01:00
Günther Deschner
286ec6847b s3-spoolss: use pidl for _spoolss_GetPrintProcessorDirectory.
Guenther.
2009-02-19 19:21:57 +01:00
Günther Deschner
e9c42e3c21 s3-spoolss: fix _spoolss_GetPrinterDriverDirectory.
treat architecture correctly as it is a [unique] pointer, and newer
Windows versions sometimes send in an empty string.

Guenther
2009-02-19 19:20:19 +01:00
Günther Deschner
0038acb20d s3-spoolss: _spoolss_OpenPrinterEx needs to wipe out policy handle upon failure.
Guenther
2009-02-19 19:19:59 +01:00
Günther Deschner
bcb5331fa7 s3-spoolss: _spoolss_AddPrinterEx needs to wipe out policy handle upon failure.
Guenther
2009-02-19 19:19:50 +01:00
Günther Deschner
3b3ab50c05 s3-spoolss: use pidl for _spoolss_GetPrinterDriverDirectory.
Guenther
2009-02-19 02:06:57 +01:00
Günther Deschner
8dbb1d63e5 s3-spoolss: add support for "AddPort" via _spoolss_XcvData for Vista.
Guenther
2009-02-19 00:56:07 +01:00
Günther Deschner
7312342062 s3-spoolss: use pidl for _spoolss_XcvData.
Guenther
2009-02-18 16:11:01 +01:00
Günther Deschner
ce71a7c9a7 s3-spoolss: use pidl for _spoolss_ResetPrinter.
Guenther
2009-02-17 10:52:31 +01:00
Volker Lendecke
ea192f08e6 Fix an invalid typecasting
entry->num_of_strings is a uint16_t. Casting it with

(int *)&entry->num_of_strings

is wrong, because it gives add_string_to_array the illusion that the object
"num" points to is an int, which it is not.

In case we are running on a machine where "int" is 32 or 64 bits long, what
happens with that cast? "add_string_to_array" interprets the byte field that
starts where "num_of_strings" starts as an int. Under very particular
circumstances this might work in a limited number of cases: When the byte order
of an int is such that the lower order bits of the int are stored first, the
subsequent bytes which do not belong to the uint16_t anymore happen to be 0 and
the result of the increment still fits into the first 2 bytes of that int, i.e.
the result is < 65536.

The correct solution to this problem is to use the implicit type conversion
that happens when an assignment is done.

BTW, this bug is found if you compile with -O3 -Wall, it shows up as a warning:

rpc_server/srv_eventlog_lib.c:574: warning: dereferencing type-punned pointer
	will break strict-aliasing rules

Thanks,

Volker
2009-02-17 10:20:55 +01:00
Yasuma Takeda
e32f946114 Fix bug 5920
The length of the memcpy was calculated wrong, r->out.return_authenticator is
a pointer
2009-02-16 14:08:39 +01:00
Stefan Metzmacher
fe417b29bd s3:netlogon: implement _netr_LogonGetCapabilities() with NT_STATUS_NOT_IMPLEMENTED
This hopefully fixes bug #6100.

metze
2009-02-16 11:34:35 +01:00
Jeremy Allison
9a5d5cc1db Attempt to fix bug #6099. According to Microsoft
Windows 7 looks at the negotiate_flags
returned in this structure *even if the
call fails with access denied ! So in order
to allow Win7 to connect to a Samba NT style
PDC we set the flags before we know if it's
an error or not.
Jeremy.
2009-02-15 18:12:20 -08:00
Tim Prouty
add9b4afb1 s3: Fix uninitialized const char * 2009-02-13 17:56:08 -08:00
Günther Deschner
bcdf345df9 s3-spoolss: remove unused convert_printer_info.
Guenther
2009-02-14 01:42:11 +01:00
Günther Deschner
cd2af58af9 s3-spoolss: use pidl for _spoolss_SetPrinter.
Guenther
2009-02-14 01:42:07 +01:00
Günther Deschner
fbcccbc410 s3-spoolss: use pidl for _spoolss_AddPrinterEx.
Guenther
2009-02-14 01:42:01 +01:00
Günther Deschner
9992827838 s3-spoolss: add printer_info2_to_nt_printer_info2 and convert_printer_info_new.
Guenther
2009-02-14 01:42:00 +01:00
Günther Deschner
75562a1e34 s3-netlogon: some more appropriate debug messages.
Guenther
2009-02-14 01:21:20 +01:00
Jeremy Allison
49b52ec16f Parameterize in local.h the MAX_RPC_DATA_SIZE, and ensure
that "offered" read from the rpc packet in spoolss is under
that size. Tidyup from analysis from Veracode.
Jeremy.
2009-02-13 16:06:17 -08:00
Günther Deschner
99b45f71cc s3-netlogon: implement _netr_ServerAuthenticate3.
Guenther
2009-02-13 01:47:58 +01:00
Günther Deschner
a4b0c5d871 s3-spoolss: use pidl for _spoolss_SetPrinterDataEx.
Guenther
2009-02-12 22:51:29 +01:00
Günther Deschner
97f15fcd68 s3-spoolss: use pidl for _spoolss_GetPrinterDataEx.
Guenther
2009-02-12 22:51:29 +01:00
Günther Deschner
2a311b1ea7 s3-spoolss: use SPOOLSS_PRINTER_CONTROL flags defined in IDL.
Guenther
2009-02-11 22:42:01 +01:00
Günther Deschner
75faf7765b s3-spoolss: Fix uninitialised variable warning.
Guenther
2009-02-11 22:36:33 +01:00
Günther Deschner
e32b26931f s3-spoolss: fix rpc_server stub names for opnum 0x42 and 0x43.
Guenther
2009-02-11 22:35:49 +01:00
Günther Deschner
aee462893b s3-spoolss: use rpccli_spoolss_ReplyOpenPrinter.
Guenther
2009-02-10 23:57:30 +01:00
Volker Lendecke
bbb665501a Add queueing to np_write 2009-02-10 18:29:34 +01:00
Volker Lendecke
f6e9f1e7ea Add queueing to np_read_state, simulate message-type named pipes.
The problem with msg-type pipes is that we have to return short reads when a
message ends before the read request. When reading from the unix domain socket,
the message limits are lost. So we would happily return more than a message,
which confuses for example the s4 rpc client horribly. I'd expect other np rpc
clients also to blow up over this.

The real solution is to properly implement a two-byte length field per message
on the unix domain socket, but this requires more changes there. And as we
right now only serve DCE/RPC over the named pipes, this implements a hack that
looks into the fragment headers to figure out hdr.frag_len.
2009-02-10 18:29:34 +01:00
Günther Deschner
96f05fcd1c s3-spoolss: use pidl for _spoolss_OpenPrinter.
Guenther
2009-02-10 11:26:58 +01:00
Günther Deschner
3d4221a9cb s3-spoolss: remove old spoolss_OpenPrinterEx.
Guenther
2009-02-10 11:26:52 +01:00
Günther Deschner
b4bda6da5a s3-spoolss: use pidl for _spoolss_OpenPrinterEx.
Guenther
2009-02-10 11:26:45 +01:00
Günther Deschner
e4b5e67566 s3-spoolss: use pidl for _spoolss_SetJob.
Guenther
2009-02-10 11:26:33 +01:00
Günther Deschner
0a34c140cc s3-spoolss: use pidl for _spoolss_StartDocPrinter.
Guenther
2009-02-10 11:26:19 +01:00
Günther Deschner
46200a7cd4 s3-spoolss: add temporary convert_devicemode_new function.
Guenther
2009-02-10 11:24:47 +01:00
Günther Deschner
ee469585eb s3-spoolss: use SPOOLSS_JOB_CONTROL bits defined in IDL.
Guenther
2009-02-10 11:09:51 +01:00
Tim Prouty
1d65b7a742 s3 spoolss: arch needs to be set before it's passed to get_version_id.
7717ad6880 left arch unitialized.

Guenther, please check.
2009-02-09 16:12:20 -08:00
Günther Deschner
0d281b76a9 s3-spoolss: use pidl for _spoolss_ScheduleJob.
Guenther
2009-02-09 22:48:14 +01:00
Günther Deschner
cb1ada9cc0 s3-spoolss: use pidl for _spoolss_AddJob.
Guenther
2009-02-09 22:47:57 +01:00
Günther Deschner
d2b8fb99ee s3-spoolss: use rpccli_spoolss_ReplyClosePrinter.
Guenther
2009-02-09 19:10:29 +01:00
Günther Deschner
a7cf846d1e s3-spoolss: use pidl for _spoolss_AddPrintProcessor.
Guenther
2009-02-09 19:09:00 +01:00
Günther Deschner
c94c777d9c s3-spoolss: use PRINTER_ENUM_NAME and remove double enum define.
Guenther
2009-02-09 15:59:04 +01:00
Günther Deschner
41c01930a3 s3-spoolss: use pidl for _spoolss_FindClosePrinterNotify.
Guenther
2009-02-09 13:03:07 +01:00
Günther Deschner
dfa559145c s3-spoolss: remove whitespace in printing code.
Guenther
2009-02-09 12:42:42 +01:00
Volker Lendecke
5bc97e0cf2 Fix count in _srvsvc_NetDiskEnum()
Without this, remotely adding a share via MMC fails
2009-02-09 12:36:49 +01:00
Günther Deschner
160e8c7a37 s3-spoolss: use pidl for _spoolss_DeletePrinterDriverEx.
Guenther
2009-02-09 12:34:03 +01:00
Günther Deschner
7717ad6880 s3-spools: use pidl for _spoolss_DeletePrinterDriver.
Guenther
2009-02-09 12:34:02 +01:00
Günther Deschner
1c0b19fef6 s3-spoolss: use pidl for _spoolss_DeletePrinterKey.
Guenther
2009-02-09 12:34:02 +01:00
Günther Deschner
27acd87445 s3-spoolss: use pidl for _spoolss_DeletePrinterData.
Guenther
2009-02-09 12:34:02 +01:00
Günther Deschner
ce5b25aaa4 s3-spoolss: use pidl for _spoolss_DeletePrinterDataEx.
Guenther
2009-02-09 12:34:01 +01:00
Günther Deschner
3c1d2f2a3a s3-spoolss: use pidl for _spoolss_GetForm.
Guenther
2009-02-09 10:43:08 +01:00
Günther Deschner
9232a5be20 s3-spoolss: add fill_form_info_1.
Guenther
2009-02-09 10:43:01 +01:00
Günther Deschner
894d05bc41 s3-spoolss: restore delete_a_form().
Guenther
2009-02-09 10:42:46 +01:00
Günther Deschner
9ef58a9196 s3-spoolss: use pidl for _spoolss_SetForm.
Guenther
2009-02-09 10:42:33 +01:00
Günther Deschner
3a1f9411e5 s3-spoolss: use pidl for spoolss_AddForm.
Guenther
2009-02-09 10:42:12 +01:00
Kai Blin
c3b9b6c8aa async_sock: Use unix errnos instead of NTSTATUS
This also switches wb_reqtrans to use wbcErr instead of NTSTATUS as it would
be pointless to convert to errno first and to wbcErr later.
2009-02-09 08:36:08 +01:00
Volker Lendecke
3a4c8cd492 Make prs_struct->out_data.current_pdu dynamically allocated
Another 4k per open pipe
2009-02-08 13:53:50 +01:00
Volker Lendecke
32a7529243 Most RPC requests do not need a full fragment, start smaller 2009-02-08 13:53:49 +01:00
Volker Lendecke
51dc7b9d82 Make current_in_pdu in pipes_struct allocated
This makes an open pipe about 4K cheaper
2009-02-07 19:25:34 +01:00
Volker Lendecke
c975ce15eb Fix resume handle for _samr_EnumDomainGroups 2009-02-07 19:25:34 +01:00
Günther Deschner
7f35c3be69 s3-spoolss: use pidl for _spoolss_WritePrinter.
Guenther
2009-02-07 10:20:56 +01:00
Günther Deschner
2038da6897 s3-spoolss: some cosmetics in debug statements.
Guenther
2009-02-07 10:20:56 +01:00
Günther Deschner
f5a24b71b9 s3-spoolss: use pidl for _spoolss_DeleteForm.
Guenther
2009-02-07 01:52:29 +01:00
Günther Deschner
714ac784e1 s3-spoolss: use pidl for _spoolss_EndDocPrinter.
Guenther
2009-02-06 21:41:09 +01:00
Günther Deschner
3fe9b2fb4f s3-spoolss: use pidl for _spoolss_AbortPrinter.
Guenther
2009-02-06 21:40:21 +01:00
Günther Deschner
7f5ff88520 s3-spoolss: use pidl for _spoolss_EndPagePrinter.
Guenther
2009-02-06 21:39:48 +01:00
Günther Deschner
246a1a1eac w 2009-02-06 21:38:43 +01:00
Günther Deschner
cb6ef25341 s3-spoolss: use pidl for _spoolss_StartPagePrinter.
Guenther
2009-02-06 21:37:55 +01:00
Günther Deschner
f968057cd2 s3-spoolss: use pidl for _spoolss_DeletePrinter.
Guenther
2009-02-06 21:30:39 +01:00
Günther Deschner
126d444367 s3-spoolss: call the correct get_pipe_fns function in proxy_spoolss_call().
Guenther
2009-02-06 19:23:55 +01:00
Günther Deschner
46903a0f90 s3-spoolss: use pidl for _spoolss_ClosePrinter.
Guenther
2009-02-06 18:55:46 +01:00
Günther Deschner
a45107abca s3-spoolss server: add _spoolss_ server stubs.
Guenther
2009-02-06 18:54:52 +01:00
Günther Deschner
e11fa4cc33 s3-spoolss: prepare to use generated spoolss.
Guenther
2009-02-06 18:54:51 +01:00
Günther Deschner
f289851d70 s3-eventlog: fix Coverity #877.
Guenther
2009-02-05 16:36:44 +01:00
Volker Lendecke
a66828a37f Don't use recvall in the proxied np_read_send
We don't know how much we will get. Resort to a single recv syscall
2009-02-05 11:16:03 +01:00
Günther Deschner
a63d4c5ed1 s3-eventlog: remove old eventlog server.
Guenther
2009-02-04 22:51:39 +01:00
Günther Deschner
d7e2384dba s3-eventlog: remove fixup_eventlog_entry.
Guenther
2009-02-04 22:51:31 +01:00
Günther Deschner
8b126e942d s3-eventlog: remove write_eventlog_tdb.
Guenther
2009-02-04 22:51:23 +01:00
Günther Deschner
abb4faf813 s3-eventlog: remove add_record_to_resp.
Guenther
2009-02-04 22:51:15 +01:00
Günther Deschner
96fd6b5a01 s3-eventlog: remove read_package_entry.
Guenther
2009-02-04 22:51:07 +01:00
Günther Deschner
58ded409ab s3-eventlog: remove get_eventlog_record.
Guenther
2009-02-04 22:50:59 +01:00
Günther Deschner
64e3a90530 s3-eventlog: make can_write_to_eventlog static.
Guenther
2009-02-04 22:49:51 +01:00
Volker Lendecke
94d1dbbaf0 Restore correct handling of "is_data_available" for the socket transport
This fixes a valgrind error reading an uninitialized variable
2009-02-04 22:36:43 +01:00
Günther Deschner
f24eecffde s3-eventlog: add my copyright.
Guenther
2009-02-04 22:05:02 +01:00
Günther Deschner
456bd5ad08 s3-eventlog: use pidl for _eventlog_ReadEventLogW.
Guenther
2009-02-04 22:04:52 +01:00
Günther Deschner
63a992168d s3-eventlog: add evlog_push_record function.
Guenther
2009-02-04 21:12:05 +01:00
Günther Deschner
1b71fa5c59 s3-eventlog: add evlog_pull_record function.
Guenther
2009-02-04 21:11:52 +01:00
Günther Deschner
65200328ee s3-eventlog: add evlog_tdb_entry_to_evt_entry.
Guenther
2009-02-04 18:39:20 +01:00
Günther Deschner
df5e231a6f s3-eventlog: add evlog_evt_entry_to_tdb_entry.
Guenther
2009-02-04 18:39:20 +01:00
Günther Deschner
de7f0a70c8 s3-eventlogadm: use struct eventlog_Record_tdb for storing entries in tdbs.
Guenther
2009-02-04 17:47:07 +01:00
Günther Deschner
16f83ae750 s3-eventlog: add fixup_eventlog_record_tdb.
Guenther
2009-02-04 17:47:06 +01:00
Günther Deschner
dd306249f2 s3-eventlog: add evlog_push_record_tdb function.
This is almost a copy of write_eventlog_tdb() and still needs to be modified
to use tdb transactions.

Guenther
2009-02-04 17:46:55 +01:00
Günther Deschner
cf3be5ce7a s3-eventlog: add evlog_pull_record_tdb function.
Guenther
2009-02-03 16:06:57 +01:00
Günther Deschner
b94946697d s3-eventlog: pass down talloc context to parse_logentry().
Guenther
2009-02-03 15:45:09 +01:00
Günther Deschner
4976777e3b s3-eventlog: make logname in elog_open_tdb const.
Guenther
2009-02-03 15:44:20 +01:00
Günther Deschner
8fb6b18bac s3-eventlog: allow to open eventlog tdbs readonly.
Guenther
2009-02-03 15:44:06 +01:00
Dan Sledz
d96248a9b4 Add two new parameters to control how we verify kerberos tickets. Removes lp_use_kerberos_keytab parameter.
The first is "kerberos method" and replaces the "use kerberos keytab"
with an enum.  Valid options are:
secrets only - use only the secrets for ticket verification (default)
system keytab - use only the system keytab for ticket verification
dedicated keytab - use a dedicated keytab for ticket verification.
secrets and keytab - use the secrets.tdb first, then the system keytab

For existing installs:
"use kerberos keytab = yes" corresponds to secrets and keytab
"use kerberos keytab = no" corresponds to secrets only

The major difference between "system keytab" and "dedicated keytab" is
that the latter method relies on kerberos to find the correct keytab
entry instead of filtering based on expected principals.

The second parameter is "dedicated keytab file", which is the keytab
to use when in "dedicated keytab" mode.  This keytab is only used in
ads_verify_ticket.
2009-02-01 20:23:31 -08:00
Volker Lendecke
c14b7e648b Split up async_req into a generic and a NTSTATUS specific part 2009-02-01 19:05:39 +01:00
Volker Lendecke
7967d8c779 Move rpc_pipe_open_internal to srv_pipe_hnd.c
This is a smbd-only function
2009-02-01 14:34:23 +01:00
Volker Lendecke
53394980ad Replace pipe names in pipes_struct by ndr_syntax_id
This was mainly used for debugging output
2009-02-01 14:34:23 +01:00
Volker Lendecke
99f021d0ef Fix the build on Solaris CC 2009-02-01 00:07:16 +01:00
Volker Lendecke
fa7ddc78b8 Remove unused np_read sync wrapper 2009-01-31 17:50:18 +01:00
Volker Lendecke
8b480b52ce Remove unused np_write sync wrapper 2009-01-31 17:50:18 +01:00
Volker Lendecke
e8b2b46cae Make-np_write-handle-0-byte-writes-as-NT_STATUS_OK 2009-01-31 17:50:18 +01:00
Volker Lendecke
b797c056a6 Add an async np_read wrapper 2009-01-31 17:50:18 +01:00
Volker Lendecke
e60d69d67d Add an async np_write wrapper 2009-01-31 17:50:18 +01:00
Stefan Metzmacher
f6d8d94510 s3:rpc_server: use get_client_fd() instead of smbd_server_fd()
Both are absolutely the same, but smbd_server_fd() is otherwise
only used in smbd/*.c and would like to remove smbd_server_fd() soon.

metze
2009-01-27 15:28:12 +01:00
Volker Lendecke
8b80407712 Fix a segfault in parse_logentry
entry->data_record.strings is type smb_ucs2, so the pointer arithmetic
increments by two :-)
2009-01-24 15:08:21 +01:00
Günther Deschner
9629897094 s3-eventlog: add missing _eventlog_ReportEventAndSourceW stub call.
Guenther
2009-01-24 03:33:22 +01:00
Günther Deschner
5bcd6d760b Revert "s3-eventlog: trying to avoid to pass around full ndr structures in rpc_server."
This reverts commit c0f1309010.
2009-01-24 03:00:38 +01:00
Günther Deschner
dd2695fe52 s3-eventlog: fix various invalid memcpy in read_package_entry().
Guenther
2009-01-24 03:00:38 +01:00
todd stecher
989ad44d32 Memory leaks and other fixes found by Coverity 2009-01-21 17:13:03 -08:00
Volker Lendecke
520f88143b Remove some unused code 2009-01-20 16:41:32 +01:00
Volker Lendecke
b8b6cddb29 Remove some smb fsp knowledge from rpc_server/
np_open/read/write don't have to know about files_struct
2009-01-20 16:41:14 +01:00
Volker Lendecke
bd4718d281 Make use of TALLOC_FREE 2009-01-20 14:34:51 +01:00
Volker Lendecke
8b618d0ba9 Fix some real bugs found by "type-punned" gcc warnings
Type-casting does not the right thing if used the way it used to be. The
function arguments have not been uint32_t's, but the type cast made the calling
routine believe so. Not good...

The assignment xxx=account_policy_temp does however type-convert properly,
potentially cutting off the top-bits.
2009-01-18 13:26:21 +01:00
Günther Deschner
740c5ce081 s3-eventlog: fix _eventlog_CloseEventLog.
Guenther
2009-01-16 11:52:49 +01:00
Günther Deschner
0d2c0da7d2 s3-eventlog: remove whitespace.
Guenther
2009-01-16 00:28:45 +01:00
Günther Deschner
6dc18f2cab s3-eventlog: some minor code cleanup in eventlog server.
Guenther
2009-01-16 00:28:45 +01:00
Günther Deschner
990491d187 s3-eventlog: fix ps struct removal leftover.
Guenther
2009-01-14 10:53:04 +01:00
Günther Deschner
df8b724819 s3-eventlog: use main talloc context in eventlog read call.
Guenther
2009-01-14 10:18:14 +01:00
Volker Lendecke
964acde86e Remove the rpc_srv_register wrapper around rpc_pipe_register_commands 2009-01-09 23:17:57 +01:00
Volker Lendecke
2729c484fb Call rpc_srv_register instead of rpc_pipe_register_commands in eventlog and svcctl 2009-01-09 23:17:57 +01:00
Volker Lendecke
106e65a3b3 Fake up ndr_table_spoolss 2009-01-09 23:17:57 +01:00
Volker Lendecke
125696b73d Pass the full ndr_interface_table into the s3 rpcserver when registering 2009-01-09 23:17:57 +01:00
Volker Lendecke
c1a8e8adac Simplify find_pipe_fns_by_context slightly 2009-01-09 22:48:09 +01:00
Volker Lendecke
2714ac4d3a Fix some nonempty blank lines 2009-01-09 22:30:56 +01:00
Günther Deschner
22a96cbe31 s3-svcctl: remove last traces of hand-marshalled svcctl code.
Guenther
2009-01-09 17:08:19 +01:00
Günther Deschner
fa6053fe6d s3-svcctl: use pidl for _svcctl_EnumServicesStatusW.
Guenther
2009-01-09 17:08:18 +01:00
Volker Lendecke
84292022bf Now that all policy_handle free_fn's are just TALLOC_FREE, dump free_fn 2009-01-08 22:29:54 +01:00
Volker Lendecke
825500f5da Use TALLOC for struct lsa_info 2009-01-08 22:29:54 +01:00
Volker Lendecke
e94d7f53f9 Make use of a talloc_destructor for free_printer_entry 2009-01-08 22:29:54 +01:00
Volker Lendecke
baa5c5eeb0 Make use of a talloc_destructor for free_eventlog_info() 2009-01-08 22:29:53 +01:00
Volker Lendecke
52b6756c4e Make samr_info a talloc context of its own 2009-01-08 22:29:53 +01:00
Volker Lendecke
5a4f71d40c Simplify init_pipe_handle_list a bit 2009-01-08 22:29:53 +01:00
Günther Deschner
252d271fe4 s3-eventlog: minor cosmetics.
Guenther
2009-01-08 19:37:29 +01:00
Günther Deschner
c0f1309010 s3-eventlog: trying to avoid to pass around full ndr structures in rpc_server.
Jerry, please check.

Guenther
2009-01-08 19:37:29 +01:00
Günther Deschner
ca98357710 s3-svcctl: add copyright to svcctl rpc_server.
Guenther
2009-01-08 13:24:22 +01:00
Günther Deschner
cbc2c9059f s3-svcctl: remove some more redundant headers.
Guenther
2009-01-08 13:24:22 +01:00
Günther Deschner
3079e14f94 s3-svcctl: use pidl for _svcctl_QueryServiceConfig2W.
Guenther
2009-01-08 11:19:33 +01:00
Günther Deschner
5581637d22 s3-svcctl: fix return code for _svcctl_QueryServiceStatusEx.
Guenther
2009-01-08 11:19:33 +01:00
Günther Deschner
385316a09a s3-svcctl: remove old hand marshalling of svcctl_QueryServiceStatusEx.
Guenther
2009-01-08 11:19:33 +01:00
Günther Deschner
b42cb4944a s3-svcctl: use pidl for _svcctl_QueryServiceStatusEx.
Guenther
2009-01-08 11:19:32 +01:00
Günther Deschner
6eb507e30d s3-svcctl: use pidl's ndr opcodes for NDR_SVCCTL_QUERYSERVICECONFIGW.
Guenther
2009-01-08 11:19:31 +01:00
Günther Deschner
e2fa47a04c s3-lsa: avoid all init_lsa* functions.
Guenther
2009-01-06 16:02:13 +01:00
Günther Deschner
b0f7137883 s3-srvsvc: remove all init_srvsvc* functions.
Guenther
2009-01-06 16:02:12 +01:00
Günther Deschner
a94157c759 s3-srvsvc: avoid all init_srvsvc* functions.
Guenther
2009-01-06 16:02:12 +01:00
Günther Deschner
20ba0a947a s3-samr: avoid all init_samr_alias* functions.
Guenther
2009-01-06 16:02:12 +01:00
Günther Deschner
05784d0fa8 s3-samr: avoid all init_samr_group* functions.
Guenther
2009-01-06 16:02:11 +01:00
Günther Deschner
d2d8d7a087 s3-samr: avoid all init_samr_Domain* functions.
Guenther
2009-01-06 16:02:11 +01:00
Günther Deschner
46f55ef5bc s3-samr: avoid all init_samr_user* functions.
Guenther
2009-01-06 16:02:10 +01:00
Volker Lendecke
ef54ad52e0 Move the "rid_name" typedef to the only place where it might be used 2009-01-06 11:24:59 +01:00
Jelmer Vernooij
37e6849d45 Merge branch 'master' of ssh://git.samba.org/data/git/samba 2009-01-05 18:01:04 +01:00
Stefan Metzmacher
c34d5f445a s3:events: change event_add_timed() prototype to match samba4
metze
2009-01-05 15:07:35 +01:00