Volker Lendecke
4afcde91b9
Convert the domain handles to type-safe policy handles
2009-04-20 08:27:23 +02:00
Volker Lendecke
dd073a333e
Make force_flush_samr_cache use a dom_sid to find what to flush
2009-04-19 22:58:06 +02:00
Volker Lendecke
46317ce214
Remove flag "builtin_domain" from disp_info
2009-04-19 11:39:47 +02:00
Volker Lendecke
bf196df52f
Remove flag "builtin_domain" from samr_info
2009-04-19 09:27:15 +02:00
Volker Lendecke
386511b8e1
Make get_samr_info_by_sid use recent coding conventions
2009-04-19 09:27:15 +02:00
Volker Lendecke
35e6a0e618
Add "uint32_t access_granted" to policy handles
...
All policy handles have a mask of allowed operations attached that were
calculated at creation time, so they should carry this mask. This is the basis
for consolidating all our policy handle access checks.
If you want to do your own more complicated access checks further down, just
pass "0" to policy_handle_find.
2009-04-19 09:27:15 +02:00
Volker Lendecke
9b3f2e69f7
Make "struct policy" private to srv_lsa_hnd.c
2009-04-19 09:27:14 +02:00
Volker Lendecke
fa4ff87acd
Convert the samr connect_handles to type-safe calls
2009-04-18 13:58:48 +02:00
Volker Lendecke
c9bc1728f9
Add type-safe policy_handle_create/find
2009-04-18 13:58:48 +02:00
Volker Lendecke
fd558b37f6
Add some const
2009-04-18 13:58:48 +02:00
Günther Deschner
81b18464be
s3-spoolss: remove some direct checks for 0 uid in AddForm,SetForm,DelForm.
...
Also add some become_root()/unbecome_root() pairs which were missing IMHO.
Guenther
2009-04-17 23:20:22 +02:00
Günther Deschner
6900d61d36
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 6.
...
Guenther
2009-04-17 17:27:32 +02:00
Günther Deschner
5e563ee508
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 5.
...
Guenther
2009-04-17 17:27:26 +02:00
Günther Deschner
d76837f6da
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 4.
...
Guenther
2009-04-17 17:27:18 +02:00
Günther Deschner
0ba833f3ee
s3-samr: set the builtin_domain bool flag in get_samr_dispinfo_by_sid().
...
Volker, please check.
Found by torture test RPC-SAMR-PASSWORDS-PWDLASTSET (which we pass with
this fix).
Guenther
2009-04-17 11:21:20 +02:00
Günther Deschner
14304fc5e5
s3-lsa: Fix Bug #6263 . Unexpected LookupSids reply crashes XP pre-SP3.
...
LookupSids needs to bounce back string sids in case of NT_STATUS_NONE_MAPPED.
Guenther
(cherry picked from commit 1c9266c8ca
)
2009-04-16 01:52:56 +02:00
Jeremy Allison
d9804ae3cc
Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+
...
What a difference a name makes... :-). Just because something is missnamed
SAMR_ACCESS_OPEN_DOMAIN, when it should actually be SAMR_ACCESS_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
2009-04-15 15:40:00 -07:00
Andrew Bartlett
4678d1c6f4
Merge branch 'master' of ssh://git.samba.org/data/git/samba into libcli-auth-merge-without-netlogond
2009-04-15 14:36:13 +10:00
Günther Deschner
4721be488c
s3-spoolss: Fix format of description string in spoolss_PrinterInfo1.
...
This is what windows does and should get us closer to show the appropriate
printer location string in explorer.
Guenther
2009-04-14 23:21:47 +02:00
Günther Deschner
fa302020ee
s3-svcctl: fix memcpy in _svcctl_EnumServicesStatusW().
...
Make sure we are not copying more than what we have as valid data.
Fix from Jeremy. Thanks a lot for watching this so closely!
Guenther
2009-04-14 12:13:24 +02:00
Andrew Bartlett
f28f113d8e
Rework Samba3 to use new libcli/auth code (partial)
...
This commit is mostly to cope with the removal of SamOemHash (replaced
by arcfour_crypt()) and other collisions (such as changed function
arguments compared to Samba3).
We still provide creds_hash3 until Samba3 uses the credentials code in
netlogon server
Andrew Bartlett
2009-04-14 16:23:35 +10:00
Günther Deschner
a79e1ce048
s3-spoolss: fix typo in fill_printer_driver_info3().
...
Guenther
2009-04-13 23:45:12 +02:00
Günther Deschner
3ef0b8671d
s3-spoolss: Fix permission checks for _spoolss_AddForm,SetForm and DelForm.
...
Found by smbtorture test.
Guenther
2009-04-13 16:15:32 +02:00
Günther Deschner
97ffd709f8
s3-spoolss: use enumprinterdrivers_level() for level 3 enum.
...
Guenther
2009-04-13 16:12:56 +02:00
Günther Deschner
9b3d3e8aeb
s3-spoolss: use enumprinterdrivers_level() for level 2 enum.
...
Guenther
2009-04-13 16:12:49 +02:00
Günther Deschner
f325c34203
s3-spoolss: use enumprinterdrivers_level() for level 1 enum.
...
Guenther
2009-04-13 16:12:42 +02:00
Günther Deschner
0393c99302
s3-spoolss: add generic enumprinterdrivers_level function.
...
Guenther
2009-04-13 16:12:35 +02:00
Günther Deschner
bc5cd07764
s3-spoolss: implement dummy _spoolss_AddPort().
...
Guenther
2009-04-10 13:25:09 +02:00
Günther Deschner
65ee4ae30b
s3-spoolss: add support for level 8 in _spoolss_GetPrinter().
...
Guenther
2009-04-10 13:25:01 +02:00
Günther Deschner
bcd042e595
s3-eventlog: implement _eventlog_FlushEventLog().
...
Guenther
2009-04-10 13:15:25 +02:00
Günther Deschner
9b585a1282
s3-eventlog: implement _eventlog_GetLogInformation().
...
Guenther
2009-04-10 13:15:24 +02:00
Günther Deschner
b7caf13851
s3-ntsvcs: fix _PNP_GetDeviceList and _PNP_GetDeviceListSize.
...
Guenther
2009-04-10 01:06:57 +02:00
Günther Deschner
76da89daaa
s3-svcctl: minor fix for _svcctl_EnumDependentServicesW().
...
Guenther
2009-04-09 16:42:28 +02:00
Günther Deschner
8b9f2abfcb
s3-svcctl: Fix invalid buffer memset in _svcctl_QueryServiceObjectSecurity().
...
Found by torture-test.
Guenther
2009-04-09 15:08:29 +02:00
Günther Deschner
acd7fef984
s3-svcctl: Fix _svcctl_Set/GetServiceObjectSecurity after IDL changes.
...
Guenther
2009-04-09 14:51:21 +02:00
Günther Deschner
d8a6ea8141
s3-svcctl: Fix _svcctl_EnumServicesStatusW (again).
...
The final plan is to use the same macro based code that we have in spoolss to
handle the buffers and calculate the buffer-sizes.
Guenther
2009-04-08 23:23:17 +02:00
Günther Deschner
98d703a6b7
s3-eventlog: move rpc_server/srv_eventlog_lib.c out of rpc_server.
...
Guenther
2009-04-08 19:45:57 +02:00
Günther Deschner
5654f141a2
s3-rpc-server: remove unused rpc_server/srv_util.c file.
...
Guenther
2009-04-08 14:41:28 +02:00
Günther Deschner
8e3145e551
svcctl: use offered/needed for buffer sizes as in spoolss.
...
Guenther
2009-04-08 11:03:53 +02:00
Günther Deschner
b36fab0491
s3-svcctl: no need to define SVCCTL_NUM_INTERNAL_SERVICES twice in a file.
...
Guenther
2009-04-08 01:52:28 +02:00
Günther Deschner
c5b24d65cd
s3-spoolss: set servername to global_myname() in set_printer_hnd_name().
...
This allows spoolss_OpenPrinterEx to open a printer by printername.
Now the Samba3 spoolss server passes the RPC-SPOOLSS-WIN test.
Guenther
2009-04-07 22:15:15 +02:00
Günther Deschner
21b083a647
s3-svcctl: Fix _svcctl_EnumServicesStatusW() crash bug on too small buffer.
...
Guenther
2009-04-07 01:16:30 +02:00
Günther Deschner
12d9765177
s3-samr: add support for _samr_Connect3() while planning to pass a s4 smbtorture test.
...
Guenther
2009-04-06 22:37:11 +02:00
Günther Deschner
df29f49edd
s3-samr: add support for setting password hashes via samr_SetUserInfo level 21.
...
Guenther
2009-04-03 13:14:26 +02:00
Günther Deschner
31ab1d6a64
s3-lsa: use LSA_ROLE definitions in _lsa_QueryInfoPolicy().
...
Guenther
2009-04-02 22:52:52 +02:00
Günther Deschner
168eb23252
s3-lsa: don't SAFE_FREE talloced structs.
...
Guenther
2009-04-02 22:50:44 +02:00
Günther Deschner
37aff885a6
s3-spoolss: implement _spoolss_GetPrinterDriver2 level 101 (Bug #5140 ).
...
Guenther
2009-04-02 12:46:04 +02:00
Volker Lendecke
4b88f2c17e
Fix external np read after conversion to tevent_req
2009-03-27 21:12:17 +01:00
Günther Deschner
283e135298
s3-spoolss: implement enumprinters_level0.
...
Guenther
2009-03-25 12:46:40 +01:00
Volker Lendecke
f91565544f
Fix bug 6097
...
A client sent a SID with authority 0 and 0 sub-authorities. W2k3 replies with
NT_STATUS_INVALID_SID, even if other SIDs in the list are valid.
Thanks to Pavel <wylda@volny.cz> for the bug report!
2009-03-24 11:59:42 +01:00
Günther Deschner
19de802c17
s3-spoolss: _spoolss_EnumPrinters level 3 always returns WERR_UNKNOWN_LEVEL.
...
Guenther
2009-03-20 17:20:33 +01:00
Günther Deschner
d2de9b068c
s3-spoolss: implement enumprinters_level4.
...
Guenther
2009-03-20 17:20:33 +01:00
Günther Deschner
aa6dbcfc11
s3-spoolss: implement enumprinters_level5.
...
Guenther
2009-03-20 17:20:33 +01:00
Günther Deschner
6713244d46
s3-spoolss: use enum_all_printers_info_level for level 1 and 2.
...
Guenther
2009-03-20 17:20:33 +01:00
Günther Deschner
95f2913c7d
s3-spoolss: add enum_all_printers_info_level().
...
Guenther
2009-03-20 17:20:33 +01:00
Günther Deschner
5a388115a9
s3-spoolss: apply some const in spoolss server.
...
Guenther
2009-03-20 17:20:32 +01:00
Günther Deschner
045151b767
s3-spoolss: pure comsetics.
...
sorry, I just need to do that.
Guenther
2009-03-20 10:49:45 +01:00
Günther Deschner
842edcd2b0
s3-samr: try to to fix password_expired flag handling.
...
Guenther
2009-03-20 10:39:18 +01:00
Günther Deschner
531af136f9
s3: remove POLICY_HND.
...
Guenther
2009-03-18 23:22:29 +01:00
Günther Deschner
a1256594b0
s3-spoolss: fix _spoolss_GetPrinterData printerserver handle query error code.
...
When _spoolss_GetPrinterData receives a query on a printserver handle for a
value that we have not stored or do not provide, we need to return
WERR_INVALID_PARAM, not WERR_BADFILE. Tested with w2k and w2k3 servers.
Found by torture test.
Guenther
2009-03-18 21:57:07 +01:00
Günther Deschner
43182fdff8
s3-spoolss: fix _spoolss_EnumPrinterDataEx error path.
...
When a windows clients queries the "" key, we need to make sure to return with
the appropriate error (WERR_INVALID_PARAM in that case), and not fall through
to the buffer size handling macros. Found by torture test.
Guenther
2009-03-18 21:56:38 +01:00
Günther Deschner
9d1ab9a001
spoolss: add my copyright.
...
Guenther
2009-03-18 17:18:46 +01:00
Günther Deschner
36d0785806
s3-spoolss: remove rpc_server/srv_spoolss.c alltogether.
...
Guenther
2009-03-18 17:09:33 +01:00
Günther Deschner
0cfb1aea29
s3-spoolss: use pidl for _spoolss_EnumPrinterDataEx.
...
Please note that this has been the last call in samba3 that was
using hand-marshalled rpc. With this commit all named pipe rpc services
in samba3 have now fully moved to pidl generated code :-)
Guenther
2009-03-18 17:07:39 +01:00
Günther Deschner
31106cdace
s3-spoolss: use printer and job notify enums provided by idl.
...
Guenther
2009-03-18 16:47:01 +01:00
Günther Deschner
e61c9ca36d
s3-spoolss: fix spoolss server after spoolss_Field changes.
...
Guenther
2009-03-18 16:46:49 +01:00
Günther Deschner
9fdeb7f7b3
s3-spoolss: remove custom syntax_spoolss and use the syntax defined in IDL.
...
Guenther
2009-03-18 14:18:42 +01:00
Günther Deschner
ef02342562
s3-spoolss: add registry_value_to_printer_enum_value.
...
Guenther
2009-03-18 11:55:54 +01:00
Günther Deschner
f683341294
s3-spoolss: add SPOOLSS_BUFFER_ARRAY macro.
...
Guenther
2009-03-18 11:55:47 +01:00
Günther Deschner
b57d5eaac0
s3-spoolss: remove (disabled) enum_all_printers_info_1_remote.
...
Jerry, please check. I do not understand how this could work and in
it's current form, we cannot make this even compile anymore, I'm afraid :)
I think it is safe to remove.
Guenther
2009-03-17 19:07:38 +01:00
Günther Deschner
479d91ae9f
s3-spoolss: remove SPL Port definitions now in IDL.
...
Guenther
2009-03-17 19:07:37 +01:00
Günther Deschner
5778a36357
s3-spoolss: rename convert_printer_info_new to convert_printer_info.
...
Guenther
2009-03-17 18:39:55 +01:00
Günther Deschner
1e7f602f8c
s3-spoolss: rename convert_nt_devicemode_new to convert_nt_devicemode.
...
Guenther
2009-03-17 18:39:49 +01:00
Günther Deschner
6549408a4d
s3-spoolss: rename construct_dev_mode_new to construct_dev_mode.
...
Guenther
2009-03-17 18:39:43 +01:00
Günther Deschner
47c024fd75
s3-spoolss: rename temporary convert_devicemode_new function.
...
Guenther
2009-03-17 18:39:17 +01:00
Volker Lendecke
bce98d8c03
Convert np_read to tevent_req
2009-03-17 17:31:22 +01:00
Volker Lendecke
89543d6c78
Convert np_write to tevent_req
2009-03-17 17:31:22 +01:00
Günther Deschner
e89e739e22
s3-spoolss: remove unused init_unistr_array().
...
Guenther
2009-03-17 12:21:31 +01:00
Günther Deschner
4a58f263b9
s3-spoolss: remove unused get_printer_dataex().
...
Guenther
2009-03-17 12:21:23 +01:00
Günther Deschner
63d78712bc
s3-spoolss: use pidl for _spoolss_EnumPrinterKey.
...
Guenther
2009-03-17 12:18:57 +01:00
Günther Deschner
56691dfe4b
s3-spoolss: cleanup _spoolss_SetPrinterDataEx a little.
...
Guenther
2009-03-17 12:14:35 +01:00
Günther Deschner
d189824240
s3-spoolss: cleanup _spoolss_GetPrinterDataEx a little.
...
Guenther
2009-03-17 12:14:28 +01:00
Günther Deschner
80ecd11050
s3-spoolss: use pidl for _spoolss_EnumPrinterData.
...
Guenther
2009-03-17 12:07:58 +01:00
Günther Deschner
f9871a846d
s3-spoolss: use pidl for _spoolss_SetPrinterData.
...
Guenther
2009-03-17 11:57:26 +01:00
Günther Deschner
aeba6381d3
s3-spoolss: use pidl for _spoolss_GetPrinterData.
...
Guenther
2009-03-17 11:49:30 +01:00
Günther Deschner
6df9e1f7aa
s3-spoolss: add push_spoolss_PrinterData().
...
Guenther
2009-03-17 10:53:43 +01:00
Günther Deschner
9a8f19672d
s3-spoolss: add pull_spoolss_PrinterData().
...
Guenther
2009-03-17 10:53:24 +01:00
Günther Deschner
0068abe716
s3-spoolss: remove some unused functions.
...
Guenther
2009-03-13 09:25:26 +01:00
Günther Deschner
1ceb298ed6
s3-spoolss: use pidl for _spoolss_GetPrinter.
...
Guenther
2009-03-13 09:25:25 +01:00
Günther Deschner
7e753b28ea
s3-spoolss: use snum_is_shared_printer (allows to make code a little easier to
...
read).
Guenther
2009-03-13 09:25:24 +01:00
Günther Deschner
0174d4d3b2
s3-spoolss: add snum_is_shared_printer fn.
...
Guenther
2009-03-13 09:25:24 +01:00
Günther Deschner
f6f703f16e
s3-spoolss: use pidl for _spoolss_EnumPrinters.
...
Guenther
2009-03-13 09:25:24 +01:00
Günther Deschner
1b3e068e83
s3-spoolss: remove old spoolss_GetPrinterDriver2.
...
Guenther
2009-03-13 09:25:23 +01:00
Günther Deschner
8df8abb890
s3-spoolss: use pidl for _spoolss_GetPrinterDriver2.
...
Guenther
2009-03-13 09:25:23 +01:00
Günther Deschner
d6e2ef51ec
s3-spoolss: use pidl for _spoolss_EnumPrinterDrivers.
...
Guenther
2009-03-13 09:25:23 +01:00
Günther Deschner
e605e4503c
s3-spoolss: remove old spoolss_GetJob and spoolss_EnumJob.
...
Guenther
2009-03-13 09:25:22 +01:00
Günther Deschner
9b143e6de5
s3-spoolss: use pidl for _spoolss_GetJob.
...
Guenther
2009-03-13 09:25:21 +01:00
Günther Deschner
b80e3e5724
s3-spoolss: use pidl for _spoolss_EnumJobs.
...
Guenther
2009-03-13 09:25:21 +01:00
Günther Deschner
661e81d48c
s3-spoolss: add construct_dev_mode_new.
...
Guenther
2009-03-13 09:25:21 +01:00
Günther Deschner
427987d2bf
s3-spoolss: use macros for _spoolss_GetForm and split out level 1 get.
...
Guenther
2009-03-13 09:25:20 +01:00