1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Commit Graph

22601 Commits

Author SHA1 Message Date
Jeremy Allison
59590a1c4d r23752: Fix bug introduced by checkin 22920, allow large
readX. Fix from Dmitry Shatrov <dhsatrov@linux.vnet.ibm.com>.

"In send_file_readX(), if startpos > sbuf.st_size, then smb_maxcnt is set
to an invalid large value due to integer overflow.
As for me, this resulted in MS Word hanging while trying to save
a 1.5Mb document."

This isn't in shipping code.

Jeremy.
(This used to be commit af715c602a)
2007-10-10 12:23:52 -05:00
Michael Adam
052ddc9cd0 r23751: Call tdb_close even when validation was not successful.
Michael
(This used to be commit b68856d990)
2007-10-10 12:23:52 -05:00
Michael Adam
a5946cb46a r23750: Change the behaviour of net conf import when there is a global section
in the current registry and there is no global section in the input
file (or only global options with default values):
In that case the existing global section is now not touched. Before, it
would have been deleted and recreated empty. The new behaviour is how
other shares are treated too.

Note that since the input file is parsed by lp_load, there is currently
no way to distinguish between a section with only default parameters
and a non-existing section in net conf import.

Michael

PS: A couple of trailing white-spaces have been eliminated
and a line was broken to be not longer than 80 chars, too.
(This used to be commit ec21a0cf9f)
2007-10-10 12:23:52 -05:00
Michael Adam
1bea19c127 r23749: Simplify prototype of reg_setvalue_internal:
eliminate "type" parameter since we store only REG_SZ.

Michael
(This used to be commit 65ce463317)
2007-10-10 12:23:52 -05:00
Michael Adam
cba898808e r23748: Clean use of talloc in import_process_service:
create a temporary talloc ctx for the function.

Michael
(This used to be commit 39df7faaa9)
2007-10-10 12:23:51 -05:00
Michael Adam
c2c96bccda r23747: Move formatting of a parameter's value into a value string
to a function of its own. (for storing it in registry),
Eliminate the valtype variable : store everything as "sz".
Eliminate some trailing white spaces on the way.

Michael
(This used to be commit 76f4f224aa)
2007-10-10 12:23:51 -05:00
Michael Adam
feff1fcfd8 r23746: Fix missing assignments to target string of asprintf in import function.
Michael
(This used to be commit 6b1bf7c1f4)
2007-10-10 12:23:51 -05:00
Michael Adam
f7b8a3782a r23745: Fix: Check whether top subkeyname instead of whole registry key name
is equal to GLOBAL_NAME.

Michael
(This used to be commit fdcdcacf0a)
2007-10-10 12:23:51 -05:00
Michael Adam
ea78cb941a r23744: Remove TODO-comment. lp_load returns False if opening
of the config file fails. That's enough of checking for
existence and readbility to my taste.

Michael
(This used to be commit 204f4f1a94)
2007-10-10 12:23:51 -05:00
Volker Lendecke
c35d814e39 r23743: Simplify stat_cache_lookup() logic. For the history of this, see
http://article.gmane.org/gmane.network.samba.internals/32486.
(This used to be commit e5e42fe3d5)
2007-10-10 12:23:51 -05:00
Volker Lendecke
0e43c1e80d r23738: Re-add commented out code snipped that got lost by accident
(This used to be commit c38c31afb7)
2007-10-10 12:23:50 -05:00
Jeremy Allison
d3965a2689 r23736: Use local variable of smb_flag2 instead of using the macro every time.
Jeremy.
(This used to be commit 9e1663b1f1)
2007-10-10 12:23:50 -05:00
Jeremy Allison
10c83ace04 r23735: Second part of the bugfix for #4763
This should coalesce identical adjacent notify records - making the "too large"
bug very rare indeed. Please test.
Jeremy.
(This used to be commit 1aaa1f5bbe)
2007-10-10 12:23:50 -05:00
Lars Müller
c05cbbe41c r23733: Limit LDAP lookup in lookup_usergroups_member() to security groups.
Credits to Ralf Haferkamp for the discussion and help on this.
(This used to be commit 5be96d09a7)
2007-10-10 12:23:50 -05:00
Herb Lewis
24ebb4b1b6 r23732: removed reference to non-existent structure
(This used to be commit 4c04059f7d)
2007-10-10 12:23:50 -05:00
Volker Lendecke
6821e39e4b r23731: Forgot one reference to inbuf
(This used to be commit b02115f2ca)
2007-10-10 12:23:50 -05:00
Gerald Carter
a6706eee9b r23730: Squashed commit of the following:
commit 3941269fa01038fca242a197e8d7c1f234d45ea7
Author: Gerald (Jerry) Carter <jerry@samba.org>
Date:   Thu Jul 5 14:52:03 2007 -0500

    Two fixes for "winbind expand groups".

    (a) Update the counter for the number of new groups to resolve else
        we'll only expand one group member per level and drop the rest.
    (b) Don't reset the num_names counter in winbindd_ads.c:lookup_groupmem()
        or we'll drop the SIDs resolved to names via cache from the resulting
        list.
(This used to be commit dfb89dfcaa)
2007-10-10 12:23:49 -05:00
Jeremy Allison
35d09869ed r23728: First part of bugfix for #4763. Limit notify responses
to client max buf size.
Jeremy.
(This used to be commit 6113f56919)
2007-10-10 12:23:49 -05:00
Volker Lendecke
8724dfe551 r23727: Explicitly pass down FLAGS2 to srvstr_get_path.
Next step is to remove the bug that in the trans2 code we use the inbuf
as the base pointer to decide whether we need ucs2 alignment where we
need to use the beginning of the params buffer

Jeremy, last one for today to reviw :-)
(This used to be commit 18078b9faa)
2007-10-10 12:23:49 -05:00
Volker Lendecke
fcda5b5896 r23726: Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The next
checkin will pull this up to srvstr_get_path. At that point we can get more
independent of the inbuf, the base_ptr in pull_string will only be used
to satisfy UCS2 alignment constraints.
(This used to be commit 836782b07b)
2007-10-10 12:23:49 -05:00
Volker Lendecke
5391750ce6 r23725: Remove get_current_mid()
Jeremy, next one to review :-)
(This used to be commit a50555dda7)
2007-10-10 12:23:49 -05:00
Volker Lendecke
0bc56a2e5f r23724: Reduce access to the global inbuf a tiny bit. Add a struct smb_request
that contains some of the fields from the SMB header, removing the need
to access inbuf directly. This right now is used only in the open file
code & friends, and creating that header is only done when needed. This
needs more work, but it is a start.

Jeremy, I'm only checking this into 3_0, please review before I merge it
to _26.

Volker
(This used to be commit ca988f4e79)
2007-10-10 12:23:48 -05:00
Simo Sorce
4ce65137d9 r23723: Alexander Larsson pointed me at a missing mapping in clierror.c
When renaming a file across 2 filesystem a samba server returns
NT_STATUS_NOT_SAME_DEVICE but thius is not translated to EXDEV,
and the generic EINVAL is returned instead.
This should fix it, Jeremy or Derrel please check if this is ok.
(This used to be commit b35038fa4e)
2007-10-10 12:23:48 -05:00
Volker Lendecke
c509ce3675 r23722: Fix the build of the catia module
(This used to be commit fa09744cce)
2007-10-10 12:23:48 -05:00
Michael Adam
c799a1e980 r23714: but now:
This script allows for adding lists of users (or other objects)
to lists of groups (or aliases). Useful for creating large test
scenarios.

Michael
(This used to be commit b3e5082e10)
2007-10-10 12:23:48 -05:00
Michael Adam
1d95e049bb r23713: Oops accidentially checked in the wrong file - sorry!
Michael
(This used to be commit ae23e6d04b)
2007-10-10 12:23:48 -05:00
Michael Adam
459d01489f r23712: This script allows for adding lists of users (or other objects)
to lists of groups (or aliases). Useful for creating large test
scenarios.

Michael
(This used to be commit 0c03c78af8)
2007-10-10 12:23:47 -05:00
Michael Adam
4b1fbd17c4 r23711: Refactor the actual creation of object into its own small function.
Michael
(This used to be commit 26349c0b17)
2007-10-10 12:23:47 -05:00
Volker Lendecke
254e1ad28b r23710: Remove some code duplication, we do have a random number generator
(This used to be commit afd7febd98)
2007-10-10 12:23:47 -05:00
Volker Lendecke
824b3f82ac r23709: C++ warnings
(This used to be commit 2d5e3322d6)
2007-10-10 12:23:47 -05:00
Lars Müller
b824a665bb r23708: - Add define for WINBIND_WARN_PWD_EXPIRE.
- Add parameter config_flag to get_config_item_int() and do the same
  check as in get_conf_item_string.
(This used to be commit d1d1baa264)
2007-10-10 12:23:47 -05:00
Lars Müller
2f6b9c1ec4 r23707: - Move the asprintf() call to create the key even in
get_conf_item_string() to the later if statement.
- Also move the key definition to the later if statement in
  get_conf_item_string() and get_conf_item_int().
(This used to be commit 3a82ec943a)
2007-10-10 12:23:47 -05:00
Michael Adam
85f7c7127f r23706: Add a script to create domainusers,-groups and -aliases.
This is done via rpc client. The main purpose is to
be able to fill a domain controller with a large number
of users / groups easily. A the object names are
built as <prefix><num> where number ranges from a given
start number counting up until a given number of objects
has been created.

In a next step, I will submit scripts to add (many) users to
a group and to add a user to (many) groups.

Michael
(This used to be commit 8b81fbb7d9)
2007-10-10 12:23:47 -05:00
Lars Müller
26502733a5 r23705: Add suggestion for vim from Andreas 'GlaDiaC' Schneider to show tabs,
trailing whitespace, and continued lines visually.
(This used to be commit 6209ae79de)
2007-10-10 12:23:46 -05:00
Lars Müller
a3de7e9b9d r23704: Add pam_pwd_expire feature as discussed on samba-technical.
This is a slightly modified version to set warn_pwd_expire to the
default value if 0, no, or a broken value is set.

This version also has one if statement less in get_config_item_int().

Thanks a lot to Andreas 'GlaDiaC' Schneider for this feature!
(This used to be commit d26914c978)
2007-10-10 12:23:46 -05:00
Gerald Carter
866e39ad25 r23694: Make sure that when builddir != srcdir, we can still find the exports
files and library-versions file.

Also move the "-o $@" from the individual targets and into the SHLD_DSO
command.
(This used to be commit c85311b3a8)
2007-10-10 12:23:46 -05:00
Jeremy Allison
9f03efd6e5 r23692: Couldn't wait, sorry :-). Did the style change.
Jeremy.
(This used to be commit da0d6ba0f9)
2007-10-10 12:23:46 -05:00
Simo Sorce
38c84fe163 r23691: fix for bug on touching files as described here:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243897
(This used to be commit 6b68c006f8)
2007-10-10 12:23:46 -05:00
Gerald Carter
3a246ac46b r23689: Squashed commit of the following:
commit 0d4bbd197198a94bf4e29e0ccd175a40a60097f3
Author: Gerald (Jerry) Carter <jerry@samba.org>
Date:   Mon Jul 2 20:08:19 2007 -0500

    Introduce GNU ld linker export-script for hiding non-public symbols
    in shared libraries.

    Based on initial patch from Julien Cristau <jcristau@debian.org>
    and suggestions from James Peach <jpeach@samba.org>.  Currently
    the libsmbsharemodes libraries still exports *.  Signed off on
    my Derrell as well.
(This used to be commit c42cf731b4)
2007-10-10 12:23:46 -05:00
Jeremy Allison
6afbd15b67 r23688: Fix bug #4759 reported by Raul <ismell@ismell.org>.
"N" is not a valid format entry for ber_printf, should be "n"
Jeremy.
(This used to be commit f3bb102c24)
2007-10-10 12:23:45 -05:00
Stefan Metzmacher
1d5646f9ff r23685: merge from SAMBA_4_0:
Only use the bzr and git information when there's
a .bzr or .git in the top branch directory

I use bzr for my home directory and
bzr version-info in ~/devel/samba/4.0/samba4-git
gives the info about the ~/.bzr branch

metze
(This used to be commit e4df2e1c2d)
2007-10-10 12:23:45 -05:00
Simo Sorce
d37c199136 r23683: Check ports are in the correct range (1-65535)
(This used to be commit 84b193a7d9)
2007-10-10 12:23:45 -05:00
Simo Sorce
b85bfd5066 r23682: Old patch I forgot in one of my 3.0.25 trees.
Make sure we honour the directive not to allow machine password changes.
(This used to be commit 436555f05c)
2007-10-10 12:23:45 -05:00
Jeremy Allison
56f6f58df2 r23673: Check for integer wrap on incoming data.
Jeremy.
(This used to be commit 77a46c7aee)
2007-10-10 12:23:45 -05:00
Günther Deschner
7d6b8ff5b7 r23672: Allow msrpc_name_to_sid() to be called without a domain_name and just a name.
Guenther
(This used to be commit eeed62b6ca)
2007-10-10 12:23:45 -05:00
Volker Lendecke
2ae9a0b4d8 r23671: Remove unused code -- 16416 bytes of bss space...
(This used to be commit 25f3bfdb1f)
2007-10-10 12:23:44 -05:00
Volker Lendecke
0a754ca75c r23670: Fix mkversion.sh for the git case: Only use the first line where
"commit" occurs
(This used to be commit 0e9aeec370)
2007-10-10 12:23:44 -05:00
Michael Adam
b3b83941d8 r23669: Move a variable into the only block where it is used.
(This used to be commit 82be4137b7)
2007-10-10 12:23:44 -05:00
Michael Adam
7a3f98e508 r23668: When creating a new string value, win2k regedit delivers
one byte of data despite characters being two-byte.

This modifies registry_pull_value, to change the data
to the correct two-byte version of the empty string,
(as delivered by winxp), when only one byte of data is
received.

Michael
(This used to be commit a4c2b20296)
2007-10-10 12:23:44 -05:00
Michael Adam
ba2dc0530f r23667: Prevent storing of forbidden parameter names in registry
configuration as values. I would really like to check whether
the valuename is a valid parameter name (with lp_parameter_is_valid)
here, but unfortunately, regedit cereates new values as
"New Value #1" (and so on) first, before dropping into the
rename box. So this is impossible here.

Michael
(This used to be commit 10014833da)
2007-10-10 12:23:44 -05:00