sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-29 11:21:54 +03:00
Code
16,578 Commits 60 Branches 1,144 Tags 452 MiB
5db731d899
Commit Graph

16578 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Volker Lendecke
5db731d899 r1202: This hopefully fixes our memory use when unmarshalling strings. The test case 
was 'rpcclient -c "enumprinters 2"' with 4000 printers. At some point this
completely exploded in memory usage. For every string we talloc'ed memory up
to the end of the buffer. -> O(n^2).

This survives valgrind with this number of printers. It might also have
influence on winbind with a large number of users.

All those who dare to look at samba3 rpc code, could you please take a look? I
know this is a burden, but I would like comments ;-)))

Volker
(This used to be commit af251f4ea6)
 2007-10-10 10:51:59 -05:00
Jeremy Allison
ee79226d2a r1195: Ensure libsmb/clikrb5.c compiles. 
Jeremy.
(This used to be commit 7067e274dc)
 2007-10-10 10:51:59 -05:00
Jeremy Allison
59d1794527 r1194: Definition of krb5_free_unparsed_name() if we do't have it. 
Jeremy.
(This used to be commit 82c219ea02)
 2007-10-10 10:51:59 -05:00
Jeremy Allison
f38c27b4e0 r1193: Ensure we check for and use krb5_free_unparsed_name(). 
Jeremy.
(This used to be commit af5a08f5ad)
 2007-10-10 10:51:59 -05:00
Jeremy Allison
d703c350cb r1192: Fixed all memleaks/error code return path leaks I can find. Not sure if compiles yet, 
but will soon :-).
Jeremy.
(This used to be commit 0d982956f6)
 2007-10-10 10:51:59 -05:00
Jeremy Allison
92fea615f5 r1184: Keep latest changes... not compilable yet. 
Jeremy.
(This used to be commit 57c037c6c9)
 2007-10-10 10:51:59 -05:00
Jeremy Allison
04257821e9 r1183: Updates to the code cleanup so I don't lose my changes... 
Jeremy.
(This used to be commit 786a440c18)
 2007-10-10 10:51:58 -05:00
Jeremy Allison
920034ec3b r1182: Partial re-write of keytab code to clean up, remove memory leaks etc. Work in progress ! 
It seems the krb5 interfaces are so horrible it's impossible to write good error checking
code :-(.
Jeremy.
(This used to be commit 03f8c8bc07)
 2007-10-10 10:51:58 -05:00
Jeremy Allison
a986d45e98 r1180: New file - basis of new system keytab code. 
Jeremy.
(This used to be commit 858e849af6)
 2007-10-10 10:51:58 -05:00
Jeremy Allison
af10abdd55 r1179: Start of system keytab merge. Config tests. 
Jeremy.
(This used to be commit 730d750c04)
 2007-10-10 10:51:58 -05:00
Volker Lendecke
5be2af4822 r1175: Nowadays we actually do have local groups, so add the corresponding SIDs to 
the NT token we build.

Thanks to Guenther Deschner <gd@sernet.de>.

Volker
(This used to be commit 2f9143dee9)
 2007-10-10 10:51:58 -05:00
Jeremy Allison
bd178fd7a2 r1171: Patch from "Lu, Jianliang" <Jianliang.Lu@getronics.com> to 
reset password counts when account is reset.
Jeremy.
(This used to be commit 6fb64d8b36)
 2007-10-10 10:51:58 -05:00
Jeremy Allison
4dddfb74ae r1156: Ensure new remote arch of CIFSFS is seen. 
Jeremy.
(This used to be commit 33fa4b8b27)
 2007-10-10 10:51:57 -05:00
Jeremy Allison
2acd084866 r1154: Change default setting for case sensitivity to "auto". If set to auto 
then is the client supports it (current clients supported are Samba and
CIFSVFS - detected by the negprot strings "Samba", "POSIX 2" and a bare
"NT LM 0.12" string) then the setting of the per packet flag smb_flag
FLAG_CASELESS_PATHNAMES is taken into account per packet. This allows
the linux CIFS client to use Samba in a case sensitive manner.
Additional command in smbclient "case_sensitive", toggles the
flag in subsequent packets.
Docs to follow.
Jeremy.
(This used to be commit cf84c0fe1a)
 2007-10-10 10:51:57 -05:00
Andrew Bartlett
2895acb6e7 r1128: The end-of-file is not the end of the world, so don't make a load DEBUG() about it. 
Andrew Bartlett
(This used to be commit 4da976dbd0)
 2007-10-10 10:51:57 -05:00
Andrew Bartlett
c8f63452b8 r1127: Finding trusted domains is not so important as to require a DEBUG(1). 
Andrew Bartlett
(This used to be commit 999b2501a1)
 2007-10-10 10:51:57 -05:00
Andrew Bartlett
654524c71b r1126: Allow more flexible GSS-SPENGO client and server operation. The 
client now falls back to NTLMSSP, and the server allows the client to
start, without first asking for a mech list.

Andrew Bartlett
(This used to be commit feccc3daca)
 2007-10-10 10:51:57 -05:00
Andrew Bartlett
0805d1ddc3 r1125: Remove bougus comments. (The real fix was to the sealed pipe padding) 
Andrew Bartlett
(This used to be commit 61768f4cb3)
 2007-10-10 10:51:56 -05:00
Andrew Bartlett
2074b40485 r1124: ntlm_auth memory leak fixes by James Wilkinson - jwilk@alumni.cse.ucsc.edu 
Andrew Bartlett
(This used to be commit 94c0827ce2)
 2007-10-10 10:51:56 -05:00
Andrew Bartlett
3542b99cf1 r1122: As spotted by lha@stacken.kth.se we don't actually use this variable any more. 
Andrew Bartlett
(This used to be commit 9d5821d5ee)
 2007-10-10 10:51:56 -05:00
Andrew Bartlett
e27895d54f r1121: Fix memory leak in the trans2 signing code. 
We would start the trans2 state, which is fine, but never pull the
expected reply off the packet queue.

I'm not sure if this is still a major problem after jra's recent 'no
duplicate mids on the list' change, but I think this is correct
anyway.
(This used to be commit ee23a4237d)
 2007-10-10 10:51:56 -05:00
Jeremy Allison
58686e844f r1117: Doh ! Remember to turn off signing when sending a "break to level II" oplock 
message, or we mess up the signing sequence number.... Also improve sign error
reporting. Also when deferring an open that had been deferred due to an oplock
break, don't re-add the mid to the pending sign queue or we increment the sequence
number twice and mess up signing again...
I can now bounce between 2 WinXP/Win2003 boxes opening Excel spreadsheets with
signing turned on and get correct "file in use" messages.
Jeremy.
(This used to be commit 1745ce4e2c)
 2007-10-10 10:51:56 -05:00
Jeremy Allison
fddef6fc20 r1115: Fix for #1427. Catch bad path errors at the right point. Ensure all 
our pathname parsing is consistent.
Jeremy.
(This used to be commit 5e8237e306)
 2007-10-10 10:51:56 -05:00
Jelmer Vernooij
f28e4f3863 r1111: Rename vsnprintf to smb_vsnprintf so we don't get duplicate symbol errors 
when linking against an app that does have vsnprintf() (bug #478)
(This used to be commit 9f1c978088)
 2007-10-10 10:51:55 -05:00
Volker Lendecke
e107e9790d r1108: Index: pdb_ldap.c 
===================================================================
--- pdb_ldap.c	(revision 1095)
+++ pdb_ldap.c	(working copy)
@@ -1134,6 +1134,19 @@
 	return NT_STATUS_OK;
 }

+static void append_attr(char ***attr_list, const char *new_attr)
+{
+	int i;
+
+	for (i=0; (*attr_list)[i] != NULL; i++)
+		;
+
+	(*attr_list) = Realloc((*attr_list), sizeof(**attr_list) * (i+2));
+	SMB_ASSERT((*attr_list) != NULL);
+	(*attr_list)[i] = strdup(new_attr);
+	(*attr_list)[i+1] = NULL;
+}
+
 /**********************************************************************
 Get SAM_ACCOUNT entry from LDAP by username.
 *********************************************************************/
@@ -1149,6 +1162,7 @@
 	int rc;

 	attr_list = get_userattr_list( ldap_state->schema_ver );
+	append_attr(&attr_list, MODIFY_TIMESTAMP_STRING);
 	rc = ldapsam_search_suffix_by_name(ldap_state, sname, &result, attr_list);
 	free_attr_list( attr_list );

@@ -1194,6 +1208,7 @@
 	switch ( ldap_state->schema_ver ) {
 		case SCHEMAVER_SAMBASAMACCOUNT:
 			attr_list = get_userattr_list(ldap_state->schema_ver);
+			append_attr(&attr_list, MODIFY_TIMESTAMP_STRING);
 			rc = ldapsam_search_suffix_by_sid(ldap_state, sid, result, attr_list);
 			free_attr_list( attr_list );

Index: login_cache.c
===================================================================
--- login_cache.c	(revision 1095)
+++ login_cache.c	(working copy)
@@ -95,10 +95,13 @@
 			&entry->bad_password_count,
 			&entry->bad_password_time) == -1) {
 		DEBUG(7, ("No cache entry found\n"));
+		SAFE_FREE(entry);
 		SAFE_FREE(databuf.dptr);
 		return NULL;
 	}

+	SAFE_FREE(databuf.dptr);
+
 	DEBUG(5, ("Found login cache entry: timestamp %12u, flags 0x%x, count %d, time %12u\n",
 		  (unsigned int)entry->entry_timestamp, entry->acct_ctrl,
 		  entry->bad_password_count, (unsigned int)entry->bad_password_time));
(This used to be commit c0bf8425f4)
 2007-10-10 10:51:55 -05:00
Volker Lendecke
53babbb519 r1106: Lars Mueller <lmuelle@suse.de> asked me to apply this patch, as this is needed 
for their build environment. The AFS stuff is linux 2.4 only currently, it
works for me on this platform, so apply it.

Volker
(This used to be commit 69e8c65f1f)
 2007-10-10 10:51:55 -05:00
Volker Lendecke
76ca0f6f3f r1104: get_called_name is used in the printing subsystem. In case of multi-homed 
servers we need to make sure that the clients are given back the IP address
they connected to.

Volker
(This used to be commit 5f482df169)
 2007-10-10 10:51:55 -05:00
Herb Lewis
8018892b3c r1103: need to leave empty dacl so we can remove last ACE 
(This used to be commit d8a545368c)
 2007-10-10 10:51:55 -05:00
Volker Lendecke
b76daee923 r1101: Implement 'rpcclient setprintername'. 
Thanks to Guenther Deschner <gd@sernet.de>.

This needs to be generalized somewhat. Jerry, which of the parameters in the
printer_info_2 struct are settable via cli_spoolss_setprinter?

Volker
(This used to be commit 473dd03833)
 2007-10-10 10:51:55 -05:00
Jeremy Allison
459cb00785 r1097: Fix errno being incorrectly set. Noticed by Richard. 
Jeremy.
(This used to be commit c8a55e92dd)
 2007-10-10 10:51:54 -05:00
Jeremy Allison
b28d08cc14 r1093: Ensure we clear any cached errors on a deferred open call so 
we don't return the wrong error code on the next packet.
Jeremy.
(This used to be commit c1b06deb57)
 2007-10-10 10:51:54 -05:00
Jeremy Allison
effd4a3385 r1089: Removed spurious oplock message in deferred open processing. 
Fix smb signing sequence counts.
Jeremy.
(This used to be commit 7e2a5c3661)
 2007-10-10 10:51:54 -05:00
Gerald Carter
7e6734a0dd r1087: BUG 1221: revert old change that used single and double quotes as delimters in next_token(), and change print_parameter() to print out parm values surrounded by double quotes (instead of single quotes) 
(This used to be commit b0739b073a)
 2007-10-10 10:51:54 -05:00
Jeremy Allison
2fc57c9a2c r1085: Now it's had some proper user testing, merge in the deferred open fix. I'm 
still doing more testing, but it fixes a behaviour that we've been wrong
on ever since the start of Samba.
Jeremy.
(This used to be commit 894cc6d162)
 2007-10-10 10:51:54 -05:00
Gerald Carter
386a11f49e r1011: fix bad merge (from a few months ago) and ensure that we always use tdb_open_log() instead of tdb_open_ex() 
(This used to be commit e65564ab4a)
 2007-10-10 10:51:53 -05:00
Stefan Metzmacher
596eacea72 r1007: merge from SAMBA_4_0: 
print out the SVN revision by configure,
so that the build farm can use it

metze
(This used to be commit 98e6c3105d)
 2007-10-10 10:51:53 -05:00
Jeremy Allison
a6f5c88563 r998: Arrrgggh. Do it right this time :-(. 
Jeremy.
(This used to be commit 7ac7cd4162)
 2007-10-10 10:51:53 -05:00
Jeremy Allison
b7ac82294f r996: Fix error in change to queuing code (dlink). 
Jeremy.
(This used to be commit 6bd6359090)
 2007-10-10 10:51:53 -05:00
Gerald Carter
a020879964 r993: BUG 703 -- finishing patch by Eric Boehm <boehm@nortelnetworks.com> for netgroup case lookups 
(This used to be commit 82f3fee595)
 2007-10-10 10:51:53 -05:00
Gerald Carter
9dbf2e2419 r991: Allow winbindd to use the domain trust account password 
for setting up an schannel connection.  This solves the problem
of a Samba DC running winbind, trusting a native mode AD domain,
and needing to enumerate AD users via wbinfo -u.
(This used to be commit e9f109d1b3)
 2007-10-10 10:51:53 -05:00
Volker Lendecke
4e1b26db34 r989: Calling sid_to_gid from within winbind makes no sense, as this calls 
winbind_sid_to_gid. For the consistency check, local_sid_to_gid must set the
name_type it found.

Volker
(This used to be commit 5070c1b68f)
 2007-10-10 10:51:52 -05:00
Volker Lendecke
b24835c155 r988: When adding local aliases' gids to the user token, don't do a idmap_sid_to_gid 
on the user sid. This might lead to a user SID entered as a GID in the idmap.

Volker
(This used to be commit 98e10d1497)
 2007-10-10 10:51:52 -05:00
Jeremy Allison
ac5f0785c8 r984: Ensure memmove & memcpy aren't called with len == 0. 
Jeremy.
(This used to be commit 40c77dddc6)
 2007-10-10 10:51:52 -05:00
Volker Lendecke
e707189db3 r979: Implement the 'cups server' option. This makes it possible to have virtual 
smbd's connect to different cups daemons.

Volker
(This used to be commit 148dc71ea5)
 2007-10-10 10:51:52 -05:00
Volker Lendecke
47af5445f3 r977: Implement 'net rpc group rename' -- rename domain groups. 
Volker
(This used to be commit 9ceff80327)
 2007-10-10 10:51:52 -05:00
Jeremy Allison
efc96df3d5 r974: Fix open code to pass more torture tests. We now pass the Samba4 
oplock test. We do this be changing the algorithm when breaking
oplocks slightly. Previously we broke an oplock, then re-loaded
the share modes and re-iterated. Now we break all oplocks, then
re-load the share modes and check the share details - then iterate.
This seems to match the way Win2k3 does it.
Jeremy.
(This used to be commit 5ec4f4e4e6)
 2007-10-10 10:51:51 -05:00
Jeremy Allison
03d4344432 r971: Auto remove store dos attributes if underlying filesystem 
doesn't support EA's.
Jeremy.
(This used to be commit 9de6b25c9e)
 2007-10-10 10:51:51 -05:00
Gerald Carter
027c5068cd r966: fixing package dependencies 
(This used to be commit f614991544)
 2007-10-10 10:51:51 -05:00
Volker Lendecke
92cb49de77 r964: The max_size field in cli_samr_enum_als_groups is more like an account_control 
field with indiviual bits what to retrieve. Set this to 0xffff as NT4
usrmgr.exe does to get everything. I'm too lazy (sorry) to get this through to
rpc_parse/ etc.

Volker
(This used to be commit d7239c2611)
 2007-10-10 10:51:51 -05:00
Jeremy Allison
6798fd8e3c r957: Fixup moribund unix extensions mknod code path. Don't add in 
configure test yet. Also allow unix domain socket create.
Jeremy.
(This used to be commit 2db0c4ca7b)
 2007-10-10 10:51:51 -05:00