1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-01 04:58:35 +03:00

21591 Commits

Author SHA1 Message Date
Gerald Carter
5e88cb83b1 r21614: The memset() called on aligned memory was causing crashes
on x86_64 Linux boxes.  Since it is not needed, just use malloc()
on Linux.
(This used to be commit 3644bd999621e04b3fae262f172e93ea8fdcd47e)
2007-10-10 12:18:17 -05:00
Gerald Carter
aaa3a9a329 r21613: perform variable subsitution on home directories and shells provided by the nss_info backend
(This used to be commit a9028612a3f614579b28f9560cc67aef90b31cf8)
2007-10-10 12:18:17 -05:00
Gerald Carter
2c51e492f9 r21612: Make pam_winbind do the same username fixup on AIX as the WINBINDD
LAM module does to work around a system that does not support
>8 character usernames.  Without the change, pam_winbind tries
to authenticate _#uid in the domain.
(This used to be commit 7f0ba72e05acbd958fbf768a04d16c29189dc8f7)
2007-10-10 12:18:17 -05:00
Gerald Carter
85f769dbb4 r21611: I'm not entirely sure about this patch but it is working.
su - DOM\user was unable to set the process crendentials
without listing the "id" and other attributes in the attrlist[].
More fixes to come, but I didn't want this to get lost.
(This used to be commit 4c53d300fa3516a4c5113bc94dfd07413c46b038)
2007-10-10 12:18:17 -05:00
Gerald Carter
1e7ddfccd9 r21610: put libraries preceeding the @SONAMEFLAG@ variable as on AIX this ends up commenting out the remainder of the line and we have missing libraries in the link
(This used to be commit c4621de39bb9ad8d366d776b27df45dc07f782ba)
2007-10-10 12:18:17 -05:00
Jeremy Allison
8e00e9d7a6 r21609: Fix memory leaks in error code paths (and one in winbindd_group.c).
Patch from Zack Kirsch <zack.kirsch@isilon.com>.
Jeremy.
(This used to be commit df07a662e32367a52c1e8473475423db2ff5bc51)
2007-10-10 12:18:16 -05:00
Jeremy Allison
fae01b4899 r21608: Fix a couple of memleaks in error code paths before
Coverity finds them :-)
Jeremy.
(This used to be commit cbe725f1b09f3d0edbdf823e0862edf21e16d336)
2007-10-10 12:18:16 -05:00
Simo Sorce
f153274889 r21607: While committing I saw I had not newline terminated this string ...
(This used to be commit 51d296f25152ce9d719cec777bb306ca246fc3be)
2007-10-10 12:18:16 -05:00
Simo Sorce
e9e6af5951 r21606: Implement escaping function for ldap RDN values
Fix escaping of DN components and filters around the code
Add some notes to commandline help messages about how to pass DNs

revert jra's "concistency" commit to nsswitch/winbindd_ads.c, as it was
incorrect.
The 2 functions use DNs in different ways.

- lookup_usergroups_member() uses the DN in a search filter,
and must use the filter escaping function to escape it
Escaping filters that include escaped DNs ("\," becomes "\5c,") is the
correct way to do it (tested against W2k3).

- lookup_usergroups_memberof() instead uses the DN ultimately as a base dn.
Both functions do NOT need any DN escaping function as DNs can't be reliably
escaped when in a string form, intead each single RDN value must be escaped
separately.

DNs coming from other ldap calls (like ads_get_dn()), do not need escaping as
they come already escaped on the wire and passed as is by the ldap libraries

DN filtering has been tested.
For example now it is possible to do something like:
'net ads add user joe#5' as now the '#' character is correctly escaped when
building the DN, previously such a call failed with Invalid DN Syntax.

Simo.
(This used to be commit 5b4838f62ab1a92bfe02626ef40d7f94c2598322)
2007-10-10 12:18:16 -05:00
Jeremy Allison
578a817e47 r21605: Fix small typo noticed by Raúl Sánchez Siles <rss@barracuda.es>.
Jeremy.
(This used to be commit 5ed61d5af6fe56e22135406256f5d1f7ccd6a376)
2007-10-10 12:18:16 -05:00
Jeremy Allison
fd5cf34e26 r21604: I got this wrong also in libsmb :-(.
Jeremy.
(This used to be commit 4a04555e23b5fa53fbeb5b65a7c83cff1b0f9640)
2007-10-10 12:18:15 -05:00
Jeremy Allison
62a6f8940d r21603: Horrible backwards compatibility hack as an old server bug
allowed a CIFS client bug to remain unnoticed :-(.
I suck.
Jeremy.
(This used to be commit 29761173ee26b4713c9a12166a935c066fc3321b)
2007-10-10 12:18:15 -05:00
Volker Lendecke
84d2ceb1df r21581: Add an error code I just got
(This used to be commit 5ef0286b56b368abd4da2cbe3d826a3438f3acc3)
2007-10-10 12:18:15 -05:00
Jeremy Allison
1aa730ef96 r21577: Remove unneeded #define (part of earlier patch that was
removed).
Jeremy.
(This used to be commit 645b0438dde0dad26e950b3184cc412d3d87560a)
2007-10-10 12:18:15 -05:00
Jeremy Allison
3e12cf85ac r21576: Patch based on work from Todd Stecher <todd.stecher@isilon.com>
to allow client to fragment large SPNEGO blobs (large krb5
tickets). Tested against W2K3R2. Should fix bug #4400.
Jeremy.
(This used to be commit b81c5c6adce51cec06df0e993534064b20666a8e)
2007-10-10 12:18:14 -05:00
Jeremy Allison
8c5846acf2 r21569: Fix bug reported by Martin Zielinski <mz@seh.de>
where return value was incorrectly initialized.
Jeremy.
(This used to be commit 8d45f1f3b524031a34cfba21b677be8a09fc192c)
2007-10-10 12:18:14 -05:00
Jeremy Allison
2546b63f73 r21566: If we're going to be broken, at least be *consistently*
broken :-). This will do until Simo fixes the escape
calls properly.
Jeremy.
(This used to be commit b7d91ec1b20f8d58903a3283f7789a30041461be)
2007-10-10 12:18:14 -05:00
Jelmer Vernooij
2b5d317af1 r21565: Import ndrdump (doesn't compile yet, needs table support functions).
(This used to be commit 9a9b9421673ed1c455658d8ae79d7a1522a1baa7)
2007-10-10 12:18:14 -05:00
Volker Lendecke
2838d7499c r21563: Fix a memleak: We only need dispinfo structs for "our" and for the builtin
domain. Without this patch we leaked a DISPINFO for the (NULL) domain per
samr_connect*() call.

Volker
(This used to be commit 4423880ff47a94074c625a4f4f81c3b516faa644)
2007-10-10 12:18:14 -05:00
Jelmer Vernooij
7d2152b8dc r21562: Regenerate gen_ndr after pidl changes.
(This used to be commit 952f648d8132a0652bb03b9e7671239e57614ee9)
2007-10-10 12:18:13 -05:00
Günther Deschner
81e4a28718 r21561: It makes absolutely no sense to call krb5_kt_resolve() two times
directly after another.

Guenther
(This used to be commit 76ba11d7770bac7c6db2eb1640139bbe270d82c3)
2007-10-10 12:18:13 -05:00
Günther Deschner
5c0d13a8ae r21560: Convert name_to_fqdn to BOOL.
Guenther
(This used to be commit 28ce79629bc36929f508c1ccb1d27d48e8898045)
2007-10-10 12:18:13 -05:00
Günther Deschner
4e00351fd4 r21558: Safe more indent, again no code changes.
Guenther
(This used to be commit 7b18a4730d61c04867fc11df8980943d422589d8)
2007-10-10 12:18:13 -05:00
Günther Deschner
59e8bd617b r21557: indent only fix. No code change.
Guenther
(This used to be commit 8ff0903a17cfd8c09b73ef637484a72719e82071)
2007-10-10 12:18:13 -05:00
Günther Deschner
3e946cbb85 r21556: Remove superfluos return check in ads_keytab_verify_ticket().
Guenther
(This used to be commit 020601ea0abeb15f2aef9da354fcf6d7d5459710)
2007-10-10 12:18:13 -05:00
Lars Müller
2fb172f235 r21552: Ensure to check for proto_exists before linking any binary. No make
proto should be required before creating any binary from now on.

Remove proto_exists from the all, pam_smbpass, and pam_bindind rule.
(This used to be commit 95d22979743c94565d9d0bbb64eb1e9adeba10d3)
2007-10-10 12:18:12 -05:00
Volker Lendecke
f4a008424f r21551: Ok, this is more subtle. More tomorrow :-)
(This used to be commit f63189907efe857ef51ff91470ddb8d21b9a41fa)
2007-10-10 12:18:12 -05:00
Volker Lendecke
ab6a1df7a6 r21550: make disp_info_list static to get_samr_dispinfo_by_sid(), add a comment :-)
(This used to be commit fad2ee8aa3e99c31a0632a80b4a64dedb6e01495)
2007-10-10 12:18:12 -05:00
Volker Lendecke
eccb9b7962 r21549: Only create DISP_INFO structs for domain handles, the others don't need
them. It just does not make sense to do a querydispinfo on an alias handle...

This fixes a memleak: Every samr_connect*() call leaked a DISP_INFO for the
(NULL) sid.

More cleanup pending: Essentially, we only need the DISP_INFO cache for the
get_global_sam_sid() domain. BUILTIN is fixed and small enough, and there are
no other domains around where enumerations could happen.

This also removes the explicit builtin_domain flags. I don't think this is
worth it. If this makes a significant difference, then we have a *VERY* tuned
RPC layer...

Jeremy, please check this. If it's ok, we might want to merge it across.

Volker
(This used to be commit 0aceda68a825788895759e79de55b080ad3f971d)
2007-10-10 12:18:12 -05:00
Herb Lewis
bdc612a098 r21548: prevent segv (reference to -1 element of array)
(This used to be commit b5fd72282da85f50a040fd949752bc71023ff055)
2007-10-10 12:18:12 -05:00
Volker Lendecke
28e2069d1f r21547: Fix from Michael Adam <ma@sernet.de>: Refuse registry shares without path.
Thanks,

Volker
(This used to be commit e795865d58472498097edc3fb68438ed08c38d8d)
2007-10-10 12:18:11 -05:00
Herb Lewis
e7d6c7b151 r21546: remove duplicate lines
(This used to be commit 934163782bf5444ee6535b628ef80dad4b5685e6)
2007-10-10 12:18:11 -05:00
Günther Deschner
af7f764823 r21543: Fix 64bit build warning.
Guenther
(This used to be commit bc04004c182b114749d8e33edcf835efb252d35d)
2007-10-10 12:18:11 -05:00
Günther Deschner
dd110c9e7b r21540: Fix Bug #3713 and readd reporting what the profiles tool does (when
called with the -v option).

Patch from William Jojo <jojowil@hvcc.edu>.

Guenther
(This used to be commit 5889f588ee9bee6ceb6e6d517f6e69e42d55a574)
2007-10-10 12:18:11 -05:00
Günther Deschner
6af7f33bbb r21537: Avoid to trigger the confusing "cached entry differs." warning when
there is just no cache around for a user.

Guenther
(This used to be commit a6c249b59228c6891cde624f72fff23879dbd19f)
2007-10-10 12:18:11 -05:00
Günther Deschner
6784d54a77 r21536: Fix copy/paste typo.
Guenther
(This used to be commit 7edbb636f7caf43135f0320cc08ff18a34a80594)
2007-10-10 12:18:11 -05:00
Jeremy Allison
3f3a3a23ce r21530: Don't code with jet-lag and Volker looking over your
shoulder.... Correct fix for warning :-)
Jeremy.
(This used to be commit 773001870d22ef4ff7ec00f73661b59a63cade42)
2007-10-10 12:18:10 -05:00
Jeremy Allison
8e9ce06f35 r21529: Fix warning from bad cast.
Jeremy.
(This used to be commit 34675624e2be886188337a883a6c4a57ef7e3fe3)
2007-10-10 12:18:10 -05:00
Gerald Carter
e972e2967b r21526: Fix stray character in sys_memalign() that is only
is the case where we don't have memalign() or posix_memalign().
(This used to be commit 1635bac80011d15e3ed30b6d43b6e22b2ce2a000)
2007-10-10 12:18:10 -05:00
Gerald Carter
56c1d7e507 r21525: Go ahead and checkin the mlock() & memalign() fixes so
others don't get stuck with the winbindd hang.
Still waiting on additional confirmation from Guenther
that this fixes thes issues he was observing as well.
But it's been running in my local tree for a day without
problems.
(This used to be commit 0d2b80c6c4a744b05a0efdec352cddccc430e0c4)
2007-10-10 12:18:10 -05:00
Günther Deschner
d43dbee713 r21517: Fix build warnings.
Guenther
(This used to be commit 82f1da8117434c52c383b33a905b3765f0240d4a)
2007-10-10 12:18:09 -05:00
Lars Müller
fde308d6a8 r21509: Merge lp_passdb_backend() from rev 21506 to 3_0_25.
Slightly change the DEBUG 0 message as suggested by Volker on
samba-technical.
(This used to be commit c02921e95d41fe93c5913d79dfb690fcc1d73de4)
2007-10-10 12:18:09 -05:00
Simo Sorce
fa5e0a238c r21508: Fix memleak in new idmap_tdb, thanks Herb.
Jerry please check.

Simo.
(This used to be commit a5354aa9a0bd860500356f45d09fce3d01649c60)
2007-10-10 12:18:09 -05:00
Gerald Carter
2b52e35770 r21507: Fix some "cannot access LDAP when no root" bugs.
The two culprits were

* pdb_get_account_policy()
* pdb_get_group_sid()
(This used to be commit 6a69caf6907fad01b13aa4358ce5c62506f98495)
2007-10-10 12:18:09 -05:00
Lars Müller
1945571e3b r21506: Allow old pre 3.0.22 multi passdb backend configurations to work with
post 3.0.23.

This implementation considers spaces in ldapsam configs.  Such configs
are trunkated after the closing quote.
(This used to be commit 5cd9a2e25872db1881f2f67026bfcd52d060fc4b)
2007-10-10 12:18:09 -05:00
Gerald Carter
43c290639b r21505: make sure mlock()'d memory is aligned on a page boundary
(This used to be commit 52e6a2ceab794875781575ed17ec86808f6e26da)
2007-10-10 12:18:08 -05:00
Günther Deschner
9684e353a1 r21500: Fix inappropriate creation of a krb5 ticket refreshing event when a user
changed a password via pam_chauthtok. Only do this if

a) a user logs on using an expired password (or a password that needs to
be changed immediately) or

b) the user itself changes his password.

Also make sure to delete the in-memory krb5 credential cache (when a
user did not request a FILE based cred cache).

Finally honor the krb5 settings in the first pam authentication in the
chauthtok block (PAM_PRELIM_CHECK). This circumvents confusion when
NTLM samlogon authentication is still possible with the old password after
the password has been already changed (on w2k3 sp1 dcs).

Guenther
(This used to be commit c3005c48cd86bc1dd17fab80da05c2d34071b872)
2007-10-10 12:18:08 -05:00
Jeremy Allison
ca229b0980 r21483: Fix use of uninitialized variable.
Jeremy.
(This used to be commit 4a74d042c9108ed68cc92f27b390c261c0bc8885)
2007-10-10 12:18:08 -05:00
Jeremy Allison
2afcdc8732 r21482: Use IPC$ not ipc$ for consistency.
Jeremy.
(This used to be commit 42a846b3dfa50eea6592c6bb425f7bdb672c25f9)
2007-10-10 12:18:07 -05:00
Jeremy Allison
01ecda0534 r21481: No one said anything, so I'm disallowing anything
but explicit shares in "default service" :-).
Jeremy.
(This used to be commit 90bdcce765998cc0f5768d24926d52b8a4a44f90)
2007-10-10 12:18:07 -05:00