sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Code
19,893 Commits 60 Branches 1,145 Tags 452 MiB
5fb4cc9dff
Commit Graph

19893 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Allison
a90026e7a6 r16307: Make sure we know we must pass a valid pointer here. 
Klocwork #1129.
Jeremy.
(This used to be commit e8d86362ba)
 2007-10-10 11:17:32 -05:00
Jeremy Allison
3a8bf11ae3 r16306: Error handling in this asn1 code *sucks*. Fix a generic 
class of memory leak bugs on error found by Klocwork (#123).
Many of these functions didn't free allocated memory on
error exit.
Jeremy.
(This used to be commit 8ef11a7c6d)
 2007-10-10 11:17:32 -05:00
Volker Lendecke
eb41bfb91b r16301: Fix a memleak 
(This used to be commit 21aaede518)
 2007-10-10 11:17:32 -05:00
Jeremy Allison
4ba1a36d4c r16299: Fix another "dereferencing type-punned pointer will break 
strict-aliasing rules" gcc4 warning.
Jeremy.
(This used to be commit ee77dde9b6)
 2007-10-10 11:17:32 -05:00
Jeremy Allison
0a5b892aee r16298: On request of jiri sasek - Sun Microsystems - Prague Czech Republic <Jiri.Sasek@Sun.COM> 
change priv_op and priv_info to names that don't
conflict with the solaris namespace.
Jeremy.
(This used to be commit db5b4e3f13)
 2007-10-10 11:17:32 -05:00
Jeremy Allison
4b6fef6b6a r16295: Fix gcc4 "warning: dereferencing type-punned pointer will break 
strict-aliasing rules" warning.
Jeremy.
(This used to be commit 7ac5aee88c)
 2007-10-10 11:17:32 -05:00
Lars Müller
4f3e19950d r16294: Fix syntax error. 
Credits to Andreas Schwab from SUSE Linux for this fix.
(This used to be commit da4c5c3b75)
 2007-10-10 11:17:31 -05:00
Volker Lendecke
366a2d498d r16290: Fix Coverity bugs 298 and 298 
(This used to be commit b96808bb62)
 2007-10-10 11:17:31 -05:00
James Peach
e0055ce8f5 r16289: Fix smbclient test hang. This is caused by readline refusing to believe 
the end of file it receives when reading from a pipe after we force
interactive mode.
(This used to be commit 3eee126458)
 2007-10-10 11:17:31 -05:00
Jeremy Allison
0eb9bd176e r16287: Use intptr_t to return an integer of an unknown type cast 
to void *.
Jeremy.
(This used to be commit e24361ecdd)
 2007-10-10 11:17:31 -05:00
Jeremy Allison
193830091f r16285: On a 64-bit box, size_t != uint32. Ensure we use 
the right parameter type.
Jeremy.
(This used to be commit 938545f535)
 2007-10-10 11:17:31 -05:00
Jeremy Allison
300acb99ad r16284: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned 
int
in a format string.
Jeremy.
(This used to be commit face01ef01)
 2007-10-10 11:17:31 -05:00
Jeremy Allison
c115570b85 r16281: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned 
int
in a format string.
Jeremy.
(This used to be commit c49ad9200b)
 2007-10-10 11:17:30 -05:00
Jeremy Allison
87967b90c4 r16280: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned 
int
in a format string.
Jeremy.
(This used to be commit 45d5cad8c2)
 2007-10-10 11:17:30 -05:00
Jeremy Allison
17e1b83996 r16277: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int 
in a format string.
Jeremy.
(This used to be commit 3a15fff219)
 2007-10-10 11:17:30 -05:00
Jeremy Allison
9bcaf47c63 r16275: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int 
in a format string.
Jeremy.
(This used to be commit 952547471f)
 2007-10-10 11:17:30 -05:00
James Peach
06491a4cb1 r16274: Fix the smbclient prompting behaviour for both systems that have 
libreadline and those that don't. We always use the built-in readline
replacement for non-interactive mode. Interactive prompts are always
emitted to stdout and non-interactive mode never prompts at all.

Introduce x_fdup to avoid spuriously closing stdout when a logfile is
specified on the command line and setup_logging is called a second time.
(This used to be commit 848ac756f6)
 2007-10-10 11:17:30 -05:00
James Peach
ae2fb4f109 r16273: Add smbclient tests to verify that 
in interactive mode, smbclient always prompts on stdout
        in non-interactive mode, smbclient never prompts
(This used to be commit dff1eba81e)
 2007-10-10 11:17:30 -05:00
Günther Deschner
d4ad11ccd8 r16272: Fix memleak. 
Guenther
(This used to be commit afdb118902)
 2007-10-10 11:17:30 -05:00
Jeremy Allison
c2528679d8 r16270: Fix Klocwork #706 - ensure sscanf has correct format 
specifier.
Jeremy.
(This used to be commit dc53d35b0a)
 2007-10-10 11:17:29 -05:00
Günther Deschner
9e7377e81f r16269: Fix the build. 
Guenther
(This used to be commit 546710d58c)
 2007-10-10 11:17:29 -05:00
Günther Deschner
e030a9e9dc r16268: Add TCP fallback for our implementation of the CHANGEPW kpasswd calls. 
This patch is mainly based on the work of Todd Stecher
<tstecher@isilon.com> and has been reviewed by Jeremy.

I sucessfully tested and valgrinded it with MIT 1.4.3, 1.3.5, Heimdal
0.7.2 and 0.6.1rc3.

Guenther
(This used to be commit 535d03cbe8)
 2007-10-10 11:17:29 -05:00
Jeremy Allison
835bfbb8ac r16267: Fix Klocwork #401, #402 - ensure format specifier 
limited. Fix memleak in printing gencache contents.
Jeremy.
(This used to be commit 81731e1f68)
 2007-10-10 11:17:28 -05:00
Günther Deschner
e942ca4e0a r16261: Smaller fixes for net ads password. 
Guenther
(This used to be commit 689ae22c80)
 2007-10-10 11:17:28 -05:00
Gerald Carter
22b52b818b r16255: Fix 'net ads join' when the workgroup is set incorrectly 
in smb.conf.  This did work before the join rewrite.
Samba will have problems if you try to run any of the daemons
with an incorrect workgroup but it should not fail to join.

The summary is that a member server should always use it's
own machine name when setting up schannel since that is
the only account it has.  Thanks to Volker for the discussion.
(This used to be commit 95763b94f7)
 2007-10-10 11:17:28 -05:00
Günther Deschner
a6e662f556 r16253: Fix another host/ UPN case in (the currently unused) 
cli_rpc_pipe_open_krb5.

Guenther
(This used to be commit fa19099112)
 2007-10-10 11:17:28 -05:00
Volker Lendecke
c56f002525 r16252: Fix Klocwork ID 1119, 1121. 
Volker
(This used to be commit 678bbcf061)
 2007-10-10 11:17:28 -05:00
Volker Lendecke
d93b408678 r16251: for i in seq 1 1000 
do
	echo "I will always compile before commit :-)"
done

Also fix Klokwork ID 806.

Volker
(This used to be commit 4974c598c0)
 2007-10-10 11:17:28 -05:00
Volker Lendecke
05f59b2c34 r16250: Fix Klokwork IDs 148, 151, 152, 154. 
Volker
(This used to be commit d7a75ee94d)
 2007-10-10 11:17:28 -05:00
Volker Lendecke
fdced4467f r16249: Fix Klokwork ID 130 
(This used to be commit 09586824f6)
 2007-10-10 11:17:27 -05:00
Volker Lendecke
580e9817a2 r16248: Fix Coverity ID 297 
(This used to be commit e56e3c19e1)
 2007-10-10 11:17:27 -05:00
Volker Lendecke
99f271b3cb r16247: Fix Coverity ID 296 
(This used to be commit b82c95cb43)
 2007-10-10 11:17:27 -05:00
Jeremy Allison
7e40933d7b r16245: Cope with string being zero len. Klocwork bug #410. 
Jeremy.
(This used to be commit afe2d4c493)
 2007-10-10 11:17:27 -05:00
Jeremy Allison
8f2d6e4852 r16243: Fix Klocwork bugs #581 and #706, ensure we check 
the end of array first in the loop. Reformat to
modern standards.
Jeremy.
(This used to be commit 66275bd3bc)
 2007-10-10 11:17:27 -05:00
Jeremy Allison
f9147c4e40 r16241: Fix Klocwork #106 and others like it. 
Make 2 important changes. pdb_get_methods()
returning NULL is a *fatal* error. Don't try
and cope with it just call smb_panic. This
removes a *lot* of pointless "if (!pdb)" handling
code. Secondly, ensure that if samu_init()
fails we *always* back out of a function. That
way we are never in a situation where the pdb_XXX()
functions need to start with a "if (sampass)"
test - this was just bad design, not defensive
programming.
Jeremy.
(This used to be commit a0d368197d)
 2007-10-10 11:17:27 -05:00
Jeremy Allison
a1e0a0e928 r16230: Fix Klocwork #861 and others. localtime and asctime 
can return NULL. Ensure we check all returns correctly.
Jeremy.
(This used to be commit 6c61dc8ed6)
 2007-10-10 11:17:26 -05:00
Günther Deschner
2b99951e75 r16222: Fix DEBUG statements. 
Guenther
(This used to be commit 5ecfaf7d50)
 2007-10-10 11:17:26 -05:00
Günther Deschner
e8b4c92f32 r16221: No need for friednly error messages at log level 10. 
Guenther
(This used to be commit 58a7c09003)
 2007-10-10 11:17:26 -05:00
Gerald Carter
b32d2ecf9c r16219: BUG 3836, 3837, 3004: compile warning fixes from Jason Mader. 
(This used to be commit 6c1f1c091f)
 2007-10-10 11:17:26 -05:00
Jeremy Allison
2e8b3ca0cb r16216: Add debug messages to make it possible to try and 
debug why a job pause or resume command is not being
done.
Jeremy.
(This used to be commit e6aacb1426)
 2007-10-10 11:17:26 -05:00
Jeremy Allison
a5da0a72e1 r16213: Fix Klocwork #852. iface_n_ip can potentially 
return NULL. Ensure we don't deref.
Jeremy.
(This used to be commit c2f0ea2ff2)
 2007-10-10 11:17:26 -05:00
Jeremy Allison
d4a80fdf38 r16209: Klocwork bug #66, ensure no null deref. 
Jeremy.
(This used to be commit 79e693798c)
 2007-10-10 11:17:25 -05:00
Jeremy Allison
069397c63e r16207: Ensure we don't allocate an OID string unless 
we know we don't have an error. Klocwork #6.
Jeremy.
(This used to be commit 2c1a2d7b40)
 2007-10-10 11:17:25 -05:00
Gerald Carter
6cb8d09710 r16206: Don Meyer <dlmeyer@uiuc.edu> pointed out that RHEL4 rpms use 'Epoch: 0' so work around that 
(This used to be commit 304b7913cd)
 2007-10-10 11:17:25 -05:00
Gerald Carter
e6b64f6157 r16205: Fix 'make install' when srcdir != builddir 
(This used to be commit 44d4bab991)
 2007-10-10 11:17:25 -05:00
Volker Lendecke
0372e03722 r16204: Fix Klocwork # 14 
localtime() can return NULL.

Volker
(This used to be commit 07c5dcb863)
 2007-10-10 11:17:25 -05:00
Volker Lendecke
a47ffac30d r16203: Fix potentially writing one result of strtok beyond the end of alt_path. 
Found by Klocwork, ID 653.

Volker
(This used to be commit 4cb8cf221f)
 2007-10-10 11:17:25 -05:00
Jeremy Allison
92db75b4a2 r16202: Fix Klocwork #3. Strange - was already fixed in HEAD. 
Jeremy.
(This used to be commit 319f80bbf0)
 2007-10-10 11:17:25 -05:00
Volker Lendecke
edcffcbe28 r16201: Fix Klocwork 439 
(This used to be commit b369d0891a)
 2007-10-10 11:17:24 -05:00
Jeremy Allison
c0e4753cfc r16199: Fix Klocwork #1 - ensure we test the first 
strtok for NULL.
Jeremy.
(This used to be commit 98751e8190)
 2007-10-10 11:17:24 -05:00