1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

4662 Commits

Author SHA1 Message Date
Jeremy Allison
667b4113a8 Fix typos in new group sid check.
Jeremy.
(This used to be commit c48e95297e)
2000-12-18 07:22:10 +00:00
Tim Potter
cc4870aa0e Added query info policy call.
(This used to be commit dcea2a4bc0)
2000-12-18 06:09:40 +00:00
Jeremy Allison
452102deb4 Merged Tim's fixes from appliance-head.
Jeremy.
(This used to be commit 26f873540c)
2000-12-18 06:02:31 +00:00
Tim Potter
862b835040 Streamlined exit path.
Allow NULL to be passed to cli_lsa_initialise() which creates an anonymous
connection to the server.
(This used to be commit 8ccd06ee96)
2000-12-18 05:27:44 +00:00
Jeremy Allison
8372087800 Fixed chown/chgrp setting from smbcacls.
Jeremy.
(This used to be commit 43ca0d991c)
2000-12-16 00:34:58 +00:00
Jeremy Allison
8325948287 Added -C username and -G username that allow a user (usually Administrator)
to change the ownership or group ownership of a file to any arbitrary user
from the UNIX command line.
This will show the people who quote NT manuals at us about how this is
"impossible" how their operating system really works :-).
Jeremy.
(This used to be commit 12f88c9ba7)
2000-12-16 00:08:05 +00:00
Jeremy Allison
a57a6da52b Documented -C and -G options to smbcacls.
Jeremy.
(This used to be commit 89708be73a)
2000-12-16 00:06:05 +00:00
Jeremy Allison
fb82ab78fe Never free anything in the rpc_parse/prs_XXX functions. Do it in the enclosing
function.
lib/util_unistr.c: Check lengths *before* reading source - prevent uninitialised
memory reads.
Jeremy.
(This used to be commit ce4f461965)
2000-12-15 23:02:01 +00:00
Jeremy Allison
99c2693c62 Added lock backouts on fail.
When chaining together long lines of bloody "if" statements, which should
logically be separated, and one of them allocates memory, remember to
*free* it *WHETHER OR NOT THE IF STATEMENTS SUCCEEDED* !!!!
Yes I do consider this a bug in the coding style of Tridge, Rusty, Tim et al. :-).
I'm just pissed 'cos this took 4 hours to track down even with an insure error report
stating me in the face and also Ben Woodward looking over the code with me :-).
Jeremy.
(This used to be commit 506b5e34c3)
2000-12-15 21:29:06 +00:00
Jean-François Micouleau
89af6fd745 lib/util_unistr.c:
rewrote unistr2_to_ascii() to correct a bug seen on SGI boxes.

rpc_parse/parse_misc.c:
rpc_parse/parse_prs.c:
        rewrote of BUFFER5 handling to NOT byteswap when it was already in
        network byte order.

rpc_parse/parse_samr.c:
        cleanup of samr_io_q_lookup_domain(), remove the over-parsing by 2
        bytes.

rpc_server/srv_lsa.c:
        UNISTR2 strings need to be NULL terminated to pleased W2K.

rpc_server/srv_spoolss_nt.c:
        use snprintf instead of safe_strcpy as we want the string
        truncated at 32 chars.


That should fix SUN and SGI box not able to act as printserver and the
problem with joining from a W2K wks.

        J.F.
(This used to be commit 69fe739303)
2000-12-15 09:31:56 +00:00
Jeremy Allison
a18ade3fe0 Fixed memory leak in JOB_INFO_2 code.
Jeremy.
(This used to be commit d0d31eead3)
2000-12-15 01:47:37 +00:00
Jeremy Allison
369f5fd1d7 Fixed memory leaks in lsa_XX calls. Fixed memory leaks in smbcacls. Merged
in fixes from appliance-head and 2.2. Fixed multiple connection.tdb open
problem.
Jeremy.
(This used to be commit 0a40bc83e1)
2000-12-15 01:02:11 +00:00
David O'Neill
1fc3e43f9b Changes from APPLIANCE_HEAD:
- add some debugs for comparing two security descriptors.
      (source/rpc_parse/parse_sec.c)
(This used to be commit 505a8a2277)
2000-12-14 19:31:24 +00:00
Jeremy Allison
57779c6f3b Updates from appliance-head.
Jeremy.
(This used to be commit 15ae2c335b)
2000-12-14 18:37:01 +00:00
Tim Potter
624431c98b Renamed parameters and variables called acl to the_acl as it conflicts
with a Solaris system call.
(This used to be commit 5e547ddcb5)
2000-12-14 05:38:05 +00:00
Tim Potter
478ffc48ee Updated smbcacls documentation.
(This used to be commit bd87398b5a)
2000-12-14 04:57:14 +00:00
Tim Potter
237e74730c Cache lsa connection and policy handle for resolving names and sids.
(This used to be commit 09d2d972fd)
2000-12-14 03:27:53 +00:00
Gerald Carter
3b7ef4cd7d inverted dword value
jerry
(This used to be commit 0e5c1df284)
2000-12-13 21:49:31 +00:00
David O'Neill
2e87e6e8c8 Changes from APPLIANCE_HEAD:
- trivial typo in definition of enum_printing[]
	  (source/param/loadparm.c)
	- fixed printer status display bug.  When no jobs existed in queue, the
	  clients were not properly notified of printer status.  This caused
	  native tools for pausing/unpausing a print queue to not work.
	  (source/printing/printing.c)
(This used to be commit c533e77f19)
2000-12-13 21:24:06 +00:00
Jeremy Allison
5c67f8de46 Added proto definition for new RPC calls.
Added printing fix from appliance-head.
Jeremy.
(This used to be commit f4c7f9ddb9)
2000-12-13 19:55:48 +00:00
Tim Potter
55b162d221 I think it's time to go home.
(This used to be commit fde66badf1)
2000-12-13 13:10:22 +00:00
Tim Potter
06ba5ec75d OK so I shouldn't have added cli_pipe.o to LIBSMB_OBJ.
(This used to be commit a724850eb8)
2000-12-13 13:04:49 +00:00
Tim Potter
d18fb4a2c9 Add libsmb/cli_lsarpc.o and rpc_client/cli_pipe.o to LIBSMB_OBJ. Not so
sure about the latter...

Modified SMBCACLS_OBJ
(This used to be commit c130d5b0f6)
2000-12-13 12:54:57 +00:00
Tim Potter
56ee3e2e2f Convert names to sids when modifying ACLs. Convert sids to names when
displaying ACLs.
(This used to be commit 5001bbc64b)
2000-12-13 12:53:42 +00:00
Tim Potter
16e05346e5 Lightweight rpc client library. Uses only routines in libsmb and
rpc_client/cli_pipe.c

Only cli_lsa_open_policy(), cli_lsa_close(), cli_lsa_lookup_names()
and cli_lsa_lookup_sids() implemented so far.
(This used to be commit 129d5a155a)
2000-12-13 12:52:21 +00:00
Tim Potter
ed6f6ca043 Server side changes for dynamic names in lsa_lookup_names
(This used to be commit 5c5c3a8a08)
2000-12-13 12:39:55 +00:00
Tim Potter
6de135b0b2 make proto
Updates for dynamic sized lookup names/sids
(This used to be commit 34743c1576)
2000-12-13 12:13:22 +00:00
Tim Potter
e43671cd57 Wrong length for unistr2 in init_q_lookup_names()
Removed some more static arrays and replaced with tallocated memory
blocks.
(This used to be commit 1db0f31ae0)
2000-12-13 11:53:37 +00:00
Jeremy Allison
0835c7091c Two tdb bugfixes. First one - ensure that traverse lock is moved before deleting
dead records, else the record is just marked for deletion, not actually deleted.
Second, ensure allocated record is marked as "in use" before free list lock is
released, else other processes in the freelist merge code may try and merge it.
Jeremy.
(This used to be commit dd959fa325)
2000-12-13 06:33:53 +00:00
Tim Potter
a56ca9e2a4 Added support for SERVICESF shared variable to change configuration file
used in lp_load().
(This used to be commit 4d80ee4f41)
2000-12-13 04:19:48 +00:00
Jeremy Allison
cade42c05b Fixed bug noticed by JF. se_access_check needs user SID as first in token.
Jeremy.
(This used to be commit f0d7867801)
2000-12-12 20:41:02 +00:00
Jeremy Allison
4089011964 Fixed processing of dfree script (was truncating).
Jeremy.
(This used to be commit 1e719a8076)
2000-12-12 19:44:50 +00:00
David O'Neill
ae7f08398b Brief documentation on using the virtual printer code
(This used to be commit 03dd90ab92)
2000-12-12 18:03:50 +00:00
Gerald Carter
d21325dbd9 more fixes from Simo. Also fixed the password expiration field
in the tdbsam to never expire (we don't support this yet).




jerry
(This used to be commit 3b7d0fe7eb)
2000-12-12 16:50:23 +00:00
Tim Potter
76dca9c1fb Don't print out the security descriptor type as it is automatically
calculated by the new make_sec_desc() function.
(This used to be commit 6fd5dc8145)
2000-12-12 06:14:01 +00:00
Tim Potter
cbddae005f Better error checking for ACL parsing.
Print an error when attempting to delete a non-existent ACL.
(This used to be commit d119782d0d)
2000-12-12 06:06:10 +00:00
Tim Potter
65fd1be152 Fix error string.
(This used to be commit 73b237e639)
2000-12-12 06:05:13 +00:00
Tim Potter
b9c9e5d145 Fixed some accidentally reversed patches.
(This used to be commit fa604bc85e)
2000-12-12 05:58:34 +00:00
Tim Potter
90a7d7d3d7 Compile fix for new arg to create_nt_token()
(This used to be commit 806185ca8c)
2000-12-12 05:29:47 +00:00
Jeremy Allison
20ac3fc77e Merged in Tim's changes : Removed static limit of MAX_LOOKUP_SIDS in rpc server and client
lsa_lookup_names() and lsa_lookup_sids().
Jeremy.
(This used to be commit 9e9c71c8b3)
2000-12-12 02:45:11 +00:00
Jeremy Allison
276364e2a4 Removed the special casing of SIDs in se_access_check. This is now done (correctly)
when the NT_USER_TOKEN is *created*.
Jeremy.
(This used to be commit 27d72ed1cf)
2000-12-12 02:36:14 +00:00
Jeremy Allison
57fcae402b Owner always has READ_CONTROL and WRITE_DAC access.
Jeremy.
(This used to be commit 05fcb124df)
2000-12-12 00:42:55 +00:00
Jeremy Allison
4c639caa1f Sorry Gerald, I think the original code was better (plus safer as I'm sure
it's working :-).
Jeremy.
(This used to be commit e18c104ee3)
2000-12-12 00:11:34 +00:00
Jeremy Allison
71acf4cd1f Extra part of fix that Gerald missed (sorry).
Jeremy.
(This used to be commit ebf754400f)
2000-12-12 00:05:02 +00:00
Gerald Carter
93e98d0281 subtle bug where files which missed the stat_cache but were added
to the cache during the look returned a blank stat struct.  Made
weird occurrences such as...

   $ smbclient //pogo/print$
   smb:\ > cd w32x86
     ERROR: Invalid path
   smb:\ > cd w32x86

   smb:\w32x86\ >
(This used to be commit 8938dc1831)
2000-12-11 22:51:57 +00:00
Jeremy Allison
60337746ea Fix for short names not being returned correctly with non-mangled shares.
Jeremy.
(This used to be commit bcf0a5c316)
2000-12-11 22:31:25 +00:00
Jeremy Allison
ccb5cbf175 Fixed very subtle bug returning correct error on an open, when we have
a choice of invalid share mode and access denied. We must return the
access denied by preference, but also remember to break the oplocks...
This is needed for multi-user MS-Access.
Jeremy.
(This used to be commit 7eb7241442)
2000-12-11 21:09:48 +00:00
Jeremy Allison
a95ccc2779 Adding in debug for SD's.
Jeremy.
(This used to be commit a19f936b64)
2000-12-11 19:24:59 +00:00
Gerald Carter
c9d38e177b code review of rpcclient
o added some comments
  o abstracted a few code bits
  o cleaned up some code by removing unused code paths



-- jerry
(This used to be commit 679453af36)
2000-12-11 18:13:19 +00:00
Gerald Carter
b646d3f96e type for client_info struct
(This used to be commit 2c03b91d60)
2000-12-11 17:51:05 +00:00