1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-04 05:18:06 +03:00
Commit Graph

54417 Commits

Author SHA1 Message Date
Andrew Bartlett
6ba0e7f7b2 s4:kdc Only get the lp_ctx once for a LDB_fetch() 2009-06-30 12:06:38 +10:00
Andrew Bartlett
684a03e7f9 Rework hdb-samba4 to remove useless abstractions.
The function LDB_lookup_principal() has been eliminated, and it's
contents spread back to it's callers.  Removing the abstraction makes
the code clearer.

Also ensure we never pass unescaped user input to a LDB search
function.

Andrew Bartlett
2009-06-30 10:29:30 +10:00
Andrew Bartlett
db89b42c3b s4:dsdb Explain the parsing steps for userPrincipalName cracknames calls 2009-06-30 10:19:19 +10:00
Günther Deschner
0b2b9fdeda s4-smbtorture: use torture_comment & torture_warning in RPC samr tests.
Guenther
2009-06-29 23:47:47 +02:00
Michael Adam
69af9eacb9 s3:build: check for external liblua, link lua statically if using internal lib
So liblua is treated the same way as libtalloc and libtdb.

Michael
2009-06-29 23:25:38 +02:00
Günther Deschner
772d5dea30 s4-smbtorture: correctly test comment behaviour in RPC-SAMR-USERS against s3.
Guenther
2009-06-29 22:36:12 +02:00
Günther Deschner
28ef5c3ece s3-pdb_tdb: give 'unknown_str' the proper name 'comment' and set comment in passdb.
pdb_{get,set}_comment were already existing in the API but were never used.

Guenther
2009-06-29 22:36:12 +02:00
Stefan Metzmacher
ce8159b30e s3:pdb_ads: we need to make the fd for tldap/tsocket non-blocking
metze
2009-06-29 22:18:14 +02:00
Michael Adam
57d3ada2c9 s3:fix build of old linux quota system and other unixes' quota implementation
By fixing the use of struct stat_ex.

Michael
2009-06-29 16:51:53 +02:00
Michael Adam
3650143712 s3:lib/sysquotas: fix usage of SMB_STRUCT_STAT (struct stat_ex).
This fixes the build with quotas / configure time detection
of sys_quota interface.

Michael
2009-06-29 16:51:53 +02:00
Michael Adam
e4e855563b lib/util: fix building tevent_ntstatus without config.h
(when called from places with "#define NO_CONFIG_H" set, such as configure)

 Michael
2009-06-29 16:51:52 +02:00
Stefan Metzmacher
857ed9ca5a tsocket/bsd: also ask for TEVENT_FD_READ when we want to write into a stream socket
Otherwise we would not notice a broken connection.

metze
2009-06-29 16:03:57 +02:00
Stefan Metzmacher
b1d5e515b2 tsocket/bsd: more correctly check if the cached tevent_fd is still valid
I some cases the pointer value of tevent_context is the same again,
if we do something like:

	ev1 = tevent_context_init();
	...
	fde = tevent_add_fd(ev1, fd, TEVENT_FD_READ...);
	...
	talloc_free(ev1);
	...
	ev2 = tevent_context_init();

	if (ev1 == ev2) {
		/* this can happen! */
	}

	if (tevent_fd_get_flags(fde) == 0) {
		/* this is always true */
	}

But the "talloc_free(ev1)" will set fde->event_ctx to NULL
and tevent_fd_get_flags() will always return 0.

metze
2009-06-29 16:03:57 +02:00
Günther Deschner
bd997b2574 s3-selftest: add RPC-SAMR-MACHINE-AUTH to list of test to run against s3.
Guenther
2009-06-29 14:40:17 +02:00
Günther Deschner
50bb4bcc5b s4-smbtorture: add RPC-SAMR-MACHINE-AUTH test.
This test talks to a DC as a joined workstation member - in the same way
winbindd does, in particular the calls used in this test's query pattern
will all request for SEC_FLAG_MAXIMUM_ALLOWED access_mask
(which pretty much all of samba's client code does as well).

In fact this test verifies that winbind can correctly talk to a samba dc using
samr dcerpc calls.

Guenther
2009-06-29 14:40:08 +02:00
Günther Deschner
ec5c83c0db s4-smbtorture: add torture_suite_add_machine_workstation_rpc_iface_tcase.
Unlike torture_suite_add_machine_bdc_rpc_iface_tcase() which joins as a BDC
(ACB_SRVTRUST) this joins as a member workstation (ACB_WSTRUST).

Guenther
2009-06-29 12:43:32 +02:00
Jeff Layton
595d07d0ab mount.cifs: don't pass text ro/rw options to kernel
/bin/mount strips off the ro/rw options after setting the MS_RDONLY
flag appropriately. Make mount.cifs do the same thing.

Signed-off-by: Jeff Layton <jlayton@samba.org>
2009-06-29 06:16:38 -04:00
Andrew Bartlett
6e92505080 Fix ndrdump to use a common setup_logging() API
By adding a new common setup_logging_stdout() API, we no longer need to abuse the ABI compatability between the different setup_logging() calls in Samba3 and Samba4's DEBUG() subsystems.

The revert of 49a6d757b4 works with this
to fix bug 6211.

Andrew Bartlett
2009-06-29 20:12:23 +10:00
Andrew Bartlett
0e95b807b9 Revert "s4:debug: make setup_logging() a bit more compatible with samba3"
The problem is that the enum was previously a 'rachet', that is, it
would only reset to a level higher than it was previouly set to.
Changing the order broke file-based logging for our production sites.

This reverts commit 49a6d757b4.
2009-06-29 19:57:57 +10:00
Matthias Dieter Wallnöfer
15013090df Adds the impersonation level in ntcreatex requests to SAMBA 3 misc torture test
Specifies the impersonation level according to the reporter commit in bug #6283
2009-06-29 18:04:24 +10:00
David Markey
55ed0be65f Fix bug 6514: net gives unhelpful "lp_load failed" when it's missing smb.conf 2009-06-29 08:12:48 +02:00
Matthias Dieter Wallnöfer
c5a1aa5224 Correct some typos in the LDB partition module 2009-06-29 13:40:52 +10:00
Matthias Dieter Wallnöfer
4aa335be11 SAMDB: Don't check for "sAMAccountName" twice 2009-06-29 13:40:45 +10:00
Matthias Dieter Wallnöfer
077898b158 Enhancement of "simple ldap map" with "systemFlags" attribute
Enhance the simple ldap map to support also the "systemFlags" attribute in the
correct way.
2009-06-29 13:40:41 +10:00
Andrew Kroeger
994506ae2e ldb: Properly handle NULL when copying attr lists.
When copying an attribute list, ensure the list itself is not NULL before
attempting to access elements of the list.
2009-06-29 13:40:08 +10:00
Matthias Dieter Wallnöfer
2d9b51c2a8 Correct the headers of some SAMBA 4 setup python scripts 2009-06-29 13:39:55 +10:00
Nathaniel McCallum
1e21adaaf6 Two patches which fix issues on cross compiling/building 2009-06-29 13:39:52 +10:00
Matthias Dieter Wallnöfer
bc7b608625 Fixes for SAMBA3RPC torture test
On calls where both NT_STATUS and WERROR results are returned and consulted
we have to make sure to form function results considering both.
This errors have been found through a run against SAMBA 4.
2009-06-29 13:39:33 +10:00
Matthias Dieter Wallnöfer
b08beed0db Small patch for SPOOLSS pipe
Prevents a crash of the SAMBA 4 daemon on the torture SPOOLSS test due to not
initialised structures.
2009-06-29 13:38:59 +10:00
Volker Lendecke
8414048557 _lsa_QueryInfoPolicy: Use symbolic info level names 2009-06-28 22:13:50 +02:00
Volker Lendecke
711544d494 Turn the pdb_rid_algorithm into a capabilities call that returns flags 2009-06-28 22:13:50 +02:00
Volker Lendecke
325a58a653 Make pdb_ads survive a restart of Samba4
The search function retries once, the modifying call that hits a dead smbd
returns an error. The next try will reconnect. This was simple to implement and
provides a good compromise against Samba4 idling our connection. Most of the
modifying calls are quickly after a search (like OpenUser) anyway.
2009-06-28 15:51:02 +02:00
Volker Lendecke
344dbced50 If the connection is down, don't try another write. 2009-06-28 15:51:02 +02:00
Volker Lendecke
c594d21fda Add tldap_search_va 2009-06-28 15:51:02 +02:00
Volker Lendecke
ae5e1d9841 tldap_msg_received: Properly free the asn1_struct in case of an error 2009-06-28 15:51:02 +02:00
Volker Lendecke
8e22e38c9c Move read_ldap_done after read_ldap_send 2009-06-27 23:17:49 +02:00
Volker Lendecke
f5321ffea8 Convert tldap to tstream 2009-06-27 23:17:49 +02:00
Volker Lendecke
55dae4469c Add tstream_read_packet 2009-06-27 23:17:49 +02:00
Volker Lendecke
c687eb15d9 Properly free a downlevel readv request. Metze, please check 2009-06-27 23:17:49 +02:00
Volker Lendecke
53b9a24ce3 tldap: Don't fire off more than one read_ldap request during searches 2009-06-27 22:30:14 +02:00
Volker Lendecke
79c299f96f Stop listening for inotify data when there's none
There have been some reports that we're flooding syslog with "No data on
inotify fd?!". I haven't been able to reproduce this yet. Until then, it is
better to just list this message once.
2009-06-27 12:25:01 +02:00
Volker Lendecke
0fb0275657 Fix some nonempty blank lines 2009-06-27 12:25:01 +02:00
Volker Lendecke
a702dea5a8 s3/lanman: Workaround for KB932762.
This addresses bug #6498.
2009-06-27 10:12:51 +02:00
Volker Lendecke
04e4d03868 The solaris linker seems to require an extra mention of dependent libs 2009-06-26 23:15:51 +02:00
Jim McDonough
3c382db3a3 Don't use ads realm name for non-ads case. #6481
Also check that the connection to ads worked.
2009-06-26 15:24:57 -04:00
Volker Lendecke
382a937800 Fix some dead code warnings from SUN Studio 2009-06-26 17:45:16 +02:00
Volker Lendecke
cfafe9b9a9 Fix a typo in a comment 2009-06-26 16:51:02 +02:00
Sam Liddicott
131c95edda Upgrade ntvfs_map_*info to ntvfs_map_async_setup/ntvfs_map_async_finish
ntvfs_map_fsinfo, ntvfs_map_qpathinfo, ntvfs_map_qfileinfo used an
old synchronous mapping technique, acceptable on the grounds that
they were only used by the simple vfs which was synchronous.

Other vfs may/do use these functions, and by upgrading them to use the
ntvfs_map_async_setup/ntvfs_map_async_finish framework, they can now be
used asynchronously.

Signed-off-by: Sam Liddicott <sam@liddicott.com>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-06-26 14:39:44 +02:00
Michael Adam
a4bc5bfa95 s3:passdb: fix bug #6509: use gid (not uid) cache in fetch_gid_from_cache().
With the previous code, the cache can never have been hit at all.

Michael
2009-06-26 14:15:44 +02:00
Günther Deschner
2579afc897 s3-vlp: drastically shrink size and dependencies of the virtual line printer.
This gets vlp from 13M down to 214K on my box.

Guenther
2009-06-26 09:34:02 +02:00