1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Commit Graph

3841 Commits

Author SHA1 Message Date
Günther Deschner
74e416031b s3-printing: move driver_info_ctr_to_info8 to init_spoolss.h
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
2011-07-07 18:06:01 +02:00
Günther Deschner
dd5375b4a1 s3-printing: move os2 related functions to printing/nt_printing_os2.c.
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
2011-07-07 18:06:01 +02:00
Andreas Schneider
1caa7a852c s3-waf: Fix linking bugs causing segfaults.
As auth_util.c is linked several times the static variables have
different address on different calls. This leads to segfaults.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Jul  7 16:50:05 CEST 2011 on sn-devel-104
2011-07-07 16:50:05 +02:00
Volker Lendecke
f924913259 s3: Remove some unused variables
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Jul  5 18:40:11 CEST 2011 on sn-devel-104
2011-07-05 18:40:11 +02:00
Volker Lendecke
1c022d2e41 s3: Return "granted" from share_access_check
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-05 13:28:03 +02:00
Volker Lendecke
0bec150ab1 s3: Fix an enum/int mixup
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jul  4 18:47:59 CEST 2011 on sn-devel-104
2011-07-04 18:47:59 +02:00
Andrew Bartlett
b8b504a484 s3-samr Send IP address only to PAM remote hostname hook on password set
The previous behaviour was to attempt to do a reverse hostname lookup,
where enabled.  This new behaviour matches the new behaviour in the
modules called by auth stack.

Andrew Bartlett
2011-07-04 18:28:46 +10:00
Andreas Schneider
2bcbeea05e s3-rpc_server: Remove client_id and server_id from pipes struct.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04 18:28:43 +10:00
Andreas Schneider
726b6c6e52 s3-epmapper: Replace server_id in the epmapper.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04 18:28:14 +10:00
Andreas Schneider
784035fd53 s3-spoolss: Replace client_id in the spoolss server.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04 18:28:12 +10:00
Andreas Schneider
5f228fff2a s3-samr: Replace client_id in samr server.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04 18:28:10 +10:00
Andreas Schneider
f0361924fb s3-rpc_server: Replace client_id in dcerpc gssapi server.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04 18:28:08 +10:00
Andreas Schneider
7acaf405e4 s3-rpc_server: Remove unused client_id in srv_pipe.c.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04 18:28:06 +10:00
Andreas Schneider
7e46a84bb7 s3-auth: Pass the remote_address down to user_info.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04 18:28:02 +10:00
Andreas Schneider
45f70db010 s3-auth: Added remote_address to ntlmssp server.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04 18:28:00 +10:00
Andreas Schneider
541f3cf639 s3-rpc_server: Migrate rpc function to tsocket_address.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04 18:27:58 +10:00
Andreas Schneider
6ac68a803e s3-rpc_server: Add local and remote address to pipes struct.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04 18:27:57 +10:00
Andrew Bartlett
d4ef70a764 param: Finish conversion from lp_wins_support() -> lp_we_are_a_wins_server()
Jermey started this in 1997 with 0aa493cc03

(avoiding the duplicate function makes it easier to generate the
struct loadparm_globals).

Andrew Bartlett
2011-07-02 12:31:34 +10:00
Günther Deschner
e02abd6c83 s3-printing: split out printing migration code into a smaller library.
Guenther
2011-07-01 16:46:26 +02:00
Günther Deschner
8bc3f957bc s3-waf: add some missing tdb dependencies.
Guenther
2011-06-28 16:43:01 +02:00
Andrew Bartlett
734e1b6812 s3-param Remove 'announce version' parameter
The only users I can find of this on the internet involve confused
users, and our own documentation recommends never setting this.  Don't
confuse our users any longer.

Andrew Bartlett
2011-06-23 13:47:27 +02:00
Andreas Schneider
c173e6e80d s3-spoolss: Fix some valgrind warnings.
These are in/out values and need to be initialized.

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Jun 21 18:58:30 CEST 2011 on sn-devel-104
2011-06-21 18:58:29 +02:00
Andrew Bartlett
5db74b9607 lib/util Remove samba-util-common!
All of this code is now in common, so we don't need the second
'-common' library any more!

Andrew Bartlett
2011-06-21 09:36:22 +10:00
Rusty Russell
5a7874e119 tdb_traverse/tdb_traverse_read: check returns for negative, not -1.
TDB2 returns a negative error number on failure.  This is compatible
if we always check for < 0 instead of == -1.

Also, there's no tdb_traverse_read in TDB2: we don't try to make
traverse reliable any more, so there are no write locks anyway.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20 11:18:35 +02:00
Stefan Metzmacher
67512152c0 s3:rpc_server/svcctl: fix valgrind bug in _svcctl_QueryServiceObjectSecurity()
r->out.buffer needs to stay in its size, as it will be marshalled completely.
As it's preallocated and initialized with zeros, we just need to copy
the payload into it, even if it's smaller than the offered buffer size.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 14:15:47 CEST 2011 on sn-devel-104
2011-06-16 14:15:47 +02:00
Stefan Metzmacher
11683ccf3e s3:rpc_server/svcctl: fix valgrind bugs in _svcctl_QueryServiceConfig2W()
r->out.buffer needs to stay in its size, as it will be marshalled completely.
As it's preallocated and initialized with zeros, we just need to copy
the payload into it.

If we always marshall the return buffer, we already have the needed
buffer size and don't need to call ndr_size_* functions.

metze
2011-06-16 12:40:14 +02:00
Stefan Metzmacher
48de3e51ea s3:rpc_server/svcctl: don't allocate return values on a temporary stackframe
And always initialize the whole return structure.

This caused samba3.posix_s3.rpc.svcctl to be flakey.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 11:34:34 CEST 2011 on sn-devel-104
2011-06-16 11:34:34 +02:00
Andrew Bartlett
74eed8f3ed s3-param Remove special case for global_myname(), rename to lp_netbios_name()
There is no reason this can't be a normal constant string in the
loadparm system, now that we have lp_set_cmdline() to handle overrides
correctly.

Andrew Bartlett
2011-06-09 12:40:09 +02:00
Andrew Bartlett
8d4a8389bb s3-talloc Change TALLOC_MEMDUP() to talloc_memdup()
Using the standard macro makes it easier to move code into common, as
TALLOC_MEMDUP isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
5e26e94092 s3-talloc Change TALLOC_ZERO_ARRAY() to talloc_zero_array()
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
ad0a07c531 s3-talloc Change TALLOC_ZERO_P() to talloc_zero()
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_P isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
d5e6a47f06 s3-talloc Change TALLOC_P() to talloc()
Using the standard macro makes it easier to move code into common, as
TALLOC_P isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
3d15137653 s3-talloc Change TALLOC_ARRAY() to talloc_array()
Using the standard macro makes it easier to move code into common, as
TALLOC_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
73b377432c s3-talloc Change TALLOC_REALLOC_ARRAY() to talloc_realloc()
Using the standard macro makes it easier to move code into common, as
TALLOC_REALLOC_ARRAY isn't standard talloc.

Andrew Bartlett
2011-06-09 12:40:08 +02:00
Günther Deschner
47ea009e86 s3-spoolss: fix -Wunused-but-set-variable build warning in _spoolss_EnumPrintProcDataTypes().
We were in fact ignoring the error code here.

Guenther
2011-06-08 12:00:54 +02:00
Volker Lendecke
114fbc385c s3: Fix a valgrind error
For me this fixes

==1950== Invalid read of size 4
==1950==    at 0x81EBED5: GUID_equal (uuid.c:239)
==1950==    by 0x81E51AB: ndr_syntax_id_equal (ndr_misc.c:35)
==1950==    by 0x82EB0D1: get_iface_from_syntax (rpc_common.c:160)
==1950==    by 0x82EB25E: get_pipe_name_from_syntax (rpc_common.c:179)
==1950==    by 0x8509E4F: close_policy_by_pipe (rpc_handles.c:322)
==1950==    by 0x8507941: close_internal_rpc_pipe_hnd (rpc_ncacn_np.c:109)
==1950==    by 0x468270: _talloc_free_internal (talloc.c:826)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x80E6487: sam_trusted_domains (winbindd_samr.c:406)
==1950==  Address 0x687ea4 is 20 bytes inside a block of size 40 free'd
==1950==    at 0x58CDC: free (in /usr/local/lib/valgrind/vgpreload_memcheck-x86-freebsd.so)
==1950==    by 0x8507812: free_pipe_rpc_context_internal (rpc_ncacn_np.c:74)
==1950==    by 0x8507936: close_internal_rpc_pipe_hnd (rpc_ncacn_np.c:106)
==1950==    by 0x468270: _talloc_free_internal (talloc.c:826)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x80E6487: sam_trusted_domains (winbindd_samr.c:406)
==1950==    by 0x80C2F85: trusted_domains (winbindd_cache.c:2820)
==1950==    by 0x80D5188: winbindd_dual_list_trusted_domains (winbindd_misc.c:162)
==1950==    by 0x80E987F: wb_child_request_trigger (winbindd_dual.c:437)
==1950==

Andreas, Guenther, please check!

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jun  5 13:19:39 CEST 2011 on sn-devel-104
2011-06-05 13:19:39 +02:00
Jeremy Allison
b08bd96dc0 Fix bug where format arguments were reversed. Please compile with -Wall ! 2011-06-01 23:53:07 +02:00
Andreas Schneider
b5aeee76c9 s3-epmapper: Register ports on IPv4 too.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Jun  1 13:14:53 CEST 2011 on sn-devel-104
2011-06-01 13:14:53 +02:00
Andreas Schneider
4640d908f7 s3-rpc_server: Remove unused variable pipes_open. 2011-06-01 12:02:16 +02:00
Andreas Schneider
f086057ce8 s3-rpc_server: Remove syntax from pipes_struct. 2011-06-01 12:02:16 +02:00
Andreas Schneider
751ecd9bf7 s3-rpc_server: Fixed debug messages of srv_pipe_hnd. 2011-06-01 12:02:15 +02:00
Andreas Schneider
9f1b20e971 s3-rpc_server: Fixed debug messages for rpc_handles. 2011-06-01 12:02:15 +02:00
Andreas Schneider
89ced2cc49 s3-rpc_server: Fix debug messages. 2011-06-01 12:02:15 +02:00
Andreas Schneider
e744222e41 s3-rpc_server: Don't segfault if there are not handles to free. 2011-06-01 12:02:15 +02:00
Andreas Schneider
438b24a77f s3-rpc_server: Remove guessing of the syntax id.
This is only a wild guess. We don't know to which rpc service the client
wants to talk until we read the the rpc bind packet.
2011-06-01 12:02:15 +02:00
Andreas Schneider
7d800a8694 s3-rpc_server: Use the correct syntax id for debugging. 2011-06-01 12:02:15 +02:00
Andreas Schneider
6b0f82eeab s3-rpc_server: Migrate init_pipe_handles() to new syntax. 2011-06-01 12:02:15 +02:00
Andreas Schneider
58485afd91 s3-rpc_server: Use the context syntax id in api_pipe_request(). 2011-06-01 12:02:15 +02:00
Andreas Schneider
c8ec695cb3 s3-rpc_server: Use the correct syntax id in api_pipe_bind_req(). 2011-06-01 12:02:15 +02:00
Andreas Schneider
6e8c7d0834 s3-rpc_server: Use the correct context syntax. 2011-06-01 12:02:15 +02:00