1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Commit Graph

3841 Commits

Author SHA1 Message Date
Andreas Schneider
da718a5961 s3-epmapper: Use DCERPC_AUTH_LEVEL_CONNECT for ep ncalrpc. 2011-03-23 17:19:22 +01:00
Andreas Schneider
3766f3ec0e s3-rpc_server: Rename system_user to ncalrpc_as_system. 2011-03-23 17:19:22 +01:00
Volker Lendecke
cfa8b36632 s3: Fix Coverity ID 2201, NULL_RETURNS
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 23 13:06:20 CET 2011 on sn-devel-104
2011-03-23 13:06:20 +01:00
Volker Lendecke
4b347a1b17 s3: Add "print notify backchannel" parameter to prevent us doing the reverse print notify connection.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Mar 18 21:34:30 CET 2011 on sn-devel-104
2011-03-18 21:34:30 +01:00
Volker Lendecke
37870e28ab s3: Fix Coverity ID 2233, REVERSE_INULL
We have dereferenced h already in dcerpc_lsa_open_policy2 in line 425
2011-03-16 22:07:24 +01:00
Volker Lendecke
dacb392db6 s3: Fix Coverity ID 2234: REVERSE_INULL
We have dereferenced "b" already in dcerpc_samr_Connect2 in line 521
2011-03-16 22:07:24 +01:00
Volker Lendecke
a7a638c3cf s3: Fix Coverity ID 2213, PASS_BY_VALUE
There's little point to pass a copy of this structure on the stack.

Günther, please check!
2011-03-16 21:14:58 +01:00
Volker Lendecke
a282455978 s3: Fix Coverity ID 1012, CHECKED_RETURN
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
2011-03-16 21:14:58 +01:00
Volker Lendecke
9c9ed33cb7 s3: Fix Coverity ID 1013, CHECKED_RETURN
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
2011-03-16 21:14:58 +01:00
Volker Lendecke
3835d77795 s3: Fix Coverity ID 1017, CHECKED_RETURN
Günther, please check!
2011-03-16 21:14:58 +01:00
Volker Lendecke
df79b3ba76 s3: Fix Coverity ID 2317: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-16 18:08:51 +01:00
Volker Lendecke
329fcd4e34 s3: Fix Coverity ID 2318: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-16 18:08:51 +01:00
Günther Deschner
1ce4d2d83a s3-msdfs: avoid global inclusion of msdfs.h.
Guenther
2011-03-16 16:56:46 +01:00
Volker Lendecke
f0d491205c s3: Fix Coverity ID 2279: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:46 +01:00
Volker Lendecke
6b584e0e9a s3: Fix Coverity ID 2281: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:45 +01:00
Volker Lendecke
b753b0ab82 s3: Fix Coverity ID 2283: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_OpenKey.
2011-03-15 11:10:45 +01:00
Volker Lendecke
2992ccfe9c s3: Fix Coverity ID 2284: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteValue.
2011-03-15 11:10:45 +01:00
Volker Lendecke
2b26c86fe6 s3: Fix Coverity ID 2285: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteValue.
2011-03-15 11:10:45 +01:00
Volker Lendecke
c09877113d s3: Fix Coverity ID 2286: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:44 +01:00
Günther Deschner
f0d59bb3cf s3-rpc_server: handle DCERPC_AUTH_LEVEL_CONNECT in api_pipe_bind_req().
Guenther
2011-03-09 12:27:25 +01:00
Andreas Schneider
fb3e4d2be5 s3-rpc_server: Remove unused _rpc_ep_register.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Mar  9 10:32:32 CET 2011 on sn-devel-104
2011-03-09 10:32:32 +01:00
Andreas Schneider
8df4f4fd41 s3-rpc_server: Use the new endpoint register functions. 2011-03-09 09:28:42 +01:00
Andreas Schneider
71f613e9d5 s3-rpc_server: Add tevent based endpoint setup functions. 2011-03-09 09:28:42 +01:00
Andreas Schneider
133ed1cc64 s3-rpc_server: Change irritating debug message. 2011-03-09 09:28:42 +01:00
Günther Deschner
12f10a9182 s3-waf: fix the build.
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:31 +01:00
Günther Deschner
19117db52c s3-epmd: remove some unused variables.
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:31 +01:00
Andreas Schneider
794e0f5f0c s3-rpc_server: Added IPv6 support for epmapper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:31 +01:00
Andreas Schneider
a955c53843 s3-rpc_server: Free unused memory.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:31 +01:00
Andreas Schneider
69a9b9b8d0 s3-rpc_server: Fixed the accept() for ncalrpc_listener.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:31 +01:00
Andreas Schneider
07e8904a5b s3-rpc_server: Fixed the accept() for tcpip_listener.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
9dc27cb5b2 s3-rpc_server: Fixed the accept() for named_pipe_listener.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
ce491edcad s3-librpc: Register NCALRPC pipes.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
50de20979b s3-rpc_server: Create the ncalrpc endpoints.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
4b8dd08a38 s3-rpc_server: Add server support for NCALRPC system user pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
5ce12e0beb s3-rpc_server: Improved the dcerpc_ncacn_accept switch.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
42e9dde646 s3-rpc_server: Remove unneeded ncacn wrappers.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
0f97f789b2 s3-rpc_server: Fixed ncalrpc connection accept.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
53018dc37d s3-rpc_server: Only allow epm insert and delete on NCALRPC.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
cc5b88545d s3-rpc_server: Introduce transport in pipe_struct.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:30 +01:00
Andreas Schneider
bd66fc81b6 s3-rpc_server: Start the Endpoint Mapper Dameon if enabled.
Endpoint Mapper is still disabled by default!

Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
55296edb09 s3-rpc_server: Created an Endpoint Mapper Daemon.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
917a5eaf18 s3-rpc_server: Added prototype to setup a ncalrpc socket.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Simo Sorce
1e69dad446 s3-epmap: add ncalrpc listener code
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Simo Sorce
6ac34d58a9 sr-epmap: Minor cleanups and fixes
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
aa777df557 s3-epmap: Return the correct ip address.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
254c02041c s3-rpc_server: Added server address to pipes struct.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
d14de8fd4d s3-rpc_server: Set client and server connection info.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:28 +01:00
Andreas Schneider
ae67ccfb0d s3-rpc_server: Added tcpip listener for each rpc service.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:28 +01:00
Andreas Schneider
a45353b3e2 s3-librpc: Added tcpip support for dcerpc_binding_vector_create.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:28 +01:00
David Disseldorp
9c342c44a4 s3: add two missing vfs disconnect calls
The fix for bug 7976 added a vfs connect call to create_conn_struct.
This change adds two further disconnect calls that were missed by the
original change.

Signed-off-by: Andreas Schneider <asn@samba.org>

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri Mar  4 16:33:53 CET 2011 on sn-devel-104
2011-03-04 16:33:53 +01:00
Volker Lendecke
f8a13c7dbc s3: Use dom_sid_string in _lsa_lookup_sids_internal 2011-03-03 22:08:49 +01:00
Günther Deschner
ea29261186 s3-sessionid: avoid global include of sessionid.h
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar  2 12:58:12 CET 2011 on sn-devel-104
2011-03-02 12:58:12 +01:00
Günther Deschner
8643683dd8 s3-server_id: only include server_id where needed.
Guenther
2011-03-02 12:12:31 +01:00
David Disseldorp
016a8d214a s3-printing: vfs_connect prior to driver/dfs IO
samba3.posix_s3.rpc.spoolss.driver fails with the xattr_tdb vfs module
loaded as a part of make test. The (now checked) create_directory() call
in move_driver_to_download_area() fails, uncovering another bug in the
printer driver upload code path.

move_driver_to_download_area() creates a new conn_struct for
manipulating files in [print$]. The VFS layer is plumbed through with
the call to create_conn_struct(), however SMB_VFS_CONNECT() is never
called. Many vfs modules expect state stored at connect time with
SMB_VFS_HANDLE_SET_DATA() to be available on any IO operation and fail
if this is not the case.

This fix adds a call to SMB_VFS_CONNECT() in create_conn_struct() prior
to IO.

https://bugzilla.samba.org/show_bug.cgi?id=7976

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar  2 01:16:30 CET 2011 on sn-devel-104
2011-03-02 01:16:30 +01:00
David Disseldorp
14446b5280 s3-printing: fix move_driver_to_download_area() error paths
WERR_ACCESS_DENIED errors are mapped to WERR_UNKNOWN_PRINTER_DRIVER,
resulting in incorrect error messages on Windows clients.

move_driver_to_download_area() returns the same error status values
to the caller via the *perr argument as well as the return value.

The create_directory() call is not checked for error.
2011-03-02 00:31:22 +01:00
Andrew Bartlett
04f5ef83b9 s3-auth struct security_unix_token replaces UNIX_USER_TOKEN 2011-03-01 06:29:04 +01:00
Andrew Bartlett
9900aa4fb4 s3-rpc_server Handle session key as a constant buffer
This way, we don't have to check for memory allocation failures.

Andrew Bartlett
2011-03-01 06:29:03 +01:00
Jelmer Vernooij
59a077d8f5 Fix some types
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 28 23:30:06 CET 2011 on sn-devel-104
2011-02-28 23:30:06 +01:00
Andreas Schneider
bf18403c81 s3-rpc_client: Move client pipe functions to own header. 2011-02-28 18:15:04 +01:00
Volker Lendecke
fec0baacb6 s3: Make is_zero_addr take a sockaddr_storage
All callers had to cast this anyway

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Feb 27 11:02:53 CET 2011 on sn-devel-104
2011-02-27 11:02:53 +01:00
Günther Deschner
28b4b05938 s3-includes: move some chgpasswd related defines to the locations where they are used.
Guenther
2011-02-22 21:52:19 +01:00
Günther Deschner
66e040ee0a s3-printing: isolate print notification prototypes better.
Guenther
2011-02-22 21:52:18 +01:00
Stefan Metzmacher
d7fa349052 s3:auth: change num_groups to from size_t to uint32_t
This will help with the change from UNIX_USER_TOKEN to security_unix_token

metze
2011-02-22 16:20:11 +11:00
Andrew Bartlett
2e69e89456 s3-auth Rename auth_serversupplied_info varaiables: server_info -> session_info
These variables, of type struct auth_serversupplied_info were poorly
named when added into 2001, and in good consistant practice, this has
extended all over the codebase in the years since.

The structure is also not ideal for it's current purpose.  Originally
intended to convey the results of the authentication modules, it
really describes all the essential attributes of a session.  This
rename will reduce the volume of a future patch to replaced these with
a struct auth_session_info, with auth_serversupplied_info confined to
the lower levels of the auth subsystem, and then eliminated.

(The new structure will be the output of create_local_token(), and the
change in struct definition will ensure that this is always run, populating
local groups and privileges).

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-02-22 16:20:10 +11:00
Andreas Schneider
8fce37331e s3-rpc_server: Let enpoint mapper listen on port 135.
*** This is my commit #500 ***

Endpoint Mapper is disabled by default. The next steps are to setup a
tcpip and ncalrpc listener for each service and register it at epm.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Tue Feb 22 00:07:45 CET 2011 on sn-devel-104
2011-02-22 00:07:45 +01:00
Andreas Schneider
0abe7c68c5 s3-rpc_server: Added event and msg ctx to _rpc_ep_register. 2011-02-21 23:00:02 +01:00
Andreas Schneider
df5d26521a s3-rpc_server: Added port option to _rpc_ep_register. 2011-02-21 23:00:02 +01:00
Andreas Schneider
a99e670cd2 s3-rpc_server: Added function to setup tcpip listener! 2011-02-21 23:00:02 +01:00
Andreas Schneider
fc46ea981f s3-rpc_server: Rename srv_rpc_register.c. 2011-02-21 23:00:02 +01:00
Andreas Schneider
116144a4d0 s3-rpc_server: Rename srv_rpc_register. 2011-02-21 23:00:02 +01:00
Andreas Schneider
184702a43d s3-rpc_server: Pass tevent_context to dcerpc endpoints. 2011-02-21 23:00:02 +01:00
Andreas Schneider
02b356d7a8 s3-rpc_server: Create a common ncacn listen state. 2011-02-21 23:00:02 +01:00
Andreas Schneider
98fcbd0975 s3-rpc_server: Rename named_pipe_read_packet().
This is not named pipe specific.
2011-02-21 23:00:02 +01:00
Günther Deschner
debd6da27a s3-lsa: fix some uninitialized variables in our lsa server.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Feb 21 18:47:30 CET 2011 on sn-devel-104
2011-02-21 18:47:30 +01:00
Volker Lendecke
943aac2e36 s3: Add "len" to pdb_set_hours 2011-02-19 11:32:49 +01:00
Andrew Tridgell
c8b2b10976 s3-waf: use SAMBA3_*() build rules in source3/build
this brings the s3 waf build much closer to the proposed s3build top
level build, using the same bld.SAMBA3_*() rules

There are a few renames of subsystems in here, with a 3 suffix where
it would create a conflict.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-02-18 16:46:41 +11:00
Günther Deschner
f037d42e9b s3-lsa: support trust objects in _lsa_QuerySecurity().
Guenther
2011-02-17 16:02:20 +01:00
Günther Deschner
fa43de063a s3-lsa: in _lsa_QuerySecurity() query the sd from the lsa policy handle.
Guenther
2011-02-17 16:02:20 +01:00
Günther Deschner
67dfc87291 s3-lsa: only proceed in _lsa_EnumTrustedDomainsEx when backend has trusted domain support.
Guenther
2011-02-17 16:02:20 +01:00
Sumit Bose
bfa7964da8 s3-ipasam: Add aliases for trusted domain user
Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Feb 16 12:58:13 CET 2011 on sn-devel-104
2011-02-16 12:58:13 +01:00
Sumit Bose
7763816968 s3-netlogon: Implement NetrServerGetTrustInfo and NetrGetForestTrustInformation
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:07 +01:00
Sumit Bose
d638f4a3b8 s3-lsa: Implement lsaRSetForestTrustInformation
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:06 +01:00
Sumit Bose
33655d28b0 s3-lsa: Add and remove trusted domain account
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:06 +01:00
Sumit Bose
7d53893dee s3-lsa: fix return code of _lsa_QueryTrustedDomainInfoByName()
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:05 +01:00
Sumit Bose
a8ab5d582d s3-lsa: Extract auth info from trustDomainPasswords
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:05 +01:00
Sumit Bose
0b27317a5c s3-lsa: Use pdb_get_trusted_domain_by_sid in _lsa_QueryTrustedDomainInfo()
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:04 +01:00
Sumit Bose
fbd846f427 s3-lsa: fix lsa_QueryTrustedDomainInfo
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:04 +01:00
Günther Deschner
4d22986541 s3-lsa: implement _lsa_OpenTrustedDomainByName().
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:04 +01:00
Günther Deschner
cdd4df72d7 s3-lsa: implement _lsa_OpenTrustedDomain().
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:04 +01:00
Sumit Bose
13c5211fa9 s3-lsa: Implement _lsa_EnumTrustedDomainsEx()
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:03 +01:00
Günther Deschner
86771d8258 s3-lsa: implement _lsa_CloseTrustedDomainEx().
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:03 +01:00
Günther Deschner
06245d1335 s3-lsa: implement _lsa_QueryTrustedDomainInfoByName().
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:03 +01:00
Günther Deschner
b9eda2ac98 s3-lsa: implement _lsa_QueryTrustedDomainInfoBySid().
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:03 +01:00
Günther Deschner
1ce0d9791b s3-lsa: implement _lsa_QueryTrustedDomainInfo().
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:44:02 +01:00
Sumit Bose
bb947089af s3-lsa: make _lsa_DeleteTrustedDomain() use pdb_del_trusted_domain().
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:43:45 +01:00
Günther Deschner
12d16af9d6 s3-lsa: implement _lsa_DeleteTrustedDomain().
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:43:28 +01:00
Sumit Bose
f6004a1cfd s3-lsa: make lsa_lookup_trusted_domain_by_name() use pdb_get_trusted_domain().
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:43:18 +01:00
Günther Deschner
387e37efce s3-lsa: add lsa_lookup_trusted_domain_by_name and lsa_lookup_trusted_domain_by_sid.
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:35:20 +01:00
Günther Deschner
39c9f59dba s3-lsa: implement _lsa_CreateTrustedDomain().
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:35:20 +01:00
Günther Deschner
55bc1cfae3 s3-lsa: implement _lsa_CreateTrustedDomainEx().
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:35:20 +01:00
Sumit Bose
162fd0e891 s3-lsa: Let _lsa_CreateTrustedDomainEx2() use pdb_set_trusted_domain().
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:35:07 +01:00
Günther Deschner
a6bd93b8c3 s3-lsa: implement _lsa_CreateTrustedDomainEx2().
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:34:46 +01:00
Günther Deschner
424dc1b6a3 s3-lsa: add LSA_HANDLE_TRUST_TYPE.
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:34:46 +01:00
Günther Deschner
5b412117b2 s3-lsa: add create_lsa_policy_handle().
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-16 11:34:46 +01:00
Volker Lendecke
9ef0e1ef22 s3: Pass "code_page" through samr 2011-02-15 21:12:22 +01:00
Volker Lendecke
63c556e306 s3: Pass "country_code" through samr 2011-02-15 21:12:22 +01:00
Günther Deschner
7ff5bf56c8 s3-rpc_server: fix some buildwarnings in non-developer mode.
Guenther
2011-02-11 16:06:06 +01:00
Günther Deschner
4063bde3ed s3-rpc_server: move services into individual directories.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Feb 10 22:13:17 CET 2011 on sn-devel-104
2011-02-10 22:13:17 +01:00
Andreas Schneider
f0a90551b2 s3-rpc_server: Fixed possible segfaults in svcctl server.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-10 17:47:04 +01:00
Günther Deschner
7a558ea27c s3-waf: fix the build after auth changes.
Andrews, please check.

Guenther
2011-02-10 12:58:06 +01:00
Andrew Bartlett
2b05ba77b4 s3-auth Rename cryptic 'ptok' to security_token
This will allow the auth_serversupplied_info struct to be migrated
to auth_session_info easier.

Adnrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-02-10 06:51:06 +01:00
Andrew Bartlett
d66150c14d libcli/named_pipe_auth Change from 'info3' to auth_session_info_transport
This changes the structure being used to convey the current user state
from the netlogon-derived 'netr_SamInfo3' structure to a purpose-built
structure that matches the internals of the Samba auth subsystem and
contains the final group list, as well as the final privilege set and
session key.

These previously had to be re-created on the server side of the pipe
each time.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-02-10 06:51:06 +01:00
Andreas Schneider
edbd6f4a93 s3-rpc_server: We need a messaging context for rpc.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Feb  9 17:26:00 CET 2011 on sn-devel-104
2011-02-09 17:26:00 +01:00
Andreas Schneider
1b5609aa4d s3-rpc_server: Fixed possible segfault with client_id. 2011-02-09 16:42:19 +01:00
Stefan Metzmacher
d04c2c575a s3:rpc_server: create binding_handle in rpc_pipe_open_external()
metze

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb  9 12:30:50 CET 2011 on sn-devel-104
2011-02-09 12:30:50 +01:00
Volker Lendecke
5a0ee95b95 s3: Fix some nonempty blank lines and some typos
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb  9 00:01:45 CET 2011 on sn-devel-104
2011-02-09 00:01:45 +01:00
Günther Deschner
8b64d0607b s3-spoolss: Dont wipe out all drivers when only one should be deleted.
Great catch from Bjoern Baumbach <bb@sernet.de> !

Andreas, Simo, please check.

We now have a torture test (rpc.spoolss.driver.driver.multiple_drivers) for this.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb  8 18:11:48 CET 2011 on sn-devel-104
2011-02-08 18:11:48 +01:00
Günther Deschner
7637e1df8e s3-waf: fix the build after winreg and rpc services changes.
Andreas, please check.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Feb  7 13:18:41 CET 2011 on sn-devel-104
2011-02-07 13:18:41 +01:00
Andreas Schneider
1c6276ce7a s3-rpc_server: Migrated spoolss to dcerpc_winreg_set_multi_sz.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:02 +01:00
Andreas Schneider
1f0c766fa6 s3-rpc_server: Migrated spoolss to dcerpc_winreg_query_dword.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:02 +01:00
Andreas Schneider
df75045e0d s3-rpc_server: Migrated spoolss to dcerpc_winreg_set_X.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:02 +01:00
Andreas Schneider
ee817f63ce s3-rpc_server: Migrated spoolss to dcerpc_winreg_set_X.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:01 +01:00
Andreas Schneider
e8bf397eb0 s3-rpc_server: Migrated spoolss to dcerpc_winreg_set_dword.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:01 +01:00
Andreas Schneider
460aedc4b1 s3-rpc_server: Migrated spoolss to dcerpc_winreg_set_sz..
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:01 +01:00
Andreas Schneider
8238732330 s3-rpc_server: Migrated spoolss to dcerpc_winreg_enum_keys.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:01 +01:00
Andreas Schneider
b2ddfc642d s3-smbd: Init the svcctl registry keys on service startup.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:01 +01:00
Andreas Schneider
f1d5cea322 s3-rpc_server: Added a winreg based svcctl registry init.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:01 +01:00
Andreas Schneider
09dafc4a25 s3-rpc_server: Added a svcctl shutdown function.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:01 +01:00
Andreas Schneider
96565db5f6 s3-services: Migrated svcctl registry functions to winreg.
This is a bigger commit. It moves the relevant function to
svc_winreg_glue. We need to use them in the same commit else we have
problems with prototypes in proto.h.

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:01 +01:00
Andreas Schneider
a3a38fdb55 s3-smbd: Init the eventlog registry on service startup.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Andreas Schneider
22ea293381 s3-rpc_server: Added a winreg based eventlog registry init.
This enumerates the keys first and only creates them if they don't exist
yet.

Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Andreas Schneider
75abfa6f94 s3-rpc_server: Migrated eventlog to winreg.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Stefan Metzmacher
8111d95655 s3:rpc_server: fix make_external_rpc_pipe_p() and create read and write queues
They are needed for the callers in rpc_server/srv_pipe_hnd.c.

It seems I only looked at the caller in rpc_server/rpc_ncacn_np.c
when I've done the change of commit e55426fe79.

Thanks Volker for finding this :-)

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Feb  7 11:40:20 CET 2011 on sn-devel-104
2011-02-07 11:40:20 +01:00
Günther Deschner
f1d51aa6f2 s3-netlogon: fix typo.
Guenther
2011-02-07 10:02:05 +01:00
Volker Lendecke
a61b17ce56 s3: Make "endpoint_table" static
Andreas, this is only used in srv_epmapper right now. Make public again when
this will be used somewhere else.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Feb  6 21:33:04 CET 2011 on sn-devel-104
2011-02-06 21:33:04 +01:00
Stefan Metzmacher
17c01a5e90 s3:rpc_server/netlogon: reject validation level 6 without ads support
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Feb  4 10:06:26 CET 2011 on sn-devel-104
2011-02-04 10:06:26 +01:00
Günther Deschner
62048fa95c s3-waf: fix the build after epmapper changes.
Andreas, please check.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Feb  2 17:14:40 CET 2011 on sn-devel-104
2011-02-02 17:14:40 +01:00
Günther Deschner
50be0b2c1e s3: Remove superfluous ;
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Feb  2 15:44:21 CET 2011 on sn-devel-104
2011-02-02 15:44:21 +01:00
Andreas Schneider
d0d5d59943 s3-smbd: Disable the endpoint mapper by default. 2011-02-02 12:44:20 +01:00
Andreas Schneider
e3bdfd2d46 s3-smbd: Added a function to setup rpc services.
Move the complete setup of the rpc service to its own file and use
callbacks to register at the endpoint mapper.
2011-02-02 12:44:20 +01:00
Andreas Schneider
612060d677 s3-rpc_server: Only allow registering endpoints on priviledged pipes. 2011-02-02 12:44:20 +01:00
Andreas Schneider
bd5d14e6fa s3-epmapper: Commented unimplemented functions. 2011-02-02 12:44:20 +01:00
Andreas Schneider
c451a454b3 s3-epmapper: Improved the epm_Map function. 2011-02-02 12:44:20 +01:00
Andreas Schneider
1d33f5c6d6 s3-epmapper: Implemented epm_Lookup. 2011-02-02 12:44:20 +01:00
Andreas Schneider
5b93e06e6c s3-epmapper: Implemented epm_LookupHandleFree. 2011-02-02 12:44:20 +01:00
Andreas Schneider
3584dd18df s3-epmapper: Added arg to match uuid in build_ep_list(). 2011-02-02 12:44:20 +01:00
Andreas Schneider
658c05b939 s3-epmapper: Added epm_Map function from Samba4. 2011-02-02 12:44:20 +01:00
Andreas Schneider
6747b89b3c s3-epmapper: Added epm_Delete function. 2011-02-02 12:44:20 +01:00
Andreas Schneider
c31ee9a152 s3-epmapper: Added epm_Insert function. 2011-02-02 12:44:20 +01:00
Andreas Schneider
84995397a7 s3-epmapper: Added a endpoint mapper skeleton. 2011-02-02 12:44:20 +01:00
Stefan Metzmacher
4507d2b9eb s3:rpc_server/netlogon: add _netr_LogonSamLogon_check()
We need to check for invalid parameters before we check for
access denied.

metze
2011-02-02 11:58:26 +01:00
Stefan Metzmacher
1f83325261 s3:srv_spoolss: use dcerpc_spoolss_X() functions
metze

Signed-off-by: Andreas Schneider <asn@samba.org>
2011-01-21 12:30:22 +01:00
Günther Deschner
8db3258983 s3-spoolss: make it more obvious what winreg_create_printer() does.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 11:43:29 CET 2011 on sn-devel-104
2011-01-21 11:43:29 +01:00
Günther Deschner
be884c1bfd s3-spoolss: as smbtorture testing proves: devmode size is the size of the devicemode minus the driverdata extra size.
Jeremy, please check.

Guenther
2011-01-21 10:58:20 +01:00
Günther Deschner
9b1878e538 s3-spoolss: disallow storing an invalid devmode size.
Guenther
2011-01-21 10:58:20 +01:00
Günther Deschner
6feed0c9d2 s3-netlogon: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore.
Guenther
2011-01-18 23:54:31 +01:00
Günther Deschner
6ed4121d54 s3-netlogon: no need to include ../librpc/gen_ndr/cli_samr.h anymore.
Guenther
2011-01-18 23:54:31 +01:00
Jeremy Allison
7754b75065 Fix error where Windows client spoolss returns WERR_INVALID_DATA W_ERROR(0x0000000D)
on opening a printer. We can't return zero for devmode->size. Guenther please check !

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Jan 18 23:45:33 CET 2011 on sn-devel-104
2011-01-18 23:45:33 +01:00
Günther Deschner
d7af8753ab s3-waf: fix the build after rpc_winreg removal.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 14 11:38:40 CET 2011 on sn-devel-104
2011-01-14 11:38:40 +01:00
Günther Deschner
a451c54b3d s3-spoolss: no need to include cli_winreg header anymore.
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
2011-01-13 14:14:36 +01:00
Andreas Schneider
b17eb8256d s3-netlogon: Move to new dcerpc client funtions.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-01-10 18:20:55 +01:00
Andreas Schneider
8925b03b59 s3-rpcecho: Only register rpcecho in the developer build.
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Tue Jan  4 18:56:38 CET 2011 on sn-devel-104
2011-01-04 18:56:38 +01:00
Andreas Schneider
d2e93cce88 s3-waf: Fixed the static rpc service build.
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Tue Jan  4 12:09:48 CET 2011 on sn-devel-104
2011-01-04 12:09:48 +01:00
Günther Deschner
d0e164458d s3-spoolss: handle NTTIME(0) as "01/01/1601" REG_SZ in driver dates.
Guenther
2010-12-22 13:33:18 +01:00
Volker Lendecke
d096de56b1 s3: Remove unused "retry" from cli_full_connection 2010-12-20 17:10:58 +01:00
Günther Deschner
1b293c90be spoolss: fill in PerMachineConnections add and delete IDL.
Guenther
2010-12-16 10:52:50 +01:00
Stefan Metzmacher
e55426fe79 s3:rpc_client: let rpc_transport_tstream_init() create read and write queue
metze
2010-12-15 15:26:05 +01:00
Günther Deschner
5130e4a622 s3-waf: rework rpc_server handling a bit.
Guenther
2010-12-15 10:56:18 +01:00
Günther Deschner
8be11b2477 s3-waf: fix pam dependencies of the RPC_SAMR server.
Guenther
2010-12-07 11:49:57 +01:00
Günther Deschner
133a2ffd00 s3-waf: avoid module name uppercasing.
This finally allows mixed case module names like the classic build
(./configure --shared_modules=charset_CP850)

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Dec  1 18:39:14 CET 2010 on sn-devel-104
2010-12-01 18:39:14 +01:00
Günther Deschner
2b0905aeae s3-waf: convert RPC_LSARPC into a subsystem.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Dec  1 00:13:58 CET 2010 on sn-devel-104
2010-12-01 00:13:58 +01:00
Günther Deschner
c291195251 s3-waf: convert RPC_SAMR into a subsystem.
Guenther
2010-11-30 23:27:15 +01:00
Günther Deschner
5855194894 s3-spoolss: fix typo in debug message.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Nov 19 12:05:10 CET 2010 on sn-devel-104
2010-11-19 12:05:10 +01:00
Günther Deschner
98612fe793 s3-spoolss: make sure members of "BUILTIN\Print Operators" can open printers
with admin privileges.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Nov 17 15:05:02 UTC 2010 on sn-devel-104
2010-11-17 15:05:01 +00:00
Günther Deschner
ee8c035c41 s3-spoolss: add debug statement for access denied cases in OpenPrinterEx path.
Guenther
2010-11-17 15:20:15 +01:00
David Disseldorp
1c579318ae s3-spoolss: fix spoolss GetPrinterData behaviour
Windows sends spoolss GetPrinterData requests with an offered buffer
size of zero, Model and TrayFormTable data is commonly requested in
this way.

Samba's GetPrinterData response for the above case includes the correct
error code (WERR_MORE_DATA), however the type field is set to REG_NONE.
This causes Windows (seen on XP and 2k3) to give up on the request.

If the type field is retained (not set to REG_NONE) when responding with
WERR_MORE_DATA, Windows reissues the GetPrinterData request with an
increased offered buffer size.

Signed-off-by: Günther Deschner <gd@samba.org>
2010-11-10 15:23:22 +01:00
Jeremy Allison
f0dcc90f72 Fix bug 7781 - Samba transforms ShareName to lowercase (sharename) when adding new share via MMC
Change the find_service() interface to not depend on fstring, and
create a useable talloc-based interface.

Jeremy.
2010-11-10 01:14:17 +00:00
Jeremy Allison
9997ee813b Remove fstring from map_username. Create a more sane interface than the called-parameter-is-modified.
Jeremy.
2010-11-10 01:14:17 +00:00
Andrew Tridgell
986a00dcef s3-waf: fixed paths in s3 waf build for rpc_server
paths in waf rules are relative

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-10-25 11:12:03 +11:00
Jeremy Allison
272feb7bd1 Revert "Wrap security_token_has_privilege() with a check for lp_enable_privileges(). Needed"
Not needed - privileges code prevents "enable privileges = no" from adding privileges
anyway.

This reverts commit a8b95686a7.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct 22 23:41:36 UTC 2010 on sn-devel-104
2010-10-22 23:41:36 +00:00
Jeremy Allison
a8b95686a7 Wrap security_token_has_privilege() with a check for lp_enable_privileges(). Needed
to maintain compatibility with smb.conf manpage.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct 22 18:15:48 UTC 2010 on sn-devel-104
2010-10-22 18:15:48 +00:00
Günther Deschner
fa2a2d562f s3-waf: convert rpc into a subsystem.
Guenther
2010-10-19 18:26:59 +02:00
Andreas Schneider
a8f26f60ec s3-rpc_server: Normalize rpc_pipe_open_interface pipe name.
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Fri Oct 15 12:15:45 UTC 2010 on sn-devel-104
2010-10-15 12:15:45 +00:00
Andreas Schneider
f22e6cf3b7 s3-rpc_server: Make auth_serversupplied_info const. 2010-10-15 11:34:03 +00:00
Andrew Bartlett
170b345e0c s3-auth Use security_token_debug() from common code
This prints the security token including the privileges as strings
instead of just a bitmap.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-10-14 02:35:04 +00:00
Andrew Bartlett
deb7c02436 s3 Replace is_sid_in_token() with security_token_has_sid() from common code
The two routines are identical, so there is no need to keep both.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-10-14 02:35:04 +00:00
Andrew Bartlett
f768b32e37 libcli/security Provide a common, top level libcli/security/security.h
This will reduce the noise from merges of the rest of the
libcli/security code, without this commit changing what code
is actually used.

This includes (along with other security headers) dom_sid.h and
security_token.h

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Oct 12 05:54:10 UTC 2010 on sn-devel-104
2010-10-12 05:54:10 +00:00
Günther Deschner
33c6a4eb8a s3-spoolss: add more userlevel info validation to _spoolss_OpenPrinterEx.
Guenther
2010-10-11 14:31:06 +00:00
Günther Deschner
025290e9bf s3-spoolss: let set_printer_hnd_name return WERROR.
Guenther
2010-10-11 14:31:06 +00:00
Günther Deschner
c8a295ab7f s3-spoolss: convert open_printer_hnd to return WERROR.
Guenther
2010-10-11 14:31:06 +00:00
Günther Deschner
fe724c70d2 s3-spoolss: fix set_printer_hnd_name() to match torture test.
Guenther
2010-10-11 14:31:06 +00:00
Volker Lendecke
5e482aeebf s3: Implement echo_TestSleep 2010-10-08 21:11:45 +02:00
Günther Deschner
d8c86a7f77 s3-spoolss: make it possible to have and announce a [prnproc$] share on the printserver.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Oct  7 16:09:14 UTC 2010 on sn-devel-104
2010-10-07 16:09:14 +00:00
Günther Deschner
b7683a2c9d samr: for correctness, rename samr_RidTypeArray to samr_RidAttrArray.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Oct  7 12:04:32 UTC 2010 on sn-devel-104
2010-10-07 12:04:32 +00:00
Günther Deschner
71ab8f326b s3-samr: fix _samr_QueryGroupMember().
that array contains attributes, not sid types.

Guenther
2010-10-07 13:24:22 +02:00
Jeremy Allison
4618e25c95 Fix bug 7704 - Possible error in fix to rpc_server/srv_spoolss_nt.c.
From pjb1008@cam.ac.uk - Service numbers start from 0.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Oct  5 17:32:34 UTC 2010 on sn-devel-104
2010-10-05 17:32:34 +00:00
Günther Deschner
279e0c9610 spoolss: fill in spoolss_SetPort IDL.
Guenther
2010-10-04 09:29:47 +02:00
Volker Lendecke
da0ef65e04 s3: Remove talloc_autofree_context() from srv_samr_nt.c
The dispinfo structs need to survive within a process across pipe opens,
but they don't have a special destructor
2010-10-03 10:45:57 +02:00
Günther Deschner
d17a6f0493 s3-spoolss: Strip off ", DrvConvert" and ",LocalOnly" in OpenPrinterEx as seen from Win7 clients.
These suffixes and their meaning are not documented (yet).

Guenther
2010-10-02 00:42:52 +02:00
Andreas Schneider
455bbd5e1e s3-spoolss: Fixed print job access. 2010-10-02 00:04:45 +02:00