1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-05 09:18:06 +03:00
Commit Graph

2851 Commits

Author SHA1 Message Date
Matthias Dieter Wallnöfer
779d882aca s4:samldb LDB module - convert a "dsdb_module_search" into "dsdb_module_search_dn"
It saves us from checking the number of returned entries.

Reviewed-by: abartlet
2011-05-25 08:57:46 +02:00
Matthias Dieter Wallnöfer
11937ce5e1 s4:sam.py - uncomment/enhance some account type tests
Reviewed-by: abartlet
2011-05-25 08:57:42 +02:00
Matthias Dieter Wallnöfer
2ad0100d5b s4:samldb LDB modules - only objectClass "computer" is allowed to embed all types of account
Reviewed-by: abartlet
2011-05-25 08:57:35 +02:00
Matthias Dieter Wallnöfer
4740473591 s4:sam.py - tests for "isCriticalSystemObject" attribute
Reviewed-by: abartlet
2011-05-25 08:57:29 +02:00
Matthias Dieter Wallnöfer
0c753e503c s4:samldb LDB module - fix "isCriticalSystemObject" behaviour
Tests against Windows Server show that it gets set to "FALSE" (not
deleted) if we change the account type to a domain member.

Reviewed-by: abartlet
2011-05-25 08:57:24 +02:00
Matthias Dieter Wallnöfer
c72d32da6d s4:sam.py - unchanged "primaryGroupID" when account type remains the same
Enhance the testcase with a workstation example.

Reviewed-by: abartlet
2011-05-25 08:57:19 +02:00
Matthias Dieter Wallnöfer
b712c7273d s4:samldb LDB module - fix the behaviour when changing the "userAccountControl"
Ekacnet was not quite right yet but his patch made me think further.
This primary group changing is only needed if the account type changes.
With this patch we do one more search if the "userAccountControl"
changes but we save us from doing these unneeded and wrong modify replace
operations most of the time.

Reviewed-by: abartlet
2011-05-25 08:57:09 +02:00
Matthieu Patou
1b5c2d8e92 s4:sam.py - add tests to check that setting "userAccountValue" on usersdon't impact the "primaryGroupID" attribute
Notice: The domain administrators groups isn't referenced as "Domain Admins"
since this name could differ.

Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat May 21 19:19:57 CEST 2011 on sn-devel-104
2011-05-21 19:19:57 +02:00
Matthieu Patou
e3aa200a14 s4:samldb LDB module - don't change the "primaryGroupId" on LDB modifications unless we are a computer/dc/rodc
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
2011-05-21 16:25:12 +02:00
Matthias Dieter Wallnöfer
d34205add3 s4:ldb-samba/ldb_wrap.*-dsdb/samdb/samdb.c - handle LDB connection flags as unsigned
The LDB API ("ldb_connect") prescribes that they should be "unsigned".

Signed-off-by: Metze
2011-05-21 16:21:14 +02:00
Matthieu Patou
c2fa348831 s4-dsdb: add unit tests for dirsync control
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-05-21 16:25:19 +04:00
Matthieu Patou
fa400af18b s4-dsdb: implementation of the dirsync control
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-05-21 16:25:19 +04:00
Matthieu Patou
7b4e1e78be s4-dsdb: introduce dsdb_module_search_tree
With this function your own search tree can be specified

This function is similar to ldb_build_search_req_ex as it allows to
pass a parse tree structure.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-05-21 14:39:12 +04:00
Matthieu Patou
37b1662a38 s4-dsdb: relax a bit the checks on read acl when dirsync control is specified
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-05-21 14:39:12 +04:00
Matthieu Patou
1d0fc445fa s4-dsdb: create flag for requesting ACL relax in case of DIRSYNC request
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-05-21 14:39:12 +04:00
Matthieu Patou
df83e9c15e s4: do not change the critical flag when it's on a dirsync control
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-05-21 14:39:12 +04:00
Kamen Mazdrashki
a8798d8bce s4/drepl_fsmo: Add an CR so that message is visible in the logs
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed May 11 21:03:59 CEST 2011 on sn-devel-104
2011-05-11 21:03:59 +02:00
Andrew Bartlett
5d2ce400d2 s4-dsdb Add transactions to dsdb modify helpers 2011-05-08 17:36:26 +02:00
Andrew Tridgell
b96389d3e1 s4-socket: rename allow_access() to socket_allow_access()
this prevents a symbol collision with s3

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-05-03 07:37:07 +02:00
Andrew Bartlett
2742ec0e34 Remove strlower_m() and strupper_m() from source4 and common code.
This function is problematic because a string may expand in size when
changed into upper or lower case.  This will then push characters off
the end of the string in the s3 implementation, or panic in the former
s4 implementation.

Andrew Bartlett
2011-05-03 07:37:07 +02:00
Andrew Bartlett
cdd802af83 s4-messaging Rename messaging -> imessaging
This avoid symbol and structure conflicts between Samba3 and Samba4,
and chooses a less generic name.

Andrew Bartlett
2011-05-03 07:37:07 +02:00
Matthias Dieter Wallnöfer
bbf28703a4 s4:"ldb_connect" calls - proof for "!= LDB_SUCCESS"
Reviewed-by: abartlet
2011-04-29 19:05:04 +02:00
Matthias Dieter Wallnöfer
cc1cf31e55 s4:repl_meta_data LDB module - quiet a discard const ptr warning 2011-04-29 19:05:04 +02:00
Matthias Dieter Wallnöfer
3884fec3d5 s4:token_group.py python test - fix typos 2011-04-29 19:05:04 +02:00
Andrew Bartlett
67905b41a9 s4-param Rename private_path() -> lpcfg_private_path()
This is consistent with lock_path()

Andrew Bartlett
2011-04-29 16:38:14 +10:00
Jelmer Vernooij
0645c01b85 Fix case of libUTIL_LDB.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Apr 23 18:52:06 CEST 2011 on sn-devel-104
2011-04-23 18:52:06 +02:00
Matthieu Patou
85e8c86302 s4-dsdb: Add more information on why we don't check the SD control
Signed-off-by: Nadezhda Ivanova <nivanova@samba.org>

Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Fri Apr 15 16:16:27 CEST 2011 on sn-devel-104
2011-04-15 16:16:27 +02:00
Matthieu Patou
cf4a3081cb s4-dsdb: If current attribute list is empty use the one from the request
This will avoid overwritting attribute list made by upper modules.

Signed-off-by: Nadezhda Ivanova <nivanova@samba.org>
2011-04-15 16:28:08 +03:00
Andrew Bartlett
5694ba507c libcli/ldap pull LIBCLI_LDAP_MESSAGE and LIBCLI_LDAP_NDR into a library
This reduces symbol duplication

Andrew Bartlett
2011-04-13 11:47:36 +10:00
Matthias Dieter Wallnöfer
ddb41f2af4 dsdb:schema/schema_syntax.c - correctly check error code of "ldb_string_utc_to_time"
This one doesn't set ERRNO. An error happens if the result is "0".

Reviewed-by: abartlet
2011-04-07 15:53:20 +02:00
Matthias Dieter Wallnöfer
6cef940b40 dsdb:schema/schema_syntax.c - add some empty value checks on validate functions
They are needed since the check in "ldb_msg_sanity_check" will be removed.

Reviewed-by: abartlet
2011-04-07 15:53:20 +02:00
Matthias Dieter Wallnöfer
b7de06e8e7 s4:objectclass LDB module - "ldb_msg_sanity_check" call not really needed
This call should only be performed at the beginning of a request.
"ldb_msg_sanity_check" checks for DN validity (which should already have been
done at the beginning of the request) and empty attributes (which should
be done by the "objectclass_attrs" LDB module).

Hence it is superflous here.

Reviewed-by: abartlet
2011-04-07 15:53:20 +02:00
Matthias Dieter Wallnöfer
1d8980df04 s4:objectclass LDB module - fix a comment - add a ")"
Reviewed-by: abartlet
2011-04-07 15:53:19 +02:00
Andrew Tridgell
5f771b301d ldb: fixed --paged option in ldb tools
we were sometimes using 'paged_result' and sometimes using 'paged_results'.
The latter seemed to be more common, so I changed the two places that
used the 'paged_result' string to 'paged_results'
2011-04-07 10:51:30 +10:00
Stefan Metzmacher
b3bb983f25 s4:dsdb/repl_meta_data: update replPropertyMetaData on originating renames
The version of the "name" attribute needs to change even if the value
is the same. This also normalizes the rdn attribute name based on
the schema.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Apr  6 19:55:50 CEST 2011 on sn-devel-104
2011-04-06 19:55:49 +02:00
Stefan Metzmacher
4d5a2955a1 s4:dsdb/repl_meta_data: allow passing an explicit attribute list to replmd_update_rpmd()
This will be used for renames.

metze
2011-04-06 18:37:03 +02:00
Stefan Metzmacher
d622d21054 s4:dsdb/repl_meta_data: normalize the rdn attribute name based on the schema
metze
2011-04-06 18:37:01 +02:00
Matthieu Patou
0846b3c8a2 s4: Update/Set local USN only on attribute that have been modified/created
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-06 05:57:06 +02:00
Andrew Tridgell
f00d258a44 s4-dsdb: implemented creation of conflict records
when a record with the same DN gets created on two DCs at the same
time, this creates a replication conflict. To resolve this conflict
one of the DCs needs to create a conflict record, which is a rename of
one of the two DNs, based on which one is newer.

This prevents replication from failing when DCs are temporarily
disconnected and then have conflicts when they next replicate

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Apr  4 03:27:07 CEST 2011 on sn-devel-104
2011-04-04 03:27:06 +02:00
Andrew Tridgell
81f2dda626 s4-dsdb: added a ldb err -> NTSTATUS mapping
this is not perfect, but its better than always giving
NT_STATUS_UNSUCCESSFUL in our RPC servers

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-04-04 10:30:30 +10:00
Andrew Tridgell
26ccb6d5ed s4-dsdb: cope with failed searches in the linked attributes callback
This fixes a bug where we try to add an empty backlink because the
search for the forward link failed.

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Mar 31 13:37:36 CEST 2011 on sn-devel-104
2011-03-31 13:37:36 +02:00
Jeremy Allison
0c5214e2eb Ensure convert_string_XXX is always called with a valid converted_size pointer.
Preparation for cleaning up this API.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Mar 29 21:01:49 CEST 2011 on sn-devel-104
2011-03-29 21:01:49 +02:00
Andrew Tridgell
daeb6a02ea s4-dsdb: allow modification of linked attribute targets with relax
this is used to help recover a corrupt database. 

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 07:37:04 +02:00
Andrew Tridgell
b32f155bae s4-dsdb: perform FSMO transfers asynchronously
this gives the administrator a proper error message on the command
line

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 00:00:22 +02:00
Andrew Tridgell
358892e836 s4-fsmo: make rootDSE modify for FSMO transfer async
this gives the ldap client the error code from the transfer

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 00:00:22 +02:00
Andrew Tridgell
fdd9540187 s4-dsdb: only allow administrators to trigger FSMO role transfers
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-29 00:00:22 +02:00
Andrew Tridgell
15e84a9a09 charcnv: removed the allow_badcharcnv and allow_bad_conv options to convert_string*()
we shouldn't accept bad multi-byte strings, it just hides problems

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Mar 24 01:47:26 CET 2011 on sn-devel-104
2011-03-24 01:47:26 +01:00
Matthieu Patou
88d907189c pyldb: add more tests for control manipulation 2011-03-20 11:27:26 +01:00
Matthieu Patou
4a15c7e750 dsdb: read acl, sd can be null and ret == LDB_SUCCESS 2011-03-20 11:27:26 +01:00
Matthieu Patou
cbb0f881ac dsdb: acl_read fix a missed talloc_steal 2011-03-20 11:27:26 +01:00