1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

18464 Commits

Author SHA1 Message Date
Volker Lendecke
91adcd0bae r20046: Add ldb_search_exp_fmt and port comment to 4
(This used to be commit 1fe41c96f5)
2007-10-10 12:16:22 -05:00
Volker Lendecke
5b1f85a832 r20037: Reduce code size slightly by shuffling stuff around
(This used to be commit 0742faaacd)
2007-10-10 12:16:22 -05:00
Volker Lendecke
1710dd1fe2 r20036: Merge ldb_search_exp_fmt -- Thanks simo
(This used to be commit fa6fa1268b)
2007-10-10 12:16:21 -05:00
Jeremy Allison
490e3205bc r20035: Fix obvious horrible bug in falling back to MS-RPC
methods.
Jeremy.
(This used to be commit 7ac4ae4b51)
2007-10-10 12:16:21 -05:00
Volker Lendecke
2494868ffb r20020: Arglll... eventlogadm links against reg_db but not the rest of the registry
stuff. Revert the last change.

This needs better fixing.

Volker
(This used to be commit ad1e00430b)
2007-10-10 12:16:21 -05:00
Volker Lendecke
61bd0c8e45 r20019: Replace one set of tricky code by calls to another set of tricky code:
Initializing the reg_db now uses reg_createkey and reg_setvalue.

Volker
(This used to be commit cab5ccbbe4)
2007-10-10 12:16:21 -05:00
Volker Lendecke
b0a6049391 r20018: Fix a memleak in reg_createkey
(This used to be commit 281640823b)
2007-10-10 12:16:21 -05:00
Volker Lendecke
b676097927 r20017: Make srvsvc_NetShareAdd & friends take care of registry shares
(This used to be commit fc29a283cc)
2007-10-10 12:16:21 -05:00
Volker Lendecke
4a272ef0a8 r20016: Add two utility functions for easy opening/creating registry keys
(This used to be commit ad22a46718)
2007-10-10 12:16:20 -05:00
Volker Lendecke
fe34827ffd r20015: We have to zero out handle on key_close, otherwise the NT4 regedit will re-use the handle
(This used to be commit 0afd696f88)
2007-10-10 12:16:20 -05:00
Volker Lendecke
7299dc8b54 r20014: Ouch.... "res" is not a flag here, it is the service number...
(This used to be commit a4862f48d0)
2007-10-10 12:16:20 -05:00
Volker Lendecke
c6597384ba r20013: Fix segfaults: parm_error is a unique in/out ptr
(This used to be commit 0104371dd6)
2007-10-10 12:16:20 -05:00
Volker Lendecke
3f1978c059 r20012: Reformatting
(This used to be commit b32c65cb62)
2007-10-10 12:16:20 -05:00
Volker Lendecke
760056ec8d r20007: Fix a const warning just introduced
(This used to be commit 3da37287ca)
2007-10-10 12:16:19 -05:00
Volker Lendecke
fc030c313f r20006: Convert the registry shares to use the new API
(This used to be commit 66e889bbab)
2007-10-10 12:16:19 -05:00
Volker Lendecke
9690500e57 r20005: reg_open_path should become the replacement for regkey_open_internal.
(This used to be commit a6039eb46c)
2007-10-10 12:16:19 -05:00
Volker Lendecke
1a66ed34cd r20004: Remove a const, "name" is allocated anyway
(This used to be commit dc0300ec70)
2007-10-10 12:16:19 -05:00
Volker Lendecke
38cc572b1e r20003: Fix error message
(This used to be commit de05358351)
2007-10-10 12:16:19 -05:00
Volker Lendecke
d5e4b3bea8 r20001: Fix bug 4273, thanks to Pascal Terjan
(This used to be commit a2f5c92918)
2007-10-10 12:16:18 -05:00
Jeremy Allison
61ea96ec79 r19993: Fix the problem with Linux clients requesting O_WRONLY
on write-only files. Jim please check. Should not affect
Windows clients - I ensured all the relevent Samba4
torture tests still pass.
Jeremy.
(This used to be commit 6df3cac44f)
2007-10-10 12:16:18 -05:00
Paul Green
4eb9dda8a7 r19992: Add support to the tdb Makefile.in for executable extensions and for
separately specifying CPPFLAGS and LDFLAGS.
(This used to be commit 8c36f1a745)
2007-10-10 12:16:18 -05:00
Volker Lendecke
ecf90c495e r19991: Sorry for this 2000-liner...
The main thing here is a rewrite of srv_winreg_nt.c. The core functionality
has moved to registry/reg_api.c which is then usable by the rest of Samba as
well.

On that way it fixes creating keys with more than one element in the
path. This did not work before.

Two things that sneaked in (sorry :-) is the change of some routines from
NTSTATUS to WERROR the removed "parent" argument to regkey_open_internal.

Volker
(This used to be commit fea52801de)
2007-10-10 12:16:18 -05:00
Volker Lendecke
e57de5730c r19990: Fix comment
(This used to be commit 8b3d860f27)
2007-10-10 12:16:18 -05:00
Simo Sorce
dc2ed4c830 r19986: ooops
(This used to be commit 97f150fbbb)
2007-10-10 12:16:17 -05:00
Simo Sorce
c81c8cb4a7 r19984: Must have been drunk yesterday.
Freeing memctx is all we need, fix double free stupidity
(This used to be commit 2a7454959e)
2007-10-10 12:16:17 -05:00
Stefan Metzmacher
d908a897ed r19982: From Michael Adam (ma@sernet.de) (thanks!:-)
Metze: as noted by "shattered" and discussed on the irc,
  here is a patch to lib/sysquotas_linux.c replacing some
  "get"s by "set"s. The other lib/sysquotas*.c files look
  ok to me. But in the linux variant, the problem is not
  in the actual call of quotactl but in the preparation of
  the respective "D" structs. This makes the difference
  between the get and set calls for SMB_USER_FS_QUOTA_TYPE
  and SMB_GROUP_FS_QUOTA_TYPE.

metze
(This used to be commit d303cc7e62)
2007-10-10 12:16:17 -05:00
Simo Sorce
cb0402c2d3 r19980: Implement pam account stack checks when obey pam restrictions is true.
It was missing for security=server/domain/ads

Simo.
(This used to be commit 550f651499)
2007-10-10 12:16:17 -05:00
Simo Sorce
ef8d6bf5f7 r19979: Fix memleak on pw and change talloc_destroy to TALLOC_FREE for mem_ctx
(This used to be commit defa0a352b)
2007-10-10 12:16:17 -05:00
Volker Lendecke
e2bebe4865 r19978: More "net sam policy" improvements. Thanks to Karolin Seeger <ks@sernet.de>
Volker
(This used to be commit fde042f29e)
2007-10-10 12:16:17 -05:00
Gerald Carter
0d38f8af39 r19977: * Fix a crash in the secure DNS update code. Don't free
the host_principal memory while it is still being referenced
  by the gss code.
(This used to be commit 7a5a12e892)
2007-10-10 12:16:16 -05:00
Jeremy Allison
4c98afb2de r19975: Deal with 2 keytypes I messed previously (DR/DE).
Fix code that mistakenly assumed tdb_traverse
returned 0 or -1, it actually returns -1 or the
number of entries traversed. Add a static as another
way to return the bad cache value.
Jeremy.
(This used to be commit 5266a70ae9)
2007-10-10 12:16:16 -05:00
Jeremy Allison
913222d76a r19974: Add freelist check for cache. Fix testing of entry
names (all except SEQNUM are *not* null terminated
strings).
Jeremy.
(This used to be commit bcb68260ba)
2007-10-10 12:16:16 -05:00
Volker Lendecke
575845ccbe r19963: Add 'registry shares = yes' and registry key security descriptors.
(This used to be commit 6cab254c49)
2007-10-10 12:16:16 -05:00
James Peach
3fda843ac1 r19962: Revert bogus change in r19961. In future I will check configure.in
as well as Makefile.in :(
(This used to be commit 5d000fed59)
2007-10-10 12:16:16 -05:00
James Peach
1b25dd38c7 r19961: Remove VARDIR. Nothing is ever installed into this, so there's no
need to create it.
(This used to be commit f440efd961)
2007-10-10 12:16:15 -05:00
Jeremy Allison
cc13e21dbe r19959: Allow tdb to be built standalone in Samba3.
Add code to check for loops in the free list.
Should help us validate tdb's against corruption.
Jeremy.
(This used to be commit f8e7386773)
2007-10-10 12:16:15 -05:00
Jeremy Allison
2941b044b3 r19958: Add check for WINBIND_OFFLINE key.
Jeremy.
(This used to be commit 270e84db6d)
2007-10-10 12:16:15 -05:00
Jeremy Allison
ed34ffb147 r19957: Initial framework to make winbindd robust
against tdb corruption. Needs fleshing out
(and I forgot one record type) and needs helpful
suggestion from Volker to validate freelist,
but should give an idea of how this will look.
Jeremy.
(This used to be commit 8eb53f74e4)
2007-10-10 12:16:15 -05:00
Volker Lendecke
5893c0215d r19950: talloc_destroy is replaced these days
(This used to be commit b6bf2e4267)
2007-10-10 12:16:15 -05:00
Volker Lendecke
4a42371c20 r19948: Fix a memleak
(This used to be commit fd429c8c06)
2007-10-10 12:16:15 -05:00
Volker Lendecke
1c91cca86e r19947: Change regkey_open_internal to take the parent key and a talloc_ctx as
arguments. This also replaces regkey_close_internal by TALLOC_FREE.

Volker
(This used to be commit a177bbb2d5)
2007-10-10 12:16:14 -05:00
Volker Lendecke
443421828a r19946: in SetKeySec, sd is just a [in,ref] ptr
(This used to be commit 38a88ed5d7)
2007-10-10 12:16:14 -05:00
Volker Lendecke
d746c3b781 r19945: Fix a segfault -- lookup_rids needs to init the names even on failure
(This used to be commit eba404e668)
2007-10-10 12:16:14 -05:00
Volker Lendecke
dd813b6b29 r19944: Fix from Don Watson -- thanks
(This used to be commit c27e48594a)
2007-10-10 12:16:12 -05:00
Volker Lendecke
817151c87f r19943: Fix bug 4267 -- Thanks to David!
(This used to be commit 714971b34a)
2007-10-10 12:16:12 -05:00
Volker Lendecke
1c2ed58302 r19942: Fix Coverity id 333, a dereference before a NULL check.
Metze, you wanted to port talloc_get_type_abort() to 4. Should I just use it
in 3-ldb?

Volker
(This used to be commit ba0df1c915)
2007-10-10 12:16:12 -05:00
James Peach
760c7a6534 r19941: One copy of this code should be sufficient.
(This used to be commit 493ba681e5)
2007-10-10 12:16:11 -05:00
Gerald Carter
e6467907ed r19939: ,fix compile warning about unused functions when not using heimdal
(This used to be commit f53983079b)
2007-10-10 12:16:11 -05:00
Jeremy Allison
fb1430d6c9 r19936: Patch from Kai Blin <kai.blin@gmail.com> to
match Windows NTLMSSP flags.
Jeremy.
(This used to be commit 786318f84b)
2007-10-10 12:16:11 -05:00
Stefan Metzmacher
762b86ff0d r19935: always use discard_const_p() in lib/ldb/
metze
(This used to be commit 4a5da57306)
2007-10-10 12:16:11 -05:00
Volker Lendecke
15974508e8 r19932: Add some const
(This used to be commit be3c444c37)
2007-10-10 12:16:11 -05:00
Volker Lendecke
f1d492d11f r19930: Revert the winreg idl changes. At least enumkey does not work anymore today.
With more than 5 different trees I can't swear that I did test this properly
yesterday. Sorry for the noise.

Volker
(This used to be commit 978a6196bf)
2007-10-10 12:16:10 -05:00
Volker Lendecke
7ef185fae7 r19929: Fix indentation
(This used to be commit 2369ad0852)
2007-10-10 12:16:10 -05:00
Volker Lendecke
985248b638 r19928: Fix klokwork id 4509, 4573, 4574.
(This used to be commit c004d04181)
2007-10-10 12:16:10 -05:00
Volker Lendecke
78a0932145 r19927: Fix klokwork ID 4702
(This used to be commit 820a64af25)
2007-10-10 12:16:10 -05:00
Gerald Carter
16a076ae74 r19921: Add license and copyright info
(This used to be commit a3e1682ba3)
2007-10-10 12:16:10 -05:00
Volker Lendecke
8e8821b1da r19919: Convert winreg_EnumKey to use ref ** instead of a unique *.
Volker
(This used to be commit b714b51884)
2007-10-10 12:16:10 -05:00
Volker Lendecke
4a361ffd7f r19918: Convert winreg_CreateKey to use a ref ** instead of a unique *. W2k3 can still
create keys on Samba and vice versa.

Jelmer, please check.

Thanks,

Volker
(This used to be commit 1b460d6cdf)
2007-10-10 12:16:09 -05:00
Volker Lendecke
847644bdac r19917: Fix warnings
(This used to be commit cf4309b904)
2007-10-10 12:16:09 -05:00
Volker Lendecke
fb5d4f9c86 r19916: Fix some c++ warnings
(This used to be commit fb5bcb826e)
2007-10-10 12:16:09 -05:00
Volker Lendecke
2d6e409dc2 r19915: Fix two type-punned warnings
(This used to be commit f1266475da)
2007-10-10 12:16:09 -05:00
Volker Lendecke
f57cd1f63c r19914: The "default" value with the name "" need different 0-length treatment as the
other StringBufs, otherwise clicking on a key with this value being set leads
to regedit.exe on w2k3 chew all memory.
(This used to be commit b148cde7f3)
2007-10-10 12:16:09 -05:00
Volker Lendecke
213bc9d440 r19913: Fix a const warning
(This used to be commit a660993d14)
2007-10-10 12:16:08 -05:00
Volker Lendecke
b189e6d76e r19912: Move the subkey cache to srv_winreg_nt.c
(This used to be commit 01a53590a6)
2007-10-10 12:16:08 -05:00
Volker Lendecke
2685e167fa r19900: Fix klokwork ID 3148, 3149
(This used to be commit 1f3e20ef39)
2007-10-10 12:16:08 -05:00
Volker Lendecke
a12fb3afdd r19899: Fix some C++ warnings and klokwork ID 3147
(This used to be commit c5e041661e)
2007-10-10 12:16:08 -05:00
Volker Lendecke
ca3300cbd1 r19898: Fix klokwork ids 3127, 3128, 3129, 3130
(This used to be commit 3250d20d27)
2007-10-10 12:16:07 -05:00
Volker Lendecke
f6dece8b4d r19896: Fix klokwork id 2279
(This used to be commit 558a13a755)
2007-10-10 12:16:07 -05:00
Volker Lendecke
f494d7d31f r19895: Fix klokwork id 2278
(This used to be commit 8ccff6a4dd)
2007-10-10 12:16:07 -05:00
Volker Lendecke
40dc09e009 r19894: Fix klokwork id 2192
(This used to be commit 4b075f347b)
2007-10-10 12:16:06 -05:00
Volker Lendecke
7968602097 r19893: Fix klokwork id 2191
(This used to be commit a301a4a12d)
2007-10-10 12:16:05 -05:00
Volker Lendecke
7230ce8cd0 r19892: Fix klokwork id 2190
(This used to be commit 235e8c9653)
2007-10-10 12:16:05 -05:00
Volker Lendecke
76b2e7ba13 r19891: Fix klokwork id 2189
(This used to be commit b6933c3043)
2007-10-10 12:16:05 -05:00
Volker Lendecke
d128defd31 r19890: Fix klokwork ID 2188
(This used to be commit 4d44388929)
2007-10-10 12:16:04 -05:00
Volker Lendecke
433869019b r19889: Fix klokwork ID 2187
(This used to be commit 1bd660fb91)
2007-10-10 12:16:04 -05:00
Volker Lendecke
2a0e64e691 r19883: Fix bug 4248 -- thanks to Pascal Terjan :-)
(This used to be commit 66c20f2592)
2007-10-10 12:16:04 -05:00
James Peach
60936146d0 r19873: Make sure we are privileged when doing DMAPI operations on systems
that don't have capability support. Patch by J Raynor <raynorj@mn.rr.com>.
(This used to be commit 53fe047f35)
2007-10-10 12:16:03 -05:00
Volker Lendecke
015534e254 r19872: Move the value cache to srv_winreg_nt.c. Fix some minor issues found while
playing with regedit.exe.

Volker
(This used to be commit 81bd816fa2)
2007-10-10 12:16:03 -05:00
Volker Lendecke
3f62a1a3eb r19867: Introduce struct regkey_info in srv_winreg_nt.c to be able to re-add the
QueryValue and later the QueryKey cache independent of the backend.

Volker
(This used to be commit 0ed3a21fcc)
2007-10-10 12:16:03 -05:00
Volker Lendecke
6b0819e96c r19860: Streamline _winreg_QueryValue a bit. We've been pushing around memory
considerably here.

This temporarily removes a cache for the tdb based registry, I'll re-add that
in srv_winreg_nt.c in the next step.

This fixes creating/renaming values from the windows regedit.exe, as "New
Value #1" was not entering the cache after being created.

Volker
(This used to be commit c8c81f0e86)
2007-10-10 12:16:03 -05:00
Volker Lendecke
fb904d2299 r19858: Fix a memleak, add a const
(This used to be commit ed4dc40512)
2007-10-10 12:16:03 -05:00
Volker Lendecke
969a7faa7c r19853: Update a link
(This used to be commit ce44158dde)
2007-10-10 12:16:02 -05:00
James Peach
e2166a9fee r19851: Disable gcc PIE options on Darwin.
(This used to be commit 23795be8b4)
2007-10-10 12:16:02 -05:00
Jelmer Vernooij
19d7a9c315 r19849: Fix compilation after idl changes.
(This used to be commit b7f22408e9)
2007-10-10 12:16:02 -05:00
Jelmer Vernooij
4d708dfd2c r19848: Sync with Samba4 - no top-level unique pointers.
(This used to be commit 75515c5fda)
2007-10-10 12:16:02 -05:00
Volker Lendecke
7a19259051 r19841: Wrap regdb_store_keys and regdb_store_values in tdb transactions
(This used to be commit 5ec7379220)
2007-10-10 12:16:01 -05:00
Volker Lendecke
ca70f53930 r19840: Fix an uninitialized variable
(This used to be commit c4b5e8c7a0)
2007-10-10 12:16:01 -05:00
Volker Lendecke
9e29e5d2b8 r19839: Fix the build, we are not there yet :-)
(This used to be commit ff4123c8f2)
2007-10-10 12:16:01 -05:00
Volker Lendecke
45111ff1cb r19838: We have to delete the value record as well, otherwise the old values pop up
again if the key is re-created.

Volker
(This used to be commit f722f3341f)
2007-10-10 12:16:01 -05:00
Volker Lendecke
aad7194999 r19837: Some reformatting (Jerry, I hope you do not mind
(This used to be commit 6639f8c119)
2007-10-10 12:16:01 -05:00
Volker Lendecke
b724a28019 r19835: Some net sam policy improvements.
Thanks to Karolin Seeger <ks@sernet.de>

Volker
(This used to be commit 2091018a53)
2007-10-10 12:16:01 -05:00
Volker Lendecke
45fcd0f0b7 r19828: Add a helper function to pull *and* unparse local registry values
(This used to be commit 969eb9cda6)
2007-10-10 12:16:00 -05:00
Volker Lendecke
334c868b83 r19827: Move registry_push/pull_value to lib/util_reg.c
(This used to be commit 3047a4b92c)
2007-10-10 12:16:00 -05:00
Jim McDonough
807c50858f r19826: Fix typo
(This used to be commit fa656ce34e)
2007-10-10 12:16:00 -05:00
Volker Lendecke
6fad55ff89 r19825: To create a key, smbd also needs read privs assigned
(This used to be commit b2866b1318)
2007-10-10 12:16:00 -05:00
Volker Lendecke
c895111579 r19824: Fix the max value calculation in QueryInfoKey
(This used to be commit cd14b7f052)
2007-10-10 12:16:00 -05:00
Jeremy Allison
bb4fb75b22 r19823: "log" is an internal define in older versions of gcc.
Rename to log_ctx.
Jeremy.
(This used to be commit dbf0e58a1e)
2007-10-10 12:16:00 -05:00
Volker Lendecke
ef4112922a r19822: Implement net rpc registry createkey, deletekey and deletevalue
(This used to be commit 419ebc92f0)
2007-10-10 12:15:59 -05:00
Volker Lendecke
e56be1dead r19821: Make net_rpc_registry use net_run_function2.
Fix an erroneous NT_STATUS_NO_MEMORY found by Chetan S <cshring@gmail.com>.

Thanks :-)

Volker
(This used to be commit 30f02e73fd)
2007-10-10 12:15:59 -05:00
Volker Lendecke
eb96dddb28 r19820: Limit the stat cache to 1MB by default (Bug 4244). Thanks to Bjoern Jacke
<bj@sernet.de>

Volker
(This used to be commit b32c8356f7)
2007-10-10 12:15:59 -05:00
Volker Lendecke
ead21a53ae r19819: Windows returns an empty string instead of NULL here
(This used to be commit c1083216c8)
2007-10-10 12:15:59 -05:00
Volker Lendecke
c63be3a4e7 r19818: Remove reg_split_hive, make use of registry_openkey
(This used to be commit 7fd1578a90)
2007-10-10 12:15:58 -05:00
Volker Lendecke
28bbef032f r19817: Implement net rpc registry setvalue (only dword and sz so far)
(This used to be commit 9ecb69c075)
2007-10-10 12:15:58 -05:00
Volker Lendecke
3b5d82cedd r19812: dump_regval_buf is not needed anymore
(This used to be commit f24e64160d)
2007-10-10 12:15:57 -05:00
Volker Lendecke
202f63e476 r19811: Decode REG_MULTI_SZ and REG_BINARY
(This used to be commit 6793301751)
2007-10-10 12:15:57 -05:00
Gerald Carter
95bfb97547 r19809: remove winbind blacklist parameter
(This used to be commit 40cff14498)
2007-10-10 12:15:57 -05:00
Gerald Carter
932e95abde r19808: remove old smbwrapper references
(This used to be commit c142b629c8)
2007-10-10 12:15:57 -05:00
Volker Lendecke
515dea007a r19807: First attempt at wrapping something sane around the registry API. Will be
extended.

Volker
(This used to be commit 40922eb924)
2007-10-10 12:15:57 -05:00
Volker Lendecke
ef012f8e7a r19804: Fix a valgrind error
(This used to be commit cb9e16c838)
2007-10-10 12:15:57 -05:00
Volker Lendecke
ded7c032a3 r19803: Fix problem reported by Chetan S: QueryInfoKey needs to report the max name
length in *bytes* for UTF-16, not the string length. This got lost during the
conversion.

This took a while to figure out :-)

Thanks to Chetan!

Volker
(This used to be commit 8df6544fa8)
2007-10-10 12:15:56 -05:00
Gerald Carter
53c6548fbc r19800: * Remove exmpty aix directory
* remove old, commented out commands from 'make clean'
(This used to be commit 4c96a387a2)
2007-10-10 12:15:56 -05:00
Volker Lendecke
01367cdfd0 r19797: Convert the remaining pipes to the "new" unique out ptr handling
(This used to be commit bc4e0a388a)
2007-10-10 12:15:56 -05:00
Volker Lendecke
3372adce58 r19794: Convert DFS
(This used to be commit 2efd3b3509)
2007-10-10 12:15:56 -05:00
Volker Lendecke
28a01d3fdf r19793: Change the lsa calls to the new calling convention. Nobody uses the changed
calls yet.

Volker
(This used to be commit 144cddaef5)
2007-10-10 12:15:56 -05:00
Volker Lendecke
9849f04868 r19790: Check in the PIDL change and the converted unixinfo and winbind pipes without
waiting for comments. This is what version control is for, and it does fix a
segfault I ran into ;-)

Nevertheless, Jelmer & Jerry, please take a look!

Thanks,

Volker
(This used to be commit 95c14a822c)
2007-10-10 12:15:55 -05:00
Volker Lendecke
30db93664c r19786: My last checkin to winreg_StringBuf killed rpccli_winreg_EnumKeys against
W2k3. The server requires that size==0 in the [in] name. Somehow I get the
feeling that something is badly wrong here....

I did not yet recreate the gen_ndr equivalent, see next mail.

Volker
(This used to be commit 016ddce120)
2007-10-10 12:15:55 -05:00
Volker Lendecke
bfad442144 r19780: Ok, regkey_open_internal needs a regkey_close_internal. Giving a talloc ctx is
misleading here. This needs fixing properly :-)

Volker
(This used to be commit f808182346)
2007-10-10 12:15:55 -05:00
Volker Lendecke
76b320c8df r19779: Fail properly on talloc_strdup failure
(This used to be commit b57e446789)
2007-10-10 12:15:55 -05:00
Volker Lendecke
e82cd437cc r19778: Make regkey_open_internal take a talloc ctx
(This used to be commit cb7f4211b8)
2007-10-10 12:15:55 -05:00
Volker Lendecke
cbc03ec6df r19777: Make regsubkey_ctr_addkey return WERROR. Nobody checks this so far, but this
will change.

Volker
(This used to be commit 17c7c337f6)
2007-10-10 12:15:54 -05:00
Volker Lendecke
09ec562a09 r19776: Hmmm. I should have done one instead of three commits. Sorry :-)
(This used to be commit e2a35ceffe)
2007-10-10 12:15:54 -05:00
Volker Lendecke
9bb1f909fd r19775: Fix typo
(This used to be commit 370e29ebb9)
2007-10-10 12:15:54 -05:00
Volker Lendecke
e37200a82e r19774: Fix typo
(This used to be commit 842599a7fd)
2007-10-10 12:15:54 -05:00
Volker Lendecke
5e48602456 r19773: TALLOC_FREE checks for NULL itself
(This used to be commit fb3983ae1f)
2007-10-10 12:15:54 -05:00
Volker Lendecke
5f3b7ee713 r19766: Fix a const-warning. Jerry, what did you want to fix with this line?
Volker
(This used to be commit 55dc4741cf)
2007-10-10 12:15:54 -05:00
Gerald Carter
d596aa931b r19764: set version in 3.0 branch to 3.0.25
(This used to be commit d7179d945c)
2007-10-10 12:15:53 -05:00
Gerald Carter
c2aae726ea r19762: libaddns/*[ch] code fixes donated by Centeris Corporation
(http://www.centeris.com/) under my copyright.

* Rework error reporting to use DNS_ERROR instead
  of int32
* Convert memory allocation to use talloc()
* Generalize the DNS request/response packet marshalling
* Fix the secure update requests
(This used to be commit c787983336)
2007-10-10 12:15:53 -05:00
Gerald Carter
9a88644bb5 r19758: remove the LDAP_SCOPE_ONELEVEL define (not needed after svnup)
(This used to be commit e37132f219)
2007-10-10 12:15:53 -05:00
Gerald Carter
8fa0a80b49 r19754: * When using a krb5 session setup, we don't fill in the server_name
string the clis_state struct.  So call saf_store() after we
  have the short domain name in the lsa_query_inof_policy code.

* Remove unused server string in saf_delete()
(This used to be commit 3eddae2f20)
2007-10-10 12:15:53 -05:00
Lars Müller
f5a1ec7407 r19748: Ensure to link against the required libraries.
(This used to be commit 85d8c73fbb)
2007-10-10 12:15:53 -05:00
Lars Müller
571aca9927 r19747: Ensure to link with the required objects.
(This used to be commit 8d50fb3f51)
2007-10-10 12:15:52 -05:00
Stefan Metzmacher
9e7e5938ab r19744: merge from samba4
metze
(This used to be commit fe61e6ebf7)
2007-10-10 12:15:52 -05:00
Stefan Metzmacher
5a77ccfbfc r19741: fix compiler warnings
metze
(This used to be commit 18171cf54b)
2007-10-10 12:15:52 -05:00
Stefan Metzmacher
0fa75c6797 r19739: fix compiler warning
metze
(This used to be commit b7965ac26c)
2007-10-10 12:15:51 -05:00
Stefan Metzmacher
81cf0a5cd8 r19730: as libreplace always provides dlopen(), we need to always define SHLIBEXT
this fix the build on hpisgr8 HPUX 11.23

metze
(This used to be commit b61269d7e3)
2007-10-10 12:15:50 -05:00
Stefan Metzmacher
866a3b6e40 r19725: sync samba3's ldb with samba4
metze
(This used to be commit 207643e9c9)
2007-10-10 12:15:50 -05:00
Stefan Metzmacher
06715191dd r19718: define SHLIBEXT (prepare ldb merge from samba4)
metze
(This used to be commit d8f9c20055)
2007-10-10 12:15:49 -05:00
Jeremy Allison
8f723972ae r19710: Fix memory leak in get_conf_item_string(). As
we're just doing strchr on a const string there's
no need to strdup it before, we're never modifying
it. Just remove the variable "parm".
Jeremy.
(This used to be commit 1af18f613b)
2007-10-10 12:15:48 -05:00
Jeremy Allison
46e59a57eb r19709: Fix bug #4224 - deadtime timeout was broken
because of this. Probably a show-stopper for 3.0.23d.
Thanks to Alain GORLIER <alain.gorlier@altissemiconductor.com>
for the fix.
Jeremy.
(This used to be commit b167785cbd)
2007-10-10 12:15:48 -05:00
Jeremy Allison
d988af921d r19705: Fix blocker bug for 3.0.23d - find_forced_group could
return an uninitialized sid.
Jeremy.
(This used to be commit 57c60103e7)
2007-10-10 12:15:48 -05:00
Simo Sorce
b903eb231a r19703: Don't free a string if you want to return it!
(This used to be commit 3fed72ac3e)
2007-10-10 12:15:48 -05:00
Simo Sorce
4d12d3a5c8 r19692: Another fix.
(This used to be commit a86a56fed3)
2007-10-10 12:15:47 -05:00
Simo Sorce
cccf8f0633 r19691: Fix the build
(This used to be commit fd70972ad9)
2007-10-10 12:15:47 -05:00
Simo Sorce
750947dbe4 r19690: Remove this ancient module, I never realized it was ported over.
(This used to be commit 3ef6ef7cc8)
2007-10-10 12:15:47 -05:00
Volker Lendecke
64bab725f0 r19689: Fix a NULL dereference found by coverity (the call to strlen).
Jerry, please check this. The way I understood alpha_strcpy the last arg needs
to be the size of the target, not of the source.

Thanks,

Volker
(This used to be commit 287d68daab)
2007-10-10 12:15:47 -05:00
Volker Lendecke
82cd90292f r19688: Fix a deadcode warning by Coverity.
Simo, I'm not sure this is the correct fix. So I'd like you to look at it and
merge to 4 if appropriate.

Volker
(This used to be commit afd7f12124)
2007-10-10 12:15:47 -05:00
Volker Lendecke
bae1fcd20f r19687: Fix uninitialized variables found by Coverity (and gcc -O1... ;-))
Volker
(This used to be commit b7dc9b8169)
2007-10-10 12:15:47 -05:00
Volker Lendecke
782d33e1c8 r19686: Fix the build
(This used to be commit 28ac023581)
2007-10-10 12:15:46 -05:00
Volker Lendecke
3a1ada7635 r19685: Two changes inspired by problems with huge tdbs. tdbtool's list command now
prints the hash on every record for easier awk'ing, and tdbbackup allows a
different hash chain length on the backed up tdb.

Jeremy, Günther, this might be interesting for you huge domains. Not only
locking.tdb, also the winbind ones might grow huge.

In the installation I fixed with this winbind spent a huge amount of CPU
spinning through a degenerated winbindd_idmap.tdb with entries for more than
15.000 users. With a default number of hash chains of 131 on that tdb you can
imagine that the lists get large.

Not merging to 4, I don't get tdbbackup to compile there right now.

What about changing the global default hash chain number to be dramatically
larger? Disk is cheap these days.

Volker
(This used to be commit 577d0ff658)
2007-10-10 12:15:46 -05:00
Volker Lendecke
bef92ebb25 r19669: set_share_security does not need a mem_ctx passed
(This used to be commit 53eaa603eb)
2007-10-10 12:15:46 -05:00
Volker Lendecke
b6b84f98c0 r19668: Convert the locking params to use struct share_param instead of snum
(This used to be commit 609dbec600)
2007-10-10 12:15:46 -05:00
Volker Lendecke
5f3a692748 r19667: Fix incorrect null check
(This used to be commit dc9cdf37e9)
2007-10-10 12:15:46 -05:00
Volker Lendecke
dd8f8c01b7 r19666: Talloc_guide text on multithreading by Remi Turboult
(This used to be commit 36a7bf738a)
2007-10-10 12:15:45 -05:00
Volker Lendecke
b6fda7f8bd r19665: Fix a memleak
(This used to be commit bc6d4e5280)
2007-10-10 12:15:45 -05:00
Jeremy Allison
58406b0d1c r19659: Fix bug #4187. Possible crash in signing on/off code.
Jeremy.
(This used to be commit 78c1c43523)
2007-10-10 12:15:45 -05:00
Volker Lendecke
bf6bb74985 r19657: Correctly check for malloc failure
(This used to be commit e5b5c9b058)
2007-10-10 12:15:45 -05:00
Volker Lendecke
8371c0e44c r19656: Correctly check for malloc failure
(This used to be commit 3d0661b039)
2007-10-10 12:15:45 -05:00
Jim McDonough
3e8809cb4c r19655: Jeremy, please review:
I updated the vfs version in 3.0.24 from 16 to 17, beacuse 16 was the
latest released code, but on SAMBA_3_0, I reverted my earlier change
back from 19 to 18, because we've not had any released code with 18.

This is related to the kernel_flock call addition.
(This used to be commit fb8e43fb49)
2007-10-10 12:15:44 -05:00
Günther Deschner
c9567f2f22 r19652: Trying to track down which caller tries to store a 0 length domain name
in the affinity cache (which happens all the time here).

Guenther
(This used to be commit 45d6d30076)
2007-10-10 12:15:44 -05:00
Günther Deschner
61a38bd4b8 r19651: Fix interesting bug with the automatic site coverage in Active Directory:
When having DC-less sites, AD assigns DCs from other sites to that site
that does not have it's own DC. The most reliable way for us to identify
the nearest DC - in that and all other cases - is the closest_dc flag in
the CLDAP reply.

Guenther
(This used to be commit ff004f7284)
2007-10-10 12:15:44 -05:00
Jim McDonough
331cafd30f r19648: whoops, forgot to increment the vfs version number with the added flock
call.
(This used to be commit 1bc834455d)
2007-10-10 12:15:43 -05:00
Jim McDonough
4fe70bcee2 r19647: Add some GPFS support in a vfs mod. Also adds the kernel flock op to
the vfs layer, since gpfs supports it.  Thanks to Volker, Christian,
Mathias, Chetan, and Peter.
(This used to be commit 0620658890)
2007-10-10 12:15:43 -05:00
Günther Deschner
e513fb27d6 r19646: Fix memleak in the default_ou_string handling. Thanks to David Hu
<david.hu@hp.com>. Fixes #4212.

Guenther
(This used to be commit 4ec896cdbe)
2007-10-10 12:15:43 -05:00
Jeremy Allison
892d07b30b r19627: Fix for bug #4211 - logic error in acl_group_override()
function. Fix from Jim Wang of Wesoft.
Jeremy.
(This used to be commit eb78ce1f55)
2007-10-10 12:15:43 -05:00
James Peach
9a02736348 r19626: Coalesce usage of DUMP_CORE. Fix formatting on chdir error message
in core dump path.
(This used to be commit 9a51fba71c)
2007-10-10 12:15:42 -05:00
Jeremy Allison
ea705fb345 r19601: Fix protection from invalid struct tm values.
Backport from Samba4.
Jeremy.
(This used to be commit 02a0ac0bac)
2007-10-10 12:15:42 -05:00
Jelmer Vernooij
482603735d r19591: Use import' and include' in the IDL and regenerate.
(This used to be commit 68fc15a5e0)
2007-10-10 12:15:42 -05:00
Gerald Carter
cd41945acc r19579: BUG 4075: patch from Dmitry Butskoy <dmitry@butskoy.name>.
Allow smbd to use winbindd to lookup uids/gids outside the
idmap range if 'winbind trusted domains only = yes'
(This used to be commit 5b3ac400a7)
2007-10-10 12:15:42 -05:00
Jeremy Allison
f8fc3f9158 r19577: Fix from Nils Nordman for bug #4085. Thanks !
Jeremy.
(This used to be commit 3b5ab8ab82)
2007-10-10 12:15:42 -05:00
James Peach
3dcb61adcb r19576: Correct trivial typo.
(This used to be commit a0ada1aa34)
2007-10-10 12:15:42 -05:00
Jelmer Vernooij
2e1307bbc8 r19552: Fix names of known failing tests.
(This used to be commit b533620f04)
2007-10-10 12:15:41 -05:00
Jelmer Vernooij
ddc7dd256e r19542: Regenerate IDL.
(This used to be commit 759c1b0fd2)
2007-10-10 12:15:41 -05:00
Jeremy Allison
27c4b072b0 r19533: Add a suffix to the program name if this is a process with a
non-default configuration file name.
Jeremy.
(This used to be commit e8bf421c01)
2007-10-10 12:15:41 -05:00
Jeremy Allison
b7bf248985 r19529: Added showacls togle. Previously was vendor-specific code.
Merging these in - should have been merged back before (will
be tidied up later).
Jeremy.
(This used to be commit 1e9284590f)
2007-10-10 12:15:41 -05:00
Günther Deschner
31a63ab19f r19528: Fix container handling for "net ads user" and "net ads group" functions
along with some memleaks.

Guenther
(This used to be commit 4bad52c5b3)
2007-10-10 12:15:41 -05:00
Günther Deschner
4e0f560f60 r19527: Fix double free in "net ads group add".
Guenther
(This used to be commit 08db3d3b04)
2007-10-10 12:15:41 -05:00
Günther Deschner
6b65a1c26d r19526: Fix minor memleak.
Guenther
(This used to be commit 61ebedc82e)
2007-10-10 12:15:40 -05:00
Günther Deschner
25fb86570d r19525: Fix the same error in "net ads group delete".
Guenther
(This used to be commit 94ed3e9de8)
2007-10-10 12:15:40 -05:00
Günther Deschner
8a9c4331a3 r19524: Stop "net ads user delete" from doing funny things.
Guenther
(This used to be commit a20e7c0315)
2007-10-10 12:15:40 -05:00
Simo Sorce
2c14cf3b2b r19516: Fix the DN, to make searches using the domain as base
the DN must be rid,domain and not domain,rid

Also use member and not memberOf for group members
following conventions.
(This used to be commit 7c0ea791d2)
2007-10-10 12:15:40 -05:00
Gerald Carter
c101ce569d r19497: Thought I already fixes the etags target. Ignore .svn
and not CVS (since we don't use CVS anymore
(This used to be commit 782298cd03)
2007-10-10 12:15:40 -05:00
Günther Deschner
99433b1f7b r19494: When building with a static Heimdal, make sure not to link against
-lgssapi_krb5. With that change I could sucessfully verify that Heimdal
support is still working nicely after the changes from jpeach.

Guenther
(This used to be commit 53d09487a0)
2007-10-10 12:15:39 -05:00
Günther Deschner
78f977f746 r19493: There is no point in prompting for a user's password in "net ads" when
we can't find a domain controller at all.

Guenther
(This used to be commit e691ae7da3)
2007-10-10 12:15:39 -05:00
Simo Sorce
151237477b r19491: backport changes from samba4
(This used to be commit aa464c9fda)
2007-10-10 12:15:39 -05:00
Volker Lendecke
e6b56f9f0c r19487: Fix coverity # 313
(This used to be commit 0eb5a0f7b8)
2007-10-10 12:15:39 -05:00
Volker Lendecke
3a22bdf89e r19486: Probably Coverity is wrong here, but this fixes their ID 317. Not sure whether
to merge it to 4_0. I want it in 3_0 because it took a bit to persuade myself
that el can not be NULL here.

Volker
(This used to be commit c0c035b1c8)
2007-10-10 12:15:39 -05:00
Volker Lendecke
1fd4184da7 r19485: Fix Coverity # 319
(This used to be commit d9f1697c1f)
2007-10-10 12:15:38 -05:00
Volker Lendecke
16e98a60d1 r19484: Fix Coverity #329
(This used to be commit c3f860e55d)
2007-10-10 12:15:38 -05:00
James Peach
75018ad0cc r19477: Patch from Huang Dejin Eugene <hdejin@yahoo.com>.
Add configure option --enable-fam so that FAM support can explicitly
be controlled at build time. Default behaviour is to autodetect.
(This used to be commit 066951bc48)
2007-10-10 12:15:37 -05:00
Volker Lendecke
37ffa79139 r19469: Another user of NetShareEnum
(This used to be commit 3a1be1626c)
2007-10-10 12:15:37 -05:00
Volker Lendecke
24f7144930 r19468: Fix some potential NULL dereferences
(This used to be commit c8ed412976)
2007-10-10 12:15:37 -05:00
Volker Lendecke
ef05328552 r19451: Another cleanup of 18802. Referring to structures after the block has been
left is not a good idea.

Volker
(This used to be commit 88ac17db19)
2007-10-10 12:15:36 -05:00
Volker Lendecke
1c16e0d642 r19450: Fix smbtree's use of netshareenum.
Jelmer, how much of r18802 did you actually test??

Volker
(This used to be commit d0025861c0)
2007-10-10 12:15:36 -05:00
Volker Lendecke
2a10d76865 r19448: Convert delete_share_security to struct share_params plus some cleanups
(This used to be commit c73d0815a3)
2007-10-10 12:15:36 -05:00
Volker Lendecke
f916352de9 r19447: Do not throw away information
(This used to be commit 141e0dd717)
2007-10-10 12:15:36 -05:00
Volker Lendecke
f29a0d90a3 r19446: Comment can be NULL now
(This used to be commit f4dcb9bd56)
2007-10-10 12:15:36 -05:00
Volker Lendecke
0dab687fce r19445: Attempt to fix net rpc share
(This used to be commit 769988f83a)
2007-10-10 12:15:36 -05:00
Stefan Metzmacher
e7c14137fa r19444: merge from samba4:
reset trap when we have removed the test specifc files already

metze
(This used to be commit 36065025c7)
2007-10-10 12:15:35 -05:00
Andrew Tridgell
2729f448c0 r19431: merge recent talloc performance improvements from Samba4
(This used to be commit ced12bd6d8)
2007-10-10 12:15:35 -05:00
Andrew Tridgell
7a390a0dab r19430: merge recent ldb changes from Samba4. This includes memory leak fixes
and significant speedups
(This used to be commit bb5c205fef)
2007-10-10 12:15:35 -05:00
Andrew Tridgell
aa3ca346d8 r19429: moved tdb/common/tdbutil.c into lib/util_tdb.c
see discussion on samba-technical
(This used to be commit 1ad563286f)
2007-10-10 12:15:35 -05:00
Andrew Tridgell
7d52581978 r19426: merge nearly all the differences between Samba3 tdb and Samba4
tdb. This includes:

 - the new tdb_lockall and tdb_lockall_read code, which will be needed
   for the ldb speedups

 - the tdb logging changes. This is an intermediate step to keep the
   differences between the two branches small. The plan is still to
   move to a tdb_init()/tdb_set_logging_function()/tdb_attach() style
   of open which will make things much cleaner.

 - the updated test suites and standalone tdb build code

 - use libreplace headers

There are still some small differences I haven't merged. I'll discuss
those on the list.
(This used to be commit 48903c75ed)
2007-10-10 12:15:35 -05:00
Jeremy Allison
3da4607374 r19424: Protect against username == NULL
Jeremy.
(This used to be commit 78b14de27a)
2007-10-10 12:15:34 -05:00
Jeremy Allison
f58f146834 r19422: Doh ! Put the krb5 user@realm code in the right place.
Jeremy.
(This used to be commit a31bbbaee1)
2007-10-10 12:15:34 -05:00
Gerald Carter
6e2b290672 r19421: BUG 3868: Patch from Timur Bakeyev <timur@com.bat.ru> to prevent
--with-aio-support from trimping on the $LIBS variable
(This used to be commit 00bf29d352)
2007-10-10 12:15:34 -05:00
Gerald Carter
80d40172ef r19420: Remove strequal and use strcmp() instead. Meant to
make the change before theprevious commit.
(This used to be commit 815388c4c8)
2007-10-10 12:15:34 -05:00
Gerald Carter
2145eff91d r19419: BUG 4109: Patch from Timur Bakeyev. Fix bug causing smbd to turn off
winbindd and fail to disable the _NO_WINBIND environment.
(This used to be commit a6366b40b3)
2007-10-10 12:15:34 -05:00
Gerald Carter
7ac5df4824 r19417: BUG 3856: patch from Timur Bakeyev <timur@com.bat.ru> to include setting the nss soname version on FreeBSD
(This used to be commit e1490e72ea)
2007-10-10 12:15:33 -05:00
Günther Deschner
a2dfdfbf86 r19416: Fix some c++ warnings.
Guenther
(This used to be commit b076c39b6a)
2007-10-10 12:15:33 -05:00
Günther Deschner
1e86361080 r19415: oh la la, always compile before commit, I'm very sorry.
Guenther
(This used to be commit bdd2e0361c)
2007-10-10 12:15:33 -05:00
Günther Deschner
9034063617 r19414: gencache is getting really important now, make sure that lp_lockdir
always exists so that the gencache.tdb can get created there.

Guenther
(This used to be commit e5ed286125)
2007-10-10 12:15:33 -05:00
Jeremy Allison
e070996cc3 r19413: Now we're calling init_dc_connection, this code
is completely useless (and in fact harmful :-) in
that it causes a winbindd error where there should
be none.
Jeremy.
(This used to be commit acf5419d62)
2007-10-10 12:15:33 -05:00
Jeremy Allison
d273a2ef1d r19399: Now Guenther discovered one crash dereferencing domain->backends,
get paranoid. I don't think this can really happen, but let's be
sure.
Jeremy.
(This used to be commit be4709984b)
2007-10-10 12:15:33 -05:00
Günther Deschner
5afaa37662 r19394: When we fail to get the list of trusted domains, make sure to return
WINBINDD_ERROR.

Guenther
(This used to be commit 6089b3007b)
2007-10-10 12:15:32 -05:00
Günther Deschner
edba79e500 r19391: Fix crash bug within the winbind caching method.
That one was hard to find: when coming from offline mode and switching
to online, a refresh sequence number call (using the default MS-RPC
mechanism) may reset domain->backend to NULL (by the set_domain_online
event). We need to make sure to reidentify the remote domain in that
case.

Guenther
(This used to be commit 4d6503d137)
2007-10-10 12:15:32 -05:00
Jelmer Vernooij
ea032c024d r19390: Add some tests that are known failing against samba3.
(This used to be commit 6ff2ad4246)
2007-10-10 12:15:32 -05:00
James Peach
09ead9c8fa r19386: Limit the size of the connection bitmap to <64K entries.
(This used to be commit 9f0518e0b0)
2007-10-10 12:15:32 -05:00
James Peach
322863b392 r19385: These replaced symbols should have a rep_ prefix.
(This used to be commit decdb46a3f)
2007-10-10 12:15:32 -05:00
Stefan Metzmacher
74bb9cb3bd r19374: fix the build with heimdal
metze
(This used to be commit a813c75955)
2007-10-10 12:15:32 -05:00
Günther Deschner
21344a731c r19371: Add two missing refresh_sequence_number calls where they are missing
just before writing to the winbind cache tdb.

Guenther
(This used to be commit bd8548998b)
2007-10-10 12:15:32 -05:00
Günther Deschner
257c5c095b r19368: Use WINBINDD_CACHE_TDB_DEFAULT_HASH_SIZE whereever the winbindd tdb is
opened.

Guenther
(This used to be commit 49e9e1a3e7)
2007-10-10 12:15:31 -05:00
Günther Deschner
dbcb4b1266 r19355: Add getdispenumindex2 wrapper for rpcclient.
Guenther
(This used to be commit 27c35848eb)
2007-10-10 12:15:31 -05:00
Günther Deschner
8b31fccafe r19354: adjust usage printf for rpcclient's timeout command.
Guenther
(This used to be commit fb21c9c58b)
2007-10-10 12:15:31 -05:00
Günther Deschner
fb183ebd92 r19353: Add "timeout" command for rpcclient.
Guenther
(This used to be commit 4106a56d3f)
2007-10-10 12:15:30 -05:00
Günther Deschner
b26b8f95e9 r19351: Also export the info3 profilepath via the PAM_WINBIND_PROFILEPATH data
field.

Guenther
(This used to be commit 66b92f27fa)
2007-10-10 12:15:30 -05:00
Günther Deschner
da6e42b47f r19349: Fix invalid free on the PAM_WINBIND_PWD_LAST_SET data.
Guenther
(This used to be commit a4d17ee9c9)
2007-10-10 12:15:30 -05:00
Günther Deschner
e42f449fcc r19348: Fix uninitialized dictionary handle, found by valgrind.
Guenther
(This used to be commit 9621bb420a)
2007-10-10 12:15:30 -05:00
Stefan Metzmacher
2bc3099c71 r19342: we only have one BASE-LOCK test in samba4's smbtorture now
metze
(This used to be commit a2c20811d6)
2007-10-10 12:15:29 -05:00
Günther Deschner
258f7b50dc r19340: Wait longer then 10 seconds for a samr_query_groupmem lookup to succeed.
Guenther
(This used to be commit 37dd019e21)
2007-10-10 12:15:29 -05:00
Jeremy Allison
25cba8669d r19302: Use TALLOC_ZERO_P not TALLOC_P to ensure unused
fields are initialized to zero.
Jeremy.
(This used to be commit 8a0ff70e8e)
2007-10-10 12:15:29 -05:00
Jeremy Allison
76022f73d6 r19301: Correct debug statement.
(This used to be commit 3ea8399bc9)
2007-10-10 12:15:29 -05:00
Jeremy Allison
4a942c592a r19300: Fix null deref in debug statement.
Jeremy.
(This used to be commit c55b9111f6)
2007-10-10 12:15:29 -05:00
Volker Lendecke
7b9ef5e840 r19292: Avoid some potential segfaults: In winreg_EnumValue all pointers are unique
pointers and can thus be independently NULL.

Thanks,

Volker
(This used to be commit d48ac0726a)
2007-10-10 12:15:29 -05:00
Stefan Metzmacher
6ec00affb6 r19291: this should fix the build on heimdal systems
metze
(This used to be commit 785ab128c4)
2007-10-10 12:15:28 -05:00
Volker Lendecke
99cf1bef10 r19290: regedit running on nt4 will cut off the last character from a enumkey without
this patch. Jerry, Jelmer, can you please check this?

Thanks,

Volker
(This used to be commit ed95fe3c63)
2007-10-10 12:15:28 -05:00
Volker Lendecke
f799df03d4 r19288: tdb_prs_store is right now used to store printer and share security
descriptors. Both databases are long-lived and not frequently written, so I
think storing it deserves a tdb transaction.

Volker
(This used to be commit 2d4b5f5727)
2007-10-10 12:15:28 -05:00
Volker Lendecke
7d2aa0d3f1 r19287: As requested by Bjoern Jacke <bjoern@j3e.de>: Check in the NetBSD winbind module by Luke
Mewburn.

Volker
(This used to be commit 104f5e9ec9)
2007-10-10 12:15:28 -05:00
James Peach
2e46e9189a r19286: Remove dependency on Fink. If we really *need* anything from Fink,
this shold be a strong dependency. If stuff from Fink is an optional
extra, there should be a --with-stuff-from-fink argument. It's just
too easy to unexpectedly end up with binaries that depend on
/sw/{lib,include}.
(This used to be commit d0166e1172)
2007-10-10 12:15:28 -05:00
Jeremy Allison
94d565b36b r19272: Ensure we return 1 member in the optimized case.
(This used to be commit cc6cdabf19)
2007-10-10 12:15:28 -05:00
Jeremy Allison
25f0f624f8 r19271: Test the "hack" for "Domain Users" as agreed with
Jerry.
If "enum users" is set to false, and the group being looked
up is the Domain Users SID: S-1-5-domain-513, then for the
list of members check if the querying user is in that group,
and if so only return that user as the gr_mem array.
We can change this to a different parameter than "enum users"
if neccessaey, or parameterize the group list we do this for.
Jeremy.
(This used to be commit 91b40e25cc)
2007-10-10 12:15:27 -05:00
James Peach
876be25055 r19270: Stop depending on internal MIT symbols. These are private on MacOS
x, so we can't get at them even if we wanted to.

Kerberos experts, please take a look to make sure I've done the
right thing!
(This used to be commit 9b8e179fcc)
2007-10-10 12:15:27 -05:00
Günther Deschner
424d7640b8 r19263: Be more accurate in telling what the sitename problem is in this DEBUG
statement.

Guenther
(This used to be commit 62928734b8)
2007-10-10 12:15:26 -05:00
Jeremy Allison
0c72a09e7d r19260: Fix for bug #3524 from tiamat@komi.mts.ru - Solaris quotas.
Jeremy.
(This used to be commit ac510a90f3)
2007-10-10 12:15:26 -05:00
Jeremy Allison
a0c84f1b12 r19257: Janitor for Guenther - as well as a little massaging to make
his patch fit SAMBA_3_0. (This is guenthers code). Make
site support work correctly in net ads join.
Jeremy.
(This used to be commit 47352b5398)
2007-10-10 12:15:26 -05:00
Günther Deschner
7399ab779d r19255: Add blacklist of accounts when NSS initgroups calls are coming in and
"winbind use default domain" is set. Defaults to "root, nobody, lp"
currently.

Guenther
(This used to be commit b5b42196a6)
2007-10-10 12:15:26 -05:00
Günther Deschner
96869053a5 r19254: Make sure to also wait 35 seconds to receive a Netlogon GETDC reply
here in winbindd_getdcname().

Guenther
(This used to be commit 58a181edc5)
2007-10-10 12:15:26 -05:00
Derrell Lipman
c7864f3d53 r19250: Fixes bug 4156.
The protocol negotiation string "LANMAN2.1" was not listed in the set of
negotiatiable possibilities, so non-optimal negotiation was taking place.
(This used to be commit a0dfa60fc5)
2007-10-10 12:15:25 -05:00
Jeremy Allison
37be6913fe r19249: Attempt to fix a site lookup bug found by Guenther.
- "The problem is, with a fresh system, we don't know our sitename,
therefor we do a stupid DNS query for all DCs. The reply we get is a
round-robin list of all 21 DCs, we just pick the first, contact that
and safe that INET.COM#1C query in the name cache for later use...
What we need to do if we don't yet know our sitename, is to contact to
any DC, get the CLDAP reply to tell us in which site we are, then flush
the namecache and requery DNS including the sitename"

Implement the flushing of the #1C entries for a given NetBIOS name/realm
when looking up the site value.

Jeremy.
(This used to be commit b2d1e44f59)
2007-10-10 12:15:25 -05:00
Volker Lendecke
a0dd125859 r19248: Activate RPC-SAMBA3-WKSSVC
(This used to be commit ed6070b7a0)
2007-10-10 12:15:25 -05:00
Stefan Metzmacher
f9f3a2d790 r19246: merge from samba4 rev 18207 and 18208:
readline fixes for mac os 10

metze
(This used to be commit 976b97ecbf)
2007-10-10 12:15:25 -05:00
Stefan Metzmacher
51994b35f1 r19244: fix the build on systems with broken krb5
we need to make sure

HAVE_GSSAPI

HAVE_KRB5_H
HAVE_GSSAPI_H
HAVE_GSSAPI_GSSAPI_GENERIC_H
HAVE_GSSAPI_GSSAPI_H

are not in config.h

this adds 2 new macros to libreplace
AC_REMOVE_DEFINE(), AC_REMOVE_INCLUDE()

metze
(This used to be commit eb1f0b49cf)
2007-10-10 12:15:25 -05:00
Günther Deschner
06ea7f144a r19243: Fix debug statement.
Guenther
(This used to be commit 4b9d79147a)
2007-10-10 12:15:25 -05:00
Stefan Metzmacher
1843884fbf r19241: compile xattr wrappers on mac os 10
patch from Bjoern Jacke and it fixes bug 3698

metze
(This used to be commit e54302b916)
2007-10-10 12:15:24 -05:00
Stefan Metzmacher
9830fc431b r19240: move the NO_CONFIG_H check to libreplace
this fixes the quota detection configure and maybe more
configure tests

metze
(This used to be commit a3a082c42c)
2007-10-10 12:15:24 -05:00
Stefan Metzmacher
960894349f r19239: make the acl configure check more readable...
metze
(This used to be commit 0882f0c9d6)
2007-10-10 12:15:24 -05:00
Stefan Metzmacher
6c1eaffd2e r19238: Let the comfigure check find that some krb5 functions
are missing! Bailing out at compile time is ugly.

Hopefully this fixes the Mac OS 10 boxes in the build-farm
there're some missing function. Fixing that is a different
problem...

metze
(This used to be commit e00a83a0b6)
2007-10-10 12:15:24 -05:00
Stefan Metzmacher
bbefb74bca r19237: fix typo
metze
(This used to be commit d91041d4b6)
2007-10-10 12:15:24 -05:00
Stefan Metzmacher
1cbaa09ffc r19236: prepare for --with-pam=auto as default
but still leave --with-pam=no the default for now
and wait for discussion on samba-technical

metze
(This used to be commit b045d5afcf)
2007-10-10 12:15:24 -05:00
Stefan Metzmacher
f455951e1e r19235: merge from samba4:
fix configure test for net/if.h on some platforms

AC_LANG_SOURCE() adds the content of confdefs.h in front
of the compiled file

metze
(This used to be commit 7cbdc06ad9)
2007-10-10 12:15:23 -05:00
Stefan Metzmacher
fc15a2ae5f r19233: remove unused --with-spinlocks option
the defines are not used anywhere in the tree.
(grep -R SPINLOCKS . in the topdir)

metze
(This used to be commit 1697686d9d)
2007-10-10 12:15:23 -05:00
Stefan Metzmacher
2c2728b8a7 r19232: merge from samba4:
- machine/sys/getppdp.h workaround for HPUX 11.23
- more verbose check for net/if.h

metze
(This used to be commit 9b5c5bc3f3)
2007-10-10 12:15:23 -05:00
Derrell Lipman
2db5ed7fa5 r19231: I encountered a WinXP/Home system which, acting as the master browser for its
workgroup, decided periodically to stop sending recognized responses to a
NetServerEnum2 request for the workgroup.  Instead of returning the list of
servers (only itself; nothing else in the workgroup), it returns a status code
of 8 which is unsupported by samba3, samba4, and ethereal.

The code for this request assumed that if an unexpected status code was
received, the connection had a problem, i.e. that cli_errno() would show a
problem.  That turns out not to be the case.

This patch changes the behavior so tha any time a response is received and
cli_errno() == 0, we continue processing the reply and base our response on
the returned count (zero).  The pre-existing code then converts this count=0
into an ENOENT errno which can be properly handled by the application (whereas
an error return with errno=0 can't be).

This packet dump has only 2 frames.  Sorry about the text version but it's
most easily attached to this log message.  I also have it saved as .pcap if
anyone wants it.

Derrell

No.     Time            Source                Destination           Protocol Info
      1 14:31:59.802668 192.168.1.106         192.168.1.100         LANMAN   NetServerEnum2 Request, Server, SQL Server, Domain Controller, Backup Controller, Time Source, Apple Server, Novell Server, Domain Member Server, Print Queue Server, Dialin Server, Xenix Server, NT Workstation, Windows for Workgroups, Unknown server type:14, NT Server

Frame 1 (196 bytes on wire, 196 bytes captured)
    Arrival Time: Oct 10, 2006 14:31:59.802668000
    Time delta from previous packet: 0.000000000 seconds
    Time since reference or first frame: 0.000000000 seconds
    Frame Number: 1
    Packet Length: 196 bytes
    Capture Length: 196 bytes
    Protocols in frame: eth:ip:tcp:nbss:smb
Ethernet II, Src: IntelCor_4a:47:bb (00:13:20:4a:47:bb), Dst: Micro-St_74:16:e7 (00:0c:76:74:16:e7)
    Destination: Micro-St_74:16:e7 (00:0c:76:74:16:e7)
    Source: IntelCor_4a:47:bb (00:13:20:4a:47:bb)
    Type: IP (0x0800)
Internet Protocol, Src: 192.168.1.106 (192.168.1.106), Dst: 192.168.1.100 (192.168.1.100)
    Version: 4
    Header length: 20 bytes
    Differentiated Services Field: 0x00 (DSCP 0x00: Default; ECN: 0x00)
        0000 00.. = Differentiated Services Codepoint: Default (0x00)
        .... ..0. = ECN-Capable Transport (ECT): 0
        .... ...0 = ECN-CE: 0
    Total Length: 182
    Identification: 0xb838 (47160)
    Flags: 0x04 (Don't Fragment)
        0... = Reserved bit: Not set
        .1.. = Don't fragment: Set
        ..0. = More fragments: Not set
    Fragment offset: 0
    Time to live: 64
    Protocol: TCP (0x06)
    Header checksum: 0xfdea [correct]
        Good: True
        Bad : False
    Source: 192.168.1.106 (192.168.1.106)
    Destination: 192.168.1.100 (192.168.1.100)
Transmission Control Protocol, Src Port: 44932 (44932), Dst Port: netbios-ssn (139), Seq: 851982066, Ack: 1274726157, Len: 130
    Source port: 44932 (44932)
    Destination port: netbios-ssn (139)
    Sequence number: 851982066
    Next sequence number: 851982196
    Acknowledgement number: 1274726157
    Header length: 32 bytes
    Flags: 0x0018 (PSH, ACK)
        0... .... = Congestion Window Reduced (CWR): Not set
        .0.. .... = ECN-Echo: Not set
        ..0. .... = Urgent: Not set
        ...1 .... = Acknowledgment: Set
        .... 1... = Push: Set
        .... .0.. = Reset: Not set
        .... ..0. = Syn: Not set
        .... ...0 = Fin: Not set
    Window size: 6432
    Checksum: 0xb4e0 [correct]
    Options: (12 bytes)
        NOP
        NOP
        Time stamp: tsval 1184074739, tsecr 11576161
NetBIOS Session Service
    Message Type: Session message
    Flags: 0x00
        .... ...0 = Add 0 to length
    Length: 126
SMB (Server Message Block Protocol)
    SMB Header
        Server Component: SMB
        Response in: 2
        SMB Command: Trans (0x25)
        NT Status: STATUS_SUCCESS (0x00000000)
        Flags: 0x08
            0... .... = Request/Response: Message is a request to the server
            .0.. .... = Notify: Notify client only on open
            ..0. .... = Oplocks: OpLock not requested/granted
            ...0 .... = Canonicalized Pathnames: Pathnames are not canonicalized
            .... 1... = Case Sensitivity: Path names are caseless
            .... ..0. = Receive Buffer Posted: Receive buffer has not been posted
            .... ...0 = Lock and Read: Lock&Read, Write&Unlock are not supported
        Flags2: 0xc801
            1... .... .... .... = Unicode Strings: Strings are Unicode
            .1.. .... .... .... = Error Code Type: Error codes are NT error codes
            ..0. .... .... .... = Execute-only Reads: Don't permit reads if execute-only
            ...0 .... .... .... = Dfs: Don't resolve pathnames with Dfs
            .... 1... .... .... = Extended Security Negotiation: Extended security negotiation is supported
            .... .... .0.. .... = Long Names Used: Path names in request are not long file names
            .... .... .... .0.. = Security Signatures: Security signatures are not supported
            .... .... .... ..0. = Extended Attributes: Extended attributes are not supported
            .... .... .... ...1 = Long Names Allowed: Long file names are allowed in the response
        Process ID High: 0
        Signature: 0000000000000000
        Reserved: 0000
        Tree ID: 2048
        Process ID: 12967
        User ID: 2048
        Multiplex ID: 6
    Trans Request (0x25)
        Word Count (WCT): 14
        Total Parameter Count: 36
        Total Data Count: 0
        Max Parameter Count: 8
        Max Data Count: 65535
        Max Setup Count: 0
        Reserved: 00
        Flags: 0x0000
            .... .... .... ..0. = One Way Transaction: Two way transaction
            .... .... .... ...0 = Disconnect TID: Do NOT disconnect TID
        Timeout: Return immediately (0)
        Reserved: 0000
        Parameter Count: 36
        Parameter Offset: 90
        Data Count: 0
        Data Offset: 126
        Setup Count: 0
        Reserved: 00
        Byte Count (BCC): 63
        Transaction Name: \PIPE\LANMAN
SMB Pipe Protocol
Microsoft Windows Lanman Remote API Protocol
    Function Code: NetServerEnum2 (104)
    Parameter Descriptor: WrLehDz
    Return Descriptor: B16BBDz
    Detail Level: 1
    Receive Buffer Length: 65535
    Server Type: 0x0000fffe
        .... .... .... .... .... .... .... ...0 = Workstation: This is NOT a Workstation
        .... .... .... .... .... .... .... ..1. = Server: This is a Server
        .... .... .... .... .... .... .... .1.. = SQL: This is an SQL server
        .... .... .... .... .... .... .... 1... = Domain Controller: This is a Domain Controller
        .... .... .... .... .... .... ...1 .... = Backup Controller: This is a Backup Controller
        .... .... .... .... .... .... ..1. .... = Time Source: This is a Time Source
        .... .... .... .... .... .... .1.. .... = Apple: This is an Apple host
        .... .... .... .... .... .... 1... .... = Novell: This is a Novell server
        .... .... .... .... .... ...1 .... .... = Member: This is a Domain Member server
        .... .... .... .... .... ..1. .... .... = Print: This is a Print Queue server
        .... .... .... .... .... .1.. .... .... = Dialin: This is a Dialin server
        .... .... .... .... .... 1... .... .... = Xenix: This is a Xenix server
        .... .... .... .... ...1 .... .... .... = NT Workstation: This is an NT Workstation
        .... .... .... .... ..1. .... .... .... = WfW: This is a WfW host
        .... .... .... .... 1... .... .... .... = NT Server: This is an NT Server
        .... .... .... ...0 .... .... .... .... = Potential Browser: This is NOT a Potential Browser
        .... .... .... ..0. .... .... .... .... = Backup Browser: This is NOT a Backup Browser
        .... .... .... .0.. .... .... .... .... = Master Browser: This is NOT a Master Browser
        .... .... .... 0... .... .... .... .... = Domain Master Browser: This is NOT a Domain Master Browser
        .... .... ...0 .... .... .... .... .... = OSF: This is NOT an OSF host
        .... .... ..0. .... .... .... .... .... = VMS: This is NOT a VMS host
        .... .... .0.. .... .... .... .... .... = Windows 95+: This is NOT a Windows 95 or above host
        .0.. .... .... .... .... .... .... .... = Local: This is NOT a local list only request
        0... .... .... .... .... .... .... .... = Domain Enum: This is NOT a Domain Enum request
    Enumeration Domain: WORKGROUP

No.     Time            Source                Destination           Protocol Info
      2 14:31:59.803918 192.168.1.100         192.168.1.106         LANMAN   NetServerEnum2 Response

Frame 2 (134 bytes on wire, 134 bytes captured)
    Arrival Time: Oct 10, 2006 14:31:59.803918000
    Time delta from previous packet: 0.001250000 seconds
    Time since reference or first frame: 0.001250000 seconds
    Frame Number: 2
    Packet Length: 134 bytes
    Capture Length: 134 bytes
    Protocols in frame: eth:ip:tcp:nbss:smb
Ethernet II, Src: Micro-St_74:16:e7 (00:0c:76:74:16:e7), Dst: IntelCor_4a:47:bb (00:13:20:4a:47:bb)
    Destination: IntelCor_4a:47:bb (00:13:20:4a:47:bb)
    Source: Micro-St_74:16:e7 (00:0c:76:74:16:e7)
    Type: IP (0x0800)
Internet Protocol, Src: 192.168.1.100 (192.168.1.100), Dst: 192.168.1.106 (192.168.1.106)
    Version: 4
    Header length: 20 bytes
    Differentiated Services Field: 0x00 (DSCP 0x00: Default; ECN: 0x00)
        0000 00.. = Differentiated Services Codepoint: Default (0x00)
        .... ..0. = ECN-Capable Transport (ECT): 0
        .... ...0 = ECN-CE: 0
    Total Length: 120
    Identification: 0xea10 (59920)
    Flags: 0x04 (Don't Fragment)
        0... = Reserved bit: Not set
        .1.. = Don't fragment: Set
        ..0. = More fragments: Not set
    Fragment offset: 0
    Time to live: 128
    Protocol: TCP (0x06)
    Header checksum: 0x8c50 [correct]
        Good: True
        Bad : False
    Source: 192.168.1.100 (192.168.1.100)
    Destination: 192.168.1.106 (192.168.1.106)
Transmission Control Protocol, Src Port: netbios-ssn (139), Dst Port: 44932 (44932), Seq: 1274726157, Ack: 851982196, Len: 68
    Source port: netbios-ssn (139)
    Destination port: 44932 (44932)
    Sequence number: 1274726157
    Next sequence number: 1274726225
    Acknowledgement number: 851982196
    Header length: 32 bytes
    Flags: 0x0018 (PSH, ACK)
        0... .... = Congestion Window Reduced (CWR): Not set
        .0.. .... = ECN-Echo: Not set
        ..0. .... = Urgent: Not set
        ...1 .... = Acknowledgment: Set
        .... 1... = Push: Set
        .... .0.. = Reset: Not set
        .... ..0. = Syn: Not set
        .... ...0 = Fin: Not set
    Window size: 64606
    Checksum: 0x1e0d [correct]
    Options: (12 bytes)
        NOP
        NOP
        Time stamp: tsval 11576161, tsecr 1184074739
NetBIOS Session Service
    Message Type: Session message
    Flags: 0x00
        .... ...0 = Add 0 to length
    Length: 64
SMB (Server Message Block Protocol)
    SMB Header
        Server Component: SMB
        Response to: 1
        Time from request: 0.001250000 seconds
        SMB Command: Trans (0x25)
        NT Status: STATUS_SUCCESS (0x00000000)
        Flags: 0x88
            1... .... = Request/Response: Message is a response to the client/redirector
            .0.. .... = Notify: Notify client only on open
            ..0. .... = Oplocks: OpLock not requested/granted
            ...0 .... = Canonicalized Pathnames: Pathnames are not canonicalized
            .... 1... = Case Sensitivity: Path names are caseless
            .... ..0. = Receive Buffer Posted: Receive buffer has not been posted
            .... ...0 = Lock and Read: Lock&Read, Write&Unlock are not supported
        Flags2: 0xc801
            1... .... .... .... = Unicode Strings: Strings are Unicode
            .1.. .... .... .... = Error Code Type: Error codes are NT error codes
            ..0. .... .... .... = Execute-only Reads: Don't permit reads if execute-only
            ...0 .... .... .... = Dfs: Don't resolve pathnames with Dfs
            .... 1... .... .... = Extended Security Negotiation: Extended security negotiation is supported
            .... .... .0.. .... = Long Names Used: Path names in request are not long file names
            .... .... .... .0.. = Security Signatures: Security signatures are not supported
            .... .... .... ..0. = Extended Attributes: Extended attributes are not supported
            .... .... .... ...1 = Long Names Allowed: Long file names are allowed in the response
        Process ID High: 0
        Signature: 0000000000000000
        Reserved: 0000
        Tree ID: 2048
        Process ID: 12967
        User ID: 2048
        Multiplex ID: 6
    Trans Response (0x25)
        Word Count (WCT): 10
        Total Parameter Count: 8
        Total Data Count: 0
        Reserved: 0000
        Parameter Count: 8
        Parameter Offset: 56
        Parameter Displacement: 0
        Data Count: 0
        Data Offset: 64
        Data Displacement: 0
        Setup Count: 0
        Reserved: 00
        Byte Count (BCC): 9
        Padding: 00
SMB Pipe Protocol
Microsoft Windows Lanman Remote API Protocol
    Function Code: NetServerEnum2 (104)
    Status: Unknown (8)
    Convert: 0
    Entry Count: 0
    Available Entries: 0
(This used to be commit 88fa5ac734)
2007-10-10 12:15:23 -05:00
Jeremy Allison
ee0ec18101 r19230: Doh ! Fix obvious crash bug.....
(This used to be commit e656027049)
2007-10-10 12:15:23 -05:00
Volker Lendecke
4980baf2e1 r19224: Add setting the rng_fault_state to the already converted pipes.
Convert the low-hanging fruit of the LSA server. This provides a sample how
the server calls can be converted one by one, see the "proxy_lsa_call"
function.

Volker
(This used to be commit 99e54a213a)
2007-10-10 12:15:23 -05:00
Volker Lendecke
6b0b563fa4 r19221: Monster-Checkin after "make idl"
(This used to be commit 416466a16f)
2007-10-10 12:15:22 -05:00
Volker Lendecke
b71a0be998 r19220: Check if a backend has set rng_fault_state and send a dce-level fault pdu.
Volker
(This used to be commit 21c08e7ef4)
2007-10-10 12:15:22 -05:00
Volker Lendecke
ced8406402 r19218: With the new RPC server infrastructure all backend functions are filled, at
least with dummy routines. We need a way to indicate that we do not support a
call, so that srv_pipe_hnd.c can return the DCE level RNG_ERROR.

This flag can be set in the backend routines for this one. I'll change pidl to
generate code to "return False" in srv_lsa.c if this flag is set.

Volker
(This used to be commit 5260657664)
2007-10-10 12:15:22 -05:00
Jeremy Allison
ed088e5ee0 r19212: Make sure domains marked internal don't do
network queries.
Jeremy.
(This used to be commit e4d5e1d90b)
2007-10-10 12:15:22 -05:00
Jeremy Allison
fe3fc9c8d5 r19209: Ensure we don't make mistakes by sending online/offline
messages to internal domains, or to domains not being
serviced by a winbindd child. Ensure the child online
offline requests are domain specific.
Jeremy.
(This used to be commit 81a9dc4b9f)
2007-10-10 12:15:22 -05:00
Jeremy Allison
9421a0a9cd r19207: Properly canonicalize incoming names to the
NSS protocols auth, chauthtok, logoff, ccache_ntlm_auth.
That way we ensure winbindd only deals with fully
qualified names internally. The NSS protocols
auth_crap and chng_pswd_auth_crap should be fixed
to do the same thing.
Jeremy.
(This used to be commit dbd2454d33)
2007-10-10 12:15:21 -05:00
Günther Deschner
b405a39714 r19206: Jeremy, for some reason storing a value-less entry in TDB does not work
anymore in 3_0. I'm just adding a time(NULL) as value for the
WINBINDD_OFFLINE key.

Guenther
(This used to be commit 2bdf9f140f)
2007-10-10 12:15:21 -05:00
Volker Lendecke
9d20474a48 r19203: Part two of returning our real name. This code is a bit ancient... :-)
(This used to be commit 370c24ba2a)
2007-10-10 12:15:21 -05:00
Stefan Metzmacher
442f5526a0 r19193: merge from samba4:
fixed another checker warning and a possible error on allocation
failure

metze
(This used to be commit d64583a763)
2007-10-10 12:15:21 -05:00
Stefan Metzmacher
c9b797b3ba r19192: merge from samba4:
ensure that data values from ldap libs are null terminated, to allow
ldb_msg_find_attr_as_string() to work correctly.

Thanks to Jim Myers for spotting this!

metze
(This used to be commit a5ea82bb05)
2007-10-10 12:15:21 -05:00
Stefan Metzmacher
85281ec526 r19191: merge from samba4:
fix checker warnings

metze
(This used to be commit 93a0fe093b)
2007-10-10 12:15:21 -05:00
Stefan Metzmacher
25e233db57 r19190: merge from samba4:
remove wrong check and statement.
to manipulate rootDSE we use ldb_dn_new() as base and that has 0 elements.

metze
(This used to be commit b81cae4180)
2007-10-10 12:15:21 -05:00
Günther Deschner
046a4756d4 r19189: No display name is normal for some GPOs.
Guenther
(This used to be commit 1ec1c5dd17)
2007-10-10 12:15:20 -05:00
Stefan Metzmacher
ca79df9061 r19185: merge comment from samba4
metze
(This used to be commit 256b838201)
2007-10-10 12:15:20 -05:00
Volker Lendecke
cfed7a5a71 r19184: W2k3 returns its name for the GetServerInfo RAP call. Do the same.
Implement 'net rap server name'.

Volker
(This used to be commit 919385ed2a)
2007-10-10 12:15:20 -05:00
Stefan Metzmacher
d63a3e05a2 r19183: merge from samba4:
don't crash on invalid utf8 chars

metze
(This used to be commit 71e1f8550f)
2007-10-10 12:15:20 -05:00
Stefan Metzmacher
617c39ab5f r19182: merge from samba4:
add ldb_set_create_perms() function to set the create_perms after
ldb_init() and before ldb_connect()

metze
(This used to be commit dd9d469eef)
2007-10-10 12:15:20 -05:00
Stefan Metzmacher
6c6842ee94 r19181: merge from samba4:
with "export MAKE_TEST_KEEP_PCAP=yes" make test
doesn't delete the generated pcap files

metze
(This used to be commit 74212c3056)
2007-10-10 12:15:20 -05:00
Stefan Metzmacher
354ddf6c57 r19179: remove difference with samba4
metze
(This used to be commit e97e1ffea8)
2007-10-10 12:15:20 -05:00
Stefan Metzmacher
ebc2f440e7 r19177: merge from samba4:
fix the standalone build of socket_wrapper by not using
samba's DLIST_ macros

metze
(This used to be commit bc7b2e8db8)
2007-10-10 12:15:19 -05:00
Stefan Metzmacher
e4e3dc064d r19172: merge from samba4:
change the socket wrapper license to
what heimdal uses...

metze
(This used to be commit d19c19ae4b)
2007-10-10 12:15:19 -05:00
Stefan Metzmacher
4a83c77c95 r19170: use a very clever trick to pass the binary name to the
gdb_backtrace script, I never noticed that %$(envvar)
exists...

Thanks to Bjoern Jacke for the suggestion!

metze
(This used to be commit 12a37bab3e)
2007-10-10 12:15:19 -05:00
Stefan Metzmacher
0e66bafd47 r19169: port the trick to only display the smbd and nmbd log output
of the current test

metze
(This used to be commit f668d4839d)
2007-10-10 12:15:19 -05:00
Stefan Metzmacher
e739baf3a1 r19168: use the correct configuration
metze
(This used to be commit bf90ac567f)
2007-10-10 12:15:19 -05:00
Stefan Metzmacher
78d21c7785 r19164: merge the gdb_backtrace script from samba4
this more portable and try to make use of ladebug on Tru64,
but that only works when the binary is passed as 2nd arg to gdb_backtrace
as Tru64 doesn't know /proc/${PID}/exe

we need to find a way to pass the progname in 'panic action'
in samba3

metze
(This used to be commit 2f55fd82ff)
2007-10-10 12:15:19 -05:00
Stefan Metzmacher
628fc4b53a r19163: pass always a mem_ctx to functions and a ldb_context where needed
It would be nice if someone can merge that to samba4,
otherwise I'll merge that to samba4 on monday

metze
(This used to be commit 6bc42f31ce)
2007-10-10 12:15:19 -05:00
Günther Deschner
7b84b133fe r19161: Add NET_GETANYDCNAME (getdcname only gives the PDC while getanydcname
gives just any DC), also make sure to set timeouts in rpcclient
accordingly so that we actually get the DC's reply.

Guenther
(This used to be commit 6091c8152a)
2007-10-10 12:15:18 -05:00
Günther Deschner
e0b6961ac5 r19160: Add new WERR codes seen by working with NETLOGON getdcname.
Guenther
(This used to be commit 78b0124a6e)
2007-10-10 12:15:18 -05:00
Jeremy Allison
00056ab431 r19159: The getdc call can take a long time. Allow for timeouts.
Jeremy.
(This used to be commit 99bebb6527)
2007-10-10 12:15:18 -05:00
Jim McDonough
2395cd57f8 r19158: Remove root and nobody users from ldif, from Björn Jacke
(This used to be commit 17880d6cad)
2007-10-10 12:15:18 -05:00
Volker Lendecke
9e69c4fbea r19157: Fix the build
(This used to be commit 3fc328dade)
2007-10-10 12:15:18 -05:00
Volker Lendecke
9d8d4f24b1 r19156: Make enumprinters use the share iterators.
Volker
(This used to be commit 9b1759617c)
2007-10-10 12:15:18 -05:00
Jeremy Allison
80b4e7ae7d r19155: Fix debug message.
Jeremy.
(This used to be commit 42e5481ce4)
2007-10-10 12:15:17 -05:00
Volker Lendecke
e918cf3abf r19154: Trivial logic simplification: Get rid of two indentation levels. Survives the
consistency checks just checked into Samba4.

Volker
(This used to be commit c48bb4b37b)
2007-10-10 12:15:17 -05:00
Volker Lendecke
9315bcd1e3 r19151: Create some dummy printers in the build farm
(This used to be commit c26a20e6d5)
2007-10-10 12:15:16 -05:00
Jeremy Allison
10ada62bed r19148: Finish last nights patch - make offline
work again. Still under test.
Jeremy.
(This used to be commit 40a455db78)
2007-10-10 12:15:16 -05:00
Volker Lendecke
1362fd0b68 r19147: This is WRONG, but the way the VFS works this is the only fix to get rid of
this type-punned warning.

Volker
(This used to be commit d815b1a7e9)
2007-10-10 12:15:16 -05:00
Stefan Metzmacher
b61d1e665e r19145: talloc_reference() can fail!
metze
(This used to be commit e4f2183684)
2007-10-10 12:15:16 -05:00
Günther Deschner
adc299bd08 r19143: getdcname on the NETLOGON pipe returns WERROR, not NTSTATUS.
Guenther
(This used to be commit 44e228ac79)
2007-10-10 12:15:16 -05:00
Stefan Metzmacher
a6e45f0da5 r19137: that looks nicer:-)
metze
(This used to be commit db40552d94)
2007-10-10 12:15:16 -05:00
Stefan Metzmacher
3652a2360f r19135: fix bugs...
- passing mem_ctx as ldb_context is a bad idea!
- naming a static function talloc_ is also bad and misleading

metze
(This used to be commit 0523ad2493)
2007-10-10 12:15:15 -05:00
Volker Lendecke
695c6fbe00 r19133: More C++ warnings -- Merge across?
(This used to be commit c879ed3d1e)
2007-10-10 12:15:15 -05:00
Volker Lendecke
fd1cf23567 r19132: Fix some C++ warnings. Is there interest to have them in Samba4 as well?
I have some problems resolving the last 3 ones in attrib_handlers.c. In line
251 the function ldb_dn_explode_casefold is called with mem_ctx as the first
argument. Looking at ldb_dn_explode_casefold I see that the first argument it
expects is a struct ldb_context. I could certainly add a cast to (struct
ldb_context *) to that call, but I would assume that this is the wrong fix. Is
it possible that attrib_handlers.c:251 and :254 should have ldb and not
mem_ctx as the first argument?

Can anybody from Samba4 clarify this for me and apply the correct fix?

Thanks a lot.

Volker
(This used to be commit 26f2cb71eb)
2007-10-10 12:15:15 -05:00
Stefan Metzmacher
d898cbce90 r19130: fix the logic for the AC_PROG_CC_C99 check
metze
(This used to be commit 21516dc5ac)
2007-10-10 12:15:14 -05:00
Volker Lendecke
2941d46b82 r19127: Fix bug 4152
(This used to be commit 70038e8f7b)
2007-10-10 12:15:14 -05:00
Volker Lendecke
43141d64ca r19126: Fix some uninitialized variable warnings
(This used to be commit 90bfa34610)
2007-10-10 12:15:14 -05:00
Andrew Tridgell
803d33a326 r19125: merge from samba4
(This used to be commit 65e1500ae6)
2007-10-10 12:15:14 -05:00
Stefan Metzmacher
a0a47d8149 r19124: merge from samba4:
pass LDFLAGS from configure to Makefile

metze
(This used to be commit 7ba9fddacb)
2007-10-10 12:15:14 -05:00
Stefan Metzmacher
1b80624c57 r19121: try to get rid of the difference between in system/iconv.h
between samba 3 and 4.

metze
(This used to be commit 04031a9fca)
2007-10-10 12:15:13 -05:00
Stefan Metzmacher
a856a88ba4 r19119: try to be more portable...
metze
(This used to be commit 380e647534)
2007-10-10 12:15:13 -05:00
Jeremy Allison
4be3f7665c r19105: Ok - this is currently untested (but I'm testing it at
the moment) but winbindd isn't run in the build farm
so hopefully won't break anything too badly - I don't
want to lose this.

If winbindd starts offline then it falls back to using
MS-RPC backend. On going online it needs to reset the
backend and try and go to using the AD backend code if
possible, as the MS-RPC sequence number fetch just returns
1 as the sequence number if run against an AD DC.

In addition, the winbindd async child may end up
with the AD backend whilst the main winbindd - which
still contacts the DC for some non-async calls, is
left using MS-RPC. This can cause some trouble (as
you can imagine :-).

Attempt to ensure both main winbindd and async children
us AD backends on going online.

Jeremy.
(This used to be commit 5efd4b04b8)
2007-10-10 12:15:13 -05:00
Jeremy Allison
06e36b4e18 r19104: Fix from Björn JACKE <bjoern@j3e.de>
"here's a small fix for gdb_backtrace."
Jeremy.
(This used to be commit a0b4e5d118)
2007-10-10 12:15:13 -05:00
Jeremy Allison
05109131b0 r19103: From "Björn JACKE <bjoern@j3e.DE>":
The attached patch cleans up pam_winbind a tiny bit. Instead of making
exceptions for all pam implementations except for Linux' it's better
to make an exception for the only pam implementation which is
different from all the others. This is equivalent to what pam_smb_auth
does already.
-----------------
Jeremy
(This used to be commit 8e55964708)
2007-10-10 12:15:13 -05:00
Stefan Metzmacher
b25c065786 r19102: fix typo, thanks derrell!
metze
(This used to be commit 0a516c3026)
2007-10-10 12:15:13 -05:00
Stefan Metzmacher
0a32e31cbe r19101: add sys_recv() wrapper
metze
(This used to be commit 2f146ec683)
2007-10-10 12:15:12 -05:00
Stefan Metzmacher
4366ca702d r19100: merge from samba4:
export MAKE_TEST_ENABLE_PCAP=yes enables
SOCKET_WRAPPER_PCAP_FILE support
in make test

metze
(This used to be commit 5faf816885)
2007-10-10 12:15:12 -05:00
Stefan Metzmacher
f9449b752f r19099: merge socket wrapper changes from samba4
including SOCKET_WRAPPER_PCAP_FILE support

but I just noticed that samba don't use recv()/send()
on the socket, so the capture only contain connect()/close()

metze
(This used to be commit b894e33023)
2007-10-10 12:15:12 -05:00
Stefan Metzmacher
f6e72ba4a6 r19096: - fix the build with included popt
- and fix some whitespaces

metze
(This used to be commit 4906e60151)
2007-10-10 12:15:12 -05:00
Günther Deschner
04e7e6b457 r19095: Fix some compile warnings.
Guenther
(This used to be commit a0d19e1ebe)
2007-10-10 12:15:12 -05:00
Günther Deschner
a8281b19c7 r19094: Fix debug statement.
Guenther
(This used to be commit e99696c970)
2007-10-10 12:15:11 -05:00
Stefan Metzmacher
63a0d4aa5b r19093: speed up the samba3 build from 8mins to 5mins:-)
we now don't compile mostly each .c file twice.

- we use PICFLAG for all object files
- PICFLAG defaults to PIE_CFLAGS and is then overwritten
  if the system supports shared libraries

as we currently always use -fPIE if available
(and at least on linux -fPIE produces the same code as -fPIC)
it doesn't change anything in the resulting code.

"high performance" binaries can be build with
"--disable-pie --disable-shared" if someone really needs to...

metze
(This used to be commit 6db1f57f45)
2007-10-10 12:15:11 -05:00
Stefan Metzmacher
6bcb2ea271 r19090: - the LIBREPLACE_C99 isn't needed in aclocal.m4
- including the ldb configure tests via aclocal.m4 is wrong

metze
(This used to be commit cd4b1cf0e7)
2007-10-10 12:15:11 -05:00
Stefan Metzmacher
11d219f1a1 r19089: normalize KRB5_LIBS too
metze
(This used to be commit c7788f6c71)
2007-10-10 12:15:11 -05:00
Stefan Metzmacher
4e47aef017 r19088: filter out -Wl,-rpath combinations with /usr/lib too
metze
(This used to be commit 52ffc8b12c)
2007-10-10 12:15:11 -05:00
Stefan Metzmacher
eade80109b r19087: normalize vars before printing them
metze
(This used to be commit 9900abf8ab)
2007-10-10 12:15:10 -05:00
Stefan Metzmacher
4bc71f13c8 r19086: fix --disable-pie together with -C
metze
(This used to be commit 035579b62c)
2007-10-10 12:15:10 -05:00
Stefan Metzmacher
5b77d0a856 r19085: merge from samba4:
- source and destination address handling
- tcp handling

metze
(This used to be commit 98154fd433)
2007-10-10 12:15:10 -05:00
Volker Lendecke
d193fa1a4d r19083: Fix objectclass
(This used to be commit 6c4d68d849)
2007-10-10 12:15:09 -05:00
Volker Lendecke
e28ae1f5fd r19080: Fix a potential NULL dereference
(This used to be commit 682b490c23)
2007-10-10 12:15:09 -05:00
Volker Lendecke
407873df53 r19079: talloc_array can fail
(This used to be commit 7b6738522a)
2007-10-10 12:15:09 -05:00
Volker Lendecke
8f553d8d3c r19078: talloc_strdup can fail
(This used to be commit 2b3b9ce2a1)
2007-10-10 12:15:09 -05:00
Volker Lendecke
f27d5c7838 r19077: Fix an uninitialized variable
(This used to be commit 6bc2cce645)
2007-10-10 12:15:09 -05:00
Volker Lendecke
faaec2f04a r19076: ldb_dn_copy_partial can fail
(This used to be commit c247cf3fba)
2007-10-10 12:15:09 -05:00
Volker Lendecke
38c4955c2a r19075: Fix a potential NULL dereference
(This used to be commit 0ab5d7692c)
2007-10-10 12:15:08 -05:00
Volker Lendecke
638a16900c r19073: mapping_dn can fail
(This used to be commit d234f39c79)
2007-10-10 12:15:08 -05:00
Volker Lendecke
14502053e9 r19072: Fix a potential NULL dereference. Simo/Tridge, not merging yet to 4_0, I'd
like you to comment.

Volker
(This used to be commit ba18c58f1f)
2007-10-10 12:15:08 -05:00
Simo Sorce
a65c6b3914 r19071: Backport to SAMBA_3_0 as well
(This used to be commit df148a5def)
2007-10-10 12:15:08 -05:00
Volker Lendecke
8cd27dc1c3 r19070: If there's an error in the data struct, there's no point to continue with
asn1_pop_tag.

Volker
(This used to be commit d18e9f1da9)
2007-10-10 12:15:07 -05:00
Volker Lendecke
101428b7e5 r19067: Fix a potential NULL dereference
(This used to be commit 6a8937ed03)
2007-10-10 12:15:07 -05:00
Volker Lendecke
7bce558fec r19066: Fix a memleak
(This used to be commit c53e2e5475)
2007-10-10 12:15:07 -05:00
Volker Lendecke
9989649fb4 r19065: No functional change, just a trivial simplification
(This used to be commit 45628f71cf)
2007-10-10 12:15:07 -05:00
Volker Lendecke
58b8f72af6 r19064: This code block is already #ifdef'ed by WITH_ADS which should imply
HAVE_KRB5. If WITH_ADS does not imply KRB5, we have to fix that.

Lets see what the build farm thinks about this.

Volker
(This used to be commit 27b063078d)
2007-10-10 12:15:07 -05:00
Stefan Metzmacher
71f2d744c9 r19062: try to fix the valgrind noise in the build-farm
metze
(This used to be commit 9cb182507c)
2007-10-10 12:15:07 -05:00
Volker Lendecke
a390f72bc1 r19060: Attempt to fix the valgrind suppressions for "fort"
(This used to be commit f8c4578f91)
2007-10-10 12:15:06 -05:00
Jim McDonough
dc1f0804dd r19058: Implement "user cannot change password", and complete "user must change
password at next logon" code.  The "password last set time" of zero now
means "user must change password", because that's how windows seems to
use it.  The "can change" and "must change" times are now calculated
based on the "last set" time and policies.

We use the "can change" field now to indicate that a user cannot change
a password by putting MAX_TIME_T in it (so long as "last set" time isn't
zero).  Based on this, we set the password-can-change bit in the
faked secdesc.
(This used to be commit 21abbeaee9)
2007-10-10 12:15:06 -05:00
Jeremy Allison
b96aae779b r19054: Callers of gencache may not have the rights to
open read/write. Allow them to fallback to read-only.
Jeremy
(This used to be commit ec526e1b88)
2007-10-10 12:15:06 -05:00
Volker Lendecke
8c15a6ff2e r19046: It does not do much yet, but activate RPC-SAMBA3-SPOOLSS
(This used to be commit 3bf313240c)
2007-10-10 12:15:06 -05:00
Volker Lendecke
bc2a760498 r19043: There's no point in #ifdef'ing the detection whether we were offered KRB5 in
SPNEGO, as long as we don't make use of it without krb libs. Makes the code a
bit simpler.

Volker
(This used to be commit 23549e6c08)
2007-10-10 12:15:06 -05:00
Volker Lendecke
4295292734 r19042: Fix the non-krb5 build. This needs sooo severe cleanup ... :-)
Volker
(This used to be commit b601fc42cb)
2007-10-10 12:15:05 -05:00
Volker Lendecke
eb00981fc3 r19041: Make us connect to Vista RC1. Apparently metze had done the same patch some
weeks ago.

We have some work before us, when in AD mode Vista sends
"not_defined_in_RFC4178@please_ignore" as the principal.....

Volker
(This used to be commit af85d8ec02)
2007-10-10 12:15:05 -05:00
Stefan Metzmacher
c25f331cf9 r19040: use more portable shellscripting, hopefully give better results on Tru64
metze
(This used to be commit e8dd73f796)
2007-10-10 12:15:05 -05:00
Günther Deschner
ac080e3184 r19039: Do not segfault in "net ads printer info" when a requested printserver
does not exist.

Guenther
(This used to be commit 359315021d)
2007-10-10 12:15:04 -05:00
Stefan Metzmacher
6b80d173ed r19038: build libreplace testsuite as replacetort
and run it with make test

metze
(This used to be commit 9db9eb199f)
2007-10-10 12:15:04 -05:00
Volker Lendecke
a3a082b248 r19037: Fix a segfault
(This used to be commit 1c18ebe675)
2007-10-10 12:15:04 -05:00
Stefan Metzmacher
7e310277ff r19034: merge from samba4:
prepare libreplace testsuite for usage in smbtorture

metze
(This used to be commit 281677084e)
2007-10-10 12:15:04 -05:00
Stefan Metzmacher
f0244fbffe r19031: merge from samba4:
add test that opendir() on files sets errno = ENOTDIR

metze
(This used to be commit fdad2ce734)
2007-10-10 12:15:03 -05:00
Stefan Metzmacher
a831353be4 r19030: merge missing stuff from samba4:
- strnlen() and strndup() are broken on AIX
- we need some extra CFLAGS on HPUX 11.11

metze
(This used to be commit 61aa60c60f)
2007-10-10 12:15:03 -05:00
Volker Lendecke
7ced2e983d r19028: Implement getprinterinfo level 6 (only the status) and get rid of snum in the
getprinter calls. Survives the RPC-SAMBA3-SPOOLSS test which I will activate
when the Samba4 build farm has picked it up.

Volker
(This used to be commit d7248b6cfa)
2007-10-10 12:15:03 -05:00
Stefan Metzmacher
7f9aca9772 r19026: we don't need this twice
metze
(This used to be commit 5d16aa61c6)
2007-10-10 12:15:03 -05:00
Volker Lendecke
4cc309c3da r19016: As per Samba4 coding standards, turn tabs into spaces
(This used to be commit 3f59c8ef0c)
2007-10-10 12:15:02 -05:00
Stefan Metzmacher
c6b22621be r19015: we don't need talloc_* in proto.h
metze
(This used to be commit 685304e574)
2007-10-10 12:15:02 -05:00
Volker Lendecke
bb5c820542 r19013: Fix some 64-bit warnings.
Jelmer, Jerry, in cmd_unixinfo.c:159 there is still the warning that "info" is
being used uninitialized which I don't really know how to fix.

Any hints?

Volker
(This used to be commit 4a5d11e194)
2007-10-10 12:15:02 -05:00
Volker Lendecke
69287da633 r19012: Fix an uninitialized variable
(This used to be commit 46cae04fbe)
2007-10-10 12:15:01 -05:00
Volker Lendecke
bffbda804d r19011: Attempt to fix the BSD RAW-CHKPATH failures: In Samba3 we rely on opendir
returning ENOTDIR when the file opened is not a directory. Can we merge this
back into Samba4?

Volker
(This used to be commit 448d7c0c4b)
2007-10-10 12:14:57 -05:00
Volker Lendecke
9430017b30 r19010: Fix bug 4137
(This used to be commit 3790d00a78)
2007-10-10 12:14:57 -05:00
Volker Lendecke
2b7d1fc779 r19008: Fix a segfault
(This used to be commit adfc82f0e6)
2007-10-10 12:14:57 -05:00
Gerald Carter
7b7e7dcb8c r19007: reformat service control manager IDL
(This used to be commit d0658139a3)
2007-10-10 12:14:56 -05:00
Gerald Carter
ff8f68840d r19006: Final cleanups for the winreg libmsrpc functions.
Needs thorough testing but the code has been adapted
to the new rpccli_winreg_XX() API.
(This used to be commit c3d1c3ca4d)
2007-10-10 12:14:56 -05:00
Günther Deschner
88a98e35c7 r19003: Finally activate "net ads gpo".
For those who are interested, try

        net ads gpo refresh mybox$

to get your machine related GPOs downloaded to /var/lib/samba/gpo_cache.
Detailed information about GPOs is currently only printed when setting a
higher debuglevel then 0.

Guenther
(This used to be commit d086babf9d)
2007-10-10 12:14:55 -05:00
Günther Deschner
824966fb3c r19002: Add a very simple synchronisation function to download the full GPO.
Guenther
(This used to be commit 02b75ff2a8)
2007-10-10 12:14:55 -05:00
Volker Lendecke
c9cea2d624 r19001: Fix comment
(This used to be commit 048127f9dd)
2007-10-10 12:14:55 -05:00
Volker Lendecke
81014d255e r19000: Merge the max tcon check from 3_0_23. Thanks to James Peach that this was not
done in the 3_0 tree.

Volker
(This used to be commit b2fbf5ac0c)
2007-10-10 12:14:55 -05:00
Stefan Metzmacher
ce11194ce0 r18998: - make more usage of PRINTF_ATTRIBUTE()
- vsyslog takes a 'const char *format'

metze
(This used to be commit 8899bc45f9)
2007-10-10 12:14:55 -05:00
Stefan Metzmacher
43be47f56b r18996: merge from samba4:
- fix bug 4078
- talloc_free(talloc_autofree_context()); should not result
  in a SIGABORT on exit
- add a test for this, but this test can also pass in the standalone build
  and samba3, as samba4 uses talloc_autofree_context()

metze
(This used to be commit f5b0924f97)
2007-10-10 12:14:54 -05:00
Stefan Metzmacher
da6c811eca r18993: merge from samba4:
prepare SOCKET_WRAPPER_PCAP_FILE support

metze
(This used to be commit 372471cbad)
2007-10-10 12:14:54 -05:00
Volker Lendecke
f9d077cfb3 r18991: Fix bug 4133 -- Thanks to Olaf Flebbe
(This used to be commit 00f09d851c)
2007-10-10 12:14:54 -05:00
Günther Deschner
21bdd5833e r18988: Check and refresh expired GPOs.
Guenther
(This used to be commit e0e44bfadb)
2007-10-10 12:14:54 -05:00
Günther Deschner
7a5d2f5c1a r18987: Add some usage prints for "net ads gpo".
Guenther
(This used to be commit 581152f819)
2007-10-10 12:14:54 -05:00
Günther Deschner
3727503872 r18986: Add some more GPO download helper functions.
Guenther
(This used to be commit d2db3b6b46)
2007-10-10 12:14:53 -05:00
Günther Deschner
4db2fc3c89 r18985: Add parse_gpt_ini() to parse GPT.INI files using iniparser.
Guenther
(This used to be commit 46db28de48)
2007-10-10 12:14:53 -05:00
Günther Deschner
7c1ca378ed r18984: Removing ads_gpo_get_sysvol_gpt_version() which was just doing stupid
things.

Guenther
(This used to be commit a597ef83c4)
2007-10-10 12:14:53 -05:00
Günther Deschner
031506eb51 r18983: Add some comments for the LDAP based GPO routines.
Guenther
(This used to be commit 2c21ee684c)
2007-10-10 12:14:53 -05:00
Günther Deschner
73f4ac012a r18982: Move the gpo related functions to "libgpo".
Guenther
(This used to be commit 1308a84271)
2007-10-10 12:14:53 -05:00
Gerald Carter
18d4176633 r18981: * cleanup some vestiges of old cli_reg.c code and mark some TODO
items in cac_winreg.c
* Get 'net rpc registry enumerate' to list values again
* Fix winreg.idl QueryInfoKey().  The max_subkeysize is the
  max_classlen (we previously had this correct in Samba3")
* fix valgrind error about uninitialized memory and use-before-set
  on size value inmemset() call
* Fix key enumeration in 'net rpc registry enumerate'
* regenerate gen_dir files based on local pidl patches

Please note that the generated ndr files are from my local
copy of pidl.  If you need to regenerate, please apply the
patch that I posted to the samba-technical list earlier today.
(This used to be commit 5d843612a1)
2007-10-10 12:14:53 -05:00
Jeremy Allison
0f56237bc0 r18980: Be a little more intelligent about "startup_time",
move into the domain struct. Allow message to go online
to set this state and cope with removing it.
Jeremy.
(This used to be commit 51f0e60cc3)
2007-10-10 12:14:52 -05:00
Stefan Metzmacher
e07df9be38 r18976: follow the advice from "William Jojo" <jojowil@hvcc.edu>
and pass -bbigtoc also to the linker when building shared libs

metze
(This used to be commit 4948b676a8)
2007-10-10 12:14:52 -05:00
Stefan Metzmacher
8f4f93a201 r18973: we should always set LDFLAGS and DYNEXP depending on the host_os
but disable building of shared libs and modules whe enable_shared != yes

Also make it easier to track down the problem with lost LDFLAGS values
on AIX.

metze
(This used to be commit 3367e306e6)
2007-10-10 12:14:52 -05:00
Günther Deschner
b80cbfc20e r18969: Fix typo.
Guenther
(This used to be commit 31f21282cd)
2007-10-10 12:14:52 -05:00
Andrew Tridgell
b6b9898a07 r18966: this bug affects Samba3 too. I'm actually surprised nobody has
reported that Samba3 on Solaris Sparc with the native compiler can't
join Windows domains. If it worked we were just lucky. I suspect it
just didn't work.
(This used to be commit 9df1e7d989)
2007-10-10 12:14:52 -05:00
Gerald Carter
95e4091596 r18964: fix 'net rpc registry save' to use the new wnireg client code
(This used to be commit f2747daafc)
2007-10-10 12:14:52 -05:00
Gerald Carter
2326b147d0 r18963: * Move parts of registry headers that were still in
use to reg_objects.h
* Remove unused rpc headers
(This used to be commit 4f79d8c83d)
2007-10-10 12:14:51 -05:00
Gerald Carter
b3ec4697ef r18962: * Add IDL for SaveKey() and RestoreKey() and regenerated
* Tested RegSaveKey() using win32 app.  Apparently
  this code has been brokne for a really long time.
(This used to be commit 5381dcbde3)
2007-10-10 12:14:51 -05:00
Stefan Metzmacher
3ae0baefa1 r18961: merge from samba4:
fix caching of some configure tests AC_CACHE_CHECK()
*needs* '_cv_' in the shell var to do caching...

metze
(This used to be commit c460f28b68)
2007-10-10 12:14:51 -05:00
Gerald Carter
94c9d52872 r18959: reformat using indent
(This used to be commit 69c298f85d)
2007-10-10 12:14:50 -05:00
Stefan Metzmacher
6aed2cd44e r18958: merge from samba4:
we need to include unistd.h in system/network.h because
it contains the ioctl() prototype on some systems
and we need to make sure it gets included before socket_wrapper
defines ioctl swrap_ioctl

metze
(This used to be commit d827534760)
2007-10-10 12:14:50 -05:00
Stefan Metzmacher
3da1690692 r18956: fix -pie and -fPIE together with configure -C
metze
(This used to be commit aafb86f6eb)
2007-10-10 12:14:50 -05:00
Stefan Metzmacher
d18ec9fac8 r18955: fix the build on solaris where unistd.h needs to be includes before
socket_wrapper defined ioctl swrap_ioctl

metze
(This used to be commit e43d1f6c17)
2007-10-10 12:14:50 -05:00
Gerald Carter
2279881bd4 r18954: Fix segv in QueryValue and Enumvalue. regedit.exe now
is happy again when creating keys and values
(This used to be commit 6e9e9f8fac)
2007-10-10 12:14:50 -05:00
Stefan Metzmacher
cb99b612f8 r18953: sync socket_wrapper with samba4
metze
(This used to be commit 77b0af43f0)
2007-10-10 12:14:50 -05:00
Stefan Metzmacher
cf5ab86a65 r18952: fix compiler warning (merge from samba4)
metze
(This used to be commit 4cd59d47c8)
2007-10-10 12:14:50 -05:00
Stefan Metzmacher
dc030ce813 r18951: socket_wrapper has only 16 interfaces anymore...
metze
(This used to be commit a1966a9c07)
2007-10-10 12:14:49 -05:00
Stefan Metzmacher
93dc24eed9 r18950: I can't see where stropts.h and poll.h are needed
(I just removed the only reference to poll() in my last commit)

they were added in this commit, without make usage of them.

http://cvs.samba.org/cgi-bin/cvsweb/samba/source/configure.in.diff?r1=1.21&r2=1.22&f=h
http://cvs.samba.org/cgi-bin/cvsweb/samba/source/include/includes.h.diff?r1=1.105&r2=1.106&f=h

metze
(This used to be commit b852cf46c2)
2007-10-10 12:14:49 -05:00
Stefan Metzmacher
1888bb4fd9 r18949: use sys_usleep()
metze
(This used to be commit f994494141)
2007-10-10 12:14:49 -05:00
Günther Deschner
296b450f16 r18941: Minor cleanup in ads_parse_gpo().
Guenther
(This used to be commit 7579a91f81)
2007-10-10 12:14:49 -05:00
Gerald Carter
d89a951517 r18940: Fix a few memory corruption bugs to make CreateKey() and DeleteKey() work
(This used to be commit e7e3e35c1d)
2007-10-10 12:14:49 -05:00
Andrew Tridgell
0cc2cee8d5 r18939: don't rely on the umask being right in ldb creation. Both Samba3 and
Samba4 smbd force the umask to 0, which meant we ended up with ldb
being world writable.

This isn't really an ideal fix, as it means ldb no longer honors umask
(as it should do, like all good libraries).

Unfortunately the 'proper' fix is too complex for now

this also merges a tiny code style fix from s4 to s3
(This used to be commit dd8ec8725f)
2007-10-10 12:14:49 -05:00
Andrew Tridgell
afbc8a1faa r18938: fixed a group map bug reported by Jerry. The caller in mapping.c
relies on appending to this list. Unfortunately this can't be tested
using 'net groupmap'
(This used to be commit a8d398edf0)
2007-10-10 12:14:48 -05:00
Gerald Carter
6a492e7122 r18937: Protect against segc in the idmap winbindd child process
(the domain is NULL here)
(This used to be commit a36de910d2)
2007-10-10 12:14:48 -05:00
Günther Deschner
efffbc9036 r18935: Make "netshareenum" work again. There is most probably a better way to
do this... Any pointers?

Guenther
(This used to be commit 1f09e54fec)
2007-10-10 12:14:48 -05:00
Gerald Carter
c67b555874 r18934: fix a segv in CreateKey()
(This used to be commit 92f22f67ed)
2007-10-10 12:14:48 -05:00
Gerald Carter
855d12e567 r18932: In RegEnumvalue() and RegQueryValue(), the output buffer
size must match the real value of the data.
(This used to be commit e11108024a)
2007-10-10 12:14:48 -05:00
Gerald Carter
49c73b5734 r18931: * Fix the IDL for QueryInfoKey. teh Classname in an
in,out ref pointer
* Clarify variable names in EnumValue IDL
* Fix server code for _winreg_EnumValue() and _winreg_QueryInfoKe()
(This used to be commit f520a9d0fb)
2007-10-10 12:14:48 -05:00
Gerald Carter
5935ea9da1 r18929: * Clarify QueryValue IDL and regenerate code
* Fix server _winreg_Query_Value() implementation so that
  usrmgr.exe starts now
(This used to be commit 435d7bfc37)
2007-10-10 12:14:47 -05:00
Günther Deschner
16fecf7875 r18928: Some more const for iniparser.
Guenther
(This used to be commit ac3de529b3)
2007-10-10 12:14:47 -05:00
Gerald Carter
b0e29c79e7 r18927: Fix build. *please* compile the code at least once before checking it in.
(This used to be commit 4e464a2c35)
2007-10-10 12:14:47 -05:00
Günther Deschner
9d931a8421 r18926: Add some useful macros.
Guenther
(This used to be commit 9be5cb27e4)
2007-10-10 12:14:47 -05:00
Günther Deschner
f1c2398723 r18924: Minor cleanup.
Guenther
(This used to be commit 143a48927b)
2007-10-10 12:14:47 -05:00
Günther Deschner
f7633eca18 r18923: Fix more memleaks.
Guenther
(This used to be commit ecb632a153)
2007-10-10 12:14:47 -05:00
Günther Deschner
bf6962b5e8 r18922: Apply some const.
Guenther
(This used to be commit d87994788b)
2007-10-10 12:14:47 -05:00
Günther Deschner
bd2f02e696 r18921: Fix some c++ warnings.
Guenther
(This used to be commit b1bc7fd347)
2007-10-10 12:14:46 -05:00
Stefan Metzmacher
52d45a51d3 r18920: merge socket_wrapper changes from samba4
metze
(This used to be commit b36d47c698)
2007-10-10 12:14:46 -05:00
Gerald Carter
bbaa0b178d r18919: * Get the new rpccli_winreg_XXXX() functions into the tree
There some broken functionality here that I'm still working on.
* remove unneeded parsing routines
(This used to be commit cbfe1a4b49)
2007-10-10 12:14:46 -05:00
Andrew Tridgell
cda3a18f23 r18912: we don't need the special case for comments now in the
This also fixes comments in group mappings, as the code accidentially
put in "ntName" in the comment field :-)
(This used to be commit 7f1f5d6056)
2007-10-10 12:14:46 -05:00
Andrew Tridgell
45c0a4874b r18910: Change ldb_msg_add_string() to not actually add an attribute if the
string is zero length. This allows callers to not have to worry about
creating an invalid ldap attribute.

See extensive discussion on samba-technical list :-)
(This used to be commit 9e66df05a4)
2007-10-10 12:14:45 -05:00
Jeremy Allison
28800c54dc r18907: W00t. My original fix was correct after all :-).
Re-checking it in.
Fix bug #4095 - username composed into domain\user
twice in spnego path.
Jeremy.
(This used to be commit 0c77046751)
2007-10-10 12:14:45 -05:00
Gerald Carter
2a04cff7a9 r18906: Fix 'make clean' to deal with new lib/ldb/ directory structure.
(This used to be commit 9b43d7c63a)
2007-10-10 12:14:45 -05:00
Gerald Carter
1254bdc86d r18905: I'm not really proud of this but I don't want to maintain
2 separate CPPFLAGS variables.  So just cleanup the SAMBA_CPPFLAGS
for out of tree builds.  This has been tested locally and works.
Maybe metze can find a better way tomorrow.
(This used to be commit 8aa681df99)
2007-10-10 12:14:45 -05:00
Gerald Carter
e2a5072b96 r18904: * Revert previous fix for building out of tree and
add a better one which fixes the network interface detection
  breakage (caused by the previous commit).
(This used to be commit 7e908acdef)
2007-10-10 12:14:45 -05:00
Günther Deschner
dd992469dd r18902: Also dump mS-DS-CreatorSID.
Guenther
(This used to be commit e7cae9bbae)
2007-10-10 12:14:44 -05:00
Stefan Metzmacher
ed724f9047 r18901: try to fix the samba3 build without having ldap
vl: you were a few seconds faster than me...:-)

metze
(This used to be commit 63e5727471)
2007-10-10 12:14:44 -05:00
Volker Lendecke
b70ee55a7c r18900: Next attempt to fix the Solaris build. Not sure about whether to merge this
one. Tridge? Metze?

Volker
(This used to be commit d0eef2f6e8)
2007-10-10 12:14:44 -05:00
Gerald Carter
22a21fdf04 r18899: remove check for root when running configure since it does not appear to be used anymore
(This used to be commit da17fb41db)
2007-10-10 12:14:44 -05:00
Jeremy Allison
fec9850644 r18898: Fix for bug #4100 from Udo Eberhardt <udo.eberhardt@thesycon.de>.
Ensure we initialize values for smb_io_notify_info_data_strings to
fix crash.
Jeremy.
(This used to be commit ceefb8dd3c)
2007-10-10 12:14:44 -05:00
Jeremy Allison
f1964048a5 r18897: Fix valgrind bug found by Volker.
Jeremy.
(This used to be commit db458d3e8b)
2007-10-10 12:14:43 -05:00
Gerald Carter
2cb15a9516 r18896: * Fix out of tree builds after libreplace merge
* Remove unused -D define in Makefile
(This used to be commit 3c9632bedc)
2007-10-10 12:14:43 -05:00
Stefan Metzmacher
75064ae95e r18895: AIX need to call pidl with --uint-enums as the compiler doesn't
like negative values in the generated code.

I'm not sure how we can solve that in samba3 as the generated code is commited

Maybe we need to alsways pass --uint-enums

metze
(This used to be commit 9468dcc5d5)
2007-10-10 12:14:43 -05:00
Volker Lendecke
868daf42b2 r18893: Attempt to fix the Solaris build
(This used to be commit db838f49a0)
2007-10-10 12:14:43 -05:00
Volker Lendecke
22a23881c7 r18892: Copy over the Samba4 valgrind suppressions
(This used to be commit 6d7e3f3983)
2007-10-10 12:14:42 -05:00
Volker Lendecke
147fc86a94 r18891: Fix "double const" warning from host opi
(This used to be commit 47c19811ae)
2007-10-10 12:14:42 -05:00
Volker Lendecke
ba68916c9a r18889: Add some const. What's the policy here? Should I do this in Samba4 as well?
Volker
(This used to be commit fd020a1998)
2007-10-10 12:14:41 -05:00
Volker Lendecke
10a8d62e96 r18888: Fix a 64-bit warning
(This used to be commit 94b53f2f2a)
2007-10-10 12:14:41 -05:00
Volker Lendecke
170ee35a66 r18886: First, RPC_SRVSVC is called RPC-SRVSVC and second, we're so far off on that
one that there's no point yet to run this in the build farm.

Volker
(This used to be commit bbd9f0bb6f)
2007-10-10 12:14:41 -05:00
Günther Deschner
82bf0da9d3 r18879: Fix crash for "net ads gpo list".
Guenther
(This used to be commit 7df5808d8b)
2007-10-10 12:14:41 -05:00
Volker Lendecke
611b5d29fc r18878: With the recent checkins for me Samba3 compiles again with the NTSTATUS/WERROR
checks enabled. I'll look at the build farm in a couple of hours and fix it if
not.

Volker
(This used to be commit 58583aa943)
2007-10-10 12:14:41 -05:00
Volker Lendecke
e1fa2ea721 r18877: More WERROR/NTSTATUS bugs
(This used to be commit 88a928a233)
2007-10-10 12:14:40 -05:00
Volker Lendecke
2c94123e86 r18876: Fix smbclient -L
(This used to be commit a03fb81a9d)
2007-10-10 12:14:40 -05:00