1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-25 06:04:04 +03:00

12728 Commits

Author SHA1 Message Date
Jeremy Allison
7a62d6215d Avoid mb conversion overflow when sending an announcement.
Jeremy.
-
Jeremy Allison
b9da3e941d Use "unix netbios name" type unstring - 64 bytes long to manipulate netbios
names in nmbd. Allows conversion from dos codepage mb strings (ie. SJIS) to
expand to utf8 size on read.
Jeremy.
-
Gerald Carter
ad1bf59a79 removing extra comma in --with-fhs -
Gerald Carter
211cead67c more fixes from 3.0 -
Gerald Carter
c640594c93 sync small fixes from 3.0 and fix compiler warning in priv code -
Gerald Carter
ce49e4f2b9 fix byte ordering problem when storing the updating pid for the lpq cache; was causing an abort in process_exists() on solaris -
Volker Lendecke
ae080f2cfa Ok, one of the latest cleanups did too much... :-)
Re-add adding the local aliases to winbindd_getgroups.

Volker
-
Volker Lendecke
66c4a6dee8 Clean up a bit :-)
Volker
-
Volker Lendecke
3acac5d626 Fix 'getent group aliasname', this did not look in pdb. -
Volker Lendecke
7f62cf933c Add and delete aliases via srv_samr_nt. For that I added a RID allocation call
to winbindd. idmap_allocate_rid wants information about whether this will be a
user or a group, I did not export this to the winbind interface.

The reason for idmap to get that info is to keep consistent with the
algorithmic convention to alloc only even rids for users and odd rids for
groups. I'm not fully convinced that this really gains us anything. Any real
good arguments?

Volker
-
Volker Lendecke
87fa7904f7 When trying to remove a user from a group, winbind should be informed
about the user and group...

Volker
-
Tim Potter
c8db2f7cdb Merge from 3.0 -
Volker Lendecke
975c60b997 Make alias membership maintainable via net rpc group add/delmem. Alias
creation and deletion still has to be done as well as a 'net alias' command.

Volker
-
Volker Lendecke
d1f38cd73e Rest of my winbindd_passdb alias support -
Volker Lendecke
9e0fb457ba Add alias support to winbindd_passdb. Sorry, Simo, this does not leave too
much of your winbindd_passdb, users are currently not provided by that, only
aliases. Currently the code to maintain that stuff is not yet in, this will be
next, see my next posting to samba-technical.

Volker
-
Volker Lendecke
4e96b46a84 Remove the prototype for alias support in winbind again. This will be
replaced by a winbindd_passdb.c checkin soon.

Volker
-
Volker Lendecke
f44bf63d11 Add find_alias, create_alias, delete_alias, get_aliasinfo, set_aliasinfo and
enum_aliases to passdb. create and delete are not yet filled, you have to do
this with net groupmap and net idmap restore.

Volker
-
Jeremy Allison
b3aff7f214 Ensure we don't truncate strcmps to nstring anymore...
Jeremy.
-
Jeremy Allison
128dec9ae6 Modified fix for bugid #784. Based on a patch from moriyama@miraclelinux.com (MORIYAMA Masayuki).
Don't use nstrings to hold workgroup and netbios names. The problem with them is that MB netbios
and workgroup names in unix charset (particularly utf8) may be up to 3x bigger than the name
when represented in dos charset (ie. cp932). So go back to using fstrings for these but
translate into nstrings (ie. 16 byte length values) for transport on the wire.
Jeremy.
-
Jeremy Allison
beca3829d1 First part of patch from moriyama@miraclelinux.com (MORIYAMA Masayuki) to
fix up netbios names with mb strings. Includes reformat of libsmb/nmblib.c
so it's readable.
Jeremy.
-
Christopher R. Hertel
8e52439f4a Bug report 1079 and fix both from Bert Driehuis.
This is an odd corner case having to do with <1C> group names (DC names).
<1C> group names are called (by MS) "Internet Special Groups", which means
that Microsoft's WINS servers will attempt to handle these names in
something approximating an RFC1001/1002 compliant manner.

The problem being reported here is this:  If an initial registration sent
by one of the group members is lost (network error, whatever) then
subsequent refreshes from that particular machine will also fail.  This
only happens if the name is already active (because of other group
members).

In most cases, we (and MS) handle refreshes as registrations if the name
is not in the database.  In this situation, we missed the corner case.

Bert's fix adds an 'else if' that catches the situation in which a refresh
for an unlisted IP of an active <1C> group name is received.  The refresh
is simply handled as a registration when this happens.

[Note: Committing in HEAD.  I am writing some tools to do registrations
       and refreshes so that I can test this.  I don't have an NT Domain
       for testing so I'm going to have to fudge.  This fix is small (I
       cleaned up some Debug messages and comments in addition to the fix)
       and if you want to test it with 3.0.x you can just copy the HEAD
       version into your 3.0.x tree and recompile.]
-
Jeremy Allison
11487e2466 Fix from Robert.Dahlem@gmx.net (Robert Dahlem) for bugid #1048
when mangled names are turned off.
Jeremy.
-
Alexander Bokovoy
cc70a548f3 Fix problems with very long filenames in both smbd and smbclient.
It appears that we pass filename through resolve_wildcards() as pstring and use fstring temporary buffer there.
As result, a long filename in unix charset (UTF-8 by default) can easily expand over 255 bytes while
Windows is able to send to us such names (e.g. Japanese name of ~190 mb chars) which we unable to process through
this small fstring buffer. Tested with W2K and smbclient, Japanese and Cyrillics.
-
Alexander Bokovoy
e117ed1db8 Fix build after Jeremy -- yet another place where convert_string() wasn't updated -
Alexander Bokovoy
cf0285f3ea Fix string overflow due to wrong size calculation -
Jeremy Allison
3c89393e29 Allow msdfs symlink syntax to be more forgiving (it took me ages to remember
what it was :-). Allow msdfs links to now look like UNC paths : eg.
sym_link -> msdfs://server/share/path/in/share
or :
sym_link -> msdfs:\\server\share\path\in\share
Jeremy.
-
Jeremy Allison
3c9fd2bdee Fix bug introduced by Jim (touche :-) :-) - use new smbldap_get_single_pstring
call :-).
Jeremy.
-
Jeremy Allison
3b4fca7b7f Restore the contract on all convert_stringXX() interfaces. Add a "allow_bad_conv"
boolean parameter that allows broken iconv conversions to work. Gets rid of the
nasty errno checks in mangle_hash2 and check_path_syntax and allows correct
return code checking.
Jeremy.
-
Jim McDonough
46544e957f Merge from 3.0. Fix munged dial in pdb_ldap -
Herb Lewis
5e831f48f0 add missing #ifdef HAVE_BICONV stuff -
Gerald Carter
e7d2315e45 BUG 1088: patch from SATOH Fumiyasu <fumiya@miraclinux.com> -- use strchr_m() for query_host (smbclient -L) -
Jeremy Allison
ebf82e2c14 Ensure we use check_path_syntax() to pull out DFS paths.
Jeremy
-
Jeremy Allison
30c30c5ac5 Fix processing of pathnames with embedded '\\' characters (0x5c) in CP932
character set. Because of the allowing of "broken conversions" for people
who have broken iconv libraries we can't rely on the return from convert_string()
to be valid - we must check errno instead. This is ripe for revisiting at
some stage. I prefer adding a bool parameter to all convert_string_XX varients
to specify if we will allow broken conversions or not. With "allow_broken_conversions"
set to false we could then rely on the return from convert_string rather than
checking errno.
Jeremy.
-
Volker Lendecke
32d196e9bb lsa_enumaccounts lists all SIDs that have been granted privileges. Simo,
you should look at this.

Change behaviour from listing all groups to listing only BUILTIN\Administrator

Volker
-
Volker Lendecke
67bb1d2338 Remove expanding sids from smbd, this will be done in winbindd.
Volker
-
Volker Lendecke
e2696b81bb Apply some const -
Volker Lendecke
27b27c28cd Don't pass DOM_SIDs around when pointers are enough.
Volker
-
Herb Lewis
40634650d0 another type -
Jeremy Allison
859529aff3 Moving towards getting msdfs working again (this looks like it was broken
in 3.0.2a actually). We now send a correct referral back, but the client
refuses to follow it... Not sure why. Will do more tests.. Maybe unicode
character count is wrong (it looks it).
Jeremy.
-
Jeremy Allison
e93aeb9677 Formatting reformat before I start to change anything here.
Jeremy.
-
Herb Lewis
cd1ed1a23b fix type for tag in proto file -
Jeremy Allison
7067084102 Fix dfs referrals - don't use check_path_syntax. Also use mb char calls in
dfs code.
Jeremy.
-
Rafal Szczesniak
6c8e39b7cc Yet another '\n' termination of debug message.
rafal
-
Rafal Szczesniak
b3efdcf0ae Forgot to put some more comments.
rafal
-
Rafal Szczesniak
2ed23fbce8 1) Two new functions to trust passwords interface in passdb:
settrustpwent, gettrustpwnam

2) Implementation of another couple of these functions in tdbsam:
   settrustpwent, gettrustpwnam, gettrustpwsid

3) Testing (mostly for now) usage of the interface in pdbedit
   which is soon to be offline tool back again.

This is quite a new code, so many changes will be put in soon.


rafal
-
Rafal Szczesniak
6fdb20f5a7 Fix to debug message lacking termination with '\n'.
rafal
-
Gerald Carter
45b2efd60a fix build with gcc 2.96 and --with-developer -
Andrew Bartlett
6bad895462 Commit to HEAD the updates to smb signing code that I was propsing for 3.0.
This code implements 'opportunistic signing' in our client (when the
server supports it, we will use it), and correct downgrading on both
the client and server for the 'enabled' (rather than required) signing
level.

This means that we can actually set 'server signing = yes' and not
have the world fall apart.  We had a number of bugs in that code, and
it certainly looks like most of the testing was with the 'requried'
setting.

While the changes are reasonable, I'm putting this into HEAD rather
than 3.0 for the timebeing.  SMB signing, like NTLMSSP, tends to have
gotchas in it :-)

(I also need to give it a workout with more than smbclient before I
move it across).

Andrew Bartlett
-
Andrew Bartlett
a9363b45b0 Merge fixes and tests for jra's broken strstr_m() function from 3.0
STF rules!  (Pity we don't use it for more stuff)

Andrew Bartlett
-
Jeremy Allison
93c2d50f1a Added strstr_m() function. Use in all places where we might run into mb
(should fix the mb service name problem, can't remember the bugid).
Jeremy.
-