1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-14 19:24:43 +03:00

68732 Commits

Author SHA1 Message Date
Kamen Mazdrashki
7ada90ec29 s4-test: repl_schema - Make sure LdbError and ERR_NO_SUCH_OBJECT are visible 2010-11-11 18:54:20 +00:00
Volker Lendecke
beaf14ec91 s3: Well... Fix a stupid error
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Nov 11 18:54:00 UTC 2010 on sn-devel-104
2010-11-11 18:54:00 +00:00
Volker Lendecke
e7970c02f3 s3: Make cli_set_ea_fnum return NTSTATUS
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Nov 11 16:59:27 UTC 2010 on sn-devel-104
2010-11-11 16:59:27 +00:00
Volker Lendecke
ddd33f0351 s3: Make cli_set_ea_path return NTSTATUS 2010-11-11 16:16:24 +00:00
Volker Lendecke
1b13a4d22b s3: Remove two pointless variables 2010-11-11 16:16:24 +00:00
Volker Lendecke
9c664dbd8c s3: Convert cli_set_ea() to cli_trans() 2010-11-11 16:16:24 +00:00
Volker Lendecke
1d96161132 s3: Convert cli_dfs_get_referral to cli_trans 2010-11-11 16:16:24 +00:00
Volker Lendecke
612ded1abf s3: cli_dfs_check_error does not need to depend on cli->inbuf 2010-11-11 16:16:24 +00:00
Volker Lendecke
3a01edd607 s3: Make split_dfs_path return bool 2010-11-11 16:16:24 +00:00
Volker Lendecke
8a22fac3a0 s3: Remove some dead code 2010-11-11 16:16:24 +00:00
Volker Lendecke
d320ae7cbe s3: Untangle an if-expression 2010-11-11 16:16:24 +00:00
Anatoliy Atanasov
9cdb0b5cee s4/test: Expand BindTest
The test now binds with user@realm, domain\user, user dn, computer dn

Autobuild-User: Anatoliy Atanasov <anatoliy.atanasov@postpath.com>
Autobuild-Date: Thu Nov 11 16:15:30 UTC 2010 on sn-devel-104
2010-11-11 16:15:30 +00:00
Anatoliy Atanasov
4574d497ce s4/test: Add bind.py to make test
bind.py is a place to have tests for ldb binding with different credentials.
For starter we have a simple bind with machine account.
2010-11-11 15:33:07 +00:00
Andrew Bartlett
ba127f9849 heimdal Don't dereference NULL in error verify_checksum error path
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Nov 11 10:37:03 UTC 2010 on sn-devel-104
2010-11-11 10:37:03 +00:00
Andrew Bartlett
a9baabed56 s4-provision UTF16 encode the password in sam.ldb, not secrets.ldb
The password in secrets.ldb is UTF8, while clearTextPassword in
sam.ldb is UTF16.

This corrects commit bd5039546e520b6d6897a658bc0a358f0511f7c7, which
had these the wrong way around.

Andrew Bartlett
2010-11-11 09:55:06 +00:00
Andrew Bartlett
78928f5956 s4-dsdb Remove incorrectly declared ** variable used as *.
The cleartext_utf16_str variable was declared char **, but due to the
cast on convert_string_talloc() and the lack of type checking here and
on data_blob_const (due to void *) it was able to be used as if it was
a char *.

The simple solution seems to be to fill in cleartext_utf16 blob directly.

Andrew Bartlett
2010-11-11 09:55:06 +00:00
Andrew Bartlett
eebbbeac14 s4-dsdb Convert new krbtgt_xxx password into UTF16
The new stricter test on clearTextPassword values caught out that
we did not provide a utf16 password here.

Andrew Bartlett
2010-11-11 09:55:06 +00:00
Andrew Bartlett
01d10c8413 s4-dsdb Return an error if we can't convert UTF16MUNGED -> UTF8
The UTF16MUNGED helper will map all invalid sequences (except odd
input length) to valid input sequences, per the rules.  Therefore if
it fails, we need to bail out, somehing serious is wrong.

Andrew Bartlett
2010-11-11 09:55:06 +00:00
Matthias Dieter Wallnöfer
bb241f5cf8 s4:pytevent.c - fix a discard const warning
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov 11 09:47:55 UTC 2010 on sn-devel-104
2010-11-11 09:47:54 +00:00
Matthias Dieter Wallnöfer
f0367905d9 ldb:ldb_ldap.c rename operation - check for the RDN name and value
Make it more similar to "ldb_ildap.c" and also more save
2010-11-11 10:03:41 +01:00
Matthias Dieter Wallnöfer
feb00fe7cc s4:dsdb - proof against empty RDN values where expected
This should prevent crashes as pointed out on the mailing list.
2010-11-11 10:03:40 +01:00
Zahari Zahariev
4fe63d927e Cannot create OU using custom Schema class
If we define our own child class 'subClassOf' system Schema class
e.g. organizationalUnit then we cannot create OU in the Dafualt
Naming Context that has this custom Schama class in the objectClass
attribute.
2010-11-11 10:03:40 +01:00
Matthias Dieter Wallnöfer
e96c9df817 s4:objectclass LDB module - allow RDNs also to come from superclasses
Detected by a testcase written by Zahari Zahariev.
2010-11-11 10:03:40 +01:00
Matthias Dieter Wallnöfer
4f86f297a2 s4:passwords.py - add a test for the normal "userPassword" behaviour
Just to make sure that this works now too
2010-11-11 10:03:40 +01:00
Matthias Dieter Wallnöfer
7f171a9e0f s4:password_hash and acl LDB modules - handle the "userPassword" attribute according to the "dSHeuristics" 2010-11-11 10:03:39 +01:00
Matthias Dieter Wallnöfer
d6c78fbd3a s4:password_hash LDB module - move "samdb_msg_find_old_and_new_ldb_val" into the password_hash LDB module
It's only used there and so I think it doesn't really belong in
"dsdb/common/util.c" (I first thought that it could be useful for ACL checking
but obviously it wasn't).
2010-11-11 10:03:39 +01:00
Matthias Dieter Wallnöfer
eff1e8cd5d s4:libnet/libnet_samsync_ldb.c - remove "userPassword" remove code
It could also be a normal attribute with a normal content, and if it's not
like that then it's for sure empty.
2010-11-11 10:03:39 +01:00
Matthias Dieter Wallnöfer
39f86619f5 s4:local_password LDB module - remove schema checking code and fix some typos
This is now done by the "objectclass_attrs" LDB module.
2010-11-11 10:03:39 +01:00
Matthias Dieter Wallnöfer
ed704c28b2 s4:ldb_modules/util.c - "dsHeuristics" -> "dSHeuristics" 2010-11-11 10:03:38 +01:00
Matthias Dieter Wallnöfer
79548f0da2 s4:selftest/tests.py - skip the "passwords.py" suite on Windows 2000 domain function level
The "userPassword" password change functionality isn't available and so it
causes big parts of the testsuite to fail. On the other hand we've basic tests
in "acl.py" and indirectly also over SAMR and kpasswd so I propose to simply
skip it.
2010-11-11 10:03:38 +01:00
Matthias Dieter Wallnöfer
5ded90ef66 s4:acl.py - two password change tests are expected to fails on Windows 2000 function level 2010-11-11 09:50:06 +01:00
Matthias Dieter Wallnöfer
2403aaa759 s4:upgradehelpers.py - use "clearTextPassword" rather than "userPassword"
It's the default internal s4 password change attribute
2010-11-11 09:12:25 +01:00
Matthias Dieter Wallnöfer
7c59ecec50 s4:speedtest.py - use "unicodePwd" for setting user's password
It's available on all AD hosts (including Windows 2000) and on all configurations!
2010-11-11 09:12:25 +01:00
Matthias Dieter Wallnöfer
0e945697f5 s4:speedtest.py - remove duplicated code 2010-11-11 09:12:25 +01:00
Matthias Dieter Wallnöfer
0a29e552cb s4:speedtest.py - fix script name in the help text 2010-11-11 09:12:25 +01:00
Matthias Dieter Wallnöfer
ed1ca1c49e s4:speedtest.py - make it executable 2010-11-11 09:12:25 +01:00
Matthias Dieter Wallnöfer
cc7f390bf9 s4:python tests - fix script names in the help text 2010-11-11 09:12:24 +01:00
Andrew Tridgell
ee50bdd42f s4-loadparm: fix the FLAG_DEFAULT settings on specially handled parameters
parameters with special handlers also need to clear the FLAG_DEFAULT
flag when set

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov 11 03:39:23 UTC 2010 on sn-devel-104
2010-11-11 03:39:23 +00:00
Andrew Tridgell
21fe96e8f9 s4-provision: include command line provision options in the generated smb.conf
this saves the smb.conf using lp.dump_globals() to ensure that any
command line options (for example directory overrides) are saved in
the generated smb.conf 

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-11 02:57:04 +00:00
Andrew Tridgell
60cb372bd6 s4-devel: useful script for testing join with empty smb.conf
this sets up all the needed --options for a join with a prefix other
than the one compiled in
2010-11-11 02:57:04 +00:00
Andrew Tridgell
e908c26391 s4-test: use IPC$ instead of ADMIN$ for srvsvc NetShareGetInfo test
IPC$ is guaranteed to exist on servers that do RPC, whereas ADMIN$
isn't

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-11 02:57:04 +00:00
Andrew Tridgell
81c9b98ecd s4-join: use the command line loadparm in provision during a join
this allows a join with an empty smb.conf to override locations of
files correctly with --option

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-11 02:57:04 +00:00
Andrew Tridgell
1d7d09a8f7 s4-loadparm: fixed dumping of non-default parms with testparm
when using testparm without -v we should only dump non-default
parameters. This patch fixes up the handling of the FLAG_DEFAULT flag
in loadparm to correctly mark parameters as default or not, including
parametric options

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-11 02:57:04 +00:00
Andrew Tridgell
ed8ea4ed18 s4-server: move the creation of the IPC$ share into ntvfs
the IPC$ share is only used by the ntvfs backends, and doesn't need to
be created on every load of smb.conf. This fixes a problem with
testparm showing the ipc$ share when it isn't defined in smb.conf.

This also removes the admin$ share, which really shouldn't be on by
default. The admin$ share is used for remote software installation,
and normally exposes the c:\windows directory on a windows
server. That makes no sense on Samba. If for some reason a admin$
share is needed, then the admin can create one as usual. Exposing /tmp
via admin$ by default seems like a bad idea.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-11 02:57:04 +00:00
Jeremy Allison
0afb2995a2 Fix bug #7791 - gvfsd-smb (Gnome vfs) fails to copy files from a SMB share using SMB signing.
The underlying problem is that the old code invoked by cli_write() increments
cli->mid directly when issuing outstanding writes. This should now be done only
in libsmb/clientgen.c to make metze's new signing engine works correctly. Just
deleting this code fixes the problem.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Nov 11 02:50:08 UTC 2010 on sn-devel-104
2010-11-11 02:50:08 +00:00
Jeremy Allison
ac0ffba004 Add test that detects problems in the SMB signing code when run through cli_write() (which doesn't use the new async methods).
Unfortunately, and I think due to the socket wrapper code, this doesn't
detect the failure on the build farm, but running the RW-SIGNING test
separately against a Samba or Windows server using signing does.

Jeremy.
2010-11-10 18:07:51 -08:00
Björn JACKE
c4c230bd0f autobuild: perfer to use git mail address in autobuild comment
Signed-off-by: Andrew Tridgell <tridge@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Nov 10 23:56:37 UTC 2010 on sn-devel-104
2010-11-10 23:56:37 +00:00
Günther Deschner
ec50db61fa s4-smbtorture: use test_GetPrinterData{Ex}_checktype calls in RPC-SPOOLSS tests.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Nov 10 15:07:12 UTC 2010 on sn-devel-104
2010-11-10 15:07:12 +00:00
David Disseldorp
1c579318ae s3-spoolss: fix spoolss GetPrinterData behaviour
Windows sends spoolss GetPrinterData requests with an offered buffer
size of zero, Model and TrayFormTable data is commonly requested in
this way.

Samba's GetPrinterData response for the above case includes the correct
error code (WERR_MORE_DATA), however the type field is set to REG_NONE.
This causes Windows (seen on XP and 2k3) to give up on the request.

If the type field is retained (not set to REG_NONE) when responding with
WERR_MORE_DATA, Windows reissues the GetPrinterData request with an
increased offered buffer size.

Signed-off-by: Günther Deschner <gd@samba.org>
2010-11-10 15:23:22 +01:00
Günther Deschner
fa0b44ed9c s4-smbtorture: allow to test returned type after specific error code in PrinterData tests.
Guenther
2010-11-10 15:23:21 +01:00