1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-17 02:05:21 +03:00

68431 Commits

Author SHA1 Message Date
Andrew Bartlett
7d0f04a651 s3-libsmbclient Don't store 'debug_stderr' on the libsmbclient context
Following the review of this patch series by Derrell Lipman, remove
the seperate storage of the debug_stderr variable from the
libsmbclient SMBC_internal_data context.

Andrew Bartlett
2010-11-02 04:36:05 +00:00
Andrew Bartlett
b1099a5b56 s3-libsmbclient Add comments to describe the behaviour of DEBUG()
This isn't quite what you would expect from this interface, but actually
avoids some really nasty situations if you ever have more than one
libsmbclient context in a process.

In the real world, if you have asked for DEBUG() to stderr in one part
of the code, you will want it globally, even in a different thread
(which in the past would have rest everything to stdout again, at
least while starting up).

Andrew Bartlett
2010-11-02 04:36:04 +00:00
Andrew Bartlett
e16c9904c6 s3-libsmbclient-examples Add tests for debug behaviour. 2010-11-02 04:36:04 +00:00
Andrew Bartlett
db2a61ab26 debug Explain the behaviour of setup_logging() more clearly 2010-11-02 04:36:04 +00:00
Andrew Bartlett
4aeb608eca s3-debug Clarify the handling of invalid state.fd values in debug.c
This makes it clear that -1 and 0 are both invalid file descriptor values
for DEBUG output.

Andrew Bartlett
2010-11-02 04:36:04 +00:00
Andrew Bartlett
ed111d11eb s3-debug Move 'load_case_tables()' before lp_set_cmdline() and popt calls
The problem here is that we cannot run lp_set_cmdline() (directly or
indirectly via the popt helpers) until load_case_tables() has been run.

However, load_case_tables does not have auto-initialisation, so we
must init it once, and once only.

Andrew Bartlett
2010-11-02 04:36:04 +00:00
Andrew Bartlett
e64dfdcc71 s3-debug Convert from x_file to real file descriptors.
X_FILE does not gain us anything in this use case, we want our log
messages on disk, not in a buffer, and we don't gain anything from the
X_FILE api.  I discussed the matter with tridge, who feels that to use
FILE in the first place was a mistake, and that X_FILE isn't any
better, but was a stop-gap to avoid issues on solaris.

Andrew Bartlett
2010-11-02 04:36:04 +00:00
Andrew Bartlett
d9f67eebf6 s3-debug Remove last direct assignements to DEBUGLEVEL
All future assignments of the debug level should go via
lp_set_cmdline("log level", "x") because this will ensure the value is
not overwritten in an smb.conf load.

Andrew Bartlett
2010-11-02 04:36:04 +00:00
Andrew Bartlett
cf4de8ec2c s3-debug Remove 'AllowDebugChange' and use lp_set_cmdline() instead
By removing this global variable, the API between the two different
debug systems is made more similar.  Both s3 and s4 now have
lp_set_cmdline() which ensures that the smb.conf cannot overwrite
these the user-specified log level.

Andrew Bartlett
2010-11-02 04:36:04 +00:00
Andrew Bartlett
9da4ace1d9 s3-debug Impove setup_logging() to specify logging to stderr
This change improves the setup_logging() API so that callers which
wish to set up logging to stderr can simply ask for it, rather than
directly modify the dbf global variable.

Andrew Bartlett
2010-11-02 04:36:04 +00:00
Andrew Bartlett
4ae27891f8 lib/debug Use vdprintf rather than manually allocate
This allows the system to use whatever buffers it wants for the string
rather than assuming we need to malloc() it.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Nov  2 00:18:43 UTC 2010 on sn-devel-104
2010-11-02 00:18:43 +00:00
Andrew Bartlett
ad7b551edc s4-torture Remove torture/locktest2.c (no longer compiled and unused)
This is a left-over of a speculative approach to lock testing that
didn't go anywhere.

Andrew Bartlett
2010-11-01 23:34:06 +00:00
Andrew Bartlett
e7eac0e391 lib/util Remove setup_logging_stdout()
This API is no longer required now that we don't attempt to build ndrdump
with the s3 build system, and because the s3 debug system will soon have the
same setup_logging() API.

Andrew Bartlett
2010-11-01 23:34:06 +00:00
Andrew Tridgell
7e23363455 s4-ldb: removed ldb_includes.h
it causes problems with the openchange build as it is not installed

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov  1 21:49:47 UTC 2010 on sn-devel-104
2010-11-01 21:49:47 +00:00
Jelmer Vernooij
ce1eb1f726 talloc: Install pytalloc.h.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Nov  1 17:25:07 UTC 2010 on sn-devel-104
2010-11-01 17:25:07 +00:00
Matthias Dieter Wallnöfer
8770c8fe2f s4:samldb LDB module - the "sAMAccountName" cannot be substituted by nothing
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Nov  1 14:36:24 UTC 2010 on sn-devel-104
2010-11-01 14:36:24 +00:00
Matthias Dieter Wallnöfer
2f9480407d s4:sam.py - additional testing for "servicePrincipalName" updates 2010-11-01 14:53:25 +01:00
Matthias Dieter Wallnöfer
1b2f4c11a0 s4:samldb LDB module - support now the full "servicePrincipalName" update trigger
With "dNSHostName" and/or "sAMAccountName" updates
2010-11-01 14:53:25 +01:00
Matthias Dieter Wallnöfer
3eb0311aa6 s4:samldb LDB module - "sAMAccountName" checker
We need a "talloc_steal" for the retrieved "sAMAccountName" since the
memory is afterwards freed using the "talloc_free" call.
2010-11-01 14:53:25 +01:00
Andrew Tridgell
9b0f8a8e5f s4-ldb: use ldb_set_modules_dir() to load additional ldb modules
this allows ldb_wrap to enable s4 modules in a standalone ldb install
without any additional installation

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov  1 13:47:33 UTC 2010 on sn-devel-104
2010-11-01 13:47:33 +00:00
Andrew Tridgell
9103047782 s4-ldb: enable version checking in dsdb ldb modules 2010-11-01 13:05:04 +00:00
Andrew Tridgell
a386ca8559 s4-ldb: enable ldb module version checking 2010-11-01 13:05:04 +00:00
Andrew Tridgell
8366bb495a s4-ldb: added support for ldb module version checking 2010-11-01 13:05:04 +00:00
Michael Adam
1ccb69aabb s3:winbindd: fix query_user for users with NULL full name.
Not sure whether query_user ever sends a NULL full name.
Query Display Info does, and it does not harm to add the
check here, too.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Nov  1 13:03:33 UTC 2010 on sn-devel-104
2010-11-01 13:03:33 +00:00
Michael Adam
53d19fac5f s3:winbindd: fix query_user_list for users with NULL full_name 2010-11-01 12:21:30 +00:00
Matthias Dieter Wallnöfer
05d7524736 s4:setup/spn_update_list - the DNS SPN is only used in DNS mode
Not all DCs are automatically DNS servers.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Nov  1 12:20:36 UTC 2010 on sn-devel-104
2010-11-01 12:20:36 +00:00
Matthias Dieter Wallnöfer
02547de5f9 s4:ldap.py/sam.py - simplify the objectclass specifications
- For user accounts we only need to specify "user" ("person" is an inherited
  objectclass)
- Don't use the brackets when we have only one objectclass specified
2010-11-01 12:34:51 +01:00
Matthias Dieter Wallnöfer
6f2001efa5 s4:sam.py - test "objectSid" modification lockdown 2010-11-01 12:34:51 +01:00
Matthias Dieter Wallnöfer
7da84bc7b6 s4:samldb LDB module - unify objectSid assignment error messages 2010-11-01 12:34:48 +01:00
Matthias Dieter Wallnöfer
7ca6b3ee6d s4:samldb LDB module - deny "objectSid" modifications
The same as with Windows
2010-11-01 12:34:21 +01:00
Matthias Dieter Wallnöfer
7578e04fb8 s4:provision - adapt the "provision" so that SIDs are only set on entry creation
SID modifications are denied.
2010-11-01 12:25:24 +01:00
Matthias Dieter Wallnöfer
2a25f7515a s4:torture - suppress printf "%llu" on uint64_t variables warnings
The signed/unsignedness does match (always unsigned). The bitlength (64 bit) on
all regular platforms does also. Therefore simply add a cast to
"unsigned long long".
2010-11-01 11:31:33 +01:00
Matthias Dieter Wallnöfer
c8bcf82119 ldb:tools/ldbtest.c - fix build warning
Cause was an incomplete declaration.
2010-11-01 11:31:32 +01:00
Andrew Tridgell
e59a8a563b s4-ldb: fixed build of paged searches
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov  1 09:41:27 UTC 2010 on sn-devel-104
2010-11-01 09:41:27 +00:00
Andrew Tridgell
952ce1521c s4-ldb: fixed build of oLschema2ldif 2010-11-01 18:55:20 +11:00
Andrew Tridgell
6f2c4abadd s4-ldb: convert existing ldb tools to use new command line hooks
the usage() function needs to take a ldb context, as the popt_options
is specific to the ldb context

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-01 18:55:20 +11:00
Andrew Tridgell
f924a022cb s4-ldb: added ldb command line hook support
ldb modules can now add hooks to the command line processing for ldb
tools

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-01 18:55:20 +11:00
Andrew Tridgell
fd8815335d s4-ldb: added samba_extensions ldb module
this module hooks into the ldb command line processing, to add extra
command line options and initialisation of samba4 internal subsystems
such as gensec

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-01 18:55:20 +11:00
Andrew Tridgell
cdf19ec5e2 s4-ldb: moved the ldb_ildap backend into lib/ldb-samba
this backend is samba4 specific
2010-11-01 18:55:20 +11:00
Andrew Tridgell
d103f2d346 s4-ldb: added support for general ldb hooks in modules
this allows a ldb module to register a hook function called at various
stages of processing. It will be initially used for ldb command line
hooks, but should work generally.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-01 18:55:19 +11:00
Andrew Tridgell
c74601e0b3 s4-ldb: added an override flag to ldb_register_backend()
this will be used to allow a system ldb build with an ldb backend to
have its ldap handler overridden by the s4 one
2010-11-01 18:55:19 +11:00
Andrew Tridgell
05b37385fc s4-ldb: it is not an error for the modules directory to not exist 2010-11-01 18:55:19 +11:00
Andrew Tridgell
28c1e4d3eb s4-modules: get rid of the remaining static prototypes for modules
the waf build now generates the prototype declarations for us
2010-11-01 18:55:19 +11:00
Andrew Tridgell
4404b4c700 waf: removed the module aliases code
This is not needed with the new ldb modules approacg
2010-11-01 18:55:19 +11:00
Andrew Tridgell
7eb2eed156 s4-dsdb: convert the rest of the ldb modules to the new module type 2010-11-01 18:55:19 +11:00
Andrew Tridgell
43f7c9ca26 s4-test: we don't need to set LDB_MODULES_PATH any more 2010-11-01 18:55:19 +11:00
Andrew Tridgell
6db57658a9 s4-ldb: removed the old ldb module loading style
this gets rid of some particularly obscure cpp macros for module lists
2010-11-01 18:55:19 +11:00
Andrew Tridgell
be8e91d9ca s4-ldb: convert the rest of the ldb modules to the new style 2010-11-01 18:55:19 +11:00
Andrew Tridgell
b887b69151 s4-process_model: use the static module prototyping
remove the manual prototyping of static init functions
2010-11-01 18:55:19 +11:00
Andrew Tridgell
0a703c7fd1 waf: added automatic prototyping of static module init functions
this avoids the need to manually list all our static init functions in
the code

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-01 18:55:19 +11:00