Jeremy Allison
835bfbb8ac
r16267: Fix Klocwork #401 , #402 - ensure format specifier
...
limited. Fix memleak in printing gencache contents.
Jeremy.
(This used to be commit 81731e1f68cdf4af80733338238aeae0a7d108c0)
2007-10-10 11:17:28 -05:00
Günther Deschner
e942ca4e0a
r16261: Smaller fixes for net ads password.
...
Guenther
(This used to be commit 689ae22c80a890278610d9ada1eb4fa5e37bd5ce)
2007-10-10 11:17:28 -05:00
Gerald Carter
22b52b818b
r16255: Fix 'net ads join' when the workgroup is set incorrectly
...
in smb.conf. This did work before the join rewrite.
Samba will have problems if you try to run any of the daemons
with an incorrect workgroup but it should not fail to join.
The summary is that a member server should always use it's
own machine name when setting up schannel since that is
the only account it has. Thanks to Volker for the discussion.
(This used to be commit 95763b94f709fe1ad9e381dbc6b364c2f3759024)
2007-10-10 11:17:28 -05:00
Günther Deschner
a6e662f556
r16253: Fix another host/ UPN case in (the currently unused)
...
cli_rpc_pipe_open_krb5.
Guenther
(This used to be commit fa19099112490daa085bb310f2f4ed877bb22b40)
2007-10-10 11:17:28 -05:00
Volker Lendecke
c56f002525
r16252: Fix Klocwork ID 1119, 1121.
...
Volker
(This used to be commit 678bbcf06109b276d3e4514c3788a9fb31348de0)
2007-10-10 11:17:28 -05:00
Volker Lendecke
d93b408678
r16251: for i in seq 1 1000
...
do
echo "I will always compile before commit :-)"
done
Also fix Klokwork ID 806.
Volker
(This used to be commit 4974c598c00abc20cfb73eee12a7c49c279e0f54)
2007-10-10 11:17:28 -05:00
Volker Lendecke
05f59b2c34
r16250: Fix Klokwork IDs 148, 151, 152, 154.
...
Volker
(This used to be commit d7a75ee94db009085165c062f73b68162a8b6da8)
2007-10-10 11:17:28 -05:00
Volker Lendecke
fdced4467f
r16249: Fix Klokwork ID 130
...
(This used to be commit 09586824f6568fb3305e3e59ba6bc8f5f632fb56)
2007-10-10 11:17:27 -05:00
Volker Lendecke
580e9817a2
r16248: Fix Coverity ID 297
...
(This used to be commit e56e3c19e1244e2b7409d57a030ca8b7ec446932)
2007-10-10 11:17:27 -05:00
Volker Lendecke
99f271b3cb
r16247: Fix Coverity ID 296
...
(This used to be commit b82c95cb438b57bb8910e26657f8ffb590fe02df)
2007-10-10 11:17:27 -05:00
Jeremy Allison
7e40933d7b
r16245: Cope with string being zero len. Klocwork bug #410 .
...
Jeremy.
(This used to be commit afe2d4c49333309b940cec8408ccd37ed3747cb7)
2007-10-10 11:17:27 -05:00
Jeremy Allison
8f2d6e4852
r16243: Fix Klocwork bugs #581 and #706 , ensure we check
...
the end of array first in the loop. Reformat to
modern standards.
Jeremy.
(This used to be commit 66275bd3bc56e67759dbabe77cb2ba019c6f4887)
2007-10-10 11:17:27 -05:00
Jeremy Allison
f9147c4e40
r16241: Fix Klocwork #106 and others like it.
...
Make 2 important changes. pdb_get_methods()
returning NULL is a *fatal* error. Don't try
and cope with it just call smb_panic. This
removes a *lot* of pointless "if (!pdb)" handling
code. Secondly, ensure that if samu_init()
fails we *always* back out of a function. That
way we are never in a situation where the pdb_XXX()
functions need to start with a "if (sampass)"
test - this was just bad design, not defensive
programming.
Jeremy.
(This used to be commit a0d368197d6ae6777b7c2c3c6e970ab8ae7ca2ae)
2007-10-10 11:17:27 -05:00
Jeremy Allison
a1e0a0e928
r16230: Fix Klocwork #861 and others. localtime and asctime
...
can return NULL. Ensure we check all returns correctly.
Jeremy.
(This used to be commit 6c61dc8ed6d84f310ef391fb7700e93ef42c4afc)
2007-10-10 11:17:26 -05:00
Günther Deschner
2b99951e75
r16222: Fix DEBUG statements.
...
Guenther
(This used to be commit 5ecfaf7d505e6acc23a06dd64d00f5e6fb8efe6f)
2007-10-10 11:17:26 -05:00
Günther Deschner
e8b4c92f32
r16221: No need for friednly error messages at log level 10.
...
Guenther
(This used to be commit 58a7c0900325065cc969eb4f2f4c85d41e27bc89)
2007-10-10 11:17:26 -05:00
Gerald Carter
b32d2ecf9c
r16219: BUG 3836, 3837, 3004: compile warning fixes from Jason Mader.
...
(This used to be commit 6c1f1c091f5e87bf9464fe8ad7eb2cb683819a62)
2007-10-10 11:17:26 -05:00
Jeremy Allison
2e8b3ca0cb
r16216: Add debug messages to make it possible to try and
...
debug why a job pause or resume command is not being
done.
Jeremy.
(This used to be commit e6aacb1426bd04c4006f7be66228f9f8d9a7065d)
2007-10-10 11:17:26 -05:00
Jeremy Allison
a5da0a72e1
r16213: Fix Klocwork #852 . iface_n_ip can potentially
...
return NULL. Ensure we don't deref.
Jeremy.
(This used to be commit c2f0ea2ff2f6ad925cee9c85110c6ad828ffb7a9)
2007-10-10 11:17:26 -05:00
Jeremy Allison
d4a80fdf38
r16209: Klocwork bug #66 , ensure no null deref.
...
Jeremy.
(This used to be commit 79e693798cf322071ea64a4014a01ad9eaba73e8)
2007-10-10 11:17:25 -05:00
Jeremy Allison
069397c63e
r16207: Ensure we don't allocate an OID string unless
...
we know we don't have an error. Klocwork #6 .
Jeremy.
(This used to be commit 2c1a2d7b40e7ef353461f97f5c69c2079b5670ab)
2007-10-10 11:17:25 -05:00
Gerald Carter
6cb8d09710
r16206: Don Meyer <dlmeyer@uiuc.edu> pointed out that RHEL4 rpms use 'Epoch: 0' so work around that
...
(This used to be commit 304b7913cd25a024269fecdd541af06836816f68)
2007-10-10 11:17:25 -05:00
Gerald Carter
e6b64f6157
r16205: Fix 'make install' when srcdir != builddir
...
(This used to be commit 44d4bab991d5fc88005a542d2490ae3254a0f5b5)
2007-10-10 11:17:25 -05:00
Volker Lendecke
0372e03722
r16204: Fix Klocwork # 14
...
localtime() can return NULL.
Volker
(This used to be commit 07c5dcb8633e6fadb596dc5a22d8d31b2e16a3ef)
2007-10-10 11:17:25 -05:00
Volker Lendecke
a47ffac30d
r16203: Fix potentially writing one result of strtok beyond the end of alt_path.
...
Found by Klocwork, ID 653.
Volker
(This used to be commit 4cb8cf221f986b15de3ac608b173310c14248533)
2007-10-10 11:17:25 -05:00
Jeremy Allison
92db75b4a2
r16202: Fix Klocwork #3 . Strange - was already fixed in HEAD.
...
Jeremy.
(This used to be commit 319f80bbf0455cfaf80eab51313a56db4ed04ac5)
2007-10-10 11:17:25 -05:00
Volker Lendecke
edcffcbe28
r16201: Fix Klocwork 439
...
(This used to be commit b369d0891afe8b777b837eaac317131232568ca7)
2007-10-10 11:17:24 -05:00
Jeremy Allison
c0e4753cfc
r16199: Fix Klocwork #1 - ensure we test the first
...
strtok for NULL.
Jeremy.
(This used to be commit 98751e8190317416de56b4a19a489c5f4b7d6bc9)
2007-10-10 11:17:24 -05:00
Volker Lendecke
4d1688bf6b
r16198: Fix Klocwork 1023
...
(This used to be commit 3a7d01afbebe5c4c36935b6128998e1327c8f856)
2007-10-10 11:17:24 -05:00
Volker Lendecke
8fa2907efd
r16197: Fix Klocwork id 1338
...
(This used to be commit 963ae5bd144b90e71331a88029698a1a6dc52190)
2007-10-10 11:17:24 -05:00
Volker Lendecke
15e26314b6
r16196: A bit of defensive programming:
...
Klocwork ID 1773 complained about oldest being dereferenced in line 2275 where
it could be NULL. I think you can construct extreme racy conditions where this
actually could happen.
Volker
(This used to be commit b5602cc4f1d77ed48ddca0f7f42b28706160c923)
2007-10-10 11:17:24 -05:00
Gerald Carter
668727d035
r16195: starting development for 3.0.24pre1
...
(This used to be commit 1b64f9a48bbb5a88c2029585e208865b41f2f423)
2007-10-10 11:17:24 -05:00
Gerald Carter
e52615f957
r16193: fix packaging dependency on RH platforms for the Unicode::MapUTF8 perl module (caused by upgarde in smbldap-tools)
...
(This used to be commit abca3b12e78814a395b806a9969a8f12b3230dfd)
2007-10-10 11:17:24 -05:00
Günther Deschner
395aa679f0
r16192: Fix timeformats in the winbind response struct.
...
(pam_winbind users were forced to change a password inappropriately)
Guenther
(This used to be commit 65643d31725a4e3fe157d66e9ecad03a65a484e2)
2007-10-10 11:17:23 -05:00
Günther Deschner
1628d33ba0
r16190: Fix more memleaks.
...
Guenther
(This used to be commit dfebcc8e19bee06b7c03f88845314e9cfd6f398a)
2007-10-10 11:17:23 -05:00
Günther Deschner
2828356be3
r16187: Fix memleak.
...
Guenther
(This used to be commit e7d2b84aba2f2f5d844ba6a5fdcce35c3750d0b2)
2007-10-10 11:17:23 -05:00
Volker Lendecke
3ea740f5e5
r16156: Fix storing NULL in the wrong place. Klocwork id's 127 and 128.
...
Volker
(This used to be commit 7674a4f8361d3f3b649245118b82d8a074a2760e)
2007-10-10 11:17:23 -05:00
Jeremy Allison
685aed3fb4
r16155: Janitor for jelmer.
...
Fix typo in DEBUG()
Jeremy.
(This used to be commit da768bf9c2761884cc97f690133d6897ed353e15)
2007-10-10 11:17:23 -05:00
Günther Deschner
ee1105754c
r16154: Fix winbind function table typo.
...
Guenther
(This used to be commit aeff1f0c47992ce3941e27e63f9b1516c4918963)
2007-10-10 11:17:23 -05:00
Volker Lendecke
ab710c9e25
r16153: Fix possible NULL dereference found by Klocwork # 252
...
(This used to be commit 128260527b90d77ca3dfc900e012018ef00ba9e0)
2007-10-10 11:17:23 -05:00
Volker Lendecke
780f121462
r16150: Fix possible NULL dereference found by Klocwork ID # 17
...
(This used to be commit 3159bd3a4e3ad70c60fea4cacc892be9f1d71ab9)
2007-10-10 11:17:22 -05:00
Volker Lendecke
21eeddb80d
r16141: Dummy commit to make the build farm re-test against Samba4 16140
...
(This used to be commit a1fcacf75683e4c08236bb4cc4164678ea1a1ce4)
2007-10-10 11:17:22 -05:00
Alexander Bokovoy
21706838f5
r16138: By default, rootsbindir relies on SBINDIR so import it here
...
(This used to be commit a18af427d7ea7b5a04d7006d10299d9e43317ae4)
2007-10-10 11:17:22 -05:00
Alexander Bokovoy
c403a5525c
r16136: By default, rootsbindir relies on SBINDIR so import it here
...
(This used to be commit 5ffb424641bfc71ce396800a6e426015b11fd6ba)
2007-10-10 11:17:22 -05:00
Gerald Carter
f337a089d1
r16131: fix RedHat 9 spec files
...
(This used to be commit 1ffb0f06adeb1658fa1f5eed747841c6ff1e5665)
2007-10-10 11:17:22 -05:00
Gerald Carter
7112413350
r16130: fix a shell portability issue for Solaris sh in installman.sh
...
(This used to be commit 9be3e07884e7f8121bc64766e7d036495cd94a15)
2007-10-10 11:17:22 -05:00
Jeremy Allison
3b469083be
r16126: Janitor for Volker..... This looks correct to me.
...
Jeremy.
Fix a parsing error that became apparent in 'make test': If we have no
group
rids in the info3 we set the array buffer pointer to "1" but fail to
actually
ship the array.
Volker.
(This used to be commit ee1b9207d3119c2b3e7c1c4e59250dbd323eae6a)
2007-10-10 11:17:22 -05:00
Günther Deschner
38060f70a5
r16122: As we use 'inetOrgPerson' as structural objectclass for new accounts for
...
eDir, we already add 'sn' as required attribute on LDAP add
operations.
When we modify an entry, we need to request 'sn' as well in our
attribute lists, so that we don't try to add it a second time.
Guenther
(This used to be commit e018ea3d1d70e68e6802843f88b3245dc09244c9)
2007-10-10 11:17:21 -05:00
Günther Deschner
d28456fe22
r16121: Fix a eDir related memory leak.
...
Guenther
(This used to be commit 322f1664df553d95fcdfc24f19bd7f34ce9b834b)
2007-10-10 11:17:21 -05:00
Günther Deschner
97f496a0e3
r16117: Make winbindd work again in security=ads.
...
We still used the old HOST/* UPN to get e.g. users, now we need
samaccountname$@REA.LM .
Guenther
(This used to be commit f6516a799aec2db819f79b9a1e641637422a9b4c)
2007-10-10 11:17:21 -05:00