Jeremy Allison
8962be69c7
Make us clean under valgrind --leak-check=full by using talloc_autofree_context() instead of NULL.
...
Remove the code in memcache that does a TALLOC_FREE on stored pointers. That's a disaster waiting
to happen. If you're storing talloc'ed pointers, you can't know their lifecycle and they should
be deleted when their parent context is deleted, so freeing them at some arbitrary point later
will be a double-free.
Jeremy.
2008-11-06 20:48:13 -08:00
Herb Lewis
7ae6253455
Convert to use VFS layer.
2008-11-06 20:40:20 -08:00
Jeremy Allison
8b4b5c3a92
Add wrapper str_list_make_v3() to replace the old S3 behavior of
...
str_list_make(). From Dan Sledz <dan.sledz@isilon.com>:
In samba 3.2 passing NULL or an empty string returned NULL.
In master, it now returns a list of length 1 with the first string set
to NULL (an empty list).
Jeremy.
2008-11-06 18:53:00 -08:00
Günther Deschner
2c5a9f0a57
s4-test: skip netr_DatabaseRedo test.
...
Guenther
2008-11-06 23:25:40 +01:00
Volker Lendecke
ace87f16c0
For proxied named pipes, connect to np/<pipe_name> and send auth info
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2008-11-06 21:39:15 +01:00
Stefan Metzmacher
e9b8dd561f
s3: build ndr_named_pipe_auth.c
...
metze
2008-11-06 21:39:15 +01:00
Stefan Metzmacher
6815fd1730
s3: rpc: let serverinfo_to_SamInfo3() work with no pipe_session_key
...
metze
2008-11-06 21:39:14 +01:00
Stefan Metzmacher
9666582b50
s4: rpc_server: listen on named_pipes
...
metze
2008-11-06 21:39:14 +01:00
Stefan Metzmacher
21aa4ea6b9
s4: smbd: implement stream_socket_named_pipe()
...
For now implement just a very simple protocol
to negotiate the transport session info.
We may need to pass more info later,
e.g. client ip or name...
metze
2008-11-06 21:39:13 +01:00
Stefan Metzmacher
1a60fc02d8
librpc/idl: Add named_pipe_auth.idl to Samba4
...
metze
2008-11-06 21:39:13 +01:00
Jeff Layton
32695912dd
mount.cifs: use lock/unlock_mtab scheme from util-linux-ng mount prog
...
The util-linux-ng sources have a good, but rather complex scheme for
locking the mtab before updating it. Mount helpers need to follow the
same scheme. Advisory locking only works if everyone is using the same
locking scheme.
Copy the routines we need from util-linux-ng into a separate source file
and then have mount.cifs and umount.cifs link in this object.
The long term goal is to have these routines in a separate helper
library (libmount). Mount helpers can then dynamically link in that lib.
Until that happens, this should serve as a suitable stopgap solution.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2008-11-06 15:07:07 -05:00
Günther Deschner
db26f7b7c4
s4-smbtorture: add test for netr_DatabaseRedo.
...
Guenther
2008-11-06 18:52:48 +01:00
Günther Deschner
008ac81b31
s3-rpcclient: add database_redo command.
...
Guenther
2008-11-06 18:51:38 +01:00
Günther Deschner
884c3b301c
s3-build: rerun make samba3-idl.
...
Guenther
2008-11-06 18:51:08 +01:00
Günther Deschner
7bd12a878b
netlogon: use 8bit SamDatabaseID and DeltaEnum in netr_ChangeLogEntry.
...
Guenther
2008-11-06 18:50:24 +01:00
Günther Deschner
c353c53692
netlogon: add 8bit varients of netr_SamDatabaseID8Bit and netr_DeltaEnum.
...
Guenther
2008-11-06 18:50:12 +01:00
Günther Deschner
e721e3b7f5
netlogon-idl: use netr_ChangeLogEntry subcontext in netr_DatabaseRedo.
...
Guenther
2008-11-06 18:50:03 +01:00
Günther Deschner
64fff239e0
netlogon-idl: add netr_ChangeLogObject union.
...
Guenther
2008-11-06 18:49:55 +01:00
Günther Deschner
bc6cb550ed
netlogon-idl: add netr_ChangeLogFlags.
...
Guenther
2008-11-06 18:49:45 +01:00
Günther Deschner
66abdaac95
netlogon-idl: add netr_ChangeLogEntry.
...
Guenther
2008-11-06 18:49:36 +01:00
Jeremy Allison
0db0ce4974
Fix bug #5825 - Account locking out doesnt work with an LDAP backend.Based on a problem found by Boyang. Only the pdb_nds backend implements login attempts so this was broken for tdbsam and ldap.
...
Jeremy.
2008-11-06 06:42:04 -08:00
Günther Deschner
8d69a65110
s3-dsgetdcname: fix reply generation (forgot to map nt1 to nt5ex).
...
Guenther
2008-11-06 13:40:52 +01:00
Günther Deschner
0be668f147
doserr: add WERR_NO_TRUST_SAM_ACCOUNT.
...
Guenther
2008-11-06 13:40:47 +01:00
Jeremy Allison
87f563c230
Start factoring out the inheritance differences.
...
Jeremy.
2008-11-06 01:58:56 -08:00
Jeremy Allison
7522ef15ac
Final fix to make us pass NULL SD test in RAW-ACLs. Not sure if this is 100% right. Only inheritance left to fix.
...
Jeremy.
2008-11-06 01:45:40 -08:00
Jeremy Allison
24c598b1b9
Don't call FSET_NT_ACL on file create if there's no SD to set. Leave the default ACL in place.
...
Jeremy.
2008-11-06 01:40:21 -08:00
Jeremy Allison
4af3c2830a
Only one more issue with NULL ACL test left to solve.
...
Jeremy.
2008-11-06 01:01:01 -08:00
Jeremy Allison
f640135d12
Fix crash in module, get more of the NULL acl test right.
...
Jeremy.
2008-11-06 00:50:56 -08:00
Jeremy Allison
d93041e336
Add reference to bug #4308 to remind me to add regression test to smbtorture.
...
Jeremy.
2008-11-05 19:11:40 -08:00
Günther Deschner
6a3a8f7e16
s3-build: re-run make samba3-idl.
...
Guenther
2008-11-05 15:10:52 +01:00
Günther Deschner
7ac5660d2c
s3-samr-idl: fix samr_QueryUserInfo2.
...
Guenther
2008-11-05 15:10:01 +01:00
Günther Deschner
abd2139b42
s3-samr-idl: fix samr_ValidatePassword.
...
Guenther
2008-11-05 15:09:50 +01:00
Volker Lendecke
b9211deba8
Fix the build
2008-11-05 10:48:43 +01:00
Volker Lendecke
95d1825a51
Fix a const warning
2008-11-04 21:53:14 +01:00
Volker Lendecke
6b4d48c4bf
Convert blocking.c to store a smb_request instead of just inbuf
2008-11-04 20:52:07 +01:00
Volker Lendecke
d5f91d7a08
Simplify logic of cancel_pending_lock_requests_by_fid()
...
The only caller of this function is locking_close_file(). This checks itself if
brl_lock != NULL. The additional check is not necessary here.
2008-11-04 20:52:07 +01:00
Volker Lendecke
3376e7a6a0
Slightly simplify logic in process_lockingX()
...
The "else" is pointless here, we did a "return True" in the if branch.
2008-11-04 20:52:07 +01:00
Volker Lendecke
59e237cae5
Slightly simplify logic in remove_pending_lock_requests_by_mid()
...
Use "continue" for (SVAL(blr->inbuf,smb_mid) != mid)
2008-11-04 20:52:07 +01:00
Volker Lendecke
eddb43c713
Slightly simplify logic in cancel_pending_lock_requests_by_fid()
...
Use a "continue" for (blr->fsp->fnum != fsp->fnum)
2008-11-04 20:52:07 +01:00
Volker Lendecke
f0ba601c26
Convert blocking.c to use talloc
2008-11-04 20:52:06 +01:00
Volker Lendecke
8987641db8
Rewrite aio.c to keep the whole smb_request structure, not just the inbuf
2008-11-04 20:52:06 +01:00
Volker Lendecke
b8125663d9
Make "inbuf" a talloc child of "smb_request" for normal smb requests
...
This is necessary if we want to keep the whole smb_request for deferred ops.
The explicit settings of req->inbuf will be removed once all those deferring
operations are converted to store the whole request and not just the inbuf.
2008-11-04 20:52:06 +01:00
Volker Lendecke
e4897a5376
Add construct_reply_common_req wrapper
...
The goal is to remove the remaining direct calls to construct_reply_common.
2008-11-04 20:52:06 +01:00
Volker Lendecke
d62ff20cd5
Fix nonempty blank lines
2008-11-04 20:52:06 +01:00
Volker Lendecke
71bc6e93a1
Use talloc for struct aio_extra
2008-11-04 20:52:06 +01:00
Joe Smith
d997435f2d
Fixed typo in source/utils/net_rap.c
2008-11-04 20:40:23 +01:00
Günther Deschner
3fa7a1b085
s3-libnet_samsync: print new line in display output.
...
Guenther
2008-11-04 19:55:07 +01:00
Günther Deschner
89fac8c1b6
s4-smbtorture: fix some obvious copy-paste errors.
...
Guenther
2008-11-04 19:55:07 +01:00
Volker Lendecke
37f4c70920
Ignore 3.0 style invalid group mappings during upgrade to ldb
2008-11-04 10:56:24 +01:00
Jeremy Allison
bfc59f63f3
Pass all of RAW-ACLS except for inheritence. Working on that next.
...
Jeremy.
2008-11-04 01:34:08 -08:00