1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00

26857 Commits

Author SHA1 Message Date
Rusty Russell
2f67fae18b samba3sam.py: don't assume order of ldb results.
Switching to tdb2 breaks this test horribly, because it relied on the
order of TDB1 traversal.  Fix it to sort te results (by db), then
check them.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-02 10:22:06 +09:30
Rusty Russell
0204ae6229 lib/util/time.c: timeval_current_ofs_usec
Several places want "microseconds from current time", and several were
simply handing "usecs" values which could be over a million.

Using a helper to do this is safer and more readable.

I didn't replace any obviously correct callers (ie. constants).

I also renamed wait_nsec in source3/lib/util_sock.c; it's actually
microseconds not nanoseconds (introduced with this code in Volker's
19b783cc Async wrapper for open_socket_out_send/recv).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-01 10:38:47 +02:00
Rusty Russell
56e72337b0 lib/util/time.c: timeval_current_ofs_msec
Several places want "milliseconds from current time", and several were
simply doing "msec * 1000" which can (and does in one place) result in
a usec value over 1 a million.

Using a helper to do this is safer and more readable.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-01 10:38:47 +02:00
Andrew Tridgell
1bc1ac0d08 samba-tool: improved error handling in user setexpiry 2011-06-01 17:24:36 +10:00
Andrew Tridgell
7b3d8b6c90 samba-tool: improved user enable error handling 2011-06-01 17:24:36 +10:00
Theresa Halloran
23177b5f44 s4:samba-tool: Move samba-tool setexpiry to samba-tool user setexpiry <user>
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-06-01 17:24:36 +10:00
Theresa Halloran
726ee12bb4 s4/samba-tool: Move samba-tool enableaccount to samba-tool user enable command.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-06-01 17:24:36 +10:00
Sean Finney
08abd1f5e8 librpc/ndr: add new LIBNDR_FLAG_STR_RAW8 for ndr_pull_string
Introduce a new flag, LIBNDR_FLAG_STR_RAW8, which indicates that libndr
should not attempt to convert the corresponding byte sequence, and place
the responsibility on the caller to do so later.

This is needed in cases where the string is known to be 8-bit and either
NULL terminated or of known length, but in an unspecified character set.
For example, when pulling PT_STRING8 properties from an exchange server
via libmapi + libndr, the codepage is neither known nor in the control
of the caller, and is determined by subsequent properties requested from
the server.  Therefore the client would like to fetch all properties in
one large batch, and convert the resulting strings locally.

This commit also includes some (basic) tests of each of the flags'
respective behaviors with the ndr push/pull string functions, in a new
source4 torture test suite ndr.ndr_string.

Signed-off-by: Sean Finney <seanius@seanius.net>
2011-06-01 00:30:40 +02:00
Andrew Bartlett
c004a932c4 libcli/util Remove ntstatus_check_dos_mapping
This has been set to true since the global loadparm was removed in
2008, and removes an #ifdef SAMBA_BUILD == 4

Andrew Bartlett
2011-05-31 15:10:20 +10:00
Andrew Bartlett
159fad92d9 s4-libcli Merge error map order with source3 errmap_unix.c
This makes it easier to see what the actual differences here are.

Andrew Bartlett
2011-05-31 02:57:19 +02:00
Andrew Bartlett
81905585c0 heimdal: Remove getprogname and setprogname from the heimdal import 2011-05-31 00:32:07 +02:00
Andrew Bartlett
b19fe1995a heimdal_build: Don't use heimdal's getprogname() and setprogname()
Writing into an __progname variable spooks me, and if we use the local
variable, then we duplciate the system one, which fails SYMBOLCHECK

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Gregor Beck
de10847973 s4:torture: fix SEGFAULT in raw.acl.dynamic
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-30 17:42:27 +02:00
Matthias Dieter Wallnöfer
ff47927fb9 s4:samldb LDB module - check if the RODC group exists if creating an RODC
Older AD deployments simply don't have it and hence there is no RODC
support.

Reviewed-by: abartlet

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed May 25 10:26:37 CEST 2011 on sn-devel-104
2011-05-25 10:26:37 +02:00
Matthias Dieter Wallnöfer
08f5ed8b4f s4:samldb LDB module - better to call "samldb_prim_group_trigger"
"samldb_prim_group_trigger" which as a wrapper calls "samldb_prim_group_change"
for a LDB modify operation.

Reviewed-by: abartlet
2011-05-25 08:57:51 +02:00
Matthias Dieter Wallnöfer
779d882aca s4:samldb LDB module - convert a "dsdb_module_search" into "dsdb_module_search_dn"
It saves us from checking the number of returned entries.

Reviewed-by: abartlet
2011-05-25 08:57:46 +02:00
Matthias Dieter Wallnöfer
11937ce5e1 s4:sam.py - uncomment/enhance some account type tests
Reviewed-by: abartlet
2011-05-25 08:57:42 +02:00
Matthias Dieter Wallnöfer
2ad0100d5b s4:samldb LDB modules - only objectClass "computer" is allowed to embed all types of account
Reviewed-by: abartlet
2011-05-25 08:57:35 +02:00
Matthias Dieter Wallnöfer
4740473591 s4:sam.py - tests for "isCriticalSystemObject" attribute
Reviewed-by: abartlet
2011-05-25 08:57:29 +02:00
Matthias Dieter Wallnöfer
0c753e503c s4:samldb LDB module - fix "isCriticalSystemObject" behaviour
Tests against Windows Server show that it gets set to "FALSE" (not
deleted) if we change the account type to a domain member.

Reviewed-by: abartlet
2011-05-25 08:57:24 +02:00
Matthias Dieter Wallnöfer
c72d32da6d s4:sam.py - unchanged "primaryGroupID" when account type remains the same
Enhance the testcase with a workstation example.

Reviewed-by: abartlet
2011-05-25 08:57:19 +02:00
Matthias Dieter Wallnöfer
b712c7273d s4:samldb LDB module - fix the behaviour when changing the "userAccountControl"
Ekacnet was not quite right yet but his patch made me think further.
This primary group changing is only needed if the account type changes.
With this patch we do one more search if the "userAccountControl"
changes but we save us from doing these unneeded and wrong modify replace
operations most of the time.

Reviewed-by: abartlet
2011-05-25 08:57:09 +02:00
Andrew Bartlett
53b0c44d8c s4-provision Use correct tkey-gssapi-credential
We changed to ${DNSNAME} (the fully qualified domain name) a while
back, and while it's usually functionally idential to the previous
setting, this breaks down if there is more than one DNS server.

Andrew Bartlett
2011-05-25 12:12:53 +10:00
Andrew Bartlett
e7cf95c541 selftest: Make knowfail/skip files consistent, always use ^prefix
Except in one case (where we mark printing tests as knownfail), this
has all our regular expressions start with ^, which ensures we don't
accidentially mix up the samba3/samba4 prefix here.

Because of the particular values in these files at the moment, this
should not change the set of tests, but it will help to ensure that
future edits follow the correct pattern.

Andrew Bartlett
2011-05-25 09:15:18 +10:00
Matthieu Patou
1b5c2d8e92 s4:sam.py - add tests to check that setting "userAccountValue" on usersdon't impact the "primaryGroupID" attribute
Notice: The domain administrators groups isn't referenced as "Domain Admins"
since this name could differ.

Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat May 21 19:19:57 CEST 2011 on sn-devel-104
2011-05-21 19:19:57 +02:00
Matthieu Patou
e3aa200a14 s4:samldb LDB module - don't change the "primaryGroupId" on LDB modifications unless we are a computer/dc/rodc
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
2011-05-21 16:25:12 +02:00
Matthias Dieter Wallnöfer
67bf5cfc08 s4:lsa RPC server - handle LDB flags as "unsigned"
Signed-off-by: Metze
2011-05-21 16:21:14 +02:00
Matthias Dieter Wallnöfer
d34205add3 s4:ldb-samba/ldb_wrap.*-dsdb/samdb/samdb.c - handle LDB connection flags as unsigned
The LDB API ("ldb_connect") prescribes that they should be "unsigned".

Signed-off-by: Metze
2011-05-21 16:21:14 +02:00
Matthias Dieter Wallnöfer
4618a7f3a1 ldb:pyldb.c - all flags should be unsigned
Adapt it to the previous commits

Reviewed-by: Jelmer + Metze
2011-05-21 16:21:13 +02:00
Matthias Dieter Wallnöfer
74b50b47e9 ldb:ldb_sqlite3.c - all LDB flags should be handled as "unsigned"
Signed-off-by: Metze
2011-05-21 16:21:13 +02:00
Matthias Dieter Wallnöfer
3956e6840d ldb:tools/cmdline.c + tools/ldbtest.c - the connection flags are typed as "unsigned"
Signed-off-by: Metze
2011-05-21 16:21:13 +02:00
Matthias Dieter Wallnöfer
e6c5e11116 ldb:ldbtest.c - make more use of LDB constants
Signed-off-by: Metze
2011-05-21 16:21:13 +02:00
Matthias Dieter Wallnöfer
5c4fabb08e s4:torture - always cast correctly when using the "%x" format string argument
Signed-off-by: Metze
2011-05-21 16:21:12 +02:00
Matthias Dieter Wallnöfer
f44808fa11 s4:auth/ntlmssp/ntlmssp_server.c - add "const" in front of "dnsdomain"
Signed-off-by: Metze
2011-05-21 16:21:12 +02:00
Matthieu Patou
850cca3996 add a demo script for dirsync
Signed-off-by: Andrew Tridgell <tridge@samba.org>

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sat May 21 15:40:26 CEST 2011 on sn-devel-104
2011-05-21 15:40:26 +02:00
Matthieu Patou
c2fa348831 s4-dsdb: add unit tests for dirsync control
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-05-21 16:25:19 +04:00
Matthieu Patou
fa400af18b s4-dsdb: implementation of the dirsync control
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-05-21 16:25:19 +04:00
Matthieu Patou
7b4e1e78be s4-dsdb: introduce dsdb_module_search_tree
With this function your own search tree can be specified

This function is similar to ldb_build_search_req_ex as it allows to
pass a parse tree structure.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-05-21 14:39:12 +04:00
Matthieu Patou
37b1662a38 s4-dsdb: relax a bit the checks on read acl when dirsync control is specified
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-05-21 14:39:12 +04:00
Matthieu Patou
1d0fc445fa s4-dsdb: create flag for requesting ACL relax in case of DIRSYNC request
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-05-21 14:39:12 +04:00
Matthieu Patou
df83e9c15e s4: do not change the critical flag when it's on a dirsync control
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-05-21 14:39:12 +04:00
Matthieu Patou
49c99d0515 s4: add blackbox test for rename
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sat May 21 09:50:34 CEST 2011 on sn-devel-104
2011-05-21 09:50:34 +02:00
Matthieu Patou
f1873382da upgradeprovision: add hostname in the blackbox tests 2011-05-21 08:41:07 +02:00
Matthieu Patou
535a9b3133 Make the purge first so that the provision can reused during tests 2011-05-21 08:41:07 +02:00
Matthieu Patou
a0db60d3ea Add a script for renaming a DC 2011-05-21 08:41:07 +02:00
Matthieu Patou
22a638b616 s4-python: Remove not used imports 2011-05-21 08:41:07 +02:00
Matthieu Patou
6071ed67bf s4-python: move function find_provision_key_parameters to provision namespace as it can be used not only for upgradeprovision 2011-05-21 08:41:07 +02:00
Matthieu Patou
a2f4309112 torture-dfs: fix a typo that was causing the test to be flacky
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Fri May 20 09:39:12 CEST 2011 on sn-devel-104
2011-05-20 09:39:12 +02:00
Andrew Bartlett
fa3e2fc8bb selftest: Re-enable strings.py from source3/stf as a python subunit test 2011-05-18 16:12:08 +02:00
Andrew Bartlett
c6cc22adc0 s4-libnet: Remove libnet_Join and create libnet_Join_member
libnet_Join conflicts with a function in the source3 netapi of the
same name, and the ability to join as a DC via this particular method
is unused.

Andrew Bartlett
2011-05-18 16:12:08 +02:00