sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Code
19,792 Commits 60 Branches 1,144 Tags 452 MiB
8ef11a7c6d
Commit Graph

19792 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Allison
8ef11a7c6d r16306: Error handling in this asn1 code *sucks*. Fix a generic 
class of memory leak bugs on error found by Klocwork (#123).
Many of these functions didn't free allocated memory on
error exit.
Jeremy.
 2007-10-10 11:17:32 -05:00
Volker Lendecke
21aaede518 r16301: Fix a memleak 2007-10-10 11:17:32 -05:00
Jeremy Allison
ee77dde9b6 r16299: Fix another "dereferencing type-punned pointer will break 
strict-aliasing rules" gcc4 warning.
Jeremy.
 2007-10-10 11:17:32 -05:00
Jeremy Allison
db5b4e3f13 r16298: On request of jiri sasek - Sun Microsystems - Prague Czech Republic <Jiri.Sasek@Sun.COM> 
change priv_op and priv_info to names that don't
conflict with the solaris namespace.
Jeremy.
 2007-10-10 11:17:32 -05:00
Jeremy Allison
7ac5aee88c r16295: Fix gcc4 "warning: dereferencing type-punned pointer will break 
strict-aliasing rules" warning.
Jeremy.
 2007-10-10 11:17:32 -05:00
Lars Müller
da4c5c3b75 r16294: Fix syntax error. 
Credits to Andreas Schwab from SUSE Linux for this fix.
 2007-10-10 11:17:31 -05:00
Volker Lendecke
b96808bb62 r16290: Fix Coverity bugs 298 and 298 2007-10-10 11:17:31 -05:00
James Peach
3eee126458 r16289: Fix smbclient test hang. This is caused by readline refusing to believe 
the end of file it receives when reading from a pipe after we force
interactive mode.
 2007-10-10 11:17:31 -05:00
Jeremy Allison
e24361ecdd r16287: Use intptr_t to return an integer of an unknown type cast 
to void *.
Jeremy.
 2007-10-10 11:17:31 -05:00
Jeremy Allison
938545f535 r16285: On a 64-bit box, size_t != uint32. Ensure we use 
the right parameter type.
Jeremy.
 2007-10-10 11:17:31 -05:00
Jeremy Allison
face01ef01 r16284: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned 
int
in a format string.
Jeremy.
 2007-10-10 11:17:31 -05:00
Jeremy Allison
c49ad9200b r16281: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned 
int
in a format string.
Jeremy.
 2007-10-10 11:17:30 -05:00
Jeremy Allison
45d5cad8c2 r16280: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned 
int
in a format string.
Jeremy.
 2007-10-10 11:17:30 -05:00
Jeremy Allison
3a15fff219 r16277: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int 
in a format string.
Jeremy.
 2007-10-10 11:17:30 -05:00
Jeremy Allison
952547471f r16275: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int 
in a format string.
Jeremy.
 2007-10-10 11:17:30 -05:00
James Peach
848ac756f6 r16274: Fix the smbclient prompting behaviour for both systems that have 
libreadline and those that don't. We always use the built-in readline
replacement for non-interactive mode. Interactive prompts are always
emitted to stdout and non-interactive mode never prompts at all.

Introduce x_fdup to avoid spuriously closing stdout when a logfile is
specified on the command line and setup_logging is called a second time.
 2007-10-10 11:17:30 -05:00
James Peach
dff1eba81e r16273: Add smbclient tests to verify that 
in interactive mode, smbclient always prompts on stdout
        in non-interactive mode, smbclient never prompts
 2007-10-10 11:17:30 -05:00
Günther Deschner
afdb118902 r16272: Fix memleak. 
Guenther
 2007-10-10 11:17:30 -05:00
Jeremy Allison
dc53d35b0a r16270: Fix Klocwork #706 - ensure sscanf has correct format 
specifier.
Jeremy.
 2007-10-10 11:17:29 -05:00
Günther Deschner
546710d58c r16269: Fix the build. 
Guenther
 2007-10-10 11:17:29 -05:00
Günther Deschner
535d03cbe8 r16268: Add TCP fallback for our implementation of the CHANGEPW kpasswd calls. 
This patch is mainly based on the work of Todd Stecher
<tstecher@isilon.com> and has been reviewed by Jeremy.

I sucessfully tested and valgrinded it with MIT 1.4.3, 1.3.5, Heimdal
0.7.2 and 0.6.1rc3.

Guenther
 2007-10-10 11:17:29 -05:00
Jeremy Allison
81731e1f68 r16267: Fix Klocwork #401, #402 - ensure format specifier 
limited. Fix memleak in printing gencache contents.
Jeremy.
 2007-10-10 11:17:28 -05:00
Günther Deschner
689ae22c80 r16261: Smaller fixes for net ads password. 
Guenther
 2007-10-10 11:17:28 -05:00
Gerald Carter
95763b94f7 r16255: Fix 'net ads join' when the workgroup is set incorrectly 
in smb.conf.  This did work before the join rewrite.
Samba will have problems if you try to run any of the daemons
with an incorrect workgroup but it should not fail to join.

The summary is that a member server should always use it's
own machine name when setting up schannel since that is
the only account it has.  Thanks to Volker for the discussion.
 2007-10-10 11:17:28 -05:00
Günther Deschner
fa19099112 r16253: Fix another host/ UPN case in (the currently unused) 
cli_rpc_pipe_open_krb5.

Guenther
 2007-10-10 11:17:28 -05:00
Volker Lendecke
678bbcf061 r16252: Fix Klocwork ID 1119, 1121. 
Volker
 2007-10-10 11:17:28 -05:00
Volker Lendecke
4974c598c0 r16251: for i in seq 1 1000 
do
	echo "I will always compile before commit :-)"
done

Also fix Klokwork ID 806.

Volker
 2007-10-10 11:17:28 -05:00
Volker Lendecke
d7a75ee94d r16250: Fix Klokwork IDs 148, 151, 152, 154. 
Volker
 2007-10-10 11:17:28 -05:00
Volker Lendecke
09586824f6 r16249: Fix Klokwork ID 130 2007-10-10 11:17:27 -05:00
Volker Lendecke
e56e3c19e1 r16248: Fix Coverity ID 297 2007-10-10 11:17:27 -05:00
Volker Lendecke
b82c95cb43 r16247: Fix Coverity ID 296 2007-10-10 11:17:27 -05:00
Jeremy Allison
afe2d4c493 r16245: Cope with string being zero len. Klocwork bug #410. 
Jeremy.
 2007-10-10 11:17:27 -05:00
Jeremy Allison
66275bd3bc r16243: Fix Klocwork bugs #581 and #706, ensure we check 
the end of array first in the loop. Reformat to
modern standards.
Jeremy.
 2007-10-10 11:17:27 -05:00
Jeremy Allison
a0d368197d r16241: Fix Klocwork #106 and others like it. 
Make 2 important changes. pdb_get_methods()
returning NULL is a *fatal* error. Don't try
and cope with it just call smb_panic. This
removes a *lot* of pointless "if (!pdb)" handling
code. Secondly, ensure that if samu_init()
fails we *always* back out of a function. That
way we are never in a situation where the pdb_XXX()
functions need to start with a "if (sampass)"
test - this was just bad design, not defensive
programming.
Jeremy.
 2007-10-10 11:17:27 -05:00
Jeremy Allison
6c61dc8ed6 r16230: Fix Klocwork #861 and others. localtime and asctime 
can return NULL. Ensure we check all returns correctly.
Jeremy.
 2007-10-10 11:17:26 -05:00
Günther Deschner
5ecfaf7d50 r16222: Fix DEBUG statements. 
Guenther
 2007-10-10 11:17:26 -05:00
Günther Deschner
58a7c09003 r16221: No need for friednly error messages at log level 10. 
Guenther
 2007-10-10 11:17:26 -05:00
Gerald Carter
6c1f1c091f r16219: BUG 3836, 3837, 3004: compile warning fixes from Jason Mader. 2007-10-10 11:17:26 -05:00
Jeremy Allison
e6aacb1426 r16216: Add debug messages to make it possible to try and 
debug why a job pause or resume command is not being
done.
Jeremy.
 2007-10-10 11:17:26 -05:00
Jeremy Allison
c2f0ea2ff2 r16213: Fix Klocwork #852. iface_n_ip can potentially 
return NULL. Ensure we don't deref.
Jeremy.
 2007-10-10 11:17:26 -05:00
Jeremy Allison
79e693798c r16209: Klocwork bug #66, ensure no null deref. 
Jeremy.
 2007-10-10 11:17:25 -05:00
Jeremy Allison
2c1a2d7b40 r16207: Ensure we don't allocate an OID string unless 
we know we don't have an error. Klocwork #6.
Jeremy.
 2007-10-10 11:17:25 -05:00
Gerald Carter
304b7913cd r16206: Don Meyer <dlmeyer@uiuc.edu> pointed out that RHEL4 rpms use 'Epoch: 0' so work around that 2007-10-10 11:17:25 -05:00
Gerald Carter
44d4bab991 r16205: Fix 'make install' when srcdir != builddir 2007-10-10 11:17:25 -05:00
Volker Lendecke
07c5dcb863 r16204: Fix Klocwork # 14 
localtime() can return NULL.

Volker
 2007-10-10 11:17:25 -05:00
Volker Lendecke
4cb8cf221f r16203: Fix potentially writing one result of strtok beyond the end of alt_path. 
Found by Klocwork, ID 653.

Volker
 2007-10-10 11:17:25 -05:00
Jeremy Allison
319f80bbf0 r16202: Fix Klocwork #3. Strange - was already fixed in HEAD. 
Jeremy.
 2007-10-10 11:17:25 -05:00
Volker Lendecke
b369d0891a r16201: Fix Klocwork 439 2007-10-10 11:17:24 -05:00
Jeremy Allison
98751e8190 r16199: Fix Klocwork #1 - ensure we test the first 
strtok for NULL.
Jeremy.
 2007-10-10 11:17:24 -05:00
Volker Lendecke
3a7d01afbe r16198: Fix Klocwork 1023 2007-10-10 11:17:24 -05:00