1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Commit Graph

64126 Commits

Author SHA1 Message Date
Matthias Dieter Wallnöfer
8f20a5512a s4:samr_password.c - add a function which sets the password through encrypted password hashes
Used for password sets on "samr_SetUserInfo" level 18 and 21.
2010-06-28 14:51:03 +02:00
Günther Deschner
427c953273 s4-smbtorture: fix typo.
Not my day...

Guenther
2010-06-28 14:47:16 +02:00
Matthias Dieter Wallnöfer
f2e0ca2662 s4:torture/rpc/samr.c - test_SetPassword_LastSet - fix "pwdLastSet" test
- Remove superflous checks (on level 18, 24, 26 we do always have "pwdLastSet"
  resets if "password_expired" > 0)
- Fixed some bugs

Signed-off-by: Günther Deschner <gd@samba.org>
2010-06-28 14:33:17 +02:00
Günther Deschner
c5bab3ea33 s4-smbtorture: add trustDomainPasswords blob test to LOCAL-NDR testsuite.
Our parsing of this struct is incorrect atm. and apparently also causes the s4
server to crash.

Thanks to Sumit Bose <sbose@redhat.com> for providing the auth data retrieved
from a w2k3 domain.msc operation.

Guenther
2010-06-28 14:18:04 +02:00
Günther Deschner
158504381e s3-registry: missed one perflib keyname delimiter.
Guenther
2010-06-28 14:18:04 +02:00
Volker Lendecke
121214df91 s3: More cleanup in winbindd_ads.c:query_user
We can't ads_msgfree after the ads struct has been killed. Do early returns.
2010-06-28 14:09:58 +02:00
Volker Lendecke
8707be6d75 s3: Fix a valgrind error
nss_get_info_cached does not necessarily fill in gid
2010-06-28 13:54:45 +02:00
Volker Lendecke
09a9cc32ee s3: Re-arrange winbindd_ads.c:query_user
We can't access the LDAP message after nss_get_info_cached has potentially
destroyed the ads_struct
2010-06-28 13:54:45 +02:00
Volker Lendecke
a670804579 s3: free -> SAFE_FREE 2010-06-28 13:54:44 +02:00
Volker Lendecke
c79e0c0ce4 s3: Do an early TALLOC_FREE 2010-06-28 13:54:44 +02:00
Günther Deschner
658048ecbc s3-registry: fix printing keyname delimiter.
Guenther
2010-06-28 13:16:31 +02:00
Günther Deschner
3d24040ac6 s3-registry: fix perfmon keyname delimiter.
Guenther
2010-06-28 13:16:31 +02:00
Andreas Schneider
0c579bc3e6 s3-net: Make sure that the data blob is initialized.
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
f8b6ac6a08 s3-eventlog: Fixed the keyname delimiter for the registry key. 2010-06-28 12:56:13 +02:00
Andreas Schneider
378cd5dc38 s3-registry: Fixed keyname delimiter in KEY_CURRENT_VERSION_NORM. 2010-06-28 12:56:13 +02:00
Andreas Schneider
e716924590 s3-smbd: Make sure that status is initialized when used.
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
6ac050f73f s3-lanman: Make sure count is not used uninitialized if we jump to out.
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
d11e184ed2 s3-vfs: Make sure that retval isn't used uninitialized.
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
ac5600fc7e s3-passdb: Make sure dn is initialized and don't free it.
dn is just a pointer to a memory which hasn't been duplicated.

Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
6d89116afe s3-passdb: Make sure we don't call free on a garbage pointer.
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
06a1766315 s3-lanman: Make sure that job_info is not undefined.
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
459a1d58b1 s3-nmbd: Leave the sync function if there are no syncs.
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
34de8a00dd s3-libsmb: Make sure that finfo is initialized.
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Günther Deschner
b6100fa72f s3-eventlog: make sure _eventlog_OpenEventLogW fails when we cannot open the registry key.
Guenther
2010-06-28 12:53:10 +02:00
Volker Lendecke
c4d5cbbdc5 s3: Fix some valgrind errors
Essentially the same change as 15297ee, this time for the client side.

Günther, Andrew B, please check!

Thanks,

Volker
2010-06-28 12:28:07 +02:00
Andreas Schneider
a81b97ff34 s3-passdb: Make sure that we don't assign garbage. 2010-06-28 10:18:12 +02:00
Andreas Schneider
dc2e41a16a librpc: Use switch in GUID_from_data_blob(). 2010-06-28 10:18:12 +02:00
Andreas Schneider
b46eccfb19 nss_wrapper: Fixed a possible NULL pointer problem. 2010-06-28 10:18:12 +02:00
Stefan Metzmacher
bdfba236e9 s4:ldap_server: don't start if we can't bind to port 389
metze
2010-06-28 09:58:13 +02:00
Nadezhda Ivanova
5a18fc2b2a Implementation of self membership validated right.
When this right is granted, the user can add or remove themselves from a group even
if they dont have write property right.
2010-06-28 10:43:50 +03:00
Kamen Mazdrashki
a0bb31df5d s4/test: Run DrsDeleteObjectTestCase as part of S4 testing
I put this test in the end of the list of tests as it
runs with 'vampire_dc' environment running.

Currently there are tests that are failing when we have
2 DCs constantly replicating in the test environment
(this, of course, should be fixed in the near future)
2010-06-28 04:43:29 +03:00
Kamen Mazdrashki
431386f327 s4/drs: re-implement 'renaming' object replication
We should rename objects only after we make sure, that
changes on the partner DC are newer than what we have.
This fixes a bug, when we have following situation with 2 DCs:
- we have an object O on the two DCs
- we rename (delete) object O on DC1
- DC1 replicates from DC2
In the above scenario, object O will be renamed back
to its original name (i.e. it will be restored).

Now, we check that DC2 state is older than what we have,
so nothing happens with object's DN.
2010-06-28 04:43:29 +03:00
Kamen Mazdrashki
46556432c0 s4/drs-test: Add few comments in DrsDeleteObjectTestCase test
Also remove unused code
2010-06-28 04:43:28 +03:00
Matthias Dieter Wallnöfer
6f6365daba s4:rpc_server/srvsvc/dcesrv_srvsvc.c - remove unreachable code 2010-06-26 20:08:47 +02:00
Matthias Dieter Wallnöfer
f12dab8e00 s4:rpc_server/wkssvc/dcesrv_wkssvc.c - remove unreachable code 2010-06-26 20:08:47 +02:00
Matthias Dieter Wallnöfer
3c3ecf40e5 s4:rpc_server/lsa/dcesrv_lsa.c - remove unreachable code 2010-06-26 20:08:46 +02:00
Matthias Dieter Wallnöfer
d85d6054c9 s4:lsa/lsa_lookup.c - use a better type for the "rtype" of the wellknown SIDs
To suppress warnings on Solaris 10
2010-06-26 20:08:45 +02:00
Matthias Dieter Wallnöfer
3f2e9ce2b4 s4:rpc_server/drsuapi/drsutil.c - remove unreachable code 2010-06-26 19:46:33 +02:00
Matthias Dieter Wallnöfer
e5e4184e5a s4:rpc_server/dcesrv_auth.c - remove unreachable code 2010-06-26 19:45:45 +02:00
Matthias Dieter Wallnöfer
75d6842c40 s4:winbind/wb_samba3_protocol.c - add cast to suppress warnings on Solaris 10 cc 2010-06-26 19:45:07 +02:00
Matthias Dieter Wallnöfer
0c29224da3 s4:kdc/kdc.c - add cast to suppress warnings on Solaris 10 cc 2010-06-26 19:43:51 +02:00
Matthias Dieter Wallnöfer
c8a5ed8db9 s4:kdc/kpasswdd.c - remove unreachable code 2010-06-26 19:42:29 +02:00
Matthias Dieter Wallnöfer
c7b52b233e s4:provision.py - fix comment regarding DNS entries
I think this should mean partially Samba4 specified (all beside the "dns"
account is standard)
2010-06-26 11:11:46 +02:00
Stefan Metzmacher
50da834f13 s4:provision: add entries for root dns servers
metze
2010-06-26 09:50:56 +02:00
Stefan Metzmacher
6ab234cec9 s4:provision: move Samba4 specific DNS stuff to its own file
metze
2010-06-26 09:50:56 +02:00
Stefan Metzmacher
c6b21931c6 s4:provision: add --next-rid option
Make it possible to provision a domain with a given next rid counter.
This will be useful for upgrades, where we want to import users
with already given SIDs.

metze
2010-06-26 09:50:55 +02:00
Stefan Metzmacher
7905901bc0 s4:dsdb/ridalloc: add comment about windows behavior regarding rIDUsedPool
metze
2010-06-26 09:50:55 +02:00
Stefan Metzmacher
712a149802 s4:provision: don't use hardcoded values for 'nextRid' and 'rIDAvailablePool'
On Windows dcpromo imports nextRid from the local SAM,
which means it's not hardcoded to 1000.

The initlal rIDAvailablePool starts at nextRid + 100.

I also found that the RID Set of the local dc
should be created via provision and not at runtime,
when the first rid is needed.
(Tested with dcpromo on w2k8r2, while disabling the DNS
 check box).

After provision we should have this (assuming nextRid=1000):

rIDAllocationPool: 1100-1599
rIDPrevAllocationPool: 1100-1599
rIDUsedPool: 0
rIDNextRID: 1100

rIDAvailablePool: 1600-1073741823

Because provision sets rIDNextRid=1100, the first created account
(typically DNS related accounts) will get 1101 as rid!

metze
2010-06-26 09:50:54 +02:00
Stefan Metzmacher
89f94a43d8 s4:provision: pass relax control also to modify_ldif
metze
2010-06-26 09:50:54 +02:00
Kamen Mazdrashki
2f7fe9db02 s4/net-drs: Fix error messages typo and formatting 2010-06-26 01:16:01 +03:00