sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Code
19,134 Commits 60 Branches 1,145 Tags 452 MiB
924be04217
Commit Graph

19134 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jim McDonough
924be04217 r14053: Implement Simo's suggestion: don't use /dev/null for a 'bad' path for 
users/workstations
(This used to be commit 2690f015be)
 2007-10-10 11:11:08 -05:00
Lars Müller
f27228fc31 r14052: Remove BASEDIR use in the Makefile. BASEDIR=prefix=@prefix@ till now. 
I suggest to stay with ^BASEDIR= @prefix@$ for at least the next release
to give external projects - like samba-vscan project - time to adopt
this change.

BASEDIR is non of the default autoconf variables.  prefix is.

Jerry1: If possible please announce this with the next release.  I'll
self reply to technical.

Jerry2: This does not break your makepkg stuff as you set BASEDIR
_not_ from the Makefile.
(This used to be commit 730d5ec229)
 2007-10-10 11:11:08 -05:00
Günther Deschner
763a2d7d8e r14051: Add remaining (documented) userAccountControl bits, thanks to Luke 
Howard for pointing this out.

Guenther
(This used to be commit 170038f4cd)
 2007-10-10 11:11:08 -05:00
Günther Deschner
ca3df1d3f9 r14050: Add the ACB_PWEXPIRED bit abartlet has found. 
Guenther
(This used to be commit 5fa3f26b4c)
 2007-10-10 11:11:08 -05:00
Günther Deschner
06d6325da1 r14049: Found some more MSV1_0 bits and their behaviour; 
just for documentation purpose.

Guenther
(This used to be commit 0b00424e07)
 2007-10-10 11:11:08 -05:00
Jeremy Allison
b05af76541 r14047: Coverity fix #17. Ensure srv_name and info cannot 
be zero before deref.
Jeremy.
(This used to be commit fbf9db6624)
 2007-10-10 11:11:08 -05:00
Jeremy Allison
d8ba987bfe r14045: Coverity fix #14. Ensure if len is set buf != NULL. 
Jeremy.
(This used to be commit fb1a607332)
 2007-10-10 11:11:07 -05:00
Jeremy Allison
8d1dd8bb96 r14043: After discussion with Jerry revert part of the 
Coverity null-ref patch - put prs_rpcbuffer_p
back to the way it was (with an additional
coverity paranoia check) - move the real test
into rpcbuf_alloc_size instead.
Jeremy.
(This used to be commit f74993e65c)
 2007-10-10 11:11:07 -05:00
Gerald Carter
29c8cef22d r14042: check that create_local_nt_token() succeeds before dereferncing the NT_USER_TOKEN* 
(This used to be commit 4e5df4cb64)
 2007-10-10 11:11:07 -05:00
Volker Lendecke
753dcde401 r14036: Ok, the last one generated a const warning. Also fix Coverity # 119. 
net rpc vampire is ugly....

Volker
(This used to be commit c1ea48949d)
 2007-10-10 11:11:07 -05:00
Volker Lendecke
3cc8b8125a r14035: Fix Coverity bug # 124 
(This used to be commit 9fe21fd032)
 2007-10-10 11:11:07 -05:00
Volker Lendecke
991fd6c28e r14034: Fix Coverity id # 125. 
Jeremy, you might want to take a look here.

Volker
(This used to be commit e6e29937e8)
 2007-10-10 11:11:07 -05:00
Volker Lendecke
4479d1b061 r14033: Fix Coverity bug # 126 
(This used to be commit bb6d678575)
 2007-10-10 11:11:06 -05:00
Jeremy Allison
77709e58ad r14031: Coverity bug CID #110. Free all resources correctly 
on pipe initialization failure.
Jeremy.
(This used to be commit daa919a94b)
 2007-10-10 11:11:06 -05:00
Jeremy Allison
8f0bdb9c4e r14030: Fix resource leak in error codepath. Coverity CID #64. 
Jeremy.
(This used to be commit b51edde4d6)
 2007-10-10 11:11:06 -05:00
Jeremy Allison
6b591819dd r14026: Fix resource leak on error exit. Coverity CID #65. 
Jeremy.
(This used to be commit 3a1c4cb93d)
 2007-10-10 11:11:06 -05:00
Volker Lendecke
874a9d02de r14025: Remove unused code. When we want to export samsync, we better first port 
pidl...

Fix Coverity # 15.

Volker
(This used to be commit 29b4b986cc)
 2007-10-10 11:11:06 -05:00
Jeremy Allison
82ab2bce5a r14023: My last bug fix still left a potential null deref. 
C- "must try harder" :-).
Jeremy.
(This used to be commit 9c55bf74ca)
 2007-10-10 11:11:06 -05:00
Volker Lendecke
6491aed1ac r14022: Fix Coverity bug # 92 
(This used to be commit b824245c4e)
 2007-10-10 11:11:06 -05:00
Jeremy Allison
43ad653211 r14020: Coverity bug CID #66. Missing free on error exit. 
Jeremy.
(This used to be commit b9980bddf5)
 2007-10-10 11:11:05 -05:00
Jeremy Allison
f635dcb5f3 r14018: Coverity error CID #27. Missing return -1 on error condition. 
Jeremy.
(This used to be commit 94e869d9c6)
 2007-10-10 11:11:05 -05:00
Volker Lendecke
c7c3b98d4b r14017: Okay, okay, I have turned a double-free into dead code :-) 
Fix Coverity # 214.

Volker
(This used to be commit 4a75edf9de)
 2007-10-10 11:11:05 -05:00
Jeremy Allison
a3586ff60c r14014: Coverity paranoia. Shut it up by making the guarentee 
in the code explicit - but this was a false positive (CID #16).
Jeremy.
(This used to be commit 43a0e869f2)
 2007-10-10 11:11:05 -05:00
Jeremy Allison
9e65a2cb98 r14009: Remove last const warning (have to use CONST_DISCARD). 
Jeremy.
(This used to be commit af0ade470f)
 2007-10-10 11:11:05 -05:00
Jeremy Allison
6b35642037 r14007: Coverity bug CID #197. Don't compare against 0, we 
mean the ttl instead.
Jeremy.
(This used to be commit ccb2a52e29)
 2007-10-10 11:11:04 -05:00
Jeremy Allison
26c95f3545 r14006: Fix a couple of irritating warnings. 
Jeremy.
(This used to be commit ead13ca522)
 2007-10-10 11:11:04 -05:00
Jeremy Allison
3527b5cc25 r14003: Clarify code that lead to Coverity report #13. 
Not a bug, but better to remove false positives.
Jeremy.
(This used to be commit f9a75d7654)
 2007-10-10 11:11:04 -05:00
Jeremy Allison
dbbc06db65 r14002: Quick fix for Coverity CID #12. 
Jeremy
(This used to be commit 7c6e274cd5)
 2007-10-10 11:11:04 -05:00
Jeremy Allison
1eea156f57 r13999: Quick fix for Coverity bug #11. 
Jeremy.
(This used to be commit b9de6c9269)
 2007-10-10 11:11:04 -05:00
Lars Müller
ef5b36ca8d r13997: Prefix $prefix by default even to rootsbindir as we else run in trouble 
if we use ./configure --prefix=dir && make install

Vendors might use ./configure --with-rootsbindir=/sbin && make
DESTDIR=/var/tmp/samba/ install if they use a buildroot.

Thanks to Björn Jacke for pointing me at the stderr output of the build
farm.
(This used to be commit 75c95d149a)
 2007-10-10 11:11:04 -05:00
Jeremy Allison
f7bf439030 r13994: Belt and braces - ensure RPC_BUFFER is valid. 
Jeremy.
(This used to be commit d993797191)
 2007-10-10 11:11:03 -05:00
Volker Lendecke
eae063e965 r13991: Fix Coverity bug # 69 
(This used to be commit 6dc79e6b12)
 2007-10-10 11:11:03 -05:00
Jeremy Allison
cd49e2546e r13989: Fix for Coverity bug #45 and associated spoolss RPC_BUFFER 
problems. Ensure that if the parse succeeds on UNMARSHALL
we have a valid (although possibly empty) RPC_BUFFER returned.
Jeremy.
(This used to be commit d319cc9c08)
 2007-10-10 11:11:03 -05:00
Volker Lendecke
03b32953cf r13987: Fix Coverity bug # 74. This tool is good... 
Thanks,

Volker
(This used to be commit 86f62484dd)
 2007-10-10 11:11:03 -05:00
Volker Lendecke
a78d2a85fb r13984: Fix Coverity bug # 98 
(This used to be commit 0a2aa3a48b)
 2007-10-10 11:11:03 -05:00
Volker Lendecke
dece1a2db2 r13983: Fix Coverity bug # 111 
(This used to be commit 08d7fd31ab)
 2007-10-10 11:11:03 -05:00
Volker Lendecke
5f76ee419e r13981: Fix Coverity bug # 138 
(This used to be commit 303067ba3b)
 2007-10-10 11:11:03 -05:00
Volker Lendecke
33c9fbab12 r13980: Fix Coverity bug # 63. Jeremy, could you take a look at this? 
Thanks,

Volker
(This used to be commit 49043a756d)
 2007-10-10 11:11:02 -05:00
Volker Lendecke
4357ef3bd6 r13979: We've dereferenced my_methods already, so there's no point in checking for 
!= NULL. Coverity #149.

Volker
(This used to be commit d38e05329a)
 2007-10-10 11:11:02 -05:00
Jeremy Allison
2615b079f0 r13978: Here is why it's essential to use SAFE_FREE instead of free. 
If we use free(data.dptr) and then the subsequent tdb_open
fails in _reg_perfcount_get_counter_data() then data.dptr
is left as a non-zero pointer that has been freed. This would
cause it to be reused later on. Coverity bug #162.
Jeremy.
(This used to be commit 053efc2098)
 2007-10-10 11:11:02 -05:00
Jeremy Allison
71272fc441 r13975: Re-fix Coverity #156 - I had left the hidden arg. inconsistent 
between Realloc and realloc_array.
Jeremy.
(This used to be commit 841c9b1847)
 2007-10-10 11:11:02 -05:00
Jeremy Allison
a31c931804 r13971: Fix Coverity bugs #209 - #213 - it detected mistakes 
in the pointer aliasing once realloc could change
a pointer. This was in the bugzilla.samba.org database
as #687 but we never figured out what it was !
Jeremy.
(This used to be commit 8d18344140)
 2007-10-10 11:11:02 -05:00
Jim McDonough
247bacf19b r13968: fix typo, caught by Guenther 
(This used to be commit 217d3fbe79)
 2007-10-10 11:11:02 -05:00
Günther Deschner
3432273ab0 r13965: Make sure we always reset the userAccountControl bits when re-joining 
with an existing account.

Guenther
(This used to be commit e4c12ab167)
 2007-10-10 11:11:01 -05:00
Volker Lendecke
bd8e1b442d r13958: Fix Coverity Bug # 141 
(This used to be commit 598513d1d3)
 2007-10-10 11:11:01 -05:00
Jim McDonough
9bc20e14db r13957: Based on patch from Richard Renard <richard.renard@idealx.com>: 
Fix machine accounts (should not have valid shells) and users with no
home directory (were getting previous user's directory).
(This used to be commit f629f8a7b9)
 2007-10-10 11:11:01 -05:00
Volker Lendecke
fde3304981 r13955: Fix Coverity ID 139. 
Not a bug in the strictest sense, more a clarification. This whole routine
assumes new_gid != NULL anyway, so there's no point in checking.

Volker
(This used to be commit dfbf09c772)
 2007-10-10 11:11:01 -05:00
Volker Lendecke
c2288e6db3 r13951: Fix Coverity Bug #163. 
This code was not used anyway :-)

Volker
(This used to be commit bbfb205693)
 2007-10-10 11:11:01 -05:00
Volker Lendecke
dbb4840da5 r13950: Fix Coverity bug #168 
(This used to be commit cbf894c0e3)
 2007-10-10 11:11:01 -05:00
Jim McDonough
a0b0ac5b6a r13948: Fix the build. Remove rpcclient.h include. 
(This used to be commit 6bf879bee3)
 2007-10-10 11:11:01 -05:00