1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Commit Graph

77225 Commits

Author SHA1 Message Date
Jelmer Vernooij
a0ed2da105 ldb: Re-apply pyldb fixes from Tridge and Amity, using unittest rather
than samba.tests.
2011-11-10 23:37:04 +01:00
Jelmer Vernooij
ad40581142 subunitrun: Add notes about subunitrun being deprecated. 2011-11-10 23:37:04 +01:00
Jelmer Vernooij
d84ba4fc0a selftest: re-implement directory option for planpythontestsuite. 2011-11-10 23:37:04 +01:00
Jelmer Vernooij
f5d3e45722 Revert "test: added directory option to planpythontestsuite()"
This reverts commit b0be72d508.

I'll add an alternative that uses subunit.run.
2011-11-10 23:37:04 +01:00
Jelmer Vernooij
ae88d7390b Revert "test: added -D option to subunitrun"
This reverts commit ac0bba2ea1.

"python -m subunit.run" is the preferred way of running tests to
generate subunit. I also don't want to move too far away from
the standard test running infrastructure for python so that
other test runners (nosetests, trial, tribunal, ...) can be used with
Samba code.
2011-11-10 23:37:04 +01:00
Jelmer Vernooij
04be49f600 Revert "pyldb: fixed ldb API test"
This reverts commit 333248f08c.

This commit made the pyldb tests depend on the Samba testsuite.
2011-11-10 23:37:04 +01:00
Matthias Dieter Wallnöfer
4cafcf0e6b libcli/cldap/cldap.c - remove outdated comment
Reviewed-by: metze

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov 10 20:32:08 CET 2011 on sn-devel-104
2011-11-10 20:32:08 +01:00
Volker Lendecke
145f53e824 s3: server_id.pid has turned 64 (bits, that is)
Fix ctdb_processes_exist protocol. The socket expects pid_t which is 32 bits on
32 bit machines.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Nov 10 18:57:01 CET 2011 on sn-devel-104
2011-11-10 18:57:01 +01:00
Volker Lendecke
5e0258fc93 s3: Avoid a race with the async echo handler
We can not read from the echo handler socket when we have the main socket
locked. This leads to the echo responder to lock up sitting in the fcntl lock
while the parent wants to read the remainder of a large packet.
2011-11-10 17:18:53 +01:00
Stefan Metzmacher
17f1a97a61 libcli/cldap: fix a crash bug in cldap_socket_recv_dgram() (bug #8593)
After a calling any wrapper of tevent_req_notify_callback(),
e.g. tevent_req_nterror(), tevent_req_done(), tevent_req_nomem(),
a function has to return immediately otherwise it is very likely to
crash, unless in calls tevent_req_defer_callback() before.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 10 16:31:59 CET 2011 on sn-devel-104
2011-11-10 16:31:59 +01:00
Stefan Metzmacher
88bcdbb16a s4:finddcs_cldap: debug the correct server address instead of NULL
metze
2011-11-10 14:59:10 +01:00
Stefan Metzmacher
22ddbb5053 s3:smbd: don't limit the number of open dptrs for smb2 (bug #8592)
This fixes a crash bug that is triggered, when a client has more than
256 directory handles with searches.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 10 14:08:14 CET 2011 on sn-devel-104
2011-11-10 14:08:13 +01:00
Stefan Metzmacher
39bb5a6297 s3:smbd: fully construct the dptr before allocating a dnum in the bitmap
metze
2011-11-10 12:31:01 +01:00
Stefan Metzmacher
7644547a55 s3:smbd: avoid string_set() in dir.c
And do some more error checks.

metze
2011-11-10 12:30:52 +01:00
Martin Schwenke
538748132f Fix -Wunused-but-set-variable compiler warnings in tevent_signal.c
The results of some read(2) and write(2) calls are assigned into a
variable that is never used.  Presumably this used to avoid compiler
warnings or similar.

However, from (approximately) GCC 4.6 this produces some warnings:

  [ 609/3910] Compiling lib/tevent/tevent_signal.c
  ../lib/tevent/tevent_signal.c: In function ‘tevent_common_signal_handler’:
  ../lib/tevent/tevent_signal.c:85:10: warning: variable ‘res’ set but not used [-Wunused-but-set-variable]
  ../lib/tevent/tevent_signal.c: In function ‘signal_pipe_handler’:
  ../lib/tevent/tevent_signal.c:183:10: warning: variable ‘res’ set but not used [-Wunused-but-set-variable]

The simplest thing to do is remove the variables and cast the function
return to void.  There is already a comment above each call.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-11-10 10:28:44 +01:00
Theresa Halloran
7d84805ac0 s4: samba-tool time --help documentation improvements
Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com>

Signed-off-by: Andrew Tridgell <tridge@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov 10 06:04:22 CET 2011 on sn-devel-104
2011-11-10 06:04:22 +01:00
Theresa Halloran
4ea6225c58 s4: samba-tool group --help documentation improvements
Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com>

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-11-10 14:24:38 +11:00
Andrew Tridgell
ba41389d3d test: fixed several tests to use samba.tests
this fixes error checking. Test failures were not being detected
otherwise

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
2011-11-10 14:24:21 +11:00
Andrew Tridgell
862823a776 samba-tool: print samaccountname in samba-tool user list
this is the attribute the admin needs for other commands

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
2011-11-10 14:24:21 +11:00
Andrew Tridgell
39356761e5 test: use planpythontestsuite() for ldb.python test
Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
2011-11-10 14:24:21 +11:00
Andrew Tridgell
b0be72d508 test: added directory option to planpythontestsuite()
Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
2011-11-10 14:24:21 +11:00
Andrew Tridgell
ac0bba2ea1 test: added -D option to subunitrun
this allows for:

 subunitrun -D lib/ldb/tests/python api

which makes this easier for developers
2011-11-10 14:24:21 +11:00
Andrew Tridgell
333248f08c pyldb: fixed ldb API test
it was failing previously, but the failure wasn't being noticed
2011-11-10 14:24:21 +11:00
Andrew Tridgell
a04eac7aa2 build: only run symbol checking if running all tests
this makes it much faster to run 1 test

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
2011-11-10 14:24:21 +11:00
Andrew Tridgell
58457e6cd2 pyldb: enhanced get() method on msg object
get() now takes a default value and an idx, allowing for much easier
usage

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
2011-11-10 14:24:21 +11:00
Giampaolo Lauria
1cef3212a1 samba-tool: Added new "user disable" command 2011-11-10 14:24:21 +11:00
Giampaolo Lauria
34ff5d29e6 samba-tool: Added "user list" command 2011-11-10 14:24:21 +11:00
Giampaolo Lauria
da21ff82a5 samba-tool: Change internal argument name in domain machinepassword 2011-11-10 14:24:21 +11:00
Giampaolo Lauria
53fc437d05 samba-tool: Fix domain machinepassword secret db search
pair programmed with Jelmer Vernooij
Add search to include secrets.ldb
2011-11-10 14:24:21 +11:00
Giampaolo Lauria
ec5afae292 samba-tool: Fix domain machinepassword name search
Append '$' to name provided by user to search for a machine account
when necessary
2011-11-10 14:24:21 +11:00
Andrew Tridgell
46723aa2da s4-test: improved error checking in samba-tool time test
Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
2011-11-10 14:24:21 +11:00
Andrew Tridgell
a7c1add5c4 s4-socket: detect NULL server in socket connection code
return NT_STATUS_NOT_FOUND instead of a segfault

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
2011-11-10 14:24:20 +11:00
Sean Dague
e118d91a63 test: enable time and user samba-tool tests
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-11-10 14:24:20 +11:00
Sean Dague
a818253960 test: add samba-tool user tests
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-11-10 14:24:20 +11:00
Sean Dague
a66eae9a6d test: Add samba-tool time tests
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-11-10 14:24:20 +11:00
Sean Dague
559835dc59 test: add directory and base class for samba-tool tests
this allows for more sophisticated testing of samba-tool

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-11-10 14:24:20 +11:00
Andrew Bartlett
ca52871541 s4-setup Remove servicePrincipalName: DNS/${DNSDOMAIN} from new installations
This servicePrincipalName is incorrect (windows does not use that
servicePrincipalName, as it targets the server it is updating, not the
root of the DNS tree), and now that we have multiple DNS backends that
use the internal database, it is quite incorrect (as it cannot exist
on more than one account).

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Nov 10 01:11:46 CET 2011 on sn-devel-104
2011-11-10 01:11:46 +01:00
Andrew Bartlett
0f2ff7c5c2 s3-py_passdb Ensure that group mapping list input is initailised
This may help to ensure we consistantly crash on an incorrect de-reference.

Andrew Bartlett
2011-11-09 23:38:25 +01:00
Andrew Bartlett
1fb836d863 s3-passdb Initialise the correct level of pointer dereference
*pp_rmap may be NULL or un-initialised data.

This was introduced by 995d156726.

Andrew Bartlett
2011-11-09 23:38:25 +01:00
Matthias Dieter Wallnöfer
f4a07f0b81 s4:join.py - fix up "DsAddEntry" against Windows Server 2000
It is important to consider the result level regarding error
information. Windows 2000 seems to send us back v2, all other
implementations v3. Consider post "Joining W2k AD domain"

Reviewed-by: abartlet

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Nov  9 23:37:08 CET 2011 on sn-devel-104
2011-11-09 23:37:08 +01:00
Andreas Schneider
c49fc5264b docs: Make clear to use the workgroup name not the realm.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Nov  9 21:17:09 CET 2011 on sn-devel-104
2011-11-09 21:17:09 +01:00
Jelmer Vernooij
7feb83a1c4 s4: Install samba-tool and samba_kcc to bin/ rather than sbin/.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Nov  9 19:43:07 CET 2011 on sn-devel-104
2011-11-09 19:43:06 +01:00
Jelmer Vernooij
b8efff57dc samba_kcc: Remove unnecessary return statements. 2011-11-07 02:04:52 +01:00
Jelmer Vernooij
56081da368 util/time: Make some functions explicitly public. 2011-11-03 17:22:40 +01:00
Jelmer Vernooij
56852bf1fc util/time: Remove unnecessary _PUBLIC_ - that's implicit for things in header files. 2011-11-03 14:34:08 +01:00
Michael Adam
6727429aea s3:registry: prevent unnecessary transactions in regdb_init
Skip the transaction for the upgrade code, if the database
is already at code-level.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Nov  9 15:06:59 CET 2011 on sn-devel-104
2011-11-09 15:06:58 +01:00
Andreas Schneider
e66ceb6566 s3: Use autotools to set the winbind socket directory.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Nov  9 13:31:27 CET 2011 on sn-devel-104
2011-11-09 13:31:27 +01:00
Stefan Metzmacher
ffbd1ed279 s3:smb2_server: grant credits in async interim responses (bug #8357)
The first fix for bug #8357 intruduced a regression, so that we no
longer grant credits for real async interim responses with
STATUS_PENDING.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Nov  9 11:56:29 CET 2011 on sn-devel-104
2011-11-09 11:56:29 +01:00
Stefan Metzmacher
4b31c4273c s3:libsmb: consistently use state->size in cli_write_andx_create() (bug #5326)
Otherwise we may get unexpected results.

This is a fix that was missing in commit 95595dd93f
(s3:libsmb: fix cli_write_and_x() against OS/2 print shares (bug #5326))

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Nov  9 10:13:32 CET 2011 on sn-devel-104
2011-11-09 10:13:32 +01:00
Amitay Isaacs
0c2f91c6b2 s4-provision: Create ldap records for DNS partitions similar to windows
this allows easy comparison between windows and samba ldap trees

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Wed Nov  9 08:27:46 CET 2011 on sn-devel-104
2011-11-09 08:27:46 +01:00