Jeremy Allison
a167c2c09e
r16422: winbindd_demote_client isn't used and generates
...
a Klocwork issue (#1844 ). Remove it
Jeremy.
(This used to be commit e83c3e0a65
)
2007-10-10 11:18:52 -05:00
Jeremy Allison
dc36abe3a2
r16420: Fix Klocwork #1674 . Null deref.
...
Jeremy.
(This used to be commit f5dddf339e
)
2007-10-10 11:18:52 -05:00
Günther Deschner
0edf73c85a
r16415: Also delete object files from iniparser.
...
Guenther
(This used to be commit 4e1816855a
)
2007-10-10 11:18:52 -05:00
Volker Lendecke
7dad923a49
r16411: Fix compilation of vfs_afsacl, thanks to Greszler Szilard for trying
...
(This used to be commit 601643a460
)
2007-10-10 11:18:52 -05:00
Volker Lendecke
3c34f6085a
r16409: Fix Klocwork ID's.
...
1177
In reg_perfcount.c: 1200 1202 1203 1204
In regfio.c: 1243 1245 1246 1247 1251
Jerry, the reg_perfcount and regfio.c ones, can you take a look please? This
is really your code, and I'm not sure I did the right thing to return an
error.
smbcacls.c: 1377
srv_eventlog_nt.c: 1415 1416 1417
srv_lsa_nt.c: 1420 1421
srv_netlog_nt.c: 1429
srv_samr_nt: 1458 1459 1460
Volker
Volker
(This used to be commit d6547d12b1
)
2007-10-10 11:18:52 -05:00
Jeremy Allison
ce61fb21d9
r16397: Fix Klocwork #11767 and drasticly simplify the
...
logic in smbd/process.c. All interested (Volker,
Jerry, James etc). PLEASE REVIEW THIS CHANGE.
The logic should be identical but *much* easier
to follow and change (and shouldn't confuse Klockwork :-).
Jeremy.
(This used to be commit d357f8b335
)
2007-10-10 11:18:52 -05:00
Jeremy Allison
69678ce983
r16396: Klocwork #1170 . Null deref.
...
Jeremy.
(This used to be commit 220627ab70
)
2007-10-10 11:18:51 -05:00
Jeremy Allison
a77a699fe9
r16393: Klocwork #1164 . Null deref.
...
Jeremy.
(This used to be commit c9a4ce51ed
)
2007-10-10 11:18:51 -05:00
Jeremy Allison
1c8a871aaf
r16392: Klockwork #1168 . Protect against null deref.
...
Jeremy.
(This used to be commit cab256d72a
)
2007-10-10 11:18:51 -05:00
Jeremy Allison
e98a2e1fca
r16390: Klocwork #604 - ensure if NULL pointer we assert
...
if len != 0.
Jeremy.
(This used to be commit e99cedfb0c
)
2007-10-10 11:18:51 -05:00
Jeremy Allison
a39643f170
r16388: Klocwork #320 . Null deref.
...
Jeremy.
(This used to be commit ceea8e2100
)
2007-10-10 11:18:51 -05:00
Jeremy Allison
6d5a7494df
r16386: Klockwork #lots. Ensure talloc_get_type_abort aborts
...
if handed a NULL pointer, not returns NULL.
Jeremy.
(This used to be commit d47ec4dc25
)
2007-10-10 11:18:51 -05:00
Jeremy Allison
684dd7f2cf
r16383: Klocwork #1086 . No null deref.
...
Jeremy.
(This used to be commit 7b68a2acfc
)
2007-10-10 11:18:50 -05:00
Jeremy Allison
795c99d6b8
r16381: Now samu can't be null don't check it on set. Klockwork
...
related fix.
Jeremy.
(This used to be commit 2e5a881478
)
2007-10-10 11:18:50 -05:00
Jeremy Allison
64ed606a35
r16378: Klocwork #1079 . Allow BUFFER5 to cope with a NULL
...
dependentfiles pointer.
Jeremy.
(This used to be commit 05c50d99a4
)
2007-10-10 11:18:50 -05:00
Jeremy Allison
0f256c31c0
r16377: Klocwork #1077 .
...
Jeremy.
(This used to be commit 72709a8465
)
2007-10-10 11:18:50 -05:00
Jeremy Allison
0c88eedbeb
r16375: Klocwork #1670 .
...
Jeremy.
(This used to be commit 99605ce296
)
2007-10-10 11:18:50 -05:00
Jeremy Allison
5cccafff45
r16373: Fix Klocwork #1071 .
...
Jeremy
(This used to be commit 080464b93d
)
2007-10-10 11:18:50 -05:00
Jeremy Allison
cc01fd242b
r16371: Fix Klocwork #1048 .
...
Jeremy.
(This used to be commit 5057e90db3
)
2007-10-10 11:18:50 -05:00
Jeremy Allison
96a54e7d23
r16369: Klocwork #1035 .
...
Jeremy.
(This used to be commit 6924d1cd44
)
2007-10-10 11:18:49 -05:00
Jeremy Allison
1b64f06048
r16367: Missed one, Klocwork #915 .
...
Jeremy.
(This used to be commit b581fee982
)
2007-10-10 11:18:49 -05:00
Jeremy Allison
d5b6dedfdd
r16365: Fix Klocwork #895 , #898 , #899 , #915 , #932 , #938 and a
...
few other problems Klocwork missed.
Jeremy.
(This used to be commit fe05769a1a
)
2007-10-10 11:18:49 -05:00
Volker Lendecke
3d672717e0
r16363: Fix Klocwork ID 981 1652
...
Volker
(This used to be commit ce1d8423ef
)
2007-10-10 11:18:49 -05:00
Volker Lendecke
a70bbb921a
r16362: That's the best way to fix a Klocwork bug: Remove the (unused...;-) code
...
altogether. This was essentially a second implementation if string_to_sid.
Klocwork ID 1038
Volker
(This used to be commit e35f901067
)
2007-10-10 11:18:49 -05:00
Volker Lendecke
dfa4760eea
r16361: Fix Klocwork ID 1731 1770 1771 1775 1796
...
Volker
(This used to be commit 8a5cebc19e
)
2007-10-10 11:18:49 -05:00
Volker Lendecke
e7fc37cf0f
r16360: Fix Klocwork ID 136 520 521 522 523 542 574 575 576 607
...
in net_rpc.c: 715 716 732 734 735 736 737 738 739 749
in net_rpc_audit.c: 754 755 756
in net_rpc_join.c: 757
in net_rpc_registry: 766 767
in net_rpc_samsync.c: 771 773
in net_sam.c: 797 798
Volker
(This used to be commit 3df0bf7d60
)
2007-10-10 11:18:48 -05:00
Jeremy Allison
5c822ecc49
r16358: ALWAYS compile this stuff on a 64-bit box before
...
checking in. size_t != uint32 on a 64-bit machine.
Jeremy.
(This used to be commit 09c8973286
)
2007-10-10 11:18:48 -05:00
Jeremy Allison
f40e9fcc5b
r16356: Helping derrell out. Jeremy.
...
Only set the DFS capability flag if the share is a DFS root. Fixes bug 3814.
(This used to be commit 6193f11708
)
2007-10-10 11:18:48 -05:00
Günther Deschner
17cbb65317
r16350: Fix the build.
...
GUenther
(This used to be commit 3203ce3b49
)
2007-10-10 11:17:37 -05:00
Günther Deschner
c6a47bb4f3
r16349: Another fix to make winbind more robust in large domains:
...
We may only feed rpc_useraliases with chunks of 1024 entries. This is
important as the token generation otherwise fails when a user is member
of more then 1024 groups.
Volker, please check.
Guenther
(This used to be commit d8fd94648f
)
2007-10-10 11:17:37 -05:00
Günther Deschner
c53262d677
r16346: Allow to exit a "net rpc shell" with 'quit' or 'exit'.
...
Guenther
(This used to be commit 232566e1cb
)
2007-10-10 11:17:37 -05:00
Günther Deschner
bf9b5b9baf
r16345: Improve the chance that our users can discover one of the coolest 'net'
...
features.
Guenther
(This used to be commit 446d79a000
)
2007-10-10 11:17:37 -05:00
Günther Deschner
c893dfa500
r16344: Allow to set passwords directly when creating users via "net rpc user
...
add" (as the documentation says, and currently onle "net ads user add"
did). Fixes #3843 .
Guenther
(This used to be commit 5d776d5fab
)
2007-10-10 11:17:36 -05:00
Volker Lendecke
0f14e3eb8d
r16340: Commit Bjoern's fix for the AIX PIC suffix. 'make test' still does the first
...
tests, and vfstest is still able to load modules. Looks like this is ok :-)
Volker
(This used to be commit c08bfdf87a
)
2007-10-10 11:17:36 -05:00
Volker Lendecke
8961048d24
r16339: Fix Klocwork ID
...
277 278 (cmd_*)
485 487 488 (ldap.c)
Volker
(This used to be commit 5b1eba76b3
)
2007-10-10 11:17:36 -05:00
Volker Lendecke
ec49dff326
r16338: Fix Klocwork ID 150
...
(This used to be commit ded2952e00
)
2007-10-10 11:17:36 -05:00
Volker Lendecke
9cee5574e9
r16337: Add configure fixes by Bjoern Jacke <samba@j3e.de>.
...
Volker
(This used to be commit 1b3a24732d
)
2007-10-10 11:17:36 -05:00
Volker Lendecke
8ceeef3266
r16336: Fix Klocwork ID's 1087, 1095, 1096, 1098, 1099, 1101, 1102, 1105, 1107, 1109,
...
1111
Volker
(This used to be commit def075baf8
)
2007-10-10 11:17:35 -05:00
Volker Lendecke
ee4ee4c541
r16335: Fix Klocwork IDs 107 108 109 111 112 113 114 116 117 118 121
...
(This used to be commit 555984ea77
)
2007-10-10 11:17:34 -05:00
Volker Lendecke
e279878b28
r16334: Fix Klocwork ID's 1087, 1095, 1096, 1098, 1099, 1101, 1102, 1105, 1107, 1109,
...
1111
Volker
(This used to be commit d3f5acb16e
)
2007-10-10 11:17:34 -05:00
Jeremy Allison
86a13b97e4
r16326: Klocwork #509 . Always check return allocs.
...
Jeremy.
(This used to be commit 7e397b534a
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
d730df0493
r16324: Klocwork #499 . Allways check results from alloc.
...
Jeremy.
(This used to be commit 2b69d436da
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
be6fd76436
r16322: Klocwork #481., Don't deref null on malloc fail.
...
Jeremy.
(This used to be commit dd31f3fc0e
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
61c96308fb
r16320: Ensure variable is not null before calling fclose.
...
Klocwork #412 .
Jeremy.
(This used to be commit fed55d653a
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
52d6b8339a
r16317: Klocwork #300 . Check for error return on malloc.
...
Jeremy.
(This used to be commit aa0d739834
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
4433376361
r16313: Not a problem - but ensure Klocwork is quiet ( #872 ).
...
Jeremy.
(This used to be commit 22a345deed
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
b85b18d794
r16311: Check for NULL return. Klocwork #998 .
...
Jeremy.
(This used to be commit c430730f5a
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
17621ea080
r16309: Fix Klocwork #1596 . Check for NULL on talloc.
...
Jeremy.
(This used to be commit 34b6b6723b
)
2007-10-10 11:17:32 -05:00
Jeremy Allison
a90026e7a6
r16307: Make sure we know we must pass a valid pointer here.
...
Klocwork #1129 .
Jeremy.
(This used to be commit e8d86362ba
)
2007-10-10 11:17:32 -05:00
Jeremy Allison
3a8bf11ae3
r16306: Error handling in this asn1 code *sucks*. Fix a generic
...
class of memory leak bugs on error found by Klocwork (#123 ).
Many of these functions didn't free allocated memory on
error exit.
Jeremy.
(This used to be commit 8ef11a7c6d
)
2007-10-10 11:17:32 -05:00