Stefan Metzmacher
a581242080
s4:tests/samba_tool/gpo.py: add test_show_as_admin()
...
This calls samba-tool gpo show as admin (which should be able to
see the full nTSecurityDescriptor.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-30 17:17:19 +01:00
Stefan Metzmacher
325e921908
s4:netcmd/gpo.py: let get_gpo_info explicitly ask for the full ntSecurityDescriptor
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-30 17:17:19 +01:00
Stefan Metzmacher
67799962b8
s4:netcmd/gpo.py: only ask for OWNER/GROUP/DACL when validating the nTSecurityDescriptor
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-30 17:17:19 +01:00
Stefan Metzmacher
6bffad67d2
s4:netcmd/gpo.py: the nTSecurityDescriptor may not be visible for the current user
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-30 17:17:19 +01:00
Stefan Metzmacher
f843c04b0f
s4:netcmd/gpo.py: s/ntSecurityDescriptor/nTSecurityDescriptor
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-30 17:17:19 +01:00
Stefan Metzmacher
8563348a01
s4:dsdb/dirsync: explicitly ask for sdctr->secinfo_flags = 0xF
...
A value of 0 is mapped to 0xF.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-30 17:17:19 +01:00
Stefan Metzmacher
6991fb385e
s4:dsdb/dirsync: use the correct nc_root to fetch replUpToDateVector
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-30 17:17:19 +01:00
Stefan Metzmacher
7fe1e61ab9
s4:dsdb/dirsync: check result of replUpToDateVector fetch on nc_root
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-30 17:17:19 +01:00
Stefan Metzmacher
ac9bd1e63a
s4:dsdb/schema_data: fix debug message in schema_data_modify()
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-30 17:17:19 +01:00
Michael Adam
8f3f38ece4
ldb: fix a typo in the comment for ldb_req_is_untrusted()
...
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Nov 30 15:44:46 CET 2012 on sn-devel-104
2012-11-30 15:44:46 +01:00
Michael Adam
06e1fca044
libnet: Fix a typo in dbsync error message.
...
Signed-off-by: Michael Adam <obnox@samba.org>
2012-11-30 14:02:54 +01:00
Andreas Schneider
7a429367a9
libnet: Fix copy and paste error in dbsync error message.
2012-11-30 14:02:53 +01:00
Andreas Schneider
f3d5d14906
torture: Fix copy and paste error in debug message.
...
Found by Coverity.
2012-11-30 14:02:53 +01:00
Andreas Schneider
1b170c29bc
torture: Fix copy and paste error.
...
Found by Coverity.
2012-11-30 14:02:53 +01:00
Andreas Schneider
aa7f406317
s3-reg: Fix copy and paste error in debug message.
...
Found by coverity.
2012-11-30 14:02:53 +01:00
Stefan Metzmacher
234f9365b9
s3:popt_common: Fix password processing.
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Nov 30 14:01:08 CET 2012 on sn-devel-104
2012-11-30 14:01:07 +01:00
Stefan Metzmacher
3101fcccff
s3:util: fix usage of popt_burn_cmdline_password()
...
We should only call popt_burn_cmdline_password() after poptFreeContext(),
otherwise we remove the password to early.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-30 11:50:03 +01:00
Günther Deschner
4a73adf6e5
s3-winbind: use new reconnect logic in rpc_lookup_sids() also.
...
Volker, please check.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-30 11:49:56 +01:00
Günther Deschner
7a49c96693
s3-winbindd: rework reconnect logic in winbindd_lookup_names().
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-30 11:49:53 +01:00
Günther Deschner
cd51774316
s3-winbindd: rework reconnect logic in winbindd_lookup_sids().
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-30 11:49:50 +01:00
Günther Deschner
82ace10492
s3-winbindd: remove lookup_sids_fn_t.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-30 11:49:47 +01:00
Günther Deschner
d9243815b4
s3-winbindd: remove lookup_names_fn_t.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-30 11:49:44 +01:00
Günther Deschner
3c486dfee4
s3-rpc_client: make dcerpc_lsa_lookup_names_generic() public.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-30 11:49:41 +01:00
Günther Deschner
2d38154f91
s3-rpc_cli: make dcerpc_lsa_lookup_sids_generic() public.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-30 11:49:38 +01:00
Günther Deschner
7bd9a3b86f
s3-winbindd: add cm_connect_lsat().
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-30 11:49:34 +01:00
Günther Deschner
457c933ff0
s3-rpc_cli: Remove some unused wrapping code.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-30 11:49:21 +01:00
Volker Lendecke
d5693d99b8
Fix Bug 9422 - large read requests cause server to issue malformed reply
...
Reviewed by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Nov 30 03:27:07 CET 2012 on sn-devel-104
2012-11-30 03:27:07 +01:00
Volker Lendecke
2f38a77a2d
dbwrap: Do not rely on dbwrap_record_get_value to return a talloc object
...
db_tdb_fetch_locked returns the value as part of a larger talloc object
that also contains the key. This means we can not realloc, but have to
freshly alloc.
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Nov 29 20:21:51 CET 2012 on sn-devel-104
2012-11-29 20:21:50 +01:00
Volker Lendecke
e271db4fd8
dbwrap: Remove an unnecessary if-statement
...
TALLOC_FREE can live with a NULL pointer
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 18:27:38 +01:00
Volker Lendecke
c7af12dd30
dbwrap: No need to NULL out a talloc_zero'ed structure element
...
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 18:27:37 +01:00
Volker Lendecke
a02251333f
dbwrap: Use talloc_zero in db_open_rbt
...
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 18:27:37 +01:00
Volker Lendecke
0c0815cfe3
dbwrap: Use talloc_zero in db_open_cache
...
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 18:27:36 +01:00
Volker Lendecke
343ce16e0b
s3: Remove db_ctdb_fetch
...
Note that this also makes the request for read only copies
much more explicity visible in the code.
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 18:18:49 +01:00
Volker Lendecke
6b8a37f5ca
s3: Directly parse local existing records in db_ctdb_parse_record
...
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 18:10:13 +01:00
Volker Lendecke
9dd047d67e
s3: Factor out db_ctdb_can_use_local_hdr from db_ctdb_can_use_local_copy
...
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 18:08:06 +01:00
Volker Lendecke
55d75a3fbe
s3: Remove unused code for fetching persistent ctdb records
...
The only entry point here is parse_record, and this catches the persistent
case with a direct parse now
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 18:07:26 +01:00
Volker Lendecke
7b43362a9e
s3: Avoid db_ctdb_fetch for persistent databases
...
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 18:05:25 +01:00
Volker Lendecke
93219f92bb
s3: Factor out parse_newest_in_marshall_buffer from pull_newest_from_marshall_buffer
...
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 18:03:59 +01:00
Volker Lendecke
850d5de967
s3: reduce db_ctdb_marshall_loop_next to specialized db_ctdb_marshall_buf_parse
...
now that the db_ctdb_marshall_loop_next_key has been factored out.
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 18:00:02 +01:00
Volker Lendecke
a742b6edd5
s3: Factor out db_ctdb_marshall_loop_next_key from db_ctdb_marshall_loop_next
...
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 17:55:19 +01:00
Volker Lendecke
664b170b13
s3: Slightly simplify db_ctdb_marshall_loop_next
...
Both callers give a key argument
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 17:52:34 +01:00
Volker Lendecke
af608cdd8c
s3: Use db_ctdb_ltdb_parse in db_ctdb_fetch_db_seqnum_from_db
...
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 17:52:02 +01:00
Volker Lendecke
7127344863
s3: Use db_ctdb_ltdb_parse in db_ctdb_ltdb_fetch
...
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 17:50:36 +01:00
Volker Lendecke
560ed93147
s3: Add db_ctdb_ltdb_parse
...
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 17:43:02 +01:00
Volker Lendecke
6e0259d8ec
s3: Slightly simplify db_ctdb_transaction_commit
...
Avoid an unnecessary "else".
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 17:42:20 +01:00
Volker Lendecke
b206b52748
s3: Remove header==NULL code from db_ctdb_marshall_record
...
The only call chain (via db_ctdb_marshall_add) has header != NULL
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 17:41:46 +01:00
Volker Lendecke
24c36e7484
s3: test dbwrap_ctdb
...
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 17:41:15 +01:00
Volker Lendecke
8300791a67
dbwrap: Use dbwrap_parse_record in dbwrap_fetch_uint32_bystring
...
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29 17:24:35 +01:00
Karolin Seeger
26a0ee5a0d
docs: man oLschema2ldif: Add missing meta data.
...
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Nov 29 15:27:45 CET 2012 on sn-devel-104
2012-11-29 15:27:45 +01:00
Karolin Seeger
e9e9661b23
docs: man ntlm_auth4: Add missing meta data.
...
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-29 13:42:31 +01:00