Günther Deschner
a730dff783
s3-libndr: add ../librpc/ndr/libndr.h include in some places.
...
Guenther
2011-03-31 00:14:01 +02:00
Günther Deschner
2352e7cb7f
s3-rpcclient: include rpc_client/cli_pipe.h globally in rpcclient.h
...
Guenther
2011-03-31 00:14:01 +02:00
Günther Deschner
5fcb4d328c
rep_parse_prs: remove some dead, unused code.
...
Guenther
2011-03-31 00:14:01 +02:00
Jeremy Allison
c109a70531
Fix convert_string() to take a *converted_size arg. and return a bool.
...
Makes these interfaces much harder to misuse and easier to ensure error
checking.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar 30 23:59:37 CEST 2011 on sn-devel-104
2011-03-30 23:59:37 +02:00
Günther Deschner
9ede19fdcc
s3-build: make it a little easier to build smbtorture4.
...
Only configure with --enable-socket-wrapper --enable-nss-wrapper
--enable-uid-wrapper, not --enable-developer which turns on at least one -Werror
switch.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 23:12:42 CEST 2011 on sn-devel-104
2011-03-30 23:12:42 +02:00
Günther Deschner
3800bae260
s3-vfs: try to fix build of aio_fork module.
...
Guenther
2011-03-30 22:25:59 +02:00
Jeremy Allison
d546adeab5
Change convert_string_internal() and convert_string_error() to bool return.
...
Move closer to makeing all convert_string_XXX functions return bool.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar 30 20:58:10 CEST 2011 on sn-devel-104
2011-03-30 20:58:10 +02:00
Jeremy Allison
048471d14b
Fix the nstring calls to use the correct sizes.
2011-03-30 10:13:01 -07:00
Jeremy Allison
c964744001
This doesn't look like it has anything to do with character set conversion, but it does :-).
...
Turns out one of the *really* significant differences between
convert_string() in source4 and source3, is that the one in
source3 will return 0 for byte length converted when called
with dest_len = 0 whereas the one in source4 returns (size_t)-1
and sets errno to E2BIG.
Allow the ndr_string code to cope with the (arguably correct)
way that the source4 implementation works. This code only gets
excercised in the print spooler tests, which aren't run in source4,
which is why this bug has lasted for so long.
You don't want to know how long it took me to find this :-).
Jeremy.
2011-03-30 09:58:22 -07:00
Volker Lendecke
8f4e39f6f7
s3: Fix g_lock_lock after the select/poll conversion
...
Without clustering we don't have an fd to listen on, and sys_poll
needs one element of space
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 30 18:36:50 CEST 2011 on sn-devel-104
2011-03-30 18:36:50 +02:00
Günther Deschner
220db5aad6
s3-smbd: try to fix the irix build.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 17:17:58 CEST 2011 on sn-devel-104
2011-03-30 17:17:58 +02:00
Günther Deschner
53bdf43aca
s3-vfs acl modules: more non-linux build fixes.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 16:00:02 CEST 2011 on sn-devel-104
2011-03-30 16:00:02 +02:00
Günther Deschner
33082d016e
s3-passdb: move LOOKUP_NAME_ flags to passdb where they belong to.
...
Guenther
2011-03-30 15:14:55 +02:00
Günther Deschner
3253d5ad05
s3-passdb: move some passdb defines to passdb.h
...
Guenther
2011-03-30 15:14:55 +02:00
Günther Deschner
c8ed33ae9c
s3-proto: pure cosmetics, remove some generated comments.
...
Guenther
2011-03-30 15:14:55 +02:00
Günther Deschner
6206156465
s3-winbind: try to fix the build on hosts w/o winbind support.
...
Guenther
2011-03-30 15:14:54 +02:00
Günther Deschner
b09b694ddd
s3-vfs_solarisacl: try to fix the solaris build.
...
Guenther
2011-03-30 15:14:54 +02:00
Volker Lendecke
25b43d317f
s3: Use cli_ntcreate to when listing snapshots
...
This works for directories as well
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 30 14:37:02 CEST 2011 on sn-devel-104
2011-03-30 14:37:02 +02:00
Günther Deschner
65c9d2e621
s3: Fix Coverity ID 2041, "UNUSED_VALUE"
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 13:49:35 CEST 2011 on sn-devel-104
2011-03-30 13:49:35 +02:00
Andrew Bartlett
43e364e61b
lib/util/charset Add tests for convert_string_talloc_handle()
...
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Mar 30 13:02:47 CEST 2011 on sn-devel-104
2011-03-30 13:02:47 +02:00
Andrew Bartlett
a64958a880
lib/util Move base64 functions into lib/util/base64.c
...
Andrew Bartlett
2011-03-30 12:17:05 +02:00
Andrew Bartlett
48d0abe0b5
s3:lib make lazy_initialize_conv() static
2011-03-30 12:17:05 +02:00
Andrew Bartlett
c395209791
lib/util/charset Remove pointless static bool initialised
2011-03-30 12:17:05 +02:00
Günther Deschner
fbd0ff69ec
s3: try to fix the build on some non-linux buildfarm machines.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 11:39:31 CEST 2011 on sn-devel-104
2011-03-30 11:39:31 +02:00
Volker Lendecke
0fea80c1d6
s3: Fix Coverity ID 2217: RESOURCE_LEAK
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 30 10:45:44 CEST 2011 on sn-devel-104
2011-03-30 10:45:44 +02:00
Volker Lendecke
40306f2247
s3: Fix Coverity ID 2220: RESOURCE_LEAK
2011-03-30 09:58:35 +02:00
Volker Lendecke
a56eb9b887
s3: Fix Coverity ID 2221: RESOURCE_LEAK
2011-03-30 09:58:35 +02:00
Volker Lendecke
9a97a8307c
s3: Fix Coverity ID 2222: RESOURCE_LEAK
2011-03-30 09:58:35 +02:00
Volker Lendecke
12bf847058
s3: Fix Coverity ID 2223: RESOURCE_LEAK
2011-03-30 09:58:35 +02:00
Volker Lendecke
8486f0fa04
s3: Fix Coverity ID 2236: REVERSE_INULL
...
We have already dereferenced "b", and the other calls in this loop can only
have worked with a valid handle
2011-03-30 09:58:33 +02:00
Volker Lendecke
de635fe1f7
s3: Fix Coverity ID 2332: MISSING_BREAK
2011-03-30 09:58:33 +02:00
Volker Lendecke
0764e72051
s3: Fix Coverity ID 2237: REVERSE_INULL
2011-03-30 09:58:33 +02:00
Volker Lendecke
0080f944b4
tdb: Fix Coverity ID 2238: SECURE_CODING
2011-03-30 09:58:32 +02:00
Volker Lendecke
014d4093c3
s3: Fix Coverity ID 2304: FORWARD_NULL
2011-03-30 09:58:32 +02:00
Matthias Dieter Wallnöfer
32a76ca146
s4:lib/policy/gp_ldap.c - make more use of LDB result constants
...
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Mar 30 09:33:38 CEST 2011 on sn-devel-104
2011-03-30 09:33:38 +02:00
Matthias Dieter Wallnöfer
dcdfc27dbf
s4:lib/registry/registry.h - align a copyright line in header comment
2011-03-30 08:46:04 +02:00
Matthias Dieter Wallnöfer
6723e90d52
talloc - improve doxygen comment of "talloc_move"
...
Express better that this should be a pointer of a pointer.
Reviewed-by: Tridge
2011-03-30 08:45:58 +02:00
Matthias Dieter Wallnöfer
05a9b7c32d
s4:smb_server/smb/trans2.c - "talloc_move" isn't strictly necessary here
...
Since the "set" will be free'd afterwards "talloc_steal" is enough.
Reviewed-by: Tridge
2011-03-30 08:45:06 +02:00
Günther Deschner
72833e416f
s3-ctdb_wrap: remove unused variable from db_ctdb_fetch_persistent().
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 02:00:50 CEST 2011 on sn-devel-104
2011-03-30 02:00:50 +02:00
Günther Deschner
ab9a29eb63
s3-rpc_server: move access check functions out of samr server.
...
Guenther
2011-03-30 01:13:10 +02:00
Günther Deschner
b1e3b9d7c1
s3: only include ntioctl.h where needed.
...
Guenther
2011-03-30 01:13:10 +02:00
Günther Deschner
c2d6260f10
s3: only include lib/privileges.h where needed.
...
This finally removes the global lsa.h inclusion.
Guenther
2011-03-30 01:13:10 +02:00
Günther Deschner
643b08dd25
s3: include ../librpc/gen_ndr/lsa.h where needed.
...
Guenther
2011-03-30 01:13:10 +02:00
Günther Deschner
1d383daf39
s3-passdb: move lsa_dom_info and lsa_name_info out of smb.h into passdb.
...
Guenther
2011-03-30 01:13:09 +02:00
Günther Deschner
6e3f0d28a4
s3-includes: only include ntdomain.h where needed.
...
Guenther
2011-03-30 01:13:09 +02:00
Günther Deschner
9115615663
pidl: add an include for "ntdomain.h" for s3 server stubs.
...
Guenther
2011-03-30 01:13:09 +02:00
Günther Deschner
ab36d597e7
s3-messages: make ndr_messaging.h part of messages.h.
...
Guenther
2011-03-30 01:13:09 +02:00
Günther Deschner
b2af281e50
s3-messages: only include messages.h where needed.
...
Guenther
2011-03-30 01:13:09 +02:00
Günther Deschner
4bd5f51c43
s3-prototyes: user_in_netgroup and user_in_list moved to auth, out of smbd.
...
Guenther
2011-03-30 01:13:09 +02:00
Günther Deschner
3679c0b8c1
s3-includes: finally remove global include of auth.h.
...
Guenther
2011-03-30 01:13:09 +02:00