1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

18714 Commits

Author SHA1 Message Date
Andrew Tridgell
c6f5e1ba84 fixed some places where RPC-SECRETS needs to be changed to RPC-LSA-SECRETS
this copes with a rename of SECRETS to LSA-SECRETS in an earlier patch
by gd
2009-06-10 12:24:12 +10:00
Andrew Tridgell
a5003de56b fixed the encoding/decoding of the reverse attribute for server side sort 2009-06-10 11:45:53 +10:00
Donald T. Davis
9e7501b2cb Clarify and expand the Kerberos notes made by Andrew Bartlett in 2005
Compiled with Andrew over a series of phone calls and gobby sessions,
with the aim of documenting Kerberos requirements for Samba to us an
alternate (ie, MIT) Kerberos library.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-06-10 11:38:27 +10:00
Andrew Bartlett
fbde0011e6 Remove copy of kerberos-notes.txt added in incorrect location 2009-06-10 11:37:49 +10:00
Donald T. Davis
8e1b848aed Clarify and expand the Kerberos notes made by Andrew Bartlett in 2005
Compiled with Andrew over a series of phone calls and gobby sessions
with Andrew, with the aim of documenting Kerberos requirements for
Samba to us an alternate (ie, MIT) Kerberos library.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-06-10 11:19:18 +10:00
Andrew Tridgell
6836b16dda fixed server side sort control
when sorting a record that does not have the requested sort attribute
then put those records last in the sort result
2009-06-10 10:33:53 +10:00
Andrew Tridgell
48dbfc89cf fixed server side sorting of case-insensitive strings
The sort module uses ldb_comparison_fold() as the comparison function
for case-insensitive attributes. In other places the function is being
used to produce a boolean, but for sorting we care about ordering.

The n1 - n2 return was sorting by length, not value
2009-06-10 10:13:55 +10:00
Timur I Bakeyev
fae921e938 Fix installation path of the subunit python modules.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2009-06-09 21:54:05 +02:00
Jelmer Vernooij
6b0e6fc0b3 s4-tests: Add separate variable for tap2subunit. 2009-06-09 21:54:05 +02:00
Stefan Metzmacher
7c58a2f237 SMB2-COMPOUND: add some tests for invalid requests
TODO: check why the INVALID1 tests fails with --signing=required.

metze
2009-06-09 19:33:47 +02:00
Stefan Metzmacher
8d95883908 s4:smb2srv: don't allow the related flag on the first request in a compounded chain
metze
2009-06-09 19:33:46 +02:00
Sam Liddicott
ebf5523b6e s4: smbcli_transport_send hit the socket right away if possible
[Metze; "make test" on git master outputs exactly the same test summary
with our without this patch (apart from the "using seed" lines)]

If the transport socket is writable, then push the queue along
rather than wait until the caller returns back to the tevent loop.

This strategy keeps the sockets piping hot, and is particularly good
for cases where reading requests from one socket causes lots of
writes on another socket, or where lots of writes are made in a batch.

It doesn't matter if the socket is not writeable yet, packet_queue_run
will return quite cheaply in such a case.

Signed-off-by: Sam Liddicott <sam@liddicott.com>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-06-09 18:51:31 +02:00
Stefan Metzmacher
ba42cccf00 s4:torture: add SMB2-COMPOUND test
metze
2009-06-09 16:49:33 +02:00
Stefan Metzmacher
959503ed1a s4:smb2srv: correctly fail remaining compounded requests after a failure
metze
2009-06-09 16:49:32 +02:00
Stefan Metzmacher
f55091586d s4:smb2srv: remove old TODO comment, we already check the seqnum
metze
2009-06-09 16:49:31 +02:00
Stefan Metzmacher
7633995fa0 s4:smb2srv: fix handling of multiple compounded requests
metze
2009-06-09 16:49:31 +02:00
Stefan Metzmacher
7b27b5f674 s4:smb2srv: remove the chained file handle on close
metze
2009-06-09 16:49:31 +02:00
Stefan Metzmacher
d153430e32 s4:libcli/smb2: add smb2_transport_credits_ask_num()
metze
2009-06-09 16:49:30 +02:00
Stefan Metzmacher
5b99fa5c4f s4:libcli/smb2: only add the 1 byte dynamic buffer padding for non compounded requests
metze
2009-06-09 16:49:30 +02:00
Stefan Metzmacher
d777879aaa s4:libcli/smb2: add support sending compounded requests
metze
2009-06-09 16:49:29 +02:00
Stefan Metzmacher
81275c84d3 s4:libcli/smb2: prepare SMB2 signing code for compounded requests
metze
2009-06-09 16:49:29 +02:00
Günther Deschner
71caa90cd8 s4-selftest: change rpc.secrets to rpc.lsa.secrets here as well.
Guenther
2009-06-09 15:32:36 +02:00
Günther Deschner
b5ca5412d8 s4-smbtorture: rename SECRETS to LSA-SECRETS.
Guenther
2009-06-09 14:09:23 +02:00
Andrew Tridgell
b258c5fa67 work around conflict in pidfile() prototype for heimdal on NetBSD5 2009-06-09 14:11:20 +10:00
Günther Deschner
bf7c814694 s4-smbtorture: when testing RPC-SAMR-LARGE-DC its fine to just close the objects.
Guenther
2009-06-08 22:45:16 +02:00
Günther Deschner
80d0a12fb7 s4-smbtorture: add test_QueryDisplayInfo_level to RPC-SAMR-LARGE-DC.
Guenther
2009-06-08 22:45:16 +02:00
Jelmer Vernooij
d5e6ae5cfc python: Fix samba4.dcerpc.rpcecho.RpcEchoTests.test_surrounding test. 2009-06-08 22:41:39 +02:00
Björn Jacke
d2bb72d713 s4:heimdal: fix build on FreeBSD
Patch from Timur I. Bakeyev sent to samba-technical:

Heimdal requires openpty() presence. FreeBSD has in in standard libc, so
autodetection works, but compilation fails, as declaration of this function is
missing.

This patch adds proper header detection and inclusion for openpty().
2009-06-08 22:14:49 +02:00
Günther Deschner
d11d4382b9 s4-smbtorture: also test for "all" architecture in enum driver tests in RPC-SPOOLSS.
Guenther
2009-06-08 21:24:31 +02:00
Günther Deschner
963efb5542 s4-smbtorture: fix test_ReportEventLog in RPC-EVENTLOG.
Guenther
2009-06-08 19:56:59 +02:00
Timur I. Bakeyev
11332e106c Make tunable for modulesdir
This patch is for Samba4. It adds configure tunable for modulesdir -
location, where modules should be installed. In the case, when no
FHS compliance is used and libdir is redefined, modulesdir still
points to $PREFIX/modules. In some installations it may be not desired.
I'd rather set it myself :)

So, here is the patch.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-06-08 13:20:51 +02:00
Timur I. Bakeyev
c41a12f8ba rl_event_hook detection
This patch is relevant for Samba4 source mostly. The way, how readline
compiled under FreeBSD makes it require stdio.h to get all the necessary
declarations. Without this addition rl_event_hook is not properly detected.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-06-08 13:20:51 +02:00
Günther Deschner
9e4b510504 s4-smbtorture: exclude oem_information checking for s3 in RPC-SAMR.
Guenther
2009-06-08 10:45:11 +02:00
Günther Deschner
0845db66e0 s4-smbtorture: skip samr MultipleMember alias tests for 3 as well as we do already for s4.
Guenther
2009-06-07 00:54:57 +02:00
Volker Lendecke
256b227b27 Allow access as SYSTEM on a privileged ldapi connection
This patch creates ldap_priv/ as a subdirectory under the private dir with the
appropriate permissions to only allow the same access as the privileged winbind
socket allows. Connecting to ldap_priv/ldapi gives SYSTEM access to the ldap
database.
2009-06-06 13:10:30 +02:00
Volker Lendecke
b4d7607a52 Fix some nonempty blank lines 2009-06-06 10:42:55 +02:00
Andrew Tridgell
fcc7372975 fixed handling of change notify buffer overruns
When the notify buffer overruns and there are no pending notify
requests, the notify buffer doesn't actually get destroyed, it just
gets put in a state where new notifies are discarded and the next
notify change request will return 0 changes.
2009-06-05 16:25:44 +10:00
Günther Deschner
abbcd574db s4-smbtorture: fix comment in RPC-SAMR-LARGE-DC test.
Andrew, I think you wanted to print this instead.

Guenther
2009-06-04 21:18:14 +02:00
Volker Lendecke
d0aedeb46e Increase tevent version for tevent_req_notify_callback() 2009-06-04 17:50:44 +02:00
Andrew Bartlett
a12b8571fe s4:torture Cut the RPC-SAMR-LARGE-DC test down to size
This removes the validation of the estimated number of accounts,
because MS-SAMR 3.1.5.5.1.1 makes clear the number returned cannot be
relied apon.

I've also converted a bit more of the test to use torture_assert(),
and where that is impractical, to print error messages when things
fail.

Andrew Bartlett
2009-06-04 18:12:59 +10:00
Andrew Bartlett
44f762c30d s4:torture assert that we get a Mailslot allocated before we dereference 2009-06-04 15:10:36 +10:00
Andrew Tridgell
dfd56dd294 changed the auth path to use extended DN ops to avoid non-indexed searches
Logs showed that every SAM authentication was causing a non-indexed
ldb search for member=XXX. This was previously indexed in Samba4, but
since we switched to using the indexes from the full AD schema it now
isn't.

The fix is to use the extended DN operations to allow us to ask the
server for the memberOf attribute instead, with with the SIDs attached
to the result. This also means one less search on every
authentication.

The patch is made more complex by the fact that some common routines
use the result of these user searches, so we had to update all
searches that uses user_attrs and those common routines to make sure
they all returned a ldb_message with a memberOf filled in and the SIDs
attached.
2009-06-04 14:10:11 +10:00
Andrew Tridgell
0849c1ef77 fixed ldb rename now that we have unique indexes
With unique indexes, any rename of a record that has an attribute that
is uniquely indexed needs to be done as a delete followed by an add,
otherwse you'll get an error that the attribute value already exists.
2009-06-04 14:10:11 +10:00
Andrew Bartlett
3ce37ae750 Don't run the RPC-SAMR-LARGE-DC test multiple times 2009-06-04 11:22:52 +10:00
Andrew Bartlett
bef665baad s4:torture Make Samba4 build on hosts with an older libnetapi
For example, Samba4 would not build (for the last week) on Fedora 10,
with samba-common 3.2.11 installed.

Andrew Bartlett
2009-06-04 11:13:05 +10:00
Jeremy Allison
0daf9a042c Note that the delaytime for update has changed betweek w2k3 and w2k8.
We must eventually parameterize this.
Jeremy.
2009-06-03 14:12:18 -07:00
Jeremy Allison
b11bf8b7cf Fix S3 "make install". Don't build cifs.upcall.c in S4 as there are no
checks to see if the required include file is available.
Jeremy.
2009-06-03 11:28:52 -07:00
Jeremy Allison
96cc821497 Make the path to this uglyness complete so people can find the guilty party..
Jeremy.
2009-06-03 10:45:44 -07:00
Björn Jacke
b3491df2f9 s3:torture: fix password timestamp checks on NetBSD
The Open Group says:

"The useconds argument [of usleep] must be less than 1,000,000."

NetBSD takes this seriously. usleep of more than 999999 are effectless.
2009-06-03 17:50:01 +02:00
Jelmer Vernooij
7fddc71caa selftest: Run tests for Samba4 target in the samba 4 testsuite. 2009-06-03 16:26:30 +02:00