sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-08 05:57:51 +03:00
Code
63,552 Commits 62 Branches 1,150 Tags
Commit Graph

63552 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matthias Dieter Wallnöfer
ace9bd6560 s4:ldap.py - check if the "name" of an entry was really ignored 2010-06-11 09:17:08 +02:00
Matthias Dieter Wallnöfer
4d3362776f ldb:ldb_sqlite3 backend - remove a warning which has already been resolved 2010-06-11 08:52:12 +02:00
Matthias Dieter Wallnöfer
155a672567 ldb:ldb_sqlite3 backend - remove checks which are now done elsewhere 
(In SAMBA LDB modules)
 2010-06-11 08:50:36 +02:00
Jelmer Vernooij
4690ebf0f4 Add missing stub functions. 2010-06-11 01:47:55 +02:00
Jelmer Vernooij
c446fbc3bf s4-python: Fix formatting. 2010-06-11 01:47:55 +02:00
Simo Sorce
a53ca94416 s3:rpc improve handles memory hierarchy and use better name. 
While there also cleanup the code a bit.

Signed-off-by: Günther Deschner <gd@samba.org>
 2010-06-11 00:43:23 +02:00
Günther Deschner
bcc4383ef2 s4-smbtorture: rework internals of RPC-SPOOLSS-ACCESS testsuite. 
Guenther
 2010-06-11 00:31:17 +02:00
Kamen Mazdrashki
1ceb0dd92f s4/test: use test_libnet_context_init() function to create libnet_context 
This way we ensure that LIBNET call will be issued against
the DC we are testing against
 2010-06-11 01:20:10 +03:00
Kamen Mazdrashki
d6d8ec80f9 s4/test: fix SEGFAULT in test_group_create when rid is NULL 
Caller of this function may not need group RID and
in such case it passes NULL for rid parameter
 2010-06-11 01:20:09 +03:00
Kamen Mazdrashki
eda4926120 s4/test-libnet: Helper func to initialize libnet_context 
and create rpc connections to SAMR and LSA pipes.
This function should be used in cases where we need
'deterministic' connection to the DC we are testing against.

The problem is that most of the test follow the pattern:
1. Connect to server supplied on command line
2. Create user/group through connection in 1.
3. Use 'fresh' libnet_context to query/alter the object in
   step 2.

In singe-DC environment this work well. But in multiple-DC
environment libnet may connect to another DC (step 3), not
the one we use in step 1 and 2. This leads to false error -
object created in step 2 is not found on DC we are querying
in step 3.
 2010-06-11 01:20:09 +03:00
Kamen Mazdrashki
85d7863b2c s4/test: Call test_user_cleanup with original RDN for the user 
'name' var is changed during the test execution and should
contain samAccountName for the user, while test_user_cleanup()
expects account RDN to be passed
 2010-06-11 01:20:09 +03:00
Kamen Mazdrashki
61e5ac4a5a s4/test: Fix incorrect NTSTATUS comparison 
In case group already exists, we should get NT_STATUS_GROUP_EXISTS.
 2010-06-11 01:20:09 +03:00
Kamen Mazdrashki
64a71d380c s4/test: remove create/delete group implementation in API-CREATEGROUP test 
We already have common implementation for create/delete
group in libnet/utils.c
 2010-06-11 01:20:09 +03:00
Kamen Mazdrashki
d02c395abd s4/test: Remove duplicated test_opendomain() functionality 
We already have a nice common test_domain_open()
function in libnet/util.c
 2010-06-11 01:20:09 +03:00
Kamen Mazdrashki
7135abcd8d s4/test: libnet_user tests should use common test_user_cleanup 
implementation instead of not-so-informative test_cleanup()
 2010-06-11 01:20:08 +03:00
Kamen Mazdrashki
d1bcc23b2c s4/test: Refactor test_user_cleanup to be more robust 
We always call this function with user's account RDN
while samr_LookupNames() searches for samAccountName.
 2010-06-11 01:20:08 +03:00
Kamen Mazdrashki
1b8a8ddfe0 s4/test: remove duplicated comment 2010-06-11 01:20:08 +03:00
Andreas Schneider
0962763822 s3:misc make use of server_[event/messaging]_context directly 
Untangle these functions from smbd specific dependencies so they can be freely
used in multiple servers.
 2010-06-10 17:30:45 -04:00
Simo Sorce
cbda0369a8 s3:winbindd use common server context functions 2010-06-10 17:30:45 -04:00
Simo Sorce
5e576a53ab s3:lib make server contexts generic 
Pair-programmed-with: Andreas Schneider <asn@samba.org>
 2010-06-10 17:30:45 -04:00
Jeremy Allison
aeb25ad0b8 Fix the build in the non WITH_AIO case (sorry). 2010-06-10 14:28:55 -07:00
Björn Jacke
a8c051b2f9 s3: readd h_errno struct member but rename it 
as pointed out by metze this is a structure of fixed size, which should not be
changed.
 2010-06-10 23:22:49 +02:00
Rusty Russell
b53f8c187d Since idtree assigns sequentially, it rarely reaches high numbers. 
But such numbers can be forced with idr_get_new_above(), and that
reveals two bugs:

1) Crash in sub_remove() caused by pa array being too short.
2) Shift by more than 32 in _idr_find(), which is undefined, causing
   the "outside the current tree" optimization to misfire and return NULL.
 2010-06-10 13:27:51 -07:00
Jeremy Allison
321d7a6303 Implement AIO in SMB2. Doesn't allow cancel calls yet (to be added). 
Jeremy.
 2010-06-10 13:20:37 -07:00
Jeremy Allison
edd8940e18 Ensure we correctly setup req->subreq before testing for async. Stops crashes when 
XX_send functions set async to stop interim replies being sent.

Jeremy.
 2010-06-10 13:19:25 -07:00
Jeremy Allison
b5638a0560 Don't use the autofree context for the globals. This causes child smbd's forked 
by modules to crash due to destructors being called (found when using the vfs_aio_fork
module with smb2).

Jeremy.
 2010-06-10 13:17:35 -07:00
Simo Sorce
405a0c558c s3:cleaunp reformatting for readability 2010-06-10 14:57:06 -04:00
Simo Sorce
446deb0082 s3:cleanup remove trailing spaces 2010-06-10 14:56:59 -04:00
Björn Jacke
ec94efb79d s3: fix build on HP-UX 
this struct member h_errno is not used in the HP-UX code paths, it was just
there because Solaris has it, too. As h_errno is a function call macro on HP-UX
when thread support is enabled we run into trouble here. Just commenting it out
should be okay as we don't use it anyway.
 2010-06-10 17:24:18 +02:00
Matthias Dieter Wallnöfer
bdd83c0639 s4:ldap.py - add testcase which demonstrates the reset of the "primaryGroupID" 2010-06-10 16:22:09 +02:00
Matthias Dieter Wallnöfer
d604d49939 s4:samldb LDB module - fix up the case when the old and new "primaryGroupID" are the same 2010-06-10 16:22:09 +02:00
Matthias Dieter Wallnöfer
13ca999b3b s4:samldb LDB module - don't create multiple "ac" module contexts on modify operations 
Since we do now run sequentially through all checks we don't need multiple "ac"
contexts anymore.
 2010-06-10 16:22:08 +02:00
Matthias Dieter Wallnöfer
9f95298864 s4:dcesrv_samr_Add/DeleteAliasMember - provide better NTSTATUS return codes when something didn't work 2010-06-10 16:22:08 +02:00
Matthias Dieter Wallnöfer
7374cd0358 s4:dcesrv_samr_GetAliasMembership - fix type of counter variables 2010-06-10 16:22:07 +02:00
Matthias Dieter Wallnöfer
34b43a8642 s4:dcesrv_samr_DeleteAliasMember - add more braces to fit better the coding styles 2010-06-10 16:22:07 +02:00
Matthias Dieter Wallnöfer
305f2c7043 s4:dcesrv_samr_AddAliasMembership - Merge the two error blocks into one 2010-06-10 16:22:07 +02:00
Matthias Dieter Wallnöfer
13b1f7a2b3 s4:dcesrv_samr_Add/DelGroupMember - remove the account type check 
MS-SAMR 3.1.5.8 speaks from accounts which are not necessarely only users.
 2010-06-10 16:22:06 +02:00
Matthias Dieter Wallnöfer
f95634dbe0 s4:dcesrv_samr_AddGroupMember - also the error code "LDB_ERR_ATTRIBUTE_OR_VALUE_EXISTS" is allowed 
This is returned when the group is the primary group of the specified entry.
 2010-06-10 16:22:06 +02:00
Matthias Dieter Wallnöfer
1305c91598 s4:samba_dsdb LDB module - move the "objectclass_attrs" module back 
I think it should be lower in order to control also the "instanceType" module.
 2010-06-10 16:22:06 +02:00
Matthias Dieter Wallnöfer
c1b4ccb23b s4:ldap.py - add a test to demonstrate the 'instanceType' behaviour 2010-06-10 16:22:05 +02:00
Matthias Dieter Wallnöfer
0a41b7e95b s4:instancetype LDB module - prevent all types of "instanceType" manipulation 
Also on Windows Server you aren't able to change it.
 2010-06-10 16:22:05 +02:00
Volker Lendecke
f66cc82709 s3: Fix EnumDomainAliases when no aliases are in LDAP 
We used to return NT_STATUS_ACCESS_DENIED, now we just return 0 entries, just
like W2k8 does.

usrmgr.exe was pretty unhappy with the NT_STATUS_ACCESS_DENIED
 2010-06-10 15:28:26 +02:00
Michael Adam
ba809ecb8a s3:pdb_ldap: fix bug 7505 - init_sam_from_ldap stores group in sid2uid cache 2010-06-10 12:02:05 +02:00
Volker Lendecke
1819beb088 s3: Add a dummy test to prove the maxfd calculation 
To be run in a debugger, there's no way to inspect the internal tevent_select.c
maxfd calculation
 2010-06-10 11:24:00 +02:00
Volker Lendecke
7f29f817fa tevent: Fix maxfd calculation in tevent_select 
When doing

        fd1 = tevent_add_fd(ev, ev, 2, 0, NULL, NULL);
        fd2 = tevent_add_fd(ev, ev, 3, 0, NULL, NULL);
        TALLOC_FREE(fd2);
        fd2 = tevent_add_fd(ev, ev, 1, 0, NULL, NULL);

we end up with select_ev->maxfd==1. This is wrong.

An alternative fix might be to make select_ev->maxfd an unsigned int and make
EVENT_INVALID_MAXFD==UINT_MAX. But in theory we might end up with an fd of
UINT_MAX.

std_event_add_fd() contains exactly the same piece of code, so I'm directly
pushing it.

Volker
 2010-06-10 11:24:00 +02:00
Karolin Seeger
9fdb69ebcd s3-smbd: Fix typo in comment. 
Karolin
 2010-06-10 10:35:56 +02:00
Karolin Seeger
8ca88e2f81 s3-passdb: Fix typo in comment. 
Karolin
 2010-06-10 10:34:58 +02:00
Jeremy Allison
d28fa8faab Rename "allow_smb2" -> "using_smb2" and make the usage clearer. 2010-06-09 19:12:02 -07:00
Jeremy Allison
3c0eead9fd Split out the "finished write processing" code into a function so it can be called 
by both sync and async code.

Jeremy.
 2010-06-09 17:09:11 -07:00
Jeremy Allison
efd0c35a7e Ensure we don't send SMB1 keepalives on an SMB2 connection. 
Jeremy.
 2010-06-09 17:08:41 -07:00