Jeremy Allison
b30b1cfcaf
Apply same logic fix for #4308 Excel save operation corrupts file ACLs
...
to NFSv4 ACL code as this uses the same flawed logic as posix_acls.c.
Jeremy.
2009-01-22 16:21:02 -08:00
Jeremy Allison
634cc6b64a
Fix logic error in try_chown - we shouldn't arbitrarily chown
...
to ourselves unless that was passed in.
Jeremy.
2009-01-22 15:57:41 -08:00
Jeremy Allison
81533e2d39
Second part of the attemt to fix #4308 - Excel save operation corrupts file ACLs.
...
If the chown succeeds then the ACL set should also. Ensure this is the case
(refactor some of this code to make it simpler to read also).
Jeremy.
2009-01-22 14:38:57 -08:00
Volker Lendecke
b7094c0b80
Abstract away the transport in cli_pipe.c
...
Sorry for the monster checkin, I could not really find a way to do this in
steps.
2009-01-22 22:59:54 +01:00
Volker Lendecke
b7bd71b349
Add the socket rpc client transport
2009-01-22 22:59:54 +01:00
Volker Lendecke
c5b4371054
Add the named pipe rpc client transport
2009-01-22 22:59:53 +01:00
Volker Lendecke
9b140c7c81
RPC_CLIENT_OBJ is the right variable for cli_pipe.o
2009-01-22 22:59:53 +01:00
Volker Lendecke
42fa1441bf
Add struct rpc_cli_transport
2009-01-22 22:59:53 +01:00
Jelmer Vernooij
1fcd85e8b9
Merge branch 'master' of ssh://git.samba.org/data/git/samba
2009-01-22 22:49:30 +01:00
Tim Prouty
8e2b48e1b7
s3: Fix warning
2009-01-22 13:14:04 -08:00
Jeremy Allison
2d81c9e957
Another attempt to fix bug #4308 - Excel save operation corrupts file ACLs.
...
Simo is completely correct. We should be doing the chown *first*, and fail the
ACL set if this fails. The long standing assumption I made when writing the
initial POSIX ACL code was that Windows didn't control who could chown a file
in the same was as POSIX. In POSIX only root can do this whereas I wasn't sure
who could do this in Windows at the time (I didn't understand the privilege
model). So the assumption was that setting the ACL was more important (early
tests showed many failed ACL set's due to inability to chown). But now we have
privileges in smbd, and we must always fail an ACL set when we can't chown
first. The key that Simo noticed is that the CREATOR_OWNER bits in the ACL
incoming are relative to the *new* owner, not the old one. This is why the old
user owner disappears on ACL set - their access was set via the USER_OBJ in the
creator POSIX ACL and when the ownership changes they lose their access.
Patch is simple - just ensure we do the chown first before evaluating the
incoming ACL re-read the owners. We already have code to do this it just wasn't
rigorously being applied.
Jeremy.
2009-01-22 10:57:10 -08:00
Volker Lendecke
031f246941
Fix a segfault: rpccli_* expect the reply_pdu to always be initialized
2009-01-22 17:54:16 +01:00
Stefan Metzmacher
c5e242b1a3
s3:printing: make some functions static and use tevent functions
...
metze
2009-01-22 12:37:33 +01:00
Stefan Metzmacher
240762aefe
s3:messages: finally make message_dispatch() static
...
metze
2009-01-22 12:37:33 +01:00
Stefan Metzmacher
7a07fcdc1e
s3:printing: handle tevent_context events in the sys_select() call
...
metze
2009-01-22 12:37:32 +01:00
Stefan Metzmacher
cf53e48fec
s3:winbindd: we don't need to call message_dispatch() anymore it's event triggered now
...
metze
2009-01-22 12:37:32 +01:00
Stefan Metzmacher
4d413381a2
s3:nmbd: we don't need to call message_dispatch() anymore it's event triggered now
...
metze
2009-01-22 12:37:31 +01:00
Stefan Metzmacher
830b31a41a
s3:smbd: we don't need to call message_dispatch() anymore it's event triggered now
...
metze
2009-01-22 12:37:31 +01:00
Stefan Metzmacher
a4d605344b
s3:msgtest: don't call message_dispatch() anymore, use tevent_loop_once() instead
...
metze
2009-01-22 12:37:31 +01:00
Stefan Metzmacher
c44a0ae87a
s3:smbcontrol: don't call message_dispatch() anymore, it's triggered by tevent_loop_once()
...
metze
2009-01-22 12:37:30 +01:00
Stefan Metzmacher
f029b2b058
s3:messaging: start with to use signal events instead of the raw signal interfaces
...
metze
2009-01-22 12:37:30 +01:00
Stefan Metzmacher
196028ab7b
s3:smbd: restructure kernel oplocks code
...
This converts the irix oplocks code to use a fd event
and removes the last special case for file descriptors
for the main sys_select().
metze
2009-01-22 12:37:29 +01:00
Stefan Metzmacher
048f8dba14
s3: always call run_events() before and after sys_select()
...
And always setup the fd events.
metze
2009-01-22 12:37:29 +01:00
Stefan Metzmacher
f9dcd3d2b7
s3:events: always run_events() before sys_select()
...
We might have pending signal events not only timed events.
metze
2009-01-22 12:37:28 +01:00
Volker Lendecke
3b34486f6a
Actually complete 3662c2b...
2009-01-22 12:13:55 +01:00
Volker Lendecke
3662c2b0f6
cli_get_pipe_name_from_iface does not need the cli_state
...
I leave the TALLOC_CTX in, we might have to allocate it in the future
2009-01-22 11:38:00 +01:00
Jelmer Vernooij
8f68a716fd
Merge branch 'master' of ssh://git.samba.org/data/git/samba
2009-01-22 11:37:27 +01:00
Jelmer Vernooij
e490c1b8c8
Move configure test files to the top-level and share them between s3 and
...
s4.
2009-01-22 11:35:28 +01:00
Michael Adam
63e23a7d64
s3: run "make samba3-idl"
...
Michael
2009-01-22 08:16:55 +01:00
todd stecher
989ad44d32
Memory leaks and other fixes found by Coverity
2009-01-21 17:13:03 -08:00
Jelmer Vernooij
e9615b43b4
Fix path to check_python.m4.
2009-01-21 18:54:20 +01:00
Michael Adam
a868d2f3d5
libsmbconf: move the non-registry parts of libsmbconf to top level
...
Michael
2009-01-21 18:40:58 +01:00
Michael Adam
85447ac747
s3:libsmbconf: include smbconf headers with lib/smbconf prefix
...
Michael
2009-01-21 18:40:57 +01:00
Michael Adam
7ac06f1609
s3:libsmbconf: use talloc_free instead of TALLOC_FREE in reg backend
...
Michael
2009-01-21 18:40:57 +01:00
Michael Adam
1ed0cc7c9b
s3:libsmbconf: use talloc_free instead of TALLOC_FREE in txt backend
...
Michael
2009-01-21 18:40:56 +01:00
Michael Adam
d0a8c356fb
s3:libsmbconf: use talloc_free instead of TALLOC_FREE in smbconf_init
...
Michael
2009-01-21 18:40:56 +01:00
Michael Adam
f0f5029fd7
s3:libsmbconf: use talloc_free instead of TALLOC_FREE in testsuite
...
Michael
2009-01-21 18:40:56 +01:00
Michael Adam
53ea574255
s3:libsmbconf: use talloc_free instead of TALLOC_FREE in smbconf_util.c
...
Michael
2009-01-21 18:40:55 +01:00
Michael Adam
c94fd054ca
s3:libsmbconf: use talloc_free instead of TALLOC_FREE in smbconf.c
...
Michael
2009-01-21 18:40:55 +01:00
Michael Adam
9f3c67e80c
s3:libsmbconf: remove the init headers from smbconf.h
...
give the smbconf_init() dispatcher and the backends
(smbconf_reg and smbconf_txt) a header of their own each.
This allows to use the basic infrastructure and
single backends individually.
Michael
2009-01-21 18:40:54 +01:00
Michael Adam
52b77c928c
s3:libsmbconf: remove unused function smbconf_is_writeable_bystring()
...
Michael
2009-01-21 18:40:54 +01:00
Karolin Seeger
3089cfcc4b
s3/vfs_extd_audit: Don't ignore "syslog = 0".
...
This fixes bug #5956 .
Thanks to Oskar Wycislak <cantorek [at] gmail.com> for reporting
and providing a patch!
Karolin
2009-01-21 18:32:38 +01:00
Jelmer Vernooij
1377f28f85
Fix warning; base dn is no longer const.
2009-01-21 18:20:23 +01:00
Jelmer Vernooij
f607ad2e90
Move check_python.m4 to common m4 directory.
2009-01-21 18:07:41 +01:00
Jelmer Vernooij
076bb89028
expand-includes: Add simple protection against infinite recursion.
2009-01-21 17:32:08 +01:00
Jelmer Vernooij
2c1d70ab79
Automagically expand includes in Makefile.in during configure time
...
when make is not GNU Make.
2009-01-21 17:21:45 +01:00
Jelmer Vernooij
3a4e61ecd8
Only check for Perl once in Samba 3.
2009-01-21 16:49:36 +01:00
Jelmer Vernooij
4967f6948f
Move check_make.m4 to the top-level.
2009-01-21 16:46:52 +01:00
Jelmer Vernooij
f3ecb70133
Replace ldb_search() with ldb_search_exp_fmt(), like in Samba 4.
2009-01-21 16:15:53 +01:00
Jelmer Vernooij
47951fc5d0
Reorder arguments to ldb_search() to match what is in Samba 4.
2009-01-21 15:18:05 +01:00
